Change in vdsm[master]: volume_artifacts: Add qcow2_compat on create.

2016-10-08 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: volume_artifacts: Add qcow2_compat on create. .. Patch Set 20: (1 comment) https://gerrit.ovirt.org/#/c/64372/20/vdsm/storage/sdm/volume_artifacts.py File vdsm/s

Change in vdsm[master]: net tests: minor libvirt_tests style refactoring

2016-10-08 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net tests: minor libvirt_tests style refactoring .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65091 To unsubscribe, visit https://gerr

Change in vdsm[master]: net tests: separate ifcfg and libvirt unit tests

2016-10-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net tests: separate ifcfg and libvirt unit tests .. Patch Set 5: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/65090/5/tests/Makefile.am File tests/M

Change in vdsm[master]: net tests: separate ifcfg and libvirt unit tests

2016-10-08 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net tests: separate ifcfg and libvirt unit tests .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65090 To unsubscribe, visit https://gerr

Change in vdsm[master]: testlib: Handle EINTR in waitpid

2016-10-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: testlib: Handle EINTR in waitpid .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://

Change in vdsm[master]: testlib: Handle EINTR in waitpid

2016-10-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: testlib: Handle EINTR in waitpid .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65262 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[master]: testlib: Handle EINTR in waitpid

2016-10-08 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: testlib: Handle EINTR in waitpid .. testlib: Handle EINTR in waitpid Handle EINTR when waiting for a child process in a @forked test. Fixes this error

Change in vdsm[master]: readme: Covert to markdown format

2016-10-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: readme: Covert to markdown format .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65260/1/README.md File README.md: Line 21: In order to start vdsm a

Change in vdsm[master]: dockerfile: Add missing networking packages

2016-10-08 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: dockerfile: Add missing networking packages .. dockerfile: Add missing networking packages This patch adds: - openvswitch - bridge-utils Change-Id: I0

Change in vdsm[master]: dockerfile: Add missing networking packages

2016-10-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: dockerfile: Add missing networking packages .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, vis

Change in vdsm[master]: dockerfile: Add missing networking packages

2016-10-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: dockerfile: Add missing networking packages .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65259 To unsubscribe, visit https://gerrit

Change in vdsm[master]: mount: Add mounts monitor

2016-10-08 Thread nsoffer
Nir Soffer has restored this change. Change subject: mount: Add mounts monitor .. Restored -- To view, visit https://gerrit.ovirt.org/56516 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: restore G

Change in vdsm[master]: tests: Test both ssl and m2c

2016-10-08 Thread nsoffer
Nir Soffer has restored this change. Change subject: tests: Test both ssl and m2c .. Restored -- To view, visit https://gerrit.ovirt.org/48823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: restor

Change in vdsm[master]: hsm: Report vg name in getDeviceList

2016-10-08 Thread nsoffer
Nir Soffer has restored this change. Change subject: hsm: Report vg name in getDeviceList .. Restored -- To view, visit https://gerrit.ovirt.org/45823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType

Change in vdsm[master]: utils: Consider sleep time in deadline calculation

2016-10-08 Thread nsoffer
Nir Soffer has restored this change. Change subject: utils: Consider sleep time in deadline calculation .. Restored -- To view, visit https://gerrit.ovirt.org/46400 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerr

Change in vdsm[master]: hsm: Pep8ize function name

2016-10-08 Thread nsoffer
Nir Soffer has restored this change. Change subject: hsm: Pep8ize function name .. Restored -- To view, visit https://gerrit.ovirt.org/39306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: restore

Change in vdsm[master]: mount: Add mounts monitor

2016-10-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: mount: Add mounts monitor .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/56516 To unsubscribe, visit http

Change in vdsm[master]: utils: Consider sleep time in deadline calculation

2016-10-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: Consider sleep time in deadline calculation .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/46400 T

Change in vdsm[master]: Live Merge: Restore watermark tracking

2016-10-08 Thread Jenkins CI RO
Jenkins CI RO has abandoned this change. Change subject: Live Merge: Restore watermark tracking .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/36924 To

Change in vdsm[master]: mount: Add mounts monitor

2016-10-08 Thread Jenkins CI RO
Jenkins CI RO has abandoned this change. Change subject: mount: Add mounts monitor .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/56516 To unsubscribe,

Change in vdsm[master]: Live Merge: Restore watermark tracking

2016-10-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Live Merge: Restore watermark tracking .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/36924 To unsubscrib

Change in vdsm[master]: mkimage: mk_sysprep_floppy to supervdsm

2016-10-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: mkimage: mk_sysprep_floppy to supervdsm .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/56846 To unsubscri

Change in vdsm[master]: utils: Consider sleep time in deadline calculation

2016-10-08 Thread Jenkins CI RO
Jenkins CI RO has abandoned this change. Change subject: utils: Consider sleep time in deadline calculation .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.o

Change in vdsm[master]: mkimage: mk_sysprep_floppy to supervdsm

2016-10-08 Thread Jenkins CI RO
Jenkins CI RO has abandoned this change. Change subject: mkimage: mk_sysprep_floppy to supervdsm .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/56846 To

Change in vdsm[master]: hsm: Report vg name in getDeviceList

2016-10-08 Thread Jenkins CI RO
Jenkins CI RO has abandoned this change. Change subject: hsm: Report vg name in getDeviceList .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/45823 To un

Change in vdsm[master]: mkimage: extract mkfloppy helper

2016-10-08 Thread Jenkins CI RO
Jenkins CI RO has abandoned this change. Change subject: mkimage: extract mkfloppy helper .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/56852 To unsubs

Change in vdsm[master]: mkimage: extract mkfloppy helper

2016-10-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: mkimage: extract mkfloppy helper .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/56852 To unsubscribe, vis

Change in vdsm[master]: tests: Test both ssl and m2c

2016-10-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Test both ssl and m2c .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/48823 To unsubscribe, visit h

Change in vdsm[master]: hsm: Report vg name in getDeviceList

2016-10-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hsm: Report vg name in getDeviceList .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/45823 To unsubscribe,

Change in vdsm[master]: hsm: Pep8ize function name

2016-10-08 Thread Jenkins CI RO
Jenkins CI RO has abandoned this change. Change subject: hsm: Pep8ize function name .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/39306 To unsubscribe,

Change in vdsm[master]: GuestIF Refactoring

2016-10-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: GuestIF Refactoring .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/24618 To unsubscribe, visit https://ge

Change in vdsm[master]: tests: Test both ssl and m2c

2016-10-08 Thread Jenkins CI RO
Jenkins CI RO has abandoned this change. Change subject: tests: Test both ssl and m2c .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/48823 To unsubscrib

Change in vdsm[master]: GuestIF Refactoring

2016-10-08 Thread Jenkins CI RO
Jenkins CI RO has abandoned this change. Change subject: GuestIF Refactoring .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/24618 To unsubscribe, visit

Change in vdsm[master]: hsm: Pep8ize function name

2016-10-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hsm: Pep8ize function name .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/39306 To unsubscribe, visit htt

Change in vdsm[master]: testlib: Handle EINTR in waitpid

2016-10-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: testlib: Handle EINTR in waitpid .. Patch Set 1: Verified+1 Verified by running the tests using @forked. -- To view, visit https://gerrit.ovirt.org/65262 To unsub

Change in vdsm[master]: testlib: Handle EINTR in waitpid

2016-10-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: testlib: Handle EINTR in waitpid .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug

Change in vdsm[master]: testlib: Handle EINTR in waitpid

2016-10-08 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: testlib: Handle EINTR in waitpid .. testlib: Handle EINTR in waitpid Handle EINTR when waiting for a child process in a @forked test. Fixes this error seen on tra

Change in vdsm[master]: tests: Fail if abort was not called

2016-10-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Fail if abort was not called .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches '

Change in vdsm[master]: profiling: Decouple cpu profiling from vdsm config

2016-10-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: profiling: Decouple cpu profiling from vdsm config .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/65253 To unsubscribe, visit https://gerrit

Change in vdsm[master]: profiling: Add env context manager

2016-10-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: profiling: Add env context manager .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/65254 To unsubscribe, visit https://gerrit.ovirt.org/setti

Change in vdsm[master]: profiling: Add generic Profiler class

2016-10-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: profiling: Add generic Profiler class .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/65252 To unsubscribe, visit https://gerrit.ovirt.org/se

Change in vdsm[master]: profiling: Add devel:cpu_profile_filename option

2016-10-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: profiling: Add devel:cpu_profile_filename option .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/65255 To unsubscribe, visit https://gerrit.o

Change in vdsm[master]: profiling: Rename cpuProfileTests.py

2016-10-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: profiling: Rename cpuProfileTests.py .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/65251 To unsubscribe, visit https://gerrit.ovirt.org/set

Change in vdsm[master]: readme: Covert to markdown format

2016-10-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: readme: Covert to markdown format .. Patch Set 1: https://github.com/nirs/vdsm/tree/github#vdsm-virtual-desktop-server-manager -- To view, visit https://gerrit.ov

Change in vdsm[master]: github: Add travis build status image

2016-10-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: github: Add travis build status image .. Patch Set 1: Verified+1 See https://github.com/nirs/vdsm/tree/github#vdsm-virtual-desktop-server-manager -- To view, visi

Change in vdsm[master]: readme: Covert to markdown format

2016-10-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: readme: Covert to markdown format .. Patch Set 1: Verified+1 See https://github.com/nirs/vdsm/tree/github#vdsm-virtual-desktop-server-manager -- To view, visit ht

Change in vdsm[master]: readme: Covert to markdown format

2016-10-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: readme: Covert to markdown format .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65260/1/Makefile.am File Makefile.am: Line 19: # Line 20: TOX_MIN_VERSI

Change in vdsm[master]: github: Add travis build status image

2016-10-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: github: Add travis build status image .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65261/1/README.md File README.md: Line 1: # Vdsm: Virtual Desktop S

Change in vdsm[master]: github: Add travis build status image

2016-10-08 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: github: Add travis build status image .. github: Add travis build status image Since travis build is working now, we can show the build status in github like a dec

Change in vdsm[master]: readme: Covert to markdown format

2016-10-08 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: readme: Covert to markdown format .. readme: Covert to markdown format Markdown is nicer to work with and render nicer in github. Change-Id: I74ce4bcb8bb276e98fc6

Change in vdsm[master]: readme: Covert to markdown format

2016-10-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: readme: Covert to markdown format .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu

Change in vdsm[master]: github: Add travis build status image

2016-10-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: github: Add travis build status image .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: properties: py3: properties.py and properties_test.py compli...

2016-10-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: properties: py3: properties.py and properties_test.py compliance .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovi

Change in vdsm[master]: properties: py3: properties.py and properties_test.py compli...

2016-10-08 Thread nsoffer
Nir Soffer has abandoned this change. Change subject: properties: py3: properties.py and properties_test.py compliance .. Abandoned All the changes in this patch are already merged in separate patches. -- To view, visit https

Change in vdsm[master]: protocoldetector: Fix random double close

2016-10-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: protocoldetector: Fix random double close .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/65187 To unsubscribe, visit https://gerrit.ovirt.or

Change in vdsm[master]: tests: Create all instance variables in setUp

2016-10-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Create all instance variables in setUp .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/65101 To unsubscribe, visit https://gerrit.ovir

Change in vdsm[master]: dockerfile: Add missing networking packages

2016-10-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: dockerfile: Add missing networking packages .. Patch Set 1: Verified on travis - no errors! https://travis-ci.org/nirs/vdsm/builds/166110319#L4205 -- To view, vi

Change in vdsm[master]: dockerfile: Add missing networking packages

2016-10-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: dockerfile: Add missing networking packages .. Patch Set 1: Verified+1 We don't see the errors about missing brctl and ovs-ctl any more. -- To view, visit https:/

Change in vdsm[master]: dockerfile: Add missing networking packages

2016-10-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: dockerfile: Add missing networking packages .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header m

Change in vdsm[master]: dockerfile: Add missing networking packages

2016-10-08 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: dockerfile: Add missing networking packages .. dockerfile: Add missing networking packages This patch adds: - openvswitch - bridge-utils Change-Id: I00f2caff47b5e

Change in vdsm[master]: properties: Enable tests on python 3

2016-10-08 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: properties: Enable tests on python 3 .. properties: Enable tests on python 3 Change-Id: I7f8f9f218a1bec57d9158a01a1a024adaa5e27b1 Signed-off-by: Nir So

Change in vdsm[master]: properties: Enable tests on python 3

2016-10-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: properties: Enable tests on python 3 .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit http

Change in vdsm[master]: properties: Enable tests on python 3

2016-10-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: properties: Enable tests on python 3 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65257 To unsubscribe, visit https://gerrit.ovirt.