Change in vdsm[master]: client: add namespaces for methods

2016-11-16 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: client: add namespaces for methods .. Patch Set 5: (3 comments)

Change in vdsm[master]: sos: migrate to new jsonrpc client

2016-11-16 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: sos: migrate to new jsonrpc client .. Patch Set 1: (1 comment)

Change in vdsm[master]: Enable metrics by default

2016-11-16 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: Enable metrics by default .. Patch Set 5: Verified+1 im not sure after your mail if we need it also in

Change in vdsm[master]: client: add namespaces for methods

2016-11-16 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: client: add namespaces for methods .. Patch Set 5: (3 comments)

Change in vdsm[master]: sos: migrate to new jsonrpc client

2016-11-16 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: sos: migrate to new jsonrpc client .. Patch Set 1: (1 comment)

Change in vdsm[master]: sos: migrate to new jsonrpc client

2016-11-16 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: sos: migrate to new jsonrpc client .. Patch Set 1: (1 comment)

Change in vdsm[master]: net tests: Remove redundant label from func test template.

2016-11-16 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: net tests: Remove redundant label from func test template. .. net tests: Remove redundant label from func

Change in vdsm[master]: net tests: Remove redundant label from func test template.

2016-11-16 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net tests: Remove redundant label from func test template. .. Patch Set 3: Code-Review+2 -- To view, visit

Change in vdsm[master]: net: tests: removing redundant tests

2016-11-16 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: net: tests: removing redundant tests .. net: tests: removing redundant tests test_bondmode_in_capabilities

Change in vdsm[master]: net: tests: removing redundant tests

2016-11-16 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: tests: removing redundant tests .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/66777

Change in vdsm[master]: jsonrpc: introduce new client

2016-11-16 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: jsonrpc: introduce new client .. jsonrpc: introduce new client This is a simple jsonrpc client which is not

Change in vdsm[master]: build: add six and openssl to buildrequires

2016-11-16 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: build: add six and openssl to buildrequires .. build: add six and openssl to buildrequires six and openssl

Change in vdsm[master]: replace dots with underline in vm metrics names

2016-11-16 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: replace dots with underline in vm metrics names .. Patch Set 2: bahh it doesn't let me to edit the commit msg. I

Change in vdsm[master]: replace dots with underline in vm metrics names

2016-11-16 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: replace dots with underline in vm metrics names .. Patch Set 2: Shirley, what is the motivation for this change?

Change in vdsm[master]: jsonrpc: introduce new client

2016-11-16 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: jsonrpc: introduce new client .. Patch Set 23: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64502 To

Change in vdsm[master]: replace dots with underline in vm metrics names

2016-11-16 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: replace dots with underline in vm metrics names .. Patch Set 2: Verified+1 -- To view, visit

Change in vdsm[master]: replace dots with underline in vm metrics names

2016-11-16 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: replace dots with underline in vm metrics names .. Patch Set 2: Code-Review+1 -- To view, visit

Change in vdsm[master]: build: remove six check from configure and add it to spec

2016-11-16 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: build: remove six check from configure and add it to spec .. Patch Set 3: How would she know? has she ever built

Change in vdsm[master]: build: remove six check from configure and add it to spec

2016-11-16 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: build: remove six check from configure and add it to spec .. Patch Set 2: Yaniv, I am not 100% sure that reverting

Change in vdsm[master]: build: remove six check from configure and add it to spec

2016-11-16 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: build: remove six check from configure and add it to spec .. Patch Set 3: rebasing to avoid unrelated error -- To

Change in vdsm[master]: build: remove six check from configure and add it to spec

2016-11-16 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: build: remove six check from configure and add it to spec .. Patch Set 2: (1 comment)

Change in vdsm[master]: net virt: Network Filter Parameters

2016-11-16 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net virt: Network Filter Parameters .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/66782

Change in vdsm[master]: supervdsmServer: using moduleloader for dynamic imports

2016-11-16 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: supervdsmServer: using moduleloader for dynamic imports .. Patch Set 4: Piotr, use your +2 :) -- To view, visit

Change in vdsm[master]: supervdsmServer: using moduleloader for dynamic imports

2016-11-16 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: supervdsmServer: using moduleloader for dynamic imports .. Patch Set 4: Code-Review+1 -- To view, visit

Change in vdsm[master]: schema: fix html generation

2016-11-16 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: schema: fix html generation .. Patch Set 1: Code-Review+2 (1 comment)

Change in vdsm[master]: schema: fix html generation

2016-11-16 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: schema: fix html generation .. schema: fix html generation After rebasing html generation for schema I

Change in vdsm[master]: build: remove six check from configure and add it to spec

2016-11-16 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: build: remove six check from configure and add it to spec .. Patch Set 2: Verified-1 Nir, Im asking again.. please