Federico Simoncelli has posted comments on this change.
Change subject: spec: bump libvirt requirement
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45509
To unsubscribe, visit https
Federico Simoncelli has posted comments on this change.
Change subject: StorageDomainManifest: introduce class heirarchy
..
Patch Set 15: Code-Review+1
Couldn't review so closely to be confident in a +2.
--
To view, visit
Federico Simoncelli has posted comments on this change.
Change subject: StorageDomainManifest: move path getters
..
Patch Set 15: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41995
To unsubscribe, visit https
Federico Simoncelli has posted comments on this change.
Change subject: StorageDomainManifest: move logBlkSize
..
Patch Set 15: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41996
To unsubscribe, visit https
Federico Simoncelli has posted comments on this change.
Change subject: StorageDomainManifest: move BlockSD.getVSize
..
Patch Set 15: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41994
To unsubscribe, visit https
Federico Simoncelli has posted comments on this change.
Change subject: resize-lun: resizePV parameters
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/42608/2/vdsm/storage/lvm.py
File vdsm/storage/lvm.py:
Line 876
Federico Simoncelli has posted comments on this change.
Change subject: resize-lun: resizePV parameters
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42608
To unsubscribe, visit https
Federico Simoncelli has posted comments on this change.
Change subject: fc-scan: Replace timing code with utils.stopwatch
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42567
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: utils: Add stopwatch for timing operations
..
Patch Set 3: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/29685/3/lib/vdsm/utils.py
File lib/vdsm
Federico Simoncelli has posted comments on this change.
Change subject: multipath: Replace timing code with utils.stopwatch
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/42566/3/vdsm/storage/multipath.py
File vdsm
Federico Simoncelli has posted comments on this change.
Change subject: resize-lun: Cleanup getDeviceList
..
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41831
To unsubscribe, visit https
Federico Simoncelli has posted comments on this change.
Change subject: resize-lun: Resize devices in connectStorageServer
..
Patch Set 16: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/40864/16/vdsm/storage/hsm.py
Federico Simoncelli has posted comments on this change.
Change subject: resize-lun: Add resizePV verb
..
Patch Set 5: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/40467/5/vdsm/storage/blockSD.py
File vdsm/storage
Federico Simoncelli has posted comments on this change.
Change subject: resize-lun: Add resize map support in multipath
..
Patch Set 18: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/40468/18/vdsm/storage
Federico Simoncelli has posted comments on this change.
Change subject: resize-lun: Support guids parameter in getDeviceList
..
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40661
To unsubscribe
Federico Simoncelli has posted comments on this change.
Change subject: resize-lun: Resize multipath maps in refreshStorage
..
Patch Set 15: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40469
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: ceph: Require ceph-common package
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41804
To unsubscribe, visit https
Federico Simoncelli has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 16: Code-Review+1
I am not a fan of using path for passing the ceph volume path from engine to
vdsm
Federico Simoncelli has posted comments on this change.
Change subject: ceph: Support hotunplug of network disks
..
Patch Set 17: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/38804
To unsubscribe, visit https
Federico Simoncelli has posted comments on this change.
Change subject: ceph: Validate network disk parameters
..
Patch Set 13: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40477
To unsubscribe, visit https
Federico Simoncelli has posted comments on this change.
Change subject: ceph: Support authentication using libvirt secrets
..
Patch Set 14: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40505
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: ceph: Add libvirt secret testing infrastructure
..
Patch Set 12: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40789
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: utils: add command execution logging helpers
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/38831
To unsubscribe, visit https
Federico Simoncelli has posted comments on this change.
Change subject: tcTest: skip tests if somehow same bridge name is reused
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/41898/1/tests/tcTests.py
File tests
Federico Simoncelli has posted comments on this change.
Change subject: storageServer: Run glusterfs in its own cgroup
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40240
To unsubscribe, visit https
Federico Simoncelli has posted comments on this change.
Change subject: vm: Support replication to different storage type
..
Patch Set 13: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40185
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: gluster: fix no attribute error
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/41056/2/vdsm/gluster/storagedev.py
File vdsm/gluster
Federico Simoncelli has posted comments on this change.
Change subject: vm: Add required information to replica dict
..
Patch Set 16: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40024
To unsubscribe, visit https
Federico Simoncelli has posted comments on this change.
Change subject: gluster: fix no attribute error
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41056
To unsubscribe, visit https
Federico Simoncelli has posted comments on this change.
Change subject: spbackends.py: setSpmStatus - expect tuple as param
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/4
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: vm: Unify replication terms
..
Patch Set 15: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40023
To unsubscribe, visit https
Federico Simoncelli has posted comments on this change.
Change subject: virt: Add getReplicaXML method
..
Patch Set 14: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40068
To unsubscribe, visit https
Federico Simoncelli has posted comments on this change.
Change subject: vm: Support replication to different storage type
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/40185/10/vdsm/virt/vm.py
File vdsm/virt/vm.py
Federico Simoncelli has posted comments on this change.
Change subject: virt: Add getReplicaXML method
..
Patch Set 9:
(5 comments)
https://gerrit.ovirt.org/#/c/40068/9/tests/vmStorageTests.py
File tests/vmStorageTests.py
Federico Simoncelli has posted comments on this change.
Change subject: vm: Add required information to replica dict
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/40024/11/vdsm/virt/vm.py
File vdsm/virt/vm.py
Federico Simoncelli has posted comments on this change.
Change subject: virt: Add Drive.replicaChunked property
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40184
To unsubscribe, visit https
Federico Simoncelli has posted comments on this change.
Change subject: vm: Unify disk replication terms
..
Patch Set 7: Code-Review-1
Please squash with
https://gerrit.ovirt.org/#/c/40023
--
To view, visit https
Federico Simoncelli has posted comments on this change.
Change subject: vm: Gather disk replication private methods
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40221
To unsubscribe, visit https
Federico Simoncelli has posted comments on this change.
Change subject: vm: Delete Drive.diskReplicate before saving config
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40220
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: python3: avoid python3-inconsistent syntax
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40215
To unsubscribe, visit https
Federico Simoncelli has posted comments on this change.
Change subject: python3: avoid python3-inconsistent syntax
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/40215/5/Makefile.am
File Makefile.am:
Line 130
Federico Simoncelli has posted comments on this change.
Change subject: utils: add command execution logging helper
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/38831/6/lib/vdsm/cmdutils.py
File lib/vdsm
Federico Simoncelli has posted comments on this change.
Change subject: clusterLock: fix returned retval
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40652
To unsubscribe, visit https
Federico Simoncelli has posted comments on this change.
Change subject: Revert clusterLock: Make inquire retval consistent
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/40652/3/vdsm/storage/clusterlock.py
File vdsm
Federico Simoncelli has posted comments on this change.
Change subject: storageServer: Run glusterfs in its own cgroup
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/40240/3/vdsm/storage/storageServer.py
File vdsm
Federico Simoncelli has posted comments on this change.
Change subject: fileUtils: Fix bug when mode is not specified
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/36781/4/vdsm/storage/fileUtils.py
File vdsm
Federico Simoncelli has posted comments on this change.
Change subject: fileUtils: Fix bug when mode is not specified
..
Patch Set 4: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/36781/4/vdsm/storage/fileUtils.py
Federico Simoncelli has posted comments on this change.
Change subject: storage: Make Image.__chainSizeCalc public
..
Patch Set 6: Code-Review-1
-1 for visibility. There's an unanswered comment.
--
To view, visit https
Federico Simoncelli has posted comments on this change.
Change subject: monitor: return whether the reported status is actual
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/38874
To unsubscribe
Federico Simoncelli has posted comments on this change.
Change subject: storageServer: Run glusterfs in its own cgroup
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/40240/2/vdsm/storage/storageServer.py
File vdsm
Federico Simoncelli has posted comments on this change.
Change subject: storageServer: Run glusterfs in its own cgroup
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/40240/2/vdsm/storage/storageServer.py
File vdsm
Federico Simoncelli has posted comments on this change.
Change subject: hooks: introduce before/after_get_stats hook points
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40403
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: storage: Make Image.__chainSizeCalc public
..
Patch Set 5: -Code-Review
Actually now that I think of it... how can you reuse this in SDM if it uses
Federico Simoncelli has posted comments on this change.
Change subject: storage: Make StorageDomain._getRepoPath public
..
Patch Set 4:
Also this one implies that from SDM you would use the old objects. We probably
need
Federico Simoncelli has posted comments on this change.
Change subject: spec: Require libvirt-python supporting blockCopy
..
Patch Set 7:
They're not hidden, they're attached to the code that actually needs that new
Federico Simoncelli has posted comments on this change.
Change subject: storage: Make Image.__chainSizeCalc public
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/38995
To unsubscribe, visit https
Federico Simoncelli has posted comments on this change.
Change subject: utils: add CommandStream class
..
Patch Set 10: Verified+1
--
To view, visit https://gerrit.ovirt.org/33909
To unsubscribe, visit https
Federico Simoncelli has posted comments on this change.
Change subject: storageServer: Run glusterfs in its own cgroup
..
Patch Set 3: Code-Review+1
Only +1 because it's late and I haven't fully reviewed. If anyone else can go
Federico Simoncelli has posted comments on this change.
Change subject: monitor: return whether the reported status is actual
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38874
To unsubscribe
Federico Simoncelli has posted comments on this change.
Change subject: vm: Simplify error handling in diskReplicateStart
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40022
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: vm: Streamline names in diskReplicateStart
..
Patch Set 8: Code-Review+1
+1 to the idea, I haven't checked closely the code (if it's missing a replace
Federico Simoncelli has posted comments on this change.
Change subject: vm: Add required information to replica dict
..
Patch Set 9:
(4 comments)
https://gerrit.ovirt.org/#/c/40024/9/vdsm/virt/vm.py
File vdsm/virt/vm.py
Federico Simoncelli has posted comments on this change.
Change subject: spec: Require libvirt-python supporting blockCopy
..
Patch Set 7:
Why is this separated from where you're using it?
https://gerrit.ovirt.org/#/c/40112/6
Federico Simoncelli has posted comments on this change.
Change subject: vm: Unify disk replication terms
..
Patch Set 5:
It looks like this should have been part of https://gerrit.ovirt.org/#/c/40023/8
--
To view, visit
Federico Simoncelli has posted comments on this change.
Change subject: vm: Add _findConfDisk() helper
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/40217/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2709
Federico Simoncelli has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/38766/4/vdsm/virt/vmdevices/storage.py
File vdsm/virt
Federico Simoncelli has posted comments on this change.
Change subject: vm: Set disk replica only if it can be prepared
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/40022/5/vdsm/virt/vm.py
File vdsm/virt/vm.py
Federico Simoncelli has posted comments on this change.
Change subject: vm: Streamline names in diskReplicateStart
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40023
To unsubscribe, visit https
Federico Simoncelli has posted comments on this change.
Change subject: virt: Set source attributes consistently
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40064
To unsubscribe, visit https
Federico Simoncelli has posted comments on this change.
Change subject: virt: Separate validation from getXML
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40065
To unsubscribe, visit https
Federico Simoncelli has posted comments on this change.
Change subject: virt: Improve spacing
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40067
To unsubscribe, visit https://gerrit.ovirt.org
Federico Simoncelli has posted comments on this change.
Change subject: virt: Extract Drive.diskType property
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40062
To unsubscribe, visit https
Federico Simoncelli has posted comments on this change.
Change subject: virt: Set default device in __init__
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40063
To unsubscribe, visit https
Federico Simoncelli has posted comments on this change.
Change subject: virt: Extract helpers for major XML elements
..
Patch Set 6: Code-Review+1
I haven't checked closely but it's just XML composition so it should be safe
Federico Simoncelli has posted comments on this change.
Change subject: gluster: fix volume name parsing in getVmVolumeInfo
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/36237/1/vdsm/storage/glusterVolume.py
File
Federico Simoncelli has posted comments on this change.
Change subject: utils: add logged CPopen command execution
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/38831/2/lib/vdsm/utils.py
File lib/vdsm/utils.py
Federico Simoncelli has posted comments on this change.
Change subject: vm: Simplify dict assignment
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40020
To unsubscribe, visit https
Federico Simoncelli has posted comments on this change.
Change subject: vm: Improve error handling in diskReplicateStart
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40021
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: vm: Rename temporary for clarity
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/39977/6//COMMIT_MSG
Commit Message:
Line 9: When extending
Federico Simoncelli has posted comments on this change.
Change subject: lvm: Update hsm.__processVGInfos() with lvm.getPV() new API
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38421/1/vdsm/storage/hsm.py
File
Federico Simoncelli has posted comments on this change.
Change subject: convert print statements to functions
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/37997
To unsubscribe, visit https
Federico Simoncelli has posted comments on this change.
Change subject: convert print statements to functions
..
Patch Set 5:
+2 for the effort! and because we need it soon... it would be painful to
rebase. I haven't checked
Federico Simoncelli has posted comments on this change.
Change subject: hsm: Report info needed for refreshing devices
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/38675/7/vdsm/rpc/vdsmapi-schema.json
File vdsm
Federico Simoncelli has posted comments on this change.
Change subject: hsm: Add refreshDevice verb
..
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/38754/18/vdsm/storage/multipath.py
File vdsm/storage/multipath.py
Federico Simoncelli has posted comments on this change.
Change subject: vdsm-tool: Sort imports
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/39596
To unsubscribe, visit https://gerrit.ovirt.org
Federico Simoncelli has submitted this change and it was merged.
Change subject: udevadm: Handle errors and timeouts in udevadm.settle()
..
udevadm: Handle errors and timeouts in udevadm.settle()
In commit 4c10d3d10c
Federico Simoncelli has posted comments on this change.
Change subject: spec: Update libvirt-daemon and libvirt-python requirements
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/39551
To unsubscribe
Federico Simoncelli has submitted this change and it was merged.
Change subject: spec: Update libvirt-daemon and libvirt-python requirements
..
spec: Update libvirt-daemon and libvirt-python requirements
The errata RHBA-2015
Federico Simoncelli has posted comments on this change.
Change subject: spec: Update libvirt-daemon and libvirt-python requirements
..
Patch Set 10: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/39551
Federico Simoncelli has posted comments on this change.
Change subject: iscsi: Fix iscsi_host path lookup for hardware iSCSI.
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39555
To unsubscribe
Federico Simoncelli has posted comments on this change.
Change subject: spec: Update libvirt-daemon and libvirt-python requirements
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39671
To unsubscribe
Federico Simoncelli has posted comments on this change.
Change subject: spec: Simplify libvirt dependencies
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39670
To unsubscribe, visit https
Federico Simoncelli has posted comments on this change.
Change subject: udevadm: Handle errors and timeouts in udevadm.settle()
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/39594
To unsubscribe
Federico Simoncelli has posted comments on this change.
Change subject: udevadm: Handle errors and timeouts in udevadm.settle()
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/39594/5/vdsm/storage/udevadm.py
File
Federico Simoncelli has posted comments on this change.
Change subject: iscsi: Fix iscsi_host path lookup for hardware iSCSI.
..
Patch Set 10:
Amit can you just double check that hardware on el6 and el7 would be working
ok
Federico Simoncelli has posted comments on this change.
Change subject: vdsm-tool: Remove unneeded imp import
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/39553/1/vdsm-tool/vdsm-tool
File vdsm-tool/vdsm-tool
Federico Simoncelli has posted comments on this change.
Change subject: spec: Update libvirt-daemon and libvirt-python requirements
..
Patch Set 4:
Nir/Yaniv as far as I understand this is blocked on 39543 (which requires
Federico Simoncelli has posted comments on this change.
Change subject: lvm: Update hsm.__processVGInfos() with lvm.getPV() new API
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38421/1/vdsm/storage/hsm.py
File
Federico Simoncelli has posted comments on this change.
Change subject: hsm: Report info needed for refreshing devices
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/38675/5/vdsm/rpc/vdsmapi-schema.json
File vdsm
Federico Simoncelli has posted comments on this change.
Change subject: spec: Simplify libvirt dependencies
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/39543
To unsubscribe, visit https
1 - 100 of 1081 matches
Mail list logo
