Amit Aviram has abandoned this change.
Change subject: storage: move threadPool module to vdsm storage lib
..
Abandoned
Already moved to vdsm/storage
--
To view, visit https://gerrit.ovirt.org/56571
To unsubscribe, visit
Amit Aviram has abandoned this change.
Change subject: storage: move outOfProcess module to vdsm storage lib
..
Abandoned
oop already moved to Storage lib
--
To view, visit https://gerrit.ovirt.org/56576
To unsubscribe,
Amit Aviram has posted comments on this change.
Change subject: qemuimg: Introduce supports_compat helper
..
Patch Set 13: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59410
To unsubscribe, visit
Amit Aviram has posted comments on this change.
Change subject: verify_untrusted_volume: Check compatibility version
..
Patch Set 14: Code-Review+1
Now with the next patch, this is a good addition
--
To view, visit
Amit Aviram has posted comments on this change.
Change subject: verify_untrusted_volume: Check compatibility version
..
Patch Set 14: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/59411
To unsubscribe, visit
Amit Aviram has posted comments on this change.
Change subject: verify_untrusted_volume: Check compatibility version
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/59411/7/lib/vdsm/storage/misc.py
File
Amit Aviram has posted comments on this change.
Change subject: qemuimg: Introduce supports_compat helper
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/59410/7/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line
Amit Aviram has posted comments on this change.
Change subject: qemuimg: Introduce supports_compat helper
..
Patch Set 8: Code-Review-1
See my comment in patch set 7
--
To view, visit https://gerrit.ovirt.org/59410
To
Amit Aviram has posted comments on this change.
Change subject: verify_untrusted_volume: Check compatibility version
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/59411/1//COMMIT_MSG
Commit Message:
Line 6:
Line
Amit Aviram has posted comments on this change.
Change subject: verify_untrusted_volume: Check compatibility version
..
Patch Set 7: Code-Review-1
Please refer to my comment in 2 patches back in this chain
--
To view, visit
Amit Aviram has posted comments on this change.
Change subject: qemuimg: Introduce supports_compat helper
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/59410/7/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
PS7,
Amit Aviram has posted comments on this change.
Change subject: build: support imageio in rhev
..
Patch Set 1:
Milestone is now correct
--
To view, visit https://gerrit.ovirt.org/59799
To unsubscribe, visit
Amit Aviram has posted comments on this change.
Change subject: build: support imageio in rhev
..
Patch Set 1:
I need an approval from Allon/Yaniv for that. will take care of it asap
--
To view, visit
Amit Aviram has posted comments on this change.
Change subject: build: support imageio in rhev
..
Patch Set 2:
bp: https://gerrit.ovirt.org/#/c/59799/
--
To view, visit https://gerrit.ovirt.org/59696
To unsubscribe, visit
Amit Aviram has posted comments on this change.
Change subject: build: support imageio in rhev
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/59799
To unsubscribe, visit
Hello Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/59799
to review the following change.
Change subject: build: support imageio in rhev
..
build: support imageio in rhev
Since
Amit Aviram has posted comments on this change.
Change subject: build: support imageio in rhev
..
Patch Set 1:
Right, it is the opposite than what I said
--
To view, visit https://gerrit.ovirt.org/59696
To unsubscribe, visit
Amit Aviram has posted comments on this change.
Change subject: build: support imageio in rhev
..
Patch Set 1:
Verified with the script itself, rhev_build.sh created a spec with
"with_ovirt_imageio 0", while before this patch
Amit Aviram has posted comments on this change.
Change subject: build: support imageio in rhev
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/59696
To unsubscribe, visit
Amit Aviram has uploaded a new change for review.
Change subject: build: support imageio in rhev
..
build: support imageio in rhev
Since ovirt-imageio is now available in rhel's channels, we should
enable it in rhev. This will
Amit Aviram has posted comments on this change.
Change subject: storage: move outOfProcess module to vdsm storage lib
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/56576
To unsubscribe, visit
Amit Aviram has posted comments on this change.
Change subject: storage: move outOfProcess module to vdsm storage lib
..
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/56576/6/tests/outOfProcessTests.py
File
Amit Aviram has posted comments on this change.
Change subject: storage: move outOfProcess module to vdsm storage lib
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/56576
To unsubscribe, visit
Amit Aviram has posted comments on this change.
Change subject: storage: move threadPool module to vdsm storage lib
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/56571
To unsubscribe, visit
Amit Aviram has posted comments on this change.
Change subject: storage: move threadPool module to vdsm storage lib
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/56571/2/lib/vdsm/storage/threadPool.py
File
Amit Aviram has posted comments on this change.
Change subject: storage: move outOfProcess module to vdsm storage lib
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/56576/4/tests/miscTests.py
File
Amit Aviram has posted comments on this change.
Change subject: storage: move outOfProcess module to vdsm storage lib
..
Patch Set 2:
(8 comments)
https://gerrit.ovirt.org/#/c/56576/2/lib/vdsm/storage/outOfProcess.py
File
Amit Aviram has posted comments on this change.
Change subject: storage: move threadPool module to vdsm storage lib
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/56571/2/lib/vdsm/storage/threadPool.py
File
Amit Aviram has abandoned this change.
Change subject: storage: move threadLocal module to vdsm storage lib
..
Abandoned
We have this patch, waiting for verification:
https://gerrit.ovirt.org/55255/
--
To view, visit
Amit Aviram has uploaded a new change for review.
Change subject: storage: move outOfProcess module to vdsm storage lib
..
storage: move outOfProcess module to vdsm storage lib
This patch moves the module
Amit Aviram has uploaded a new change for review.
Change subject: storage: move threadLocal module to vdsm storage lib
..
storage: move threadLocal module to vdsm storage lib
This patch moves the module storage/threadPool.py to
Amit Aviram has posted comments on this change.
Change subject: storage: move threadPool module to vdsm storage lib
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/56571/1/vdsm/storage/storage_mailbox.py
File
Amit Aviram has uploaded a new change for review.
Change subject: storage: move threadPool module to vdsm storage lib
..
storage: move threadPool module to vdsm storage lib
This patch moves the module storage/threadPool.py to
Amit Aviram has posted comments on this change.
Change subject: hsm: add untrusted image verification.
..
Patch Set 9:
This is tested with the following engine branch:
https://gerrit.ovirt.org/#/c/55817/
Which calls this API.
Amit Aviram has posted comments on this change.
Change subject: hsm: add untrusted image verification.
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/55746
To unsubscribe, visit
Amit Aviram has posted comments on this change.
Change subject: hsm: add untrusted image verification.
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/55746/7/lib/api/vdsmapi-schema.json
File
Amit Aviram has posted comments on this change.
Change subject: hsm: add untrusted image verification.
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/55746/7/lib/api/vdsmapi-schema.json
File
Amit Aviram has posted comments on this change.
Change subject: hsm: add untrusted image verification.
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/55746/7/lib/api/vdsmapi-schema.json
File
Amit Aviram has posted comments on this change.
Change subject: hsm: add untrusted image verification.
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/55746/7/lib/api/vdsmapi-schema.json
File
Amit Aviram has posted comments on this change.
Change subject: hsm: add untrusted image verification.
..
Patch Set 6:
(5 comments)
https://gerrit.ovirt.org/#/c/55746/6/lib/api/vdsmapi-schema.json
File
Amit Aviram has posted comments on this change.
Change subject: hsm: add untrusted image verification.
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/55746/4/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line
Amit Aviram has posted comments on this change.
Change subject: hsm: add untrusted image verification.
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/55746
To unsubscribe, visit
Amit Aviram has posted comments on this change.
Change subject: hsm: add untrusted image verification.
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/55746/2/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 1562:
Amit Aviram has posted comments on this change.
Change subject: hsm: add uploaded image verification
..
Patch Set 2:
(9 comments)
https://gerrit.ovirt.org/#/c/55746/2/lib/api/vdsmapi-schema.json
File
Amit Aviram has posted comments on this change.
Change subject: hsm: add uploaded image verification
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/55746
To unsubscribe, visit
Amit Aviram has posted comments on this change.
Change subject: hsm: add uploaded image verification
..
Patch Set 2:
Verified with qcow2 image with/without backingfile, and raw images.
--
To view, visit
Amit Aviram has posted comments on this change.
Change subject: image: add a flag for preparing with illegal volumes.
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/55199
To unsubscribe, visit
Amit Aviram has posted comments on this change.
Change subject: hsm: add uploaded image verification
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/55746/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
PS1, Line
Amit Aviram has uploaded a new change for review.
Change subject: hsm: add uploaded image verification
..
hsm: add uploaded image verification
In the new image upload flow, a VDSM's image is being generated and data
is being
Amit Aviram has abandoned this change.
Change subject: volume: Add internal info from qemuimg in getVolumeInfo.
..
Abandoned
Going with different approach.
--
To view, visit https://gerrit.ovirt.org/55221
To unsubscribe,
Amit Aviram has posted comments on this change.
Change subject: volume: Add internal info from qemuimg in getVolumeInfo.
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/55221/4/vdsm/storage/volume.py
File
Amit Aviram has posted comments on this change.
Change subject: image: add a flag for preparing with illegal volumes.
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/55199/2/lib/api/vdsmapi-schema.json
File
Amit Aviram has posted comments on this change.
Change subject: image: add a flag for preparing with illegal volumes.
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/55199/2/vdsm/storage/hsm.py
File
Amit Aviram has posted comments on this change.
Change subject: storage: Organize imports in storage.sdc
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55260
To unsubscribe, visit
Amit Aviram has posted comments on this change.
Change subject: storage: Fix copyright years in storage.imagetickets
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55257
To unsubscribe, visit
Amit Aviram has posted comments on this change.
Change subject: storage: Fix copyright years in storage.imagetickets
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/55257/1/vdsm/storage/imagetickets.py
File
Amit Aviram has uploaded a new change for review.
Change subject: volume: Add internal info from qemuimg in getVolumeInfo.
..
volume: Add internal info from qemuimg in getVolumeInfo.
Currently Volume's getInfo() fetches
Amit Aviram has abandoned this change.
Change subject: :
short summary under 50 chars
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/55220
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType:
Amit Aviram has uploaded a new change for review.
Change subject: :
short summary under 50 chars
..
: short summary under
50 chars
Longer description using lines' length under 72 chars.
With multiple paragraphs if necessary.
Amit Aviram has posted comments on this change.
Change subject: image: add a flag for preparing with illegal volumes
..
Patch Set 1:
(6 comments)
https://gerrit.ovirt.org/#/c/55199/1//COMMIT_MSG
Commit Message:
Line 8:
Line
Amit Aviram has uploaded a new change for review.
Change subject: image: add a flag for preparing with illegal volumes
..
image: add a flag for preparing with illegal volumes
Currently preparing an image is impossible if one of
Amit Aviram has abandoned this change.
Change subject: hotplugDisk: Handle prepareVolumePath errors gracefully.
..
Abandoned
Common error catching is being implemented, see:
https://gerrit.ovirt.org/#/c/54664/
--
To view,
Amit Aviram has posted comments on this change.
Change subject: virt: common handling of exceptions
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54664
To unsubscribe, visit
Amit Aviram has posted comments on this change.
Change subject: vm: use the new response handling
..
Patch Set 1:
Looks good, but what about the rest? (if you need any help in
implementation/verification in the storage parts
Amit Aviram has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/52900/12/vdsm/storage/imagetickets.py
File vdsm/storage/imagetickets.py:
> Is
Amit Aviram has posted comments on this change.
Change subject: hotplugDisk: Handle prepareVolumePath errors gracefully.
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/54266
To unsubscribe, visit
Amit Aviram has posted comments on this change.
Change subject: hotplugDisk: Handle prepareVolumePath errors gracefully.
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/54266/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Amit Aviram has posted comments on this change.
Change subject: hotplugDisk: Handle prepareVolumePath errors gracefully.
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/54266/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Amit Aviram has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 12: Verified+1
--
To view, visit https://gerrit.ovirt.org/52900
To unsubscribe, visit https://gerrit.ovirt.org/settings
Amit Aviram has uploaded a new change for review.
Change subject: hotplugDisk: Handle prepareVolumePath errors gracefully.
..
hotplugDisk: Handle prepareVolumePath errors gracefully.
While hotplugging a disk, a call is being
Amit Aviram has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 10:
(2 comments)
https://gerrit.ovirt.org/#/c/52900/10/tests/imagetickets_test.py
File tests/imagetickets_test.py:
Line
Amit Aviram has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 9:
(4 comments)
https://gerrit.ovirt.org/#/c/52900/9/tests/imagetickets_test.py
File tests/imagetickets_test.py:
Line 53:
Amit Aviram has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 9: -Verified
--
To view, visit https://gerrit.ovirt.org/52900
To unsubscribe, visit https://gerrit.ovirt.org/settings
Amit Aviram has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/52900
To unsubscribe, visit https://gerrit.ovirt.org/settings
Amit Aviram has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 8: -Verified
--
To view, visit https://gerrit.ovirt.org/52900
To unsubscribe, visit https://gerrit.ovirt.org/settings
Amit Aviram has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/52900
To unsubscribe, visit https://gerrit.ovirt.org/settings
Amit Aviram has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 7:
(10 comments)
https://gerrit.ovirt.org/#/c/52900/7/tests/imagetickets_test.py
File tests/imagetickets_test.py:
Line 101:
Amit Aviram has posted comments on this change.
Change subject: localFsSD: Use the right manifest.
..
Patch Set 3:
This bug was introduced in patch 28582d, which does not exist in 3.6. so no
backport is needed. (The flow was
Amit Aviram has posted comments on this change.
Change subject: localFsSD: Use the right manifest.
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/53688
To unsubscribe, visit
Amit Aviram has uploaded a new change for review.
Change subject: localFsSD: Use the right manifest.
..
localFsSD: Use the right manifest.
Local storage domain should use its own manifest instead of the
inherited one from
Amit Aviram has abandoned this change.
Change subject: hsm: organize imports.
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/50373
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Amit Aviram has uploaded a new change for review.
Change subject: imagetickets: Add tests.
..
imagetickets: Add tests.
Change-Id: Ia1d414c96c06484365911804e438845dfe17cbb1
Signed-off-by: Amit Aviram
---
M
Amit Aviram has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/52900
To unsubscribe, visit https://gerrit.ovirt.org/settings
Amit Aviram has abandoned this change.
Change subject: imagetickets: Add tests.
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/53331
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType:
Amit Aviram has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 4: -Verified
--
To view, visit https://gerrit.ovirt.org/52900
To unsubscribe, visit https://gerrit.ovirt.org/settings
Amit Aviram has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 4:
re: first issue, Done.
re: second issue: I'm guessing you are not rebased,
https://gerrit.ovirt.org/#/c/53279/ changed
Amit Aviram has uploaded a new change for review.
Change subject: imagetickets: fix typo in Daemon Error
..
imagetickets: fix typo in Daemon Error
DeamonError -> DaemonError
Change-Id: Iea5ac6f0ca98edf8344f3040717ca825ed021e2e
Amit Aviram has posted comments on this change.
Change subject: imagetickets: fix typo in Daemon Error
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/53279
To unsubscribe, visit
Amit Aviram has uploaded a new change for review.
Change subject: imagetickets: add tests
..
imagetickets: add tests
Adding tests to the new imagetickets module.
Change-Id: I2728851a91529ec35501f423d9a798af961fb82a
Bug-Url:
Amit Aviram has posted comments on this change.
Change subject: imagetickets: Support image tickets
..
Patch Set 15: Verified+1
--
To view, visit https://gerrit.ovirt.org/50014
To unsubscribe, visit
Amit Aviram has posted comments on this change.
Change subject: imagetickets: Support image tickets
..
Patch Set 13: Verified+1
--
To view, visit https://gerrit.ovirt.org/50014
To unsubscribe, visit
Amit Aviram has uploaded a new change for review.
Change subject: Debugging vm.py
..
Debugging vm.py
Change-Id: I583efd29cc2d7fbe064c331b6e52a692fac9fc97
Signed-off-by: Amit Aviram
---
M vdsm/vdsm
1 file
Amit Aviram has uploaded a new change for review.
Change subject: DEBUG
..
DEBUG
Change-Id: I568a9cebd9b981cb387e92518dc2e64b463ea991
Signed-off-by: Amit Aviram
---
M vdsm/vdsm
1 file changed, 1
Amit Aviram has uploaded a new change for review.
Change subject: Fix
..
Fix
Change-Id: I6b0bf654b3711ac68c65fb9d2294f91efc92272d
Signed-off-by: Amit Aviram
---
M vdsm/storage/imagetickets.py
1 file
Amit Aviram has posted comments on this change.
Change subject: imagetickets: Support image tickets
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/50014/13/vdsm/storage/imagetickets.py
File
Amit Aviram has abandoned this change.
Change subject: DEBUG
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/52659
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id:
Amit Aviram has abandoned this change.
Change subject: Debugging vm.py
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/52658
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Amit Aviram has abandoned this change.
Change subject: Fix
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/52660
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id:
Amit Aviram has posted comments on this change.
Change subject: imagetickets: Support image tickets
..
Patch Set 14:
(4 comments)
https://gerrit.ovirt.org/#/c/50014/14/vdsm/storage/imagetickets.py
File
Amit Aviram has posted comments on this change.
Change subject: imagetickets: Support image tickets
..
Patch Set 10:
(6 comments)
https://gerrit.ovirt.org/#/c/50014/10//COMMIT_MSG
Commit Message:
Line 11: oVirt's storage
1 - 100 of 187 matches
Mail list logo