Ayal Baron has posted comments on this change.
Change subject: Stop spm if refresh fail on bad parameters.
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Ayal Baron has posted comments on this change.
Change subject: Remove force parameter in StoragePool.spmStop()
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Ayal Baron has posted comments on this change.
Change subject: clientIF: rescan devices on failed hotplugDisk
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13454
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: vm: update volume apparentsize after snapshot
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13346
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: libvirtvm: avoid concurrent VM changes during saveState
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13624
To unsubscribe,
Ayal Baron has posted comments on this change.
Change subject: gluster: move exportToSupervdsm at module level
..
Patch Set 14: (1 inline comment)
File
Ayal Baron has posted comments on this change.
Change subject: gluster: move exportToSupervdsm at module level
..
Patch Set 14: (1 inline comment)
File
Ayal Baron has posted comments on this change.
Change subject: Stop spm if refresh fail on bad parameters.
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Ayal Baron has posted comments on this change.
Change subject: gluster: Added gluster hooks support
..
Patch Set 27: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9671
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: gluster: move exportToSupervdsm at module level
..
Patch Set 11: (1 inline comment)
File
Ayal Baron has posted comments on this change.
Change subject: Ignore partially deleted images in getAllImages().
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12938
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: readlines - remove redundant pathExists check
..
Patch Set 4: No score
(1 inline comment)
Apparently logger name needs fixing
Ayal Baron has posted comments on this change.
Change subject: Fix getPools comment.
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14014
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: Retry MD reads when validating pool-domain membership.
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14013
To unsubscribe,
Ayal Baron has posted comments on this change.
Change subject: Prefetch domains when connecting a storage server.
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12869
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: Prefetch domains when connecting a storage server.
..
Patch Set 7: Verified
Verified by Paikov
--
To view, visit http://gerrit.ovirt.org/12869
To unsubscribe,
Ayal Baron has posted comments on this change.
Change subject: gluster: Added gluster hooks support
..
Patch Set 23: (2 inline comments)
File vdsm/gluster/hooks.py
Line 133:
Ayal Baron has posted comments on this change.
Change subject: readlines - remove redundant pathExists check
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13664
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: readlines - remove redundant pathExists check
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
Ayal Baron has posted comments on this change.
Change subject: multipath: Remove unused 'deduceType' and MIXED_DEV
..
Patch Set 2: I would prefer that you didn't submit this
(4 inline comments)
Ayal Baron has posted comments on this change.
Change subject: clientIF: rescan devices on failed hotplugDisk
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13454
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: vm: rename _updateDrive to updateDriveParameters
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13631
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: vm: update volume apparentsize after snapshot
..
Patch Set 3: (1 inline comment)
File vdsm/libvirtvm.py
Line
Ayal Baron has posted comments on this change.
Change subject: sp: refreshDomainLinks before convertDomain
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13633
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: sp: asynchronous convertDomain in activateSD
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13634
To
Ayal Baron has posted comments on this change.
Change subject: vm: catch getVolumeSize failures in _normalizeVdsmImg
..
Patch Set 2: (1 inline comment)
File vdsm/vm.py
Line
Ayal Baron has posted comments on this change.
Change subject: libvirtvm: avoid concurrent saveState during diskReplica
..
Patch Set 3: (3 inline comments)
File
Ayal Baron has posted comments on this change.
Change subject: stats: report the domain version
..
Patch Set 2: (1 inline comment)
File vdsm/storage/domainMonitor.py
Line
Ayal Baron has posted comments on this change.
Change subject: Make getAllVolumes() not fail on broken images.
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12546
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: readlines - remove redundant pathExists check
..
Patch Set 1:
Saggi, try except and do what exactly?
If file doesn't exist reading the metadata should fail.
at
Ayal Baron has posted comments on this change.
Change subject: sp: invalidate lvm cache if attachSD fails
..
Patch Set 5: Looks good to me, approved
This is much better!
--
To view, visit http://gerrit.ovirt.org/13221
To
Ayal Baron has posted comments on this change.
Change subject: Marking del/zero volumes in blockSD class.
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12545
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: Remove unnecessary storage log messages from logs
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13617
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: Make getAllVolumes() not fail on broken images.
..
Patch Set 7: I would prefer that you didn't submit this
(2 inline comments)
Ayal Baron has posted comments on this change.
Change subject: iscsi: Add FC scan to forceScsiScan
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13221
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: Relink template hard links to meta and lease files
..
Patch Set 6: (1 inline comment)
File
Ayal Baron has posted comments on this change.
Change subject: Ignore partially deleted images in getAllImages().
..
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
Ayal Baron has posted comments on this change.
Change subject: iscsi: Add FC scan to forceScsiScan
..
Patch Set 1: (1 inline comment)
Commit Message
Line 3: AuthorDate:
Ayal Baron has posted comments on this change.
Change subject: Relink template hard links to meta and lease files
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12837
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: image: update the volume permissions when needed
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13331
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: multipath: Remove unused 'deduceType'
..
Patch Set 1: (6 inline comments)
You're correct that DEV_MIXED is used as well as multipath.devIsiSCSI
Ayal Baron has posted comments on this change.
Change subject: multipath: remove unused device attribute 'devnum'
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13356
Ayal Baron has posted comments on this change.
Change subject: image: Set legality of volume to LEGAL after copy
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12457
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: image: update the volume permissions when needed
..
Patch Set 1: (1 inline comment)
File
Ayal Baron has posted comments on this change.
Change subject: sp: remove duplicated code for repoPath
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12803
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: domain: unify the createVolume method
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13329
To
Ayal Baron has posted comments on this change.
Change subject: image: placeholder optimization on preallocation
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12692
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: Prefetch domains when connecting a storage server.
..
Patch Set 6: I would prefer that you didn't submit this
(6 inline comments)
Ayal Baron has posted comments on this change.
Change subject: getAllTasksList\Status with spUUID retrieves info only if host
is the SPM
..
Patch Set 12: I would prefer that you didn't submit this
Dan, I've responded to
Ayal Baron has posted comments on this change.
Change subject: getAllTasksList\Status with spUUID retrieves info only if host
is the SPM
..
Patch Set 12: Looks good to me, approved
The bug is now public, reinstating my +2
--
Ayal Baron has posted comments on this change.
Change subject: getAllTasksList\Status with spUUID retrieves info only if host
is the SPM
..
Patch Set 12: Looks good to me, approved
--
To view, visit
Ayal Baron has posted comments on this change.
Change subject: storageServer: fix connect to detect mount errors
..
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12042
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: storageServer: fix connect to detect mount errors
..
Patch Set 6: No score
(1 inline comment)
Commit Message
Ayal Baron has posted comments on this change.
Change subject: storageServer: fix connect to detect mount errors
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12042
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: Remove hbtl attribute of non-scsi devices
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12999
To
Ayal Baron has posted comments on this change.
Change subject: Encode '=' when persisting the Task.
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13128
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: Make getAllVolumes() not fail on broken images.
..
Patch Set 6: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/12546
To
Ayal Baron has posted comments on this change.
Change subject: vdsm: propagate MountError when mount fails
..
Patch Set 6: (2 inline comments)
File
Ayal Baron has posted comments on this change.
Change subject: Storage connection reference: move persistent dir to
/var/lib/vdsm
..
Patch Set 1: Looks good to me, approved
Definitely correct.
The point of the connection info
Ayal Baron has posted comments on this change.
Change subject: vdsm: propagate MountError when mount fails
..
Patch Set 4: (3 inline comments)
Only thing that needs revising here is the logging issue (need to log mount
Ayal Baron has posted comments on this change.
Change subject: Relink template hard links to meta and lease files
..
Patch Set 2: I would prefer that you didn't submit this
(5 inline comments)
Ayal Baron has posted comments on this change.
Change subject: vdsm: propagate MountError when mount fails
..
Patch Set 5:
Edu, there is no ENOENT there so unless you comment in the code I'm not sure
what you're referring
Ayal Baron has posted comments on this change.
Change subject: Prefetch domains when connecting a storage server.
..
Patch Set 4: (1 inline comment)
File vdsm/storage/sdc.py
Ayal Baron has posted comments on this change.
Change subject: Remove hbtl attribute of non-scsi devices
..
Patch Set 3: (1 inline comment)
I still don't understand how this solves any bug?
Ayal Baron has posted comments on this change.
Change subject: getAllTasksList\Status with spUUID retrieves info only if host
SPM
..
Patch Set 9: (7 inline comments)
Commit
Ayal Baron has posted comments on this change.
Change subject: getAllTasksList\Status with spUUID retrieves info only if host
is the SPM
..
Patch Set 10: (1 inline comment)
Ayal Baron has posted comments on this change.
Change subject: Marking del/zero volumes in blockSD class.
..
Patch Set 2: (3 inline comments)
Commit Message
Line 3:
Ayal Baron has posted comments on this change.
Change subject: getAllVolumes returns partially deleted volumes too.
..
Patch Set 4: (3 inline comments)
Commit Message
Line
Ayal Baron has posted comments on this change.
Change subject: getAllVolumes returns partially deleted volumes too.
..
Patch Set 3: (2 inline comments)
File
Ayal Baron has posted comments on this change.
Change subject: getAllTasksList\Status with spUUID retrieves info only if host
is the SPM
..
Patch Set 11: Looks good to me, approved
--
To view, visit
Ayal Baron has posted comments on this change.
Change subject: Ignore partially deleted images in getAllImages().
..
Patch Set 3: (1 inline comment)
File
Ayal Baron has posted comments on this change.
Change subject: Marking del/zero volumes in blockSD class.
..
Patch Set 2: (1 inline comment)
File vdsm/storage/blockSD.py
Ayal Baron has posted comments on this change.
Change subject: vdsm: Catch OSError in _translateConnectionError
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10966
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: vdsm: Catch OSError in _translateConnectionError
..
Patch Set 3:
wrt removing _translateConnectionError it should be discussed u/s first as I'm
not sure Saggi
Ayal Baron has posted comments on this change.
Change subject: getAllTasksList\Status with spUUID retrieves info only if host
is the SPM
..
Patch Set 11: (4 inline comments)
Ayal Baron has posted comments on this change.
Change subject: Prefetch domains when connecting a storage server.
..
Patch Set 5: I would prefer that you didn't submit this
(7 inline comments)
Ayal Baron has posted comments on this change.
Change subject: Remove hbtl attribute of non-scsi devices
..
Patch Set 2: (3 inline comments)
File vdsm/storage/multipath.py
Ayal Baron has posted comments on this change.
Change subject: getAllVolumes returns partially deleted volumes too.
..
Patch Set 3: (1 inline comment)
File
Ayal Baron has posted comments on this change.
Change subject: Prefetch domains when connecting a storage server.
..
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
Ayal Baron has posted comments on this change.
Change subject: getAllVolumes returns partially deleted volumes too.
..
Patch Set 2: (5 inline comments)
File
Ayal Baron has posted comments on this change.
Change subject: Prefetch domains when connecting a storage server.
..
Patch Set 2: (3 inline comments)
File
Ayal Baron has posted comments on this change.
Change subject: getAllTasksList\Status with 'spm_tasks' option retrieves info
only if host SPM
..
Patch Set 8:
Adding 1 variable in 'options' and 1 variable externally but
Ayal Baron has posted comments on this change.
Change subject: image: unify the getChainTemplate method
..
Patch Set 1: (5 inline comments)
Commit Message
Line 3:
Ayal Baron has posted comments on this change.
Change subject: dumpStorageTable to handle images with multiple leaf volumes
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12703
To
Ayal Baron has posted comments on this change.
Change subject: Relink template hard links to meta and lease files
..
Patch Set 1: I would prefer that you didn't submit this
(5 inline comments)
Ayal Baron has posted comments on this change.
Change subject: getAllTasksList\Status with 'spm_tasks' option retrieves info
only if host SPM
..
Patch Set 8: I would prefer that you didn't submit this
(4 inline comments)
Ayal Baron has posted comments on this change.
Change subject: BZ890983 - allow dumpStorageTable to handle images with
multiple leaf volumes
..
Patch Set 1: (3 inline comments)
Ayal Baron has posted comments on this change.
Change subject: hooks: Add disk hot plug/unplug hooks
..
Patch Set 3: (1 inline comment)
File vdsm/vdsmd.8.in
Line 66:
Ayal Baron has posted comments on this change.
Change subject: If attachSD fails - rescan for new vgs not visible from spm
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10495
To
Ayal Baron has posted comments on this change.
Change subject: Ignore postZero flag when deleting an image on a fileSD.
..
Patch Set 3: Looks good to me, approved
Wrt postZero explanation - that is was and will be part of the
Ayal Baron has posted comments on this change.
Change subject: Ignore postZero flag when deleting an image on a fileSD.
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12404
To unsubscribe,
Ayal Baron has posted comments on this change.
Change subject: image: Set legality of volume to LEGAL after copy
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12457
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: pool: refactor getInfo and getRepoStats
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10304
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: sos: Follow symbolic links with tree command
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12386
To
Ayal Baron has posted comments on this change.
Change subject: Do not delete the template when zeroing a dependant image.
..
Patch Set 2: I would prefer that you didn't submit this
Dan, the fact that this patch fixes the bug
Ayal Baron has posted comments on this change.
Change subject: Do not delete the template when zeroing a dependant image.
..
Patch Set 2:
Dan, what Edu is doing is what I said but in the wrong way. He created
Ayal Baron has posted comments on this change.
Change subject: Change lvm filter use of regular expression to 'replace \x'
..
Patch Set 4: Looks good to me, approved
Dan's comment is not relevant as whatever names device
Ayal Baron has posted comments on this change.
Change subject: Adding VM based locks to ovf modify functions.
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9456
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: Fix regular expression matching for lvm filter
..
Patch Set 2: (2 inline comments)
File vdsm/storage/lvm.py
Ayal Baron has posted comments on this change.
Change subject: Fix regular expression matching for lvm filter
..
Patch Set 2: (1 inline comment)
File vdsm/storage/lvm.py
401 - 500 of 933 matches
Mail list logo
