Change in vdsm[master]: [WIP]add simple balloon functional testcase

2013-11-12 Thread agl
Adam Litke has posted comments on this change. Change subject: [WIP]add simple balloon functional testcase .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/12820 To unsubscribe, visit

Change in vdsm[master]: gluster: verbs for managing services

2013-07-12 Thread agl
Adam Litke has posted comments on this change. Change subject: gluster: verbs for managing services .. Patch Set 24: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11094 To

Change in vdsm[master]: Rename balloon_min to min_guarantee in balloon information

2013-07-12 Thread agl
Adam Litke has posted comments on this change. Change subject: Rename balloon_min to min_guarantee in balloon information .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: Enable balloon and use the MoM multiple policies feature

2013-07-12 Thread agl
Adam Litke has posted comments on this change. Change subject: Enable balloon and use the MoM multiple policies feature .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: [WIP] Implement python bindings

2013-07-08 Thread agl
Adam Litke has abandoned this change. Change subject: [WIP] Implement python bindings .. Patch Set 8: Abandoned Bitrot -- To view, visit http://gerrit.ovirt.org/11755 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: netinfo: Items in the 'bridges' dict are missing the 'bridge...

2013-07-08 Thread agl
Adam Litke has abandoned this change. Change subject: netinfo: Items in the 'bridges' dict are missing the 'bridged' field .. Patch Set 6: Abandoned Bitrot -- To view, visit http://gerrit.ovirt.org/11567 To unsubscribe,

Change in vdsm[master]: vdsm-jsonrpc depends on vdsm-yajsonrpc

2013-07-08 Thread agl
Adam Litke has abandoned this change. Change subject: vdsm-jsonrpc depends on vdsm-yajsonrpc .. Patch Set 2: Abandoned Bitrot -- To view, visit http://gerrit.ovirt.org/12317 To unsubscribe, visit

Change in vdsm[master]: schema: Fix the Hooks schema definition

2013-07-08 Thread agl
Adam Litke has abandoned this change. Change subject: schema: Fix the Hooks schema definition .. Patch Set 9: Abandoned Bitrot -- To view, visit http://gerrit.ovirt.org/11568 To unsubscribe, visit

Change in vdsm[master]: caps: Ensure package version data are always strings

2013-07-08 Thread agl
Adam Litke has abandoned this change. Change subject: caps: Ensure package version data are always strings .. Patch Set 9: Abandoned Bitrot -- To view, visit http://gerrit.ovirt.org/11569 To unsubscribe, visit

Change in vdsm[master]: api: address and deviceId are optional for VM devices

2013-07-08 Thread agl
Adam Litke has abandoned this change. Change subject: api: address and deviceId are optional for VM devices .. Patch Set 1: Abandoned Bitrot -- To view, visit http://gerrit.ovirt.org/12316 To unsubscribe, visit

Change in vdsm[master]: gluster: new vdsm verb glusterHostUUIDGet

2013-06-05 Thread agl
Adam Litke has posted comments on this change. Change subject: gluster: new vdsm verb glusterHostUUIDGet .. Patch Set 4: (1 inline comment) File

Change in vdsm[master]: gluster: Added verbs for read, update, add and remove hooks

2013-06-03 Thread agl
Adam Litke has posted comments on this change. Change subject: gluster: Added verbs for read, update, add and remove hooks .. Patch Set 5: (2 inline comments) File

Change in vdsm[master]: gluster: verbs for managing services

2013-05-31 Thread agl
Adam Litke has posted comments on this change. Change subject: gluster: verbs for managing services .. Patch Set 18: I would prefer that you didn't submit this (1 inline comment) One small change to make it correct. You can

Change in vdsm[master]: gluster: new vdsm verb glusterHostUUIDGet

2013-05-31 Thread agl
Adam Litke has posted comments on this change. Change subject: gluster: new vdsm verb glusterHostUUIDGet .. Patch Set 4: (1 inline comment) File

Change in vdsm[master]: gluster: Added gluster hooks support

2013-05-06 Thread agl
Adam Litke has posted comments on this change. Change subject: gluster: Added gluster hooks support .. Patch Set 30: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/9671 To

Change in vdsm[master]: vdsmapi: vdsmapi support for gluster vdsm verbs

2013-05-02 Thread agl
Adam Litke has posted comments on this change. Change subject: vdsmapi: vdsmapi support for gluster vdsm verbs .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13921 To unsubscribe, visit

Change in vdsm[master]: gluster: move exportToSupervdsm at module level

2013-04-26 Thread agl
Adam Litke has posted comments on this change. Change subject: gluster: move exportToSupervdsm at module level .. Patch Set 14: Looks good to me, but someone else must approve Looks ok to me. -- To view, visit

Change in vdsm[master]: gluster: Added gluster hooks support

2013-04-26 Thread agl
Adam Litke has posted comments on this change. Change subject: gluster: Added gluster hooks support .. Patch Set 27: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/9671 To

Change in vdsm[master]: vdsmapi: vdsmapi support for gluster vdsm verbs

2013-04-24 Thread agl
Adam Litke has posted comments on this change. Change subject: vdsmapi: vdsmapi support for gluster vdsm verbs .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment) No major objections. Would like to

Change in vdsm[master]: make our udev rules take effect later than default Ubuntu lv...

2013-03-27 Thread agl
Adam Litke has posted comments on this change. Change subject: make our udev rules take effect later than default Ubuntu lvm rules .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: change vdsm to use multipolicy mom

2013-03-04 Thread agl
Adam Litke has posted comments on this change. Change subject: change vdsm to use multipolicy mom .. Patch Set 4: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: dynamicly generate json-rpc client proxy methods according t...

2013-03-04 Thread agl
Adam Litke has posted comments on this change. Change subject: dynamicly generate json-rpc client proxy methods according to schema .. Patch Set 11: I would prefer that you didn't submit this I think we should get the python

Change in vdsm[master]: netinfo: Items in the 'bridges' dict are missing the 'bridge...

2013-02-26 Thread agl
Adam Litke has posted comments on this change. Change subject: netinfo: Items in the 'bridges' dict are missing the 'bridged' field .. Patch Set 6: Verified -- To view, visit http://gerrit.ovirt.org/11567 To unsubscribe,

Change in vdsm[master]: schema: Fix the Hooks schema definition

2013-02-25 Thread agl
Adam Litke has posted comments on this change. Change subject: schema: Fix the Hooks schema definition .. Patch Set 9: Verified -- To view, visit http://gerrit.ovirt.org/11568 To unsubscribe, visit

Change in vdsm[master]: caps: Ensure package version data are always strings

2013-02-25 Thread agl
Adam Litke has posted comments on this change. Change subject: caps: Ensure package version data are always strings .. Patch Set 9: Verified -- To view, visit http://gerrit.ovirt.org/11569 To unsubscribe, visit

Change in vdsm[master]: api: address and deviceId are optional for VM devices

2013-02-25 Thread agl
Adam Litke has posted comments on this change. Change subject: api: address and deviceId are optional for VM devices .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/12316 To unsubscribe, visit

Change in vdsm[master]: vdsm-jsonrpc depends on vdsm-yajsonrpc

2013-02-25 Thread agl
Adam Litke has posted comments on this change. Change subject: vdsm-jsonrpc depends on vdsm-yajsonrpc .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/12317 To unsubscribe, visit

Change in vdsm[master]: vdsm-jsonrpc depends on vdsm-yajsonrpc

2013-02-22 Thread agl
Adam Litke has uploaded a new change for review. Change subject: vdsm-jsonrpc depends on vdsm-yajsonrpc .. vdsm-jsonrpc depends on vdsm-yajsonrpc Vdsm's jsonrpc server binding imports yajsonrpc but the spec file does not list

Change in vdsm[master]: api: address and deviceId are optional for VM devices

2013-02-22 Thread agl
Adam Litke has uploaded a new change for review. Change subject: api: address and deviceId are optional for VM devices .. api: address and deviceId are optional for VM devices Signed-off-by: Adam Litke a...@us.ibm.com

Change in vdsm[master]: add verb for vdsm to tuneCpu params

2013-02-18 Thread agl
Adam Litke has posted comments on this change. Change subject: add verb for vdsm to tuneCpu params .. Patch Set 8: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7492 To unsubscribe,

Change in vdsm[master]: tests: Skip tests that behave badly when run in parallel

2013-02-18 Thread agl
Adam Litke has uploaded a new change for review. Change subject: tests: Skip tests that behave badly when run in parallel .. tests: Skip tests that behave badly when run in parallel A particular test:

Change in vdsm[master]: tests: Skip tests that behave badly when run in parallel

2013-02-18 Thread agl
Adam Litke has posted comments on this change. Change subject: tests: Skip tests that behave badly when run in parallel .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/12173 To unsubscribe, visit

Change in vdsm[master]: tests: Skip stress tests that behave badly when run in paral...

2013-02-18 Thread agl
Adam Litke has posted comments on this change. Change subject: tests: Skip stress tests that behave badly when run in parallel .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/12173 To unsubscribe, visit

Change in vdsm[master]: fix Exception message error in apiTests module

2013-02-15 Thread agl
Adam Litke has posted comments on this change. Change subject: fix Exception message error in apiTests module .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11289 To

Change in vdsm[master]: add a json rpc funtional test which sets up a VM

2013-02-15 Thread agl
Adam Litke has posted comments on this change. Change subject: add a json rpc funtional test which sets up a VM .. Patch Set 4: I would prefer that you didn't submit this (2 inline comments)

Change in vdsm[master]: blocksd: skip broken images in getAllVolumes

2013-02-15 Thread agl
Adam Litke has posted comments on this change. Change subject: blocksd: skip broken images in getAllVolumes .. Patch Set 2: FYI: This may be a candidate for fixing https://bugzilla.redhat.com/show_bug.cgi?id=910013 -- To

Change in vdsm[master]: api: Organize schema symbols by type

2013-02-15 Thread agl
Adam Litke has uploaded a new change for review. Change subject: api: Organize schema symbols by type .. api: Organize schema symbols by type Currently the vdsmapi module returns the parsed schema as a large list of symbols.

Change in vdsm[master]: api: Convert schemaTests to use vdsmapi.get_api

2013-02-15 Thread agl
Adam Litke has uploaded a new change for review. Change subject: api: Convert schemaTests to use vdsmapi.get_api .. api: Convert schemaTests to use vdsmapi.get_api Change-Id: I3e5716fcb9724621f4fb282746bf02958b1972d4

Change in vdsm[master]: api: Move DynamicBridge to vdsmapi schema processing

2013-02-15 Thread agl
Adam Litke has uploaded a new change for review. Change subject: api: Move DynamicBridge to vdsmapi schema processing .. api: Move DynamicBridge to vdsmapi schema processing Signed-off-by: Adam Litke a...@us.ibm.com Change-Id:

Change in vdsm[master]: api: Convert process_schema.py to use vdsmapi.get_api()

2013-02-15 Thread agl
Adam Litke has uploaded a new change for review. Change subject: api: Convert process_schema.py to use vdsmapi.get_api() .. api: Convert process_schema.py to use vdsmapi.get_api() Change-Id:

Change in vdsm[master]: gluster: add task support

2013-02-15 Thread agl
Adam Litke has posted comments on this change. Change subject: gluster: add task support .. Patch Set 4: I would prefer that you didn't submit this (1 inline comment) Some TODO items regarding the schema.

Change in vdsm[master]: api: Organize schema symbols by type

2013-02-15 Thread agl
Adam Litke has posted comments on this change. Change subject: api: Organize schema symbols by type .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/12106 To unsubscribe, visit

Change in vdsm[master]: api: Remove some unneeded functions from vdsmapi.py

2013-02-15 Thread agl
Adam Litke has posted comments on this change. Change subject: api: Remove some unneeded functions from vdsmapi.py .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/11865 To unsubscribe, visit

Change in vdsm[master]: api: Separate api schema into its own package

2013-02-15 Thread agl
Adam Litke has posted comments on this change. Change subject: api: Separate api schema into its own package .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/11864 To unsubscribe, visit

Change in vdsm[master]: api: Convert schemaTests to use vdsmapi.get_api

2013-02-15 Thread agl
Adam Litke has posted comments on this change. Change subject: api: Convert schemaTests to use vdsmapi.get_api .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/12108 To unsubscribe, visit

Change in vdsm[master]: api: Convert process_schema.py to use vdsmapi.get_api()

2013-02-15 Thread agl
Adam Litke has posted comments on this change. Change subject: api: Convert process_schema.py to use vdsmapi.get_api() .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/12109 To unsubscribe, visit

Change in vdsm[master]: tests: Avoid ResourceManagerTests failures when running para...

2013-02-14 Thread agl
Adam Litke has posted comments on this change. Change subject: tests: Avoid ResourceManagerTests failures when running parallel tests .. Patch Set 2: (1 inline comment)

Change in vdsm[master]: tests: Avoid ResourceManagerTests failures when running para...

2013-02-14 Thread agl
Adam Litke has posted comments on this change. Change subject: tests: Avoid ResourceManagerTests failures when running parallel tests .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/12034 To unsubscribe,

Change in vdsm[master]: Added a support for a guest hibernate command.

2013-02-14 Thread agl
Adam Litke has posted comments on this change. Change subject: Added a support for a guest hibernate command. .. Patch Set 15: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: tests: Make getFreePort work in a multithreaded environment

2013-02-13 Thread agl
Adam Litke has uploaded a new change for review. Change subject: tests: Make getFreePort work in a multithreaded environment .. tests: Make getFreePort work in a multithreaded environment getFreePort does not currently work

Change in vdsm[master]: tests: Make getFreePort work in a multithreaded environment

2013-02-13 Thread agl
Adam Litke has posted comments on this change. Change subject: tests: Make getFreePort work in a multithreaded environment .. Patch Set 2: Verified I can locally run 8 copies of the tests at the same time with this patch. --

Change in vdsm[master]: tests: Avoid ResourceManagerTests failures when running para...

2013-02-13 Thread agl
Adam Litke has uploaded a new change for review. Change subject: tests: Avoid ResourceManagerTests failures when running parallel tests .. tests: Avoid ResourceManagerTests failures when running parallel tests In the Jenkins

Change in vdsm[master]: tests: Avoid ResourceManagerTests failures when running para...

2013-02-13 Thread agl
Adam Litke has posted comments on this change. Change subject: tests: Avoid ResourceManagerTests failures when running parallel tests .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/12034 To unsubscribe,

Change in vdsm[master]: tests: Avoid ResourceManagerTests failures when running para...

2013-02-13 Thread agl
Adam Litke has posted comments on this change. Change subject: tests: Avoid ResourceManagerTests failures when running parallel tests .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/12034 To unsubscribe,

Change in vdsm[master]: blocksd: skip broken images in getAllVolumes

2013-02-11 Thread agl
Adam Litke has posted comments on this change. Change subject: blocksd: skip broken images in getAllVolumes .. Patch Set 2: Looks good to me, but someone else must approve Yes please! We are actually seeing this in a

Change in vdsm[master]: api: Separate api schema into its own package

2013-02-08 Thread agl
Adam Litke has uploaded a new change for review. Change subject: api: Separate api schema into its own package .. api: Separate api schema into its own package The vdsm schema definition is needed by the vdsm server but also by

Change in vdsm[master]: api: Remove some unneeded functions from vdsmapi.py

2013-02-08 Thread agl
Adam Litke has uploaded a new change for review. Change subject: api: Remove some unneeded functions from vdsmapi.py .. api: Remove some unneeded functions from vdsmapi.py Change-Id: I25d534033f089bf9f36592bd2be0e98f2fde2dfe

Change in vdsm[master]: jsonrpc: Fix race in ProtonReactor and add better delivery s...

2013-02-07 Thread agl
Adam Litke has posted comments on this change. Change subject: jsonrpc: Fix race in ProtonReactor and add better delivery semantics .. Patch Set 11: Looks good to me, but someone else must approve Thanks for the explanation

Change in vdsm[master]: [WIP] Implement python bindings

2013-02-07 Thread agl
Adam Litke has posted comments on this change. Change subject: [WIP] Implement python bindings .. Patch Set 2: (7 inline comments) File vdsm_api/vdsmapi-schema.json Line

Change in vdsm[master]: jsonrpc: Make jsonrpc an independent package

2013-02-06 Thread agl
Adam Litke has posted comments on this change. Change subject: jsonrpc: Make jsonrpc an independent package .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11710 To

Change in vdsm[master]: jsonrpc: Fix race in ProtonReactor and add better delivery s...

2013-02-06 Thread agl
Adam Litke has posted comments on this change. Change subject: jsonrpc: Fix race in ProtonReactor and add better delivery semantics .. Patch Set 11: (1 inline comment)

Change in vdsm[master]: jsonrpc: Add multi-threading option to JsonRpcServer

2013-02-06 Thread agl
Adam Litke has posted comments on this change. Change subject: jsonrpc: Add multi-threading option to JsonRpcServer .. Patch Set 11: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: jsonrpc: Federate context and request-response objects

2013-02-06 Thread agl
Adam Litke has posted comments on this change. Change subject: jsonrpc: Federate context and request-response objects .. Patch Set 11: Looks good to me, but someone else must approve Patch is unchanged and my review stands

Change in vdsm[master]: jsonrpc: Federate context and request-response objects

2013-02-06 Thread agl
Adam Litke has posted comments on this change. Change subject: jsonrpc: Federate context and request-response objects .. Patch Set 11: Verified -- To view, visit http://gerrit.ovirt.org/10375 To unsubscribe, visit

Change in vdsm[master]: jsonrpc: Add multi-threading option to JsonRpcServer

2013-02-06 Thread agl
Adam Litke has posted comments on this change. Change subject: jsonrpc: Add multi-threading option to JsonRpcServer .. Patch Set 11: Verified -- To view, visit http://gerrit.ovirt.org/10374 To unsubscribe, visit

Change in vdsm[master]: jsonrpc: Change cxtr to connector to make the code a bit mor...

2013-02-06 Thread agl
Adam Litke has posted comments on this change. Change subject: jsonrpc: Change cxtr to connector to make the code a bit more understandable .. Patch Set 10: Verified; Looks good to me, but someone else must approve Carrying

Change in vdsm[master]: jsonrpc: Add support for multiple listeners

2013-02-06 Thread agl
Adam Litke has posted comments on this change. Change subject: jsonrpc: Add support for multiple listeners .. Patch Set 5: Verified; Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: jsonrpc: Change start_listening to createListener

2013-02-06 Thread agl
Adam Litke has posted comments on this change. Change subject: jsonrpc: Change start_listening to createListener .. Patch Set 5: Verified; Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: jsonrpc: Make reactor clients 1st class objects

2013-02-06 Thread agl
Adam Litke has posted comments on this change. Change subject: jsonrpc: Make reactor clients 1st class objects .. Patch Set 5: Verified; Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: jsonrpc: Use asyncore instead of custom solution

2013-02-06 Thread agl
Adam Litke has posted comments on this change. Change subject: jsonrpc: Use asyncore instead of custom solution .. Patch Set 6: Verified; Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: jsonrpc: Check for credit before popping a message from the ...

2013-02-06 Thread agl
Adam Litke has posted comments on this change. Change subject: jsonrpc: Check for credit before popping a message from the queue .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: jsonrpc: Remove unecessary check

2013-02-06 Thread agl
Adam Litke has posted comments on this change. Change subject: jsonrpc: Remove unecessary check .. Patch Set 3: Verified Please add a reason why the check is not needed to your commit message. -- To view, visit

Change in vdsm[master]: tests: (OCD) Add space at the end of the sample string

2013-02-06 Thread agl
Adam Litke has posted comments on this change. Change subject: tests: (OCD) Add space at the end of the sample string .. Patch Set 3: Verified; Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: jsonrpc: Use the AsyncoreClient implementation in tests too

2013-02-06 Thread agl
Adam Litke has posted comments on this change. Change subject: jsonrpc: Use the AsyncoreClient implementation in tests too .. Patch Set 3: Verified; Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: jsonrpc: Make jsonrpc an independent package

2013-02-06 Thread agl
Adam Litke has posted comments on this change. Change subject: jsonrpc: Make jsonrpc an independent package .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/11710 To unsubscribe, visit

Change in vdsm[master]: netinfo: report IPv6 information

2013-02-06 Thread agl
Adam Litke has posted comments on this change. Change subject: netinfo: report IPv6 information .. Patch Set 6: Looks good to me, but someone else must approve I don't see any problems with the schema changes. -- To view,

Change in vdsm[master]: caps: Ensure package version data are always strings

2013-02-05 Thread agl
Adam Litke has posted comments on this change. Change subject: caps: Ensure package version data are always strings .. Patch Set 2: (2 inline comments) File vdsm/caps.py

Change in vdsm[master]: netinfo: Items in the 'bridges' dict are missing the 'bridge...

2013-02-05 Thread agl
Adam Litke has posted comments on this change. Change subject: netinfo: Items in the 'bridges' dict are missing the 'bridged' field .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/11567 To unsubscribe,

Change in vdsm[master]: [WIP] Implement python bindings

2013-02-05 Thread agl
Adam Litke has uploaded a new change for review. Change subject: [WIP] Implement python bindings .. [WIP] Implement python bindings This patch produces a native way for python programs to work with the vdsm jsonrpc API without

Change in vdsm[master]: schema: Fix the Hooks schema definition

2013-02-05 Thread agl
Adam Litke has posted comments on this change. Change subject: schema: Fix the Hooks schema definition .. Patch Set 5: Verified -- To view, visit http://gerrit.ovirt.org/11568 To unsubscribe, visit

Change in vdsm[master]: schema: Fix the Hooks schema definition

2013-02-05 Thread agl
Adam Litke has posted comments on this change. Change subject: schema: Fix the Hooks schema definition .. Patch Set 6: Verified -- To view, visit http://gerrit.ovirt.org/11568 To unsubscribe, visit

Change in vdsm[master]: caps: Ensure package version data are always strings

2013-02-05 Thread agl
Adam Litke has posted comments on this change. Change subject: caps: Ensure package version data are always strings .. Patch Set 6: Verified -- To view, visit http://gerrit.ovirt.org/11569 To unsubscribe, visit

Change in vdsm[master]: netinfo: Items in the 'bridges' dict are missing the 'bridge...

2013-02-05 Thread agl
Adam Litke has posted comments on this change. Change subject: netinfo: Items in the 'bridges' dict are missing the 'bridged' field .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/11567 To unsubscribe,

Change in vdsm[master]: jsonrpc: Make jsonrpc an independent package

2013-02-04 Thread agl
Adam Litke has posted comments on this change. Change subject: jsonrpc: Make jsonrpc an independent package .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11710 To

Change in vdsm[master]: netinfo: Items in the 'bridges' dict are missing the 'bridge...

2013-02-04 Thread agl
Adam Litke has posted comments on this change. Change subject: netinfo: Items in the 'bridges' dict are missing the 'bridged' field .. Patch Set 1: (1 inline comment) File

Change in vdsm[master]: schema: Update VmDefinition to match current behavior

2013-02-04 Thread agl
Adam Litke has uploaded a new change for review. Change subject: schema: Update VmDefinition to match current behavior .. schema: Update VmDefinition to match current behavior The schema for VmDefinition was incorrect in that

Change in vdsm[master]: schema: Eliminate 'class' from StorageDomainInfo

2013-02-04 Thread agl
Adam Litke has uploaded a new change for review. Change subject: schema: Eliminate 'class' from StorageDomainInfo .. schema: Eliminate 'class' from StorageDomainInfo 'class' is usually a reserved word and makes a bad name for a

Change in vdsm[master]: caps: Ensure package version data are always strings

2013-02-04 Thread agl
Adam Litke has posted comments on this change. Change subject: caps: Ensure package version data are always strings .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/11569 To unsubscribe, visit

Change in vdsm[master]: schema: Eliminate 'class' from StorageDomainInfo

2013-02-04 Thread agl
Adam Litke has posted comments on this change. Change subject: schema: Eliminate 'class' from StorageDomainInfo .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/11711 To unsubscribe, visit

Change in vdsm[master]: schema: Update VmDefinition to match current behavior

2013-02-04 Thread agl
Adam Litke has posted comments on this change. Change subject: schema: Update VmDefinition to match current behavior .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/11712 To unsubscribe, visit

Change in vdsm[master]: netinfo: Items in the 'bridges' dict are missing the 'bridge...

2013-02-01 Thread agl
Adam Litke has posted comments on this change. Change subject: netinfo: Items in the 'bridges' dict are missing the 'bridged' field .. Patch Set 1: (1 inline comment) File

Change in vdsm[master]: jsonrpc: Rearrange test classes for reusability

2013-01-30 Thread agl
Adam Litke has posted comments on this change. Change subject: jsonrpc: Rearrange test classes for reusability .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/11122 To unsubscribe, visit

Change in vdsm[master]: change vdsm to use multipolicy mom

2013-01-30 Thread agl
Adam Litke has posted comments on this change. Change subject: change vdsm to use multipolicy mom .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment) Mom doesn't yet have a 0.3.1 version so

Change in vdsm[master]: caps: Ensure package version data are always strings

2013-01-30 Thread agl
Adam Litke has uploaded a new change for review. Change subject: caps: Ensure package version data are always strings .. caps: Ensure package version data are always strings According to the schema, package version information

Change in vdsm[master]: schema: Fix the Hooks schema definition

2013-01-30 Thread agl
Adam Litke has uploaded a new change for review. Change subject: schema: Fix the Hooks schema definition .. schema: Fix the Hooks schema definition The schema does not correctly describe the format of the hook info as returned

Change in vdsm[master]: netinfo: Items in the 'bridges' dict are missing the 'bridge...

2013-01-30 Thread agl
Adam Litke has uploaded a new change for review. Change subject: netinfo: Items in the 'bridges' dict are missing the 'bridged' field .. netinfo: Items in the 'bridges' dict are missing the 'bridged' field According to the

Change in vdsm[master]: schema: Strengthen schema verification

2013-01-25 Thread agl
Adam Litke has uploaded a new change for review. Change subject: schema: Strengthen schema verification .. schema: Strengthen schema verification Add additional checking to process-schema.py to detect the following errors: -

Change in vdsm[master]: schema: bridges was added to VdsmCapabilities

2013-01-25 Thread agl
Adam Litke has uploaded a new change for review. Change subject: schema: bridges was added to VdsmCapabilities .. schema: bridges was added to VdsmCapabilities In 1fa30a, Dan added a new field 'bridges' to VdsmCapabilities but

Change in vdsm[master]: schema: bridges was added to VdsmCapabilities

2013-01-25 Thread agl
Adam Litke has posted comments on this change. Change subject: schema: bridges was added to VdsmCapabilities .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/11396 To unsubscribe, visit

Change in vdsm[master]: Bridge: Fix the specification of the getAllTasks return valu...

2013-01-23 Thread agl
Adam Litke has uploaded a new change for review. Change subject: Bridge: Fix the specification of the getAllTasks return value .. Bridge: Fix the specification of the getAllTasks return value Change-Id:

  1   2   3   4   5   6   >