Change in vdsm[master]: domainMonitor: Introduce cancellation points

Allon Mureinik has posted comments on this change. Change subject: domainMonitor: Introduce cancellation points .. Patch Set 5: ping? -- To view, visit http://gerrit.ovirt.org/28721 To unsubscribe, visit

Change in vdsm[master]: domainMonitor: Fix unsafe status handling

Allon Mureinik has posted comments on this change. Change subject: domainMonitor: Fix unsafe status handling .. Patch Set 1: ping? -- To view, visit http://gerrit.ovirt.org/29014 To unsubscribe, visit

Change in vdsm[master]: assert: Replace assertions with AssertionError

Allon Mureinik has posted comments on this change. Change subject: assert: Replace assertions with AssertionError .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/29307 To unsubscribe, visit

Change in vdsm[master]: task: streamlining lock acquiring api

Allon Mureinik has posted comments on this change. Change subject: task: streamlining lock acquiring api .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/29729 To unsubscribe, visit

Change in vdsm[master]: fencing: Introduce getHostLeaseStatus API

Allon Mureinik has posted comments on this change. Change subject: fencing: Introduce getHostLeaseStatus API .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28873 To unsubscribe, visit

Change in vdsm[master]: sd: IncorrectFormat cannot be decoded

Allon Mureinik has posted comments on this change. Change subject: sd: IncorrectFormat cannot be decoded .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28647 To unsubscribe, visit

Change in vdsm[master]: virt: Change log level for disk stats collection failure

Allon Mureinik has posted comments on this change. Change subject: virt: Change log level for disk stats collection failure .. Patch Set 1: Ping? -- To view, visit http://gerrit.ovirt.org/29677 To unsubscribe, visit

Change in vdsm[master]: blockSD: raise an exception if missing physical volume

Allon Mureinik has posted comments on this change. Change subject: blockSD: raise an exception if missing physical volume .. Patch Set 7: ping? -- To view, visit http://gerrit.ovirt.org/27442 To unsubscribe, visit

Change in vdsm[master]: tests: introducing whitebox tests

Allon Mureinik has posted comments on this change. Change subject: tests: introducing whitebox tests .. Patch Set 3: @Alon - IMHO, it's a good test, albeit misplaced. Why would we want to remove it? -- To view, visit

Change in vdsm[master]: tests: introducing whitebox tests

Allon Mureinik has posted comments on this change. Change subject: tests: introducing whitebox tests .. Patch Set 3: Code-Review+1 Alon - If I get your point correctly, what's missing here is documentation - a list of

Change in vdsm[master]: fencing: Introduce getHostLeaseStatus API

Allon Mureinik has posted comments on this change. Change subject: fencing: Introduce getHostLeaseStatus API .. Patch Set 8: ping? any news on this? -- To view, visit http://gerrit.ovirt.org/28873 To unsubscribe, visit

Change in vdsm[master]: init: Start vdsmd after required services

Allon Mureinik has posted comments on this change. Change subject: init: Start vdsmd after required services .. Patch Set 2: Code-Review+1 Fixed a couple of typos and grammar issues in the commit message, didn't touch the

Change in vdsm[master]: init: Start vdsmd after required services

Allon Mureinik has posted comments on this change. Change subject: init: Start vdsmd after required services .. Patch Set 2: Nir, can you please verify so this can be merged? -- To view, visit http://gerrit.ovirt.org/30659

Change in vdsm[master]: blockSD: raise an exception if missing physical volume

Allon Mureinik has posted comments on this change. Change subject: blockSD: raise an exception if missing physical volume .. Patch Set 7: Fede, what's your take on this? Can we proceed? -- To view, visit

Change in vdsm[ovirt-3.5]: virt: Restore BC for block type live snapshots

Allon Mureinik has posted comments on this change. Change subject: virt: Restore BC for block type live snapshots .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/30228 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: mailbox: Remove fatal, uneeded, and racy check

Allon Mureinik has posted comments on this change. Change subject: mailbox: Remove fatal, uneeded, and racy check .. Patch Set 2: Fixed commit message with proper BZ - Nir, please verify so this can be merged. -- To view,

Change in vdsm[ovirt-3.5]: mailbox: Remove fatal, uneeded, and racy check

Allon Mureinik has posted comments on this change. Change subject: mailbox: Remove fatal, uneeded, and racy check .. Patch Set 3: Can you verify too please? -- To view, visit http://gerrit.ovirt.org/29981 To unsubscribe,

Change in vdsm[master]: mailbox: Remove fatal, uneeded, and racy check

Allon Mureinik has posted comments on this change. Change subject: mailbox: Remove fatal, uneeded, and racy check .. Patch Set 2: Code-Review+1 Using with instead of try-finally in checkForMail seems more elegant, but that

Change in vdsm[ovirt-3.5]: vdsm: Missing hostId parameter on reconstructMaster verb

Allon Mureinik has posted comments on this change. Change subject: vdsm: Missing hostId parameter on reconstructMaster verb .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/29861 To unsubscribe, visit

Change in vdsm[master]: mailbox: Fix unsafe locking

Allon Mureinik has posted comments on this change. Change subject: mailbox: Fix unsafe locking .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/29855 To unsubscribe, visit

Change in vdsm[master]: mailbox: Log traceback after fatal failures in mailbox monitors

Allon Mureinik has posted comments on this change. Change subject: mailbox: Log traceback after fatal failures in mailbox monitors .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/29853 To unsubscribe,

Change in vdsm[master]: mailbox: Remove fatal, uneeded, and racy check

Allon Mureinik has posted comments on this change. Change subject: mailbox: Remove fatal, uneeded, and racy check .. Patch Set 2: Nir, can you please verify? -- To view, visit http://gerrit.ovirt.org/29854 To unsubscribe,

Change in vdsm[master]: domainMonitor: Fix unsafe iteration

Allon Mureinik has posted comments on this change. Change subject: domainMonitor: Fix unsafe iteration .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/29007 To unsubscribe, visit

Change in vdsm[master]: domainMonitor: Cleanup imports

Allon Mureinik has posted comments on this change. Change subject: domainMonitor: Cleanup imports .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/29015 To unsubscribe, visit

Change in vdsm[master]: fencing: Introduce getHostStatus internal API

Allon Mureinik has posted comments on this change. Change subject: fencing: Introduce getHostStatus internal API .. Patch Set 1: (4 comments) http://gerrit.ovirt.org/#/c/28873/1/vdsm/storage/clusterlock.py File

Change in vdsm[master]: fencing: Introduce getHostStatus internal API

Allon Mureinik has posted comments on this change. Change subject: fencing: Introduce getHostStatus internal API .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28873/1/vdsm/storage/hsm.py File vdsm/storage/hsm.py:

Change in vdsm[master]: clarify why scsiKey parameter is not passed on

Allon Mureinik has posted comments on this change. Change subject: clarify why scsiKey parameter is not passed on .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28560/1//COMMIT_MSG Commit Message: Line 6: Line 7:

Change in vdsm[master]: blockSD: do not try to parse metadata from missing pv

Allon Mureinik has posted comments on this change. Change subject: blockSD: do not try to parse metadata from missing pv .. Patch Set 3: Fede, can we move forward with this one? -- To view, visit

Change in vdsm[ovirt-3.4]: mutipath: Remove unneeded and dangerous -r parameter

Allon Mureinik has posted comments on this change. Change subject: mutipath: Remove unneeded and dangerous -r parameter .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28668 To unsubscribe, visit

Change in vdsm[master]: persistentDict: if no metadata do not calculate the checksum

Allon Mureinik has posted comments on this change. Change subject: persistentDict: if no metadata do not calculate the checksum .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27528 To unsubscribe,

Change in vdsm[master]: virt: Specify snapshot type

Allon Mureinik has posted comments on this change. Change subject: virt: Specify snapshot type .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/28531/1//COMMIT_MSG Commit Message: Line 15: the wrong value to be

Change in vdsm[master]: mount: Check if mount specification is a symlink

Allon Mureinik has posted comments on this change. Change subject: mount: Check if mount specification is a symlink .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27321 To unsubscribe, visit

Change in vdsm[master]: multipath: Rescan also FC devices

Allon Mureinik has posted comments on this change. Change subject: multipath: Rescan also FC devices .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27122 To unsubscribe, visit

Change in vdsm[ovirt-3.4]: blockVolume: prepare volumes for shrinkToOptimalSize

Allon Mureinik has posted comments on this change. Change subject: blockVolume: prepare volumes for shrinkToOptimalSize .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28382 To unsubscribe, visit

Change in vdsm[ovirt-3.4]: blockVolume: prepare volumes for shrinkToOptimalSize

Allon Mureinik has posted comments on this change. Change subject: blockVolume: prepare volumes for shrinkToOptimalSize .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28382/1//COMMIT_MSG Commit Message: Line 14:

Change in vdsm[ovirt-3.4]: hsm: unify vm ovf management lock

Allon Mureinik has posted comments on this change. Change subject: hsm: unify vm ovf management lock .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28379 To unsubscribe, visit

Change in vdsm[master]: multipath: Rescan also FC devices

Allon Mureinik has posted comments on this change. Change subject: multipath: Rescan also FC devices .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/27122/4/vdsm/storage/hba.py File vdsm/storage/hba.py: Line 48:

Change in vdsm[master]: Tests: log actual exceptions in RollbackContext

Allon Mureinik has posted comments on this change. Change subject: Tests: log actual exceptions in RollbackContext .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28175 To unsubscribe, visit

Change in vdsm[master]: blockSD: do not try to parse metadata from missing pv

Allon Mureinik has posted comments on this change. Change subject: blockSD: do not try to parse metadata from missing pv .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27442 To unsubscribe, visit

Change in vdsm[master]: vm: added missing diskReplicate slot in Drive class

Allon Mureinik has posted comments on this change. Change subject: vm: added missing diskReplicate slot in Drive class .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28131 To unsubscribe, visit

Change in vdsm[master]: vm: added missing diskReplicate slot in Drive class

Allon Mureinik has posted comments on this change. Change subject: vm: added missing diskReplicate slot in Drive class .. Patch Set 1: The unit test issue looks like a Jenkins foobar, not a real failure. -- To view, visit

Change in vdsm[master]: tests: fix wrong use of assertions

Allon Mureinik has posted comments on this change. Change subject: tests: fix wrong use of assertions .. Patch Set 2: Did you analyze the problem with the network functional tests? Is it just a normal Jenkins foobar, or does

Change in vdsm[master]: volume: use qemuimg and remove custom qemuConvert

Allon Mureinik has posted comments on this change. Change subject: volume: use qemuimg and remove custom qemuConvert .. Patch Set 4: Code-Review+1 (1 comment) Looks good to me. (See a minor suggestion to the commit message,

Change in vdsm[master]: hsm: unify vm ovf management lock

Allon Mureinik has posted comments on this change. Change subject: hsm: unify vm ovf management lock .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28068/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-05-23

Change in vdsm[master]: mutipath: Remove unneeded and dangerous -r parameter

Allon Mureinik has posted comments on this change. Change subject: mutipath: Remove unneeded and dangerous -r parameter .. Patch Set 1: ping? -- To view, visit http://gerrit.ovirt.org/27242 To unsubscribe, visit

Change in vdsm[master]: multipath: Rescan also FC devices

Allon Mureinik has posted comments on this change. Change subject: multipath: Rescan also FC devices .. Patch Set 2: ping? -- To view, visit http://gerrit.ovirt.org/27122 To unsubscribe, visit

Change in vdsm[master]: storage: use info log level to report missing checksum

Allon Mureinik has posted comments on this change. Change subject: storage: use info log level to report missing checksum .. Patch Set 1: I don't think that a WARNING is appropriate for a missing checksum, which we

Change in vdsm[master]: storage: ignore missing pv metadata

Allon Mureinik has posted comments on this change. Change subject: storage: ignore missing pv metadata .. Patch Set 1: Nir/Federico, can we proceed with this one? -- To view, visit http://gerrit.ovirt.org/27442 To

Change in vdsm[master]: storage: Add custom mount options to NFS SD

Allon Mureinik has posted comments on this change. Change subject: storage: Add custom mount options to NFS SD .. Patch Set 2: Code-Review+1 Federico, can we move forward with this? -- To view, visit

Change in vdsm[master]: storage: Add custom mount options to NFS SD

Allon Mureinik has posted comments on this change. Change subject: storage: Add custom mount options to NFS SD .. Patch Set 1: Code-Review+1 Xavi, can you post this as a non-draft patch? -- To view, visit

Change in vdsm[master]: storage: Add logging on filesystem altering operations

Allon Mureinik has posted comments on this change. Change subject: storage: Add logging on filesystem altering operations .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26046 To unsubscribe, visit

Change in vdsm[master]: sp: Remove invalid validation of stale meta data

Allon Mureinik has posted comments on this change. Change subject: sp: Remove invalid validation of stale meta data .. Patch Set 1: Reiterating myself: Nir, can you please verify so this can be merged? -- To view, visit

Change in vdsm[master]: spec: Require iscsi-initiator-utils = 6.2.0.873-21

Allon Mureinik has posted comments on this change. Change subject: spec: Require iscsi-initiator-utils = 6.2.0.873-21 .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27570 To unsubscribe, visit

Change in vdsm[ovirt-3.4]: hsm: fix setStoragePoolDescription execution

Allon Mureinik has posted comments on this change. Change subject: hsm: fix setStoragePoolDescription execution .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27543 To unsubscribe, visit

Change in vdsm[ovirt-3.4]: hsm: fix setStoragePoolDescription execution

Allon Mureinik has posted comments on this change. Change subject: hsm: fix setStoragePoolDescription execution .. Patch Set 1: @Federico, can you please verify? -- To view, visit http://gerrit.ovirt.org/27543 To

Change in vdsm[master]: sp: setDomainRegularRole is implemented by backend

Allon Mureinik has posted comments on this change. Change subject: sp: setDomainRegularRole is implemented by backend .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24495 To unsubscribe, visit

Change in vdsm[master]: storage: Add logging on filesystem altering operations

Allon Mureinik has posted comments on this change. Change subject: storage: Add logging on filesystem altering operations .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26046 To unsubscribe, visit

Change in vdsm[master]: multipath: Rescan also FC devices

Allon Mureinik has posted comments on this change. Change subject: multipath: Rescan also FC devices .. Patch Set 2: ping? -- To view, visit http://gerrit.ovirt.org/27122 To unsubscribe, visit

Change in vdsm[master]: mutipath: Remove unneeded and dangerous -r parameter

Allon Mureinik has posted comments on this change. Change subject: mutipath: Remove unneeded and dangerous -r parameter .. Patch Set 1: Code-Review+1 Nir, can you verify? -- To view, visit http://gerrit.ovirt.org/27242 To

Change in vdsm[ovirt-3.4]: fileUtils: Remove support for direct io on memory filesystems

Allon Mureinik has posted comments on this change. Change subject: fileUtils: Remove support for direct io on memory filesystems .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27535 To unsubscribe,

Change in vdsm[ovirt-3.4]: fileUtils: Remove support for direct io on memory filesystems

Allon Mureinik has posted comments on this change. Change subject: fileUtils: Remove support for direct io on memory filesystems .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27535/1//COMMIT_MSG Commit Message:

Change in vdsm[master]: sp: update domain links on state change

Allon Mureinik has posted comments on this change. Change subject: sp: update domain links on state change .. Patch Set 1: Code-Review+1 Ping? -- To view, visit http://gerrit.ovirt.org/27334 To unsubscribe, visit

Change in vdsm[master]: storage: ignore missing pv metadata

Allon Mureinik has posted comments on this change. Change subject: storage: ignore missing pv metadata .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27442 To unsubscribe, visit

Change in vdsm[master]: fileUtils: Remove support for direct io on memory filesystems

Allon Mureinik has posted comments on this change. Change subject: fileUtils: Remove support for direct io on memory filesystems .. Patch Set 1: Code-Review+1 Looks good to me. Please take a look at the test failure in

Change in vdsm[master]: spbackends: do not set spmRole on forceFreeSpm

Allon Mureinik has posted comments on this change. Change subject: spbackends: do not set spmRole on forceFreeSpm .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27318/1//COMMIT_MSG Commit Message: Line 8: Line 9:

Change in vdsm[master]: sp: update domain links on state change

Allon Mureinik has posted comments on this change. Change subject: sp: update domain links on state change .. Patch Set 1: Nir, without being able to access the domain, you cannot produce it. Hence, you have no way to know if

Change in vdsm[master]: core: fixing attribute error on fenceSpmStorage

Allon Mureinik has posted comments on this change. Change subject: core: fixing attribute error on fenceSpmStorage .. Patch Set 5: Federico/Liron - are we backporting the two merged patches, or are we waiting to merge

Change in vdsm[master]: Add logging on some filesystem operations

Allon Mureinik has posted comments on this change. Change subject: Add logging on some filesystem operations .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26046 To unsubscribe, visit

Change in vdsm[master]: sp: fix spm start when failing to produce domain

Allon Mureinik has posted comments on this change. Change subject: sp: fix spm start when failing to produce domain .. Patch Set 1: Liron, since http://gerrit.ovirt.org/#/c/25424 is merged, shouldn't this one be abandoned?

Change in vdsm[ovirt-3.4]: Create destination image as preallocated only if format is RAW

Allon Mureinik has posted comments on this change. Change subject: Create destination image as preallocated only if format is RAW .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/27274 To unsubscribe,

Change in vdsm[master]: core: return lver/spm id from pool metadata

Allon Mureinik has posted comments on this change. Change subject: core: return lver/spm id from pool metadata .. Patch Set 3: Liron, can you please backport this? -- To view, visit http://gerrit.ovirt.org/27226 To

Change in vdsm[master]: tests: fix read not blocksize aligned

Allon Mureinik has posted comments on this change. Change subject: tests: fix read not blocksize aligned .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27127 To unsubscribe, visit

Change in vdsm[ovirt-3.3]: fileUtils: Make memory filesystems support configurable

Allon Mureinik has posted comments on this change. Change subject: fileUtils: Make memory filesystems support configurable .. Patch Set 1: Code-Review+1 (1 comment) Why is this on ovirt-3.3 and not on master?

Change in vdsm[master]: Create destination image as preallocated only if format is RAW

Allon Mureinik has posted comments on this change. Change subject: Create destination image as preallocated only if format is RAW .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27244 To unsubscribe,

Change in vdsm[master]: core: fixing attribute error on fenceSpmStorage

Allon Mureinik has posted comments on this change. Change subject: core: fixing attribute error on fenceSpmStorage .. Patch Set 2: @Liron, can you please verify so we can get this merged? -- To view, visit

Change in vdsm[master]: core: fixing attribute error on fenceSpmStorage

Allon Mureinik has posted comments on this change. Change subject: core: fixing attribute error on fenceSpmStorage .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26358 To unsubscribe, visit

Change in vdsm[master]: core: fixing attribute error on fenceSpmStorage

Allon Mureinik has posted comments on this change. Change subject: core: fixing attribute error on fenceSpmStorage .. Patch Set 2: Fede, ping? -- To view, visit http://gerrit.ovirt.org/26358 To unsubscribe, visit

Change in vdsm[master]: lvm: Disable usage of lv_metad daemon

Allon Mureinik has posted comments on this change. Change subject: lvm: Disable usage of lv_metad daemon .. Patch Set 7: Nir, please backport this to the 3.4 branch -- To view, visit http://gerrit.ovirt.org/25408 To

Change in vdsm[master]: sp: Remove invalid validation of stale meta data

Allon Mureinik has posted comments on this change. Change subject: sp: Remove invalid validation of stale meta data .. Patch Set 1: Nir, can you please verify so this can be merged? -- To view, visit

Change in vdsm[master]: lvm: Disable usage of lv_metad daemon

Allon Mureinik has posted comments on this change. Change subject: lvm: Disable usage of lv_metad daemon .. Patch Set 4: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/25408/4//COMMIT_MSG Commit Message: Line 17:

Change in vdsm[master]: qemuimg: support relative backing file in create

Allon Mureinik has posted comments on this change. Change subject: qemuimg: support relative backing file in create .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26870 To unsubscribe, visit

Change in vdsm[master]: volume: unify the backing file path computation

Allon Mureinik has posted comments on this change. Change subject: volume: unify the backing file path computation .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26918 To unsubscribe, visit

Change in vdsm[master]: lvm: Disable usage of lv_metad daemon

Allon Mureinik has posted comments on this change. Change subject: lvm: Disable usage of lv_metad daemon .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/25408/3//COMMIT_MSG Commit Message: Line 33: caching code. This

Change in vdsm[master]: fileSD: enable mailbox on file domains

Allon Mureinik has posted comments on this change. Change subject: fileSD: enable mailbox on file domains .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26414 To unsubscribe, visit

Change in vdsm[ovirt-3.4]: hsm: Distinguish between iface and initiator when creating i...

Allon Mureinik has posted comments on this change. Change subject: hsm: Distinguish between iface and initiator when creating iSCSI iface .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26656 To

Change in vdsm[ovirt-3.4]: hsm: Rename _BCInitiatorNameResolve function

Allon Mureinik has posted comments on this change. Change subject: hsm: Rename _BCInitiatorNameResolve function .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26657 To unsubscribe, visit

Change in vdsm[ovirt-3.4]: iscsi: Specify tpgt to impose creation of a new style node r...

Allon Mureinik has posted comments on this change. Change subject: iscsi: Specify tpgt to impose creation of a new style node record .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26658 To

Change in vdsm[ovirt-3.4]: hsm: Rename _BCInitiatorNameResolve function

Allon Mureinik has posted comments on this change. Change subject: hsm: Rename _BCInitiatorNameResolve function .. Patch Set 2: @Yaniv, can we get this merged please? -- To view, visit http://gerrit.ovirt.org/26657 To

Change in vdsm[ovirt-3.4]: iscsi: Specify tpgt to impose creation of a new style node r...

Allon Mureinik has posted comments on this change. Change subject: iscsi: Specify tpgt to impose creation of a new style node record .. Patch Set 2: @Yaniv, can we get this merged please? -- To view, visit

Change in vdsm[ovirt-3.4]: hsm: Distinguish between iface and initiator when creating i...

Allon Mureinik has posted comments on this change. Change subject: hsm: Distinguish between iface and initiator when creating iSCSI iface .. Patch Set 2: @Yaniv, can we get this merged please? -- To view, visit

Change in vdsm[ovirt-3.4]: pad memory volume only when the storage domain is file based

Allon Mureinik has posted comments on this change. Change subject: pad memory volume only when the storage domain is file based .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26594 To unsubscribe,

Change in vdsm[ovirt-3.3]: hsm: refresh pool connection on connectStoragePool

Allon Mureinik has posted comments on this change. Change subject: hsm: refresh pool connection on connectStoragePool .. Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/26349/1//COMMIT_MSG Commit Message:

Change in vdsm[ovirt-3.3]: hsm: refresh pool connection on connectStoragePool

Allon Mureinik has posted comments on this change. Change subject: hsm: refresh pool connection on connectStoragePool .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26349 To unsubscribe, visit

Change in vdsm[ovirt-3.3]: hsm: refresh pool connection on connectStoragePool

Allon Mureinik has posted comments on this change. Change subject: hsm: refresh pool connection on connectStoragePool .. Patch Set 2: @Yaniv - can we get this merged please? [as noted, the -1 on verified by Jenkins is a bug in

Change in vdsm[master]: fileSD: enable mailbox on file domains

Allon Mureinik has posted comments on this change. Change subject: fileSD: enable mailbox on file domains .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/26414/3/vdsm/storage/sp.py File

Change in vdsm[master]: fileSD: unify the metadata permissions definition

Allon Mureinik has posted comments on this change. Change subject: fileSD: unify the metadata permissions definition .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26413 To unsubscribe, visit

Change in vdsm[master]: sd: improve metadata sizes definition

Allon Mureinik has posted comments on this change. Change subject: sd: improve metadata sizes definition .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26412 To unsubscribe, visit

Change in vdsm[master]: core: fixing attribute error on fenceSpmStorage

Allon Mureinik has posted comments on this change. Change subject: core: fixing attribute error on fenceSpmStorage .. Patch Set 2: Code-Review+1 Fede - what are we missing to get a +2 here? -- To view, visit

Change in vdsm[master]: sd: improve metadata sizes definition

Allon Mureinik has posted comments on this change. Change subject: sd: improve metadata sizes definition .. Patch Set 2: General +1 on the code, agree with Dan's comments though. -- To view, visit

Change in vdsm[master]: fileSD: unify the metadata permissions definition

Allon Mureinik has posted comments on this change. Change subject: fileSD: unify the metadata permissions definition .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26413 To unsubscribe, visit

<    3   4   5   6   7   8   9   10   11   >