Dan Kenigsberg has posted comments on this change.
Change subject: sos report: _importVdsmPylibModule can import all vdsm modules
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60627
To unsubscribe, v
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sos report: _importVdsmPylibModule can import all vdsm modules
..
sos report: _importVdsmPylibModule can import all vdsm modules
sos report cannot impo
Dan Kenigsberg has posted comments on this change.
Change subject: sos report: replace vdscli with jsonrpcvdscli
..
Patch Set 12:
(2 comments)
https://gerrit.ovirt.org/#/c/60605/12/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: properly teardown on hotunplug
..
hostdev: properly teardown on hotunplug
The device teardown mechanism is not explicitly invoked in hotunplug
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: use proper scsi address
..
hostdev: use proper scsi address
SCSI device requires different address than what we call host address,
as host add
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: properly detect attached scsi devices
..
hostdev: properly detect attached scsi devices
SCSI device is addressed by two fields: adapter, meani
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: improve robustness of libvirt SCSI access
..
hostdev: improve robustness of libvirt SCSI access
SCSI host device is specific as it's identifie
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: move usb device code to separate class
..
hostdev: move usb device code to separate class
We continue the effort of splitting the host device
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: use specific device classes in HostDevice
..
hostdev: use specific device classes in HostDevice
The device functionality has been split into s
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: move scsi device code to separate class
..
hostdev: move scsi device code to separate class
We continue the effort of splitting the host devic
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: move pci device code to separate class
..
hostdev: move pci device code to separate class
At present, we use a single class to contain all thr
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network/sr-iov: use device teardown to reattach device
..
network/sr-iov: use device teardown to reattach device
We have created a new mechanism for pr
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: cleanup udev files after PCI host devices
..
hostdev: cleanup udev files after PCI host devices
We have stopped reattaching PCI devices due to
Dan Kenigsberg has posted comments on this change.
Change subject: network/sr-iov: use device teardown to reattach device
..
Patch Set 6: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/60667/6/vdsm/virt/vmdevices/netwo
Dan Kenigsberg has submitted this change and it was merged.
Change subject: openstacknet hook: include after_vm_start hook in rpm
..
openstacknet hook: include after_vm_start hook in rpm
commit a655be4 excluded an important pie
Dan Kenigsberg has posted comments on this change.
Change subject: openstacknet hook: include after_vm_start hook in rpm
..
Patch Set 1: Code-Review+2 Verified+1
rpm builds, no code change vs. 4.0.
--
To view, visit https://g
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: drop legacy device config support
..
virt: drop legacy device config support
Drop the legacy Vm methods to rebuild specific device configuration
Dan Kenigsberg has posted comments on this change.
Change subject: virt: drop legacy device config support
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60326
To unsubscribe, visit https://gerrit.ovi
Dan Kenigsberg has posted comments on this change.
Change subject: contrib: jsonrpc: add example script to run a VM
..
Patch Set 2: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/61047/2/contrib/runvm
File contrib/run
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: graphics: drop legacy graphics config support
..
vm: graphics: drop legacy graphics config support
Drop the legacy Vm methods to rebuild specific g
Dan Kenigsberg has posted comments on this change.
Change subject: vm: graphics: drop legacy graphics config support
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60325
To unsubscribe, visit https://
Dan Kenigsberg has posted comments on this change.
Change subject: fix flag in contrib script
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61081
To unsubscribe, visit https://gerrit.ovirt.org/settin
Dan Kenigsberg has submitted this change and it was merged.
Change subject: fix flag in contrib script
..
fix flag in contrib script
Change-Id: I38e2b213fd1eace584bdb0705303560edb8c4a4e
Signed-off-by: Yaniv Bronhaim
Reviewed-o
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: s/parse/process
..
hostdev: s/parse/process
Hostdev library module uses term parse throughout it's libvirt XML
processing code. As previous se
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: prepare addition of per device processing
..
hostdev: prepare addition of per device processing
We presently have one large function _process_
Dan Kenigsberg has posted comments on this change.
Change subject: vdscli: Replace the default '::' host with hostname
..
Patch Set 1: Code-Review-1
please fix the test
--
To view, visit https://gerrit.ovirt.org/60020
To unsu
Dan Kenigsberg has posted comments on this change.
Change subject: openstacknet hook: include after_vm_start hook in rpm
..
Patch Set 1: Continuous-Integration+1
Unrelated
08:11:35 FAIL: testEnablePromisc (ipwrapperTests.TestD
Dan Kenigsberg has uploaded a new change for review.
Change subject: openstacknet hook: include after_vm_start hook in rpm
..
openstacknet hook: include after_vm_start hook in rpm
commit a655be4 excluded an important piece of th
Dan Kenigsberg has submitted this change and it was merged.
Change subject: openstacknet hook: include after_vm_start hook in rpm
..
openstacknet hook: include after_vm_start hook in rpm
commit a655be4 excluded an important pie
Dan Kenigsberg has posted comments on this change.
Change subject: openstacknet hook: include after_vm_start hook in rpm
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60897
To unsubscribe, visit http
Dan Kenigsberg has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 11: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/52354/11/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm
Dan Kenigsberg has posted comments on this change.
Change subject: contrib: Simple jsonrpc client
..
Patch Set 16: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/35181/16/contrib/jsonrpc
File contrib/jsonrpc:
Line 43:
Dan Kenigsberg has posted comments on this change.
Change subject: Rename execCmd and startCmd to run_cmd and start_cmd
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/60280/2/vdsm/hooking.py
File vdsm/hooking.py:
Li
Dan Kenigsberg has posted comments on this change.
Change subject: Using startCmd func for running async execution
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/60237/3/lib/vdsm/network/ipwrapper.py
File lib/vdsm/n
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Remove deathSignal usages in sync execCmd calls
..
Remove deathSignal usages in sync execCmd calls
Once moving to systemd, when vdsm dies all subproces
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tox: Exclude .ropeproject from pep8 check
..
tox: Exclude .ropeproject from pep8 check
pep8 breaks on files in .ropeproject, created by Python rope too
Dan Kenigsberg has posted comments on this change.
Change subject: tox: Exclude .ropeproject from pep8 check
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59677
To unsubscribe, visit https://gerrit.o
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tox: fail make process if required tox version isn't installed.
..
tox: fail make process if required tox version isn't installed.
Over RHEL 7.2 yum co
Dan Kenigsberg has posted comments on this change.
Change subject: tox: fail make process if required tox version isn't installed.
..
Patch Set 21: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/59306
To uns
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: network: drop legacy network config support
..
vm: network: drop legacy network config support
Drop the legacy Vm methods to rebuild specific netwo
Dan Kenigsberg has posted comments on this change.
Change subject: vm: graphics: drop legacy graphics config support
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60325
To unsubscribe, visit https://
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: storage: drop legacy drive config support
..
vm: storage: drop legacy drive config support
Drop the legacy Vm methods to rebuild specific drive con
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: always expect Vm devices to be sent
..
vm: always expect Vm devices to be sent
Ancient (< 3.6) Engines used to send the device configuration data
s
Dan Kenigsberg has posted comments on this change.
Change subject: vm: network: drop legacy network config support
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60324
To unsubscribe, visit https://ge
Dan Kenigsberg has posted comments on this change.
Change subject: vm: always expect Vm devices to be sent
..
Patch Set 7: Code-Review-1
this -1 just piggy-backs on this patch; the little script I'm requesting could
very well
Dan Kenigsberg has posted comments on this change.
Change subject: vm: always expect Vm devices to be sent
..
Patch Set 7:
would you be kind to add a doc or better - a tiny virt test script that creates
the simplest possible V
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: graphics: drop legacy configuration support
..
vm: graphics: drop legacy configuration support
We no longer need compatibility with ancient Engines
Dan Kenigsberg has posted comments on this change.
Change subject: vm: graphics: drop legacy configuration support
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60321
To unsubscribe, visit https://ge
Dan Kenigsberg has submitted this change and it was merged.
Change subject: drop painfully ancient vmConf examples
..
drop painfully ancient vmConf examples
These examples are sorely out of date. tests/functional/virtTests.py
m
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: graphics: report display info from device
..
vm: graphics: report display info from device
We used to keep the first graphic device information in
Dan Kenigsberg has posted comments on this change.
Change subject: drop painfully ancient vmConf examples
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/60894
To unsubscribe, visit https://gerrit.ovirt.o
Dan Kenigsberg has posted comments on this change.
Change subject: vm: split device init from domDependentInit
..
Patch Set 16: Code-Review+1
ack from me, but let's see if Polednik agrees.
--
To view, visit https://gerrit.ovi
Dan Kenigsberg has posted comments on this change.
Change subject: vm: split vcpu settings from domDependentInit
..
Patch Set 15: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59813
To unsubscribe, visit https://ger
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: split vcpu settings from domDependentInit
..
vm: split vcpu settings from domDependentInit
Move into helper to modularize the Vm._domDependentInit(
Dan Kenigsberg has posted comments on this change.
Change subject: vm: reorder sampling initialization
..
Patch Set 15: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59815
To unsubscribe, visit https://gerrit.ovirt.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: reorder sampling initialization
..
vm: reorder sampling initialization
The sampling subsystem initialization is actually independent
with respect t
Dan Kenigsberg has posted comments on this change.
Change subject: tests: containers: add testsuite
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/60678/8/tests/containers/conttestlib.py
File tests/containers/conttes
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Set vars/ssl to true in graphics tests
..
tests: Set vars/ssl to true in graphics tests
In 8a7479c, support for graphics defaultMode was added a
Dan Kenigsberg has submitted this change and it was merged.
Change subject: migration: wait properly for migration to begin
..
migration: wait properly for migration to begin
If the time it takes the migration to begin is longe
Dan Kenigsberg has posted comments on this change.
Change subject: network/sr-iov: use device teardown to reattach device
..
Patch Set 6: Code-Review+1
The code seems fine, but I'd appreciate if mburman can confirm that no devi
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network/sr-iov: fix ambiguous log message
..
network/sr-iov: fix ambiguous log message
The log message for detached device used self.device, which, in
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network/sr-iov: use setup in hotplug routine
..
network/sr-iov: use setup in hotplug routine
Setup is new preferred way of setting up a device. Network
Dan Kenigsberg has posted comments on this change.
Change subject: openstacknet hook: include after_vm_start hook in rpm
..
Patch Set 3: Continuous-Integration+1
unrelated CI error:
06:03:13 Error: nothing provides ovirt-image
Dan Kenigsberg has posted comments on this change.
Change subject: openstacknet hook: include after_vm_start hook in rpm
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60896
To unsubscribe, visit http
Dan Kenigsberg has submitted this change and it was merged.
Change subject: openstacknet hook: include after_vm_start hook in rpm
..
openstacknet hook: include after_vm_start hook in rpm
commit a655be4 excluded an important pie
Dan Kenigsberg has uploaded a new change for review.
Change subject: openstacknet hook: include after_vm_start hook in rpm
..
openstacknet hook: include after_vm_start hook in rpm
commit a655be4 excluded an important piece of th
Dan Kenigsberg has uploaded a new change for review.
Change subject: openstacknet hook: include after_vm_start hook in rpm
..
openstacknet hook: include after_vm_start hook in rpm
commit a655be4 excluded an important piece of th
Dan Kenigsberg has uploaded a new change for review.
Change subject: drop painfully ancient vmConf examples
..
drop painfully ancient vmConf examples
These examples are sorely out of date. tests/functional/virtTests.py
maybe be
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt net: Change graphics type from network to address
..
virt net: Change graphics type from network to address
This patch changes the graphics listen
Dan Kenigsberg has submitted this change and it was merged.
Change subject: jsonrpcvdscli: added getAllTasksInfo verb
..
jsonrpcvdscli: added getAllTasksInfo verb
getAllTasksInfo verb is needed by sos report
Change-Id: I8c02c3
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sos report: removed call to vdsClient getVGList
..
sos report: removed call to vdsClient getVGList
getVGList has been deprecated in patch
https://gerr
Dan Kenigsberg has posted comments on this change.
Change subject: vdscli: added DeprecationWarning to module
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60318
To unsubscribe, visit https://gerrit.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdscli: added DeprecationWarning to module
..
vdscli: added DeprecationWarning to module
vdscli is deprecated and will be replaced soon by jsonrpccli.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Adding python-setuptools to required ci packages
..
Adding python-setuptools to required ci packages
Over f24 we started to see the following error abo
Dan Kenigsberg has posted comments on this change.
Change subject: Adding python-setuptools to required ci packages
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60848
To unsubscribe, visit https://g
Dan Kenigsberg has posted comments on this change.
Change subject: Adding python-setuptools to required ci packages
..
Patch Set 3:
seems unrelated?
11:51:52 ERROR: test_path_ok (storage_check_test.TestDirectioChecker)
11:51:5
Dan Kenigsberg has posted comments on this change.
Change subject: vm: graphics: report display info from device
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60320
To unsubscribe, visit https://gerr
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vmxml: move metadata handling into helpers
..
vmxml: move metadata handling into helpers
to make room for future users of the `metadata' section,
we sp
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vmxml: metadata could be local variable
..
vmxml: metadata could be local variable
There is no need for `metadata' to be an instance variable,
so this
Dan Kenigsberg has posted comments on this change.
Change subject: build: enable vdsm-gluster build
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60329
To unsubscribe, visit https://gerrit.ovirt.org/
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: call address.flush explicitly after dhclient.kill
..
net: call address.flush explicitly after dhclient.kill
Change-Id: I7c03ce4917174a78fc97f216ce
Dan Kenigsberg has posted comments on this change.
Change subject: net: call address.flush explicitly after dhclient.kill
..
Patch Set 2: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/60155
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ovs hook: fix dhclient imports
..
ovs hook: fix dhclient imports
Change-Id: Ie13c017538750902713831bbcb07a30c885abd7d
Signed-off-by: Petr Horáček
Revi
Dan Kenigsberg has posted comments on this change.
Change subject: net: add address.flush family argument
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60153
To unsubscribe, visit https://gerrit.ovir
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: add address.flush family argument
..
net: add address.flush family argument
Add family argument to address.flush to be able to flush just
IP addre
Dan Kenigsberg has posted comments on this change.
Change subject: qos: fix invalid dictionary iteration
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60333
To unsubscribe, visit https://gerrit.ovirt
Dan Kenigsberg has submitted this change and it was merged.
Change subject: qos: fix invalid dictionary iteration
..
qos: fix invalid dictionary iteration
`for x, y in dictionary` is not valid dictionary iteration. This bug
was
Dan Kenigsberg has posted comments on this change.
Change subject: build: enable vdsm-gluster build
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/58605
To unsubscribe, visit https://gerrit.ovirt.org/
Dan Kenigsberg has uploaded a new change for review.
Change subject: fcoe hook: enable service
..
fcoe hook: enable service
When fcoe is requested, we should start fcoe and lldpad immediately, but
also after next boot.
Change-I
Dan Kenigsberg has posted comments on this change.
Change subject: vmxml: move metadata handling into helpers
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/57380
To unsubscribe, visit https://gerrit.
Dan Kenigsberg has posted comments on this change.
Change subject: ovs hook: fix dhclient imports
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60154
To unsubscribe, visit https://gerrit.ovirt.org/se
Dan Kenigsberg has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 7:
(2 comments)
(very partial review)
https://gerrit.ovirt.org/#/c/52354/7/lib/vdsm/constants.py.in
File
Dan Kenigsberg has posted comments on this change.
Change subject: contrib: Simple jsonrpc client
..
Patch Set 11: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/35181/11/contrib/jsonrpc
File contrib/jsonrpc:
Line 38
Dan Kenigsberg has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/59834/4//COMMIT_MSG
Commit Message:
Line 13: It would be cleaner
Dan Kenigsberg has posted comments on this change.
Change subject: build: enable vdsm-gluster build
..
Patch Set 8: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/58605/8/vdsm.spec.in
File vdsm.spec.in:
Line 238: Requ
Dan Kenigsberg has posted comments on this change.
Change subject: net address: ignore not existing iface on flush
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/59957/3/lib/vdsm/network/ip/address.py
File lib/vdsm/n
Dan Kenigsberg has posted comments on this change.
Change subject: automation: Increase timeout for make check
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/60051/1/automation/check-patch.sh
File automation/check-pa
Dan Kenigsberg has submitted this change and it was merged.
Change subject: automation: Increase timeout for make check
..
automation: Increase timeout for make check
CI slaves are sometimes very slow. Increase the timeout to 6
Dan Kenigsberg has posted comments on this change.
Change subject: automation: Increase timeout for make check
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60051
To unsubscribe, visit https://gerrit
Dan Kenigsberg has posted comments on this change.
Change subject: net test: Use fake netlink data for testGetDeviceByIP
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59881
To unsubscribe, visit http
901 - 1000 of 21419 matches
Mail list logo
