Dima Kuznetsov has posted comments on this change.
Change subject: Revert supervdsm: Decorator for supervdsm proxied calls.
..
Patch Set 1:
I think the ease of use is not a vice. It faces only the developer of the
function,
Dima Kuznetsov has posted comments on this change.
Change subject: dmidecodeUtil: move into lib
..
Patch Set 5: Verified+1
Build rpms with this change and deployed a host with it. VDSM reports correct
hardware info.
Dima Kuznetsov has posted comments on this change.
Change subject: mount: Perform mount and umount in supervdsm
..
Patch Set 4: Code-Review-1
1. supervdsm was moved into lib/vdsm a few days ago, so please import it from
vdsm.
Dima Kuznetsov has posted comments on this change.
Change subject: supervdsm: Remove getHardwareInfo call
..
Patch Set 6:
Hello, Nir.
I disagree. Supervdsm is not pulling code from vdsm, it is using code found in
its python
Dima Kuznetsov has posted comments on this change.
Change subject: supervdsm: Remove getHardwareInfo call
..
Patch Set 6:
Nir,
This approach only leads to more code duplication and in my opinion that's
moving backwards.
Dima Kuznetsov has posted comments on this change.
Change subject: ppc64HardwareInfo: move into lib
..
Patch Set 5: Verified+1
Verified by building on a ppc64 host and reading hw info:
[root@ibm-p8-rhevm-02 vdsm-dkuznets
Dima Kuznetsov has posted comments on this change.
Change subject: init: add a lock when starting / stopping svdsm
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45202
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: service: change vdsm KillMode to mixed
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45038
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: spmprotect: Switch from fencing by pid to fencing using
systemctl
..
Patch Set 7:
(1 comment)
Dima Kuznetsov has posted comments on this change.
Change subject: oop: close ioprocesses on vdsmd stop
..
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/45038/1/init/systemd/vdsmd.service.in
File
Dima Kuznetsov has posted comments on this change.
Change subject: makefile: Run pep8/pyflakes inside virtualenv
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/44928/1/Makefile.am
File Makefile.am:
Line 121:
Line
Dima Kuznetsov has uploaded a new change for review.
Change subject: makefile: Run pep8/pyflakes inside virtualenv
..
makefile: Run pep8/pyflakes inside virtualenv
Since developers often don't use the same distribution, we
Dima Kuznetsov has posted comments on this change.
Change subject: supervdsm: Move supervdsm module into lib
..
Patch Set 2: Verified+1
Verified by running the UTs and running the system tests. Both vdsmd and
supervdsmd
Dima Kuznetsov has posted comments on this change.
Change subject: supervdsm: Decorator for supervdsm proxied calls.
..
Patch Set 6: Verified+1
Verified using UTs and system tests framework
--
To view, visit
Dima Kuznetsov has uploaded a new change for review.
Change subject: core: Remove substitutions from dumpStorageTable
..
core: Remove substitutions from dumpStorageTable
This patch removes the use of substitutions from
Dima Kuznetsov has posted comments on this change.
Change subject: tests: functional - convert to run over jsonrpc
..
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43237
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: [WIP]tests: functional - convert to run over jsonrpc
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43237
To unsubscribe, visit
Dima Kuznetsov has uploaded a new change for review.
Change subject: supervdsm: Remove getHardwareInfo call
..
supervdsm: Remove getHardwareInfo call
Replaced by hwinfo, using a proxied call into supervdsm
Change-Id:
Dima Kuznetsov has uploaded a new change for review.
Change subject: dmidecodeUtil: move into lib
..
dmidecodeUtil: move into lib
Change-Id: If190e2b7b07faaacdc81e59a12ec08d2bd83f4bb
Signed-off-by: Dima Kuznetsov
Dima Kuznetsov has uploaded a new change for review.
Change subject: ppc64HardwareInfo: move into lib
..
ppc64HardwareInfo: move into lib
Change-Id: I4bee7f8ea4262d162bec8887ed8c98a0759a5f8c
Signed-off-by: Dima Kuznetsov
Dima Kuznetsov has posted comments on this change.
Change subject: supervdsm: Decorator for supervdsm proxied calls.
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/44598/3/vdsm/supervdsmServer
File
Dima Kuznetsov has posted comments on this change.
Change subject: supervdsm: Decorator for supervdsm proxied calls.
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/44598/4/tests/functional/supervdsmFuncTests.py
File
Dima Kuznetsov has posted comments on this change.
Change subject: supervdsm: Decorator for supervdsm proxied calls.
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/44598/4/tests/functional/supervdsmFuncTests.py
File
Dima Kuznetsov has posted comments on this change.
Change subject: supervdsm: Decorator for supervdsm proxied calls.
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/44598/4/tests/functional/supervdsmFuncTests.py
File
Dima Kuznetsov has posted comments on this change.
Change subject: supervdsm: Decorators for supervdsm proxy calls.
..
Patch Set 2:
Take a look at this patch: https://gerrit.ovirt.org/#/c/44599/
--
To view, visit
Dima Kuznetsov has posted comments on this change.
Change subject: supervdsm: Decorators for supervdsm proxy calls.
..
Patch Set 2:
The patches above this one demonstrate one such use.
The case I'm trying to make is that
Dima Kuznetsov has uploaded a new change for review.
Change subject: hwinfo: Move calls from utils to hwinfo
..
hwinfo: Move calls from utils to hwinfo
Change-Id: I0b949b34d0dfbadc9d91cd957edde10ce437e6d4
Signed-off-by: Dima
Dima Kuznetsov has uploaded a new change for review.
Change subject: hwinfo: Add module to get info about the platform
..
hwinfo: Add module to get info about the platform
Change-Id: I1a221f3f357038a3e1c6181d1abb53f4ad09c826
Dima Kuznetsov has uploaded a new change for review.
Change subject: supervdsm: Move supervdsm module into lib
..
supervdsm: Move supervdsm module into lib
This patch moves the code for supervdsm proxy into the lib of vdsm,
Dima Kuznetsov has uploaded a new change for review.
Change subject: supervdsm: Decorators for supervdsm proxy calls.
..
supervdsm: Decorators for supervdsm proxy calls.
These decorators allow automatic dispatch to supervdsm
Dima Kuznetsov has posted comments on this change.
Change subject: mount: Perform mount and umount in supervdsm
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/43969/4/vdsm/storage/mount.py
File
Dima Kuznetsov has posted comments on this change.
Change subject: spec: Enable vhostmd on non-koji Fedora builds
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44350
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: logging: remove log messages which give little or no value
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43720
To unsubscribe,
Dima Kuznetsov has posted comments on this change.
Change subject: migration: fix parameters
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44120
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: fakevmstats: add config entry to enable/disable the hook
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43931
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42927
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using
systemctl
..
Patch Set 5:
(1 comment)
Dima Kuznetsov has posted comments on this change.
Change subject: logging: remove log messages which give little or no value
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43262
To unsubscribe,
Dima Kuznetsov has posted comments on this change.
Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using
systemctl
..
Patch Set 4:
(1 comment)
Dima Kuznetsov has posted comments on this change.
Change subject: rwlock: Add simpler RWLock
..
Patch Set 6: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/42908/6/lib/vdsm/rwlock.py
File lib/vdsm/rwlock.py:
Line
Dima Kuznetsov has posted comments on this change.
Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using
systemctl
..
Patch Set 4:
(1 comment)
Dima Kuznetsov has posted comments on this change.
Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using
systemctl
..
Patch Set 4:
(1 comment)
Dima Kuznetsov has abandoned this change.
Change subject: tool: Remove upstart handling in libvirt configurator
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/40420
To unsubscribe, visit
Dima Kuznetsov has abandoned this change.
Change subject: [wip] spec: Drop el6 support
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/40419
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType:
Dima Kuznetsov has uploaded a new change for review.
Change subject: spmprotect: Switch from fencing by pid to fencing using
systemctl
..
spmprotect: Switch from fencing by pid to fencing using systemctl
Change-Id:
Dima Kuznetsov has posted comments on this change.
Change subject: supervdsm: Add zombiereaper to supervdsm
..
Patch Set 6: Verified+1
Verified by running the system tests (all kinds of storage) no zombies
appeared, also
Dima Kuznetsov has posted comments on this change.
Change subject: Removing support in sysv and upstart
..
Patch Set 13: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40726
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: tests: Add RWLock tests
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42907
To unsubscribe, visit https://gerrit.ovirt.org/settings
Dima Kuznetsov has posted comments on this change.
Change subject: rwlock: Support timed acquire
..
Patch Set 6: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/42909/6/lib/vdsm/rwlock.py
File lib/vdsm/rwlock.py:
Line
Dima Kuznetsov has posted comments on this change.
Change subject: rwlock: Add simpler RWLock
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/42908/4/lib/vdsm/rwlock.py
File lib/vdsm/rwlock.py:
Line 31:
Dima Kuznetsov has posted comments on this change.
Change subject: concurrent: Add CountedEvent class
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42927
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: Introducing systemctl configurator to enable vdsm required
services
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42605
To
Dima Kuznetsov has posted comments on this change.
Change subject: Removing libvirt configure fallback from spec
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40669
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: Remove el6 specific code from spec
..
Patch Set 3: Code-Review+1
(1 comment)
Small thing, don't mind if you fix it later
Dima Kuznetsov has posted comments on this change.
Change subject: Remove el6 specific code from spec
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/42317/3/vdsm.spec.in
File vdsm.spec.in:
Line 55: %if ! 0%{?rhel}
Dima Kuznetsov has posted comments on this change.
Change subject: Introducing systemctl configurator to enable vdsm required
services
..
Patch Set 2:
(1 comment)
Dima Kuznetsov has posted comments on this change.
Change subject: Removing support in sysv and upstart
..
Patch Set 8: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/40726/8/vdsm/clientIF.py
File vdsm/clientIF.py:
Dima Kuznetsov has posted comments on this change.
Change subject: Remove el6 specific code from spec
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42317
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: Removing support in sysv and upstart
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40726
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: Removing support in sysv and upstart
..
Patch Set 6:
(3 comments)
https://gerrit.ovirt.org/#/c/40726/6/vdsm.spec.in
File vdsm.spec.in:
Line 257
Line 258
Line
Dima Kuznetsov has posted comments on this change.
Change subject: daemonAdapter: remove traceback when using help option
..
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/42147/1//COMMIT_MSG
Commit
Dima Kuznetsov has posted comments on this change.
Change subject: spec: require kernel version to avoid sudo hanging
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42219
To unsubscribe, visit
Dima Kuznetsov has abandoned this change.
Change subject: ssl: Force client to use TLSv1 when using secure connection.
..
Abandoned
Not needed, TLSv1 is negitiated on el6.
--
To view, visit https://gerrit.ovirt.org/39944
To
Dima Kuznetsov has abandoned this change.
Change subject: packaging: Move libvirt_password out of PKI
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/37049
To unsubscribe, visit https://gerrit.ovirt.org/settings
Dima Kuznetsov has posted comments on this change.
Change subject: Removing support in sysv and upstart
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/40726/4/vdsm.spec.in
File vdsm.spec.in:
Line 798
Line 799
Line
Dima Kuznetsov has posted comments on this change.
Change subject: Separate MOM to an external process
..
Patch Set 8:
(2 comments)
https://gerrit.ovirt.org/#/c/41602/8/init/systemd/mom-vdsm.service.in
File
Dima Kuznetsov has posted comments on this change.
Change subject: tests: Separate tests with similar fixtures
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41364
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: vdsm-tool: is-configured: on el6, we must disable sysv's
libvirtd job
..
Patch Set 6: Code-Review-1
(1 comment)
Dima Kuznetsov has posted comments on this change.
Change subject: vdsm-tool: is-configured: on el6, we must disable sysv's
libvirtd job
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41144
To
Dima Kuznetsov has posted comments on this change.
Change subject: modify safelease executable path
..
Patch Set 13: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41024
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: modify safelease executable path
..
Patch Set 3:
Why aren't we shipping it as vdsm-safelease then?
--
To view, visit https://gerrit.ovirt.org/41024
To
Dima Kuznetsov has posted comments on this change.
Change subject: modify safelease executable path
..
Patch Set 3: Code-Review-1
We should not hardcode libexec paths if we plan to ship packages outside fedora
derived
Dima Kuznetsov has posted comments on this change.
Change subject: modify safelease executable path
..
Patch Set 4: Code-Review+1
If paths are something we're leaving out for packaging then I'm OK with this.
--
To view,
Dima Kuznetsov has posted comments on this change.
Change subject: modify safelease executable path
..
Patch Set 9: Verified+1
Verified using system testing framework job:
Dima Kuznetsov has posted comments on this change.
Change subject: utils: Add systemd_run command modifier
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40239
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: spec: Drop el6 support
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/40419/3/vdsm.spec.in
File vdsm.spec.in:
Line 836: # fallback to
Dima Kuznetsov has uploaded a new change for review.
Change subject: spec: Drop el6 support
..
spec: Drop el6 support
Since we no longer need to package for el6, we can significantly reduce
the size of our spec file. This patch
Dima Kuznetsov has uploaded a new change for review.
Change subject: tool: Remove upstart handling in libvirt configurator
..
tool: Remove upstart handling in libvirt configurator
libvirt configurator used to check if upstart
Dima Kuznetsov has posted comments on this change.
Change subject: jsonrpc: fix call to super ctor
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/39781/4/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Dima Kuznetsov has posted comments on this change.
Change subject: supervdsm: Add zombiereaper to supervdsm
..
Patch Set 2:
I am not sure we should bump the requirements just yet, as those packages are
not available for
Dima Kuznetsov has posted comments on this change.
Change subject: protocoldetector: Fix busy read loop [2/3]
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39997
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: protocoldetector: Fix busy poll loop [1/3]
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39996
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: protocoldetector: Fix next_check_interval
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39994
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: jsonrpc: fix call to super ctor
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39781
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: betterAsyncore: remove method binding
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39889
To unsubscribe, visit
Dima Kuznetsov has uploaded a new change for review.
Change subject: ssl: Force client to use TLSv1 when using secure connection.
..
ssl: Force client to use TLSv1 when using secure connection.
wrap_socket() selects
Dima Kuznetsov has posted comments on this change.
Change subject: unbreak crossImportsTests
..
Patch Set 1: Code-Review+1
Looks good. We're not using python_sitearch anymore so it should be OK.
--
To view, visit
Dima Kuznetsov has posted comments on this change.
Change subject: jsonrpc: raise JsonRpcError with meaningful message
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/39781/1/lib/yajsonrpc/__init__.py
Dima Kuznetsov has posted comments on this change.
Change subject: shell_helper: remove unneeded build statements
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39779
To unsubscribe, visit
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/39780
to review the following change.
Change subject: supervdsm: Add zombiereaper to supervdsm
..
supervdsm: Add zombiereaper
Dima Kuznetsov has posted comments on this change.
Change subject: supervdsm: Add zombiereaper to supervdsm
..
Patch Set 1:
Same as previously merged version, except with needReaping variable, that helps
avoiding adding a
Dima Kuznetsov has posted comments on this change.
Change subject: shell_helper: remove unneeded build statements
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/39779/2/contrib/shell_helper
File
Dima Kuznetsov has abandoned this change.
Change subject: client: Add warning prompt on dangerous commands
..
Abandoned
Closed as wontfix
--
To view, visit https://gerrit.ovirt.org/28174
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: Adding Vdsm cron job check for available packages update
..
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38401
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: Introducing getAvailableUpdates API
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38559
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer
..
Patch Set 11: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/35938
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: stomp: Remove redundant code
..
Patch Set 11: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/35939
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: spec: configure multipath on upgrade
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39064
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: Introducing getAvailableUpdates API
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/38559/5/vdsm/API.py
File vdsm/API.py:
Line 1309:
Dima Kuznetsov has posted comments on this change.
Change subject: Adding Vdsm cron job check for available packages update
..
Patch Set 8:
(3 comments)
https://gerrit.ovirt.org/#/c/38401/8/vdsm/updater-tool
File
1 - 100 of 447 matches
Mail list logo
