Eduardo has posted comments on this change.
Change subject: fileSD: Optimize getAllVolumes on file storage
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/36593/2/vdsm/storage/fileSD.py
File
Eduardo has posted comments on this change.
Change subject: lvm: Add an option to replace locking type 4
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/23645
To unsubscribe, visit
Eduardo has posted comments on this change.
Change subject: Create storage domain using command type 1
..
Patch Set 7: Code-Review-1
(6 comments)
http://gerrit.ovirt.org/#/c/23646/7/vdsm/storage/blockSD.py
File
Eduardo has posted comments on this change.
Change subject: Allow moving of sparse images to a block domains
..
Patch Set 8: Code-Review-1
(2 comments)
How this patch solves the canDoAction engine warning logged in the BZ?
Eduardo has posted comments on this change.
Change subject: sp: setDomainRegularRole is implemented by backend
..
Patch Set 1: Code-Review-1
(1 comment)
Modern engines never try to call deactivateSD in order to migrate MSD.
Eduardo has posted comments on this change.
Change subject: sp: fix spm start when failing to produce domain
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/25424/2/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line
Eduardo has posted comments on this change.
Change subject: sp: fix spm start when failing to produce domain
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25424/2/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line
Eduardo has posted comments on this change.
Change subject: sp: fix spm start when failing to produce domain
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25424/2/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line
Eduardo has posted comments on this change.
Change subject: sp: fix spm start when failing to produce domain
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/25424/2/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line
Eduardo has posted comments on this change.
Change subject: sp: fix spm start when failing to produce domain
..
Patch Set 2: Code-Review-2
(1 comment)
http://gerrit.ovirt.org/#/c/25424/2/vdsm/storage/sp.py
File
Eduardo has posted comments on this change.
Change subject: Avoid to recompile namedtuple ATTR classes in lvm.
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/25678/1/vdsm/storage/lvm.py
File vdsm/storage/lvm.py:
Eduardo has uploaded a new change for review.
Change subject: Avoid to recompile namedtuple ATTR classes in lvm.
..
Avoid to recompile namedtuple ATTR classes in lvm.
Change-Id: I66110a7f25fb5cfd80ddffe9a22e1cbac11de447
Eduardo has posted comments on this change.
Change subject: Avoid redundant volume produces.
..
Patch Set 1:
This change is should relevant.
Should be rebased, verified by QE and merged.
--
To view, visit
Eduardo has posted comments on this change.
Change subject: Rename *Volume.extend method to *Volume.enlarge
..
Patch Set 1:
This patch enlights what the function does and in addition simplifies grepping
the code avoiding
Eduardo has posted comments on this change.
Change subject: Fill volume children info.
..
Patch Set 2:
In spite that as said in the commit message there are not consumers today for
this info may be worth to return the proper
Eduardo has posted comments on this change.
Change subject: [WIP] lvm: Add an option to replace locking type 4
..
Patch Set 2: Code-Review-1
(4 comments)
http://gerrit.ovirt.org/#/c/23645/2/vdsm/storage/lvm.py
File
Eduardo has posted comments on this change.
Change subject: [WIP] Create storage domain using command type 1
..
Patch Set 2:
(5 comments)
http://gerrit.ovirt.org/#/c/23646/2/vdsm/storage/blockSD.py
File
Eduardo has posted comments on this change.
Change subject: [WIP] Create storage domain using command type 1
..
Patch Set 2: Code-Review-1
--
To view, visit http://gerrit.ovirt.org/23646
To unsubscribe, visit
Eduardo has posted comments on this change.
Change subject: [WIP] Create storage pool using command type 1
..
Patch Set 2: Code-Review-1
(6 comments)
http://gerrit.ovirt.org/#/c/23647/2/vdsm/storage/blockSD.py
File
Eduardo has posted comments on this change.
Change subject: [WIP] destroy storage pool using command type 1
..
Patch Set 1: Code-Review-1
(3 comments)
http://gerrit.ovirt.org/#/c/24398/1/vdsm/storage/blockSD.py
File
Eduardo has posted comments on this change.
Change subject: [WIP] destroy storage pool using command type 1
..
Patch Set 1:
After review the engine part:
1) all the regular domains are detached and removed.
2) destroy
Eduardo has posted comments on this change.
Change subject: [WIP] Create storage domain using command type 1
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/23646/2/vdsm/storage/lvm.py
File vdsm/storage/lvm.py:
Line
Eduardo has abandoned this change.
Change subject: Adding monitorPoolDomains replacing connectStoragePool.
..
Abandoned
Obsoleted by HE changes.
--
To view, visit http://gerrit.ovirt.org/11937
To unsubscribe, visit
Eduardo has posted comments on this change.
Change subject: vm: Update LUN size when starting a vm
..
Patch Set 6: Code-Review-1
(1 comment)
File vdsm/clientIF.py
Line 267:
Eduardo has posted comments on this change.
Change subject: vm: Update LUN size when starting a vm
..
Patch Set 5:
(4 comments)
File vdsm/clientIF.py
Line 263:
Eduardo has posted comments on this change.
Change subject: sdc: Change error messages to info
..
Patch Set 1: Code-Review-2
Already discussed.
There is no spontaneous SD generation.
Should not be unfetched domains, then if
Eduardo has posted comments on this change.
Change subject: getStorageDomainInfo: SP keys when disconnected.
..
Patch Set 2: Verified+1
[root@camel-vdsb ~]# vdsClient -s 0 getStorageDomainInfo
Eduardo has uploaded a new change for review.
Change subject: Fix PEP 8 issue.
..
Fix PEP 8 issue.
Change-Id: Id4952ab9cb3bfce0f787568369ead45c09aece47
Signed-off-by: Eduardo ewars...@redhat.com
---
M lib/vdsm/ipwrapper.py
1
Eduardo has posted comments on this change.
Change subject: remove irs_enable configuration attribute
..
Patch Set 3: Code-Review+1
Dan we already agreed on the need of modularize vdsm.
This configuration variable is not
Eduardo has posted comments on this change.
Change subject: remove irs_enable configuration attribute
..
Patch Set 2: Code-Review+1
(2 comments)
File vdsm/clientIF.py
Line
Eduardo has posted comments on this change.
Change subject: gluster prepareImage: return gluster-sepecific information
..
Patch Set 2: Code-Review-1
(4 comments)
* Add WIP
* Rephrase your commit message
* Merge Change-Id:
Eduardo has posted comments on this change.
Change subject: Invalidate filters on HSMs before rescanning extended VG
..
Patch Set 18: Code-Review-1
Very respectfully I disagree with this solution.
My opinion is that the
Eduardo has abandoned this change.
Change subject: Remove redundant supervsdm.validateAccess.
..
Abandoned
We need to unify this functions anyway.
--
To view, visit http://gerrit.ovirt.org/20838
To unsubscribe, visit
Eduardo has posted comments on this change.
Change subject: lvm: Prevent auto-activation of vdsm logical volumes
..
Patch Set 5: Code-Review-1
(1 comment)
File
Eduardo has posted comments on this change.
Change subject: lvm: Prevent auto-actviation of logical volumes
..
Patch Set 1: Verified-1 Code-Review-1
(6 comments)
Commit
Eduardo has uploaded a new change for review.
Change subject: lvm: Prevent auto-activation of logical volumes.
..
lvm: Prevent auto-activation of logical volumes.
When using FC storage, physical volumes are connected during
Eduardo has posted comments on this change.
Change subject: lvm: Prevent auto-actviation of logical volumes
..
Patch Set 1:
Please look at:
Change-Id: Iab9b7579990d934c60999b4c603c3acf46557be1
--
To view, visit
Eduardo has posted comments on this change.
Change subject: lvm: Prevent auto-activation of logical volumes.
..
Patch Set 1:
(1 comment)
Commit Message
Line 6:
Line 7:
Eduardo has uploaded a new change for review.
Change subject: Remove redundant supervsdm.validateAccess.
..
Remove redundant supervsdm.validateAccess.
Change-Id: Id37865225ea2d29361d6e588f9bb0acf7bf71cec
Signed-off-by: Eduardo
Eduardo has posted comments on this change.
Change subject: lvm: Prevent auto-actviation of logical volumes
..
Patch Set 3: Code-Review-1
(5 comments)
Commit Message
Line
Eduardo has uploaded a new change for review.
Change subject: Fix fix getDomUuidFromVolumePath()
..
Fix fix getDomUuidFromVolumePath()
Change-Id: I648e6a3f4e877c8f2471e82d7064c3e5a021d4d1
Bug-Url:
Eduardo has posted comments on this change.
Change subject: Fix fix fix getDomUuidFromVolumePath()
..
Patch Set 1: Code-Review-2
(1 comment)
File vdsm/storage/fileVolume.py
Eduardo has posted comments on this change.
Change subject: Fix fix getDomUuidFromVolumePath()
..
Patch Set 1:
20790 was considered and discarded before send this.
This is a broken function, for broken by design callers, but
Eduardo has posted comments on this change.
Change subject: Fix fix getDomUuidFromVolumePath()
..
Patch Set 1:
As we already discussed this function and it's callers should be removed, since
if you are reaching the volume you
Eduardo has posted comments on this change.
Change subject: iscsiadm: Add debug level option
..
Patch Set 3:
There is no necessity for this RFE or this way is questionable IMHO.
(As I wrote there.)
The bottom line is that
Eduardo has posted comments on this change.
Change subject: iscsiadm: Add debug level option
..
Patch Set 3: Code-Review-1
Note that the usefulness of these logs is questionable, as one call to iscsiadm
can generate 18KB 395
Eduardo has posted comments on this change.
Change subject: lvm: Ensure active LVs are refreshed before use.
..
Patch Set 5: Code-Review-1
So Nir/Eduardo, what do you suggest?
1) My perennial request: engine should send
Eduardo has posted comments on this change.
Change subject: lvm: Ensure active LVs are refreshed before use.
..
Patch Set 5:
we are in 'activate' flow which means that we were told to use the LV.
Why we were told to use an LV
Eduardo has posted comments on this change.
Change subject: getVolumeInfo() new implementation.
..
Patch Set 7:
(1 comment)
File vdsm/storage/volume.py
Line 894:
Eduardo has posted comments on this change.
Change subject: drop a non-variable variable
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/20425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Eduardo has posted comments on this change.
Change subject: drop a non-variable variable
..
Patch Set 2:
Already addressed in:
Change Id: Iedcfd84cd0848fbe3aca9f9af45c44c17722055e
--
To view, visit
Eduardo has posted comments on this change.
Change subject: Making getVSize and getVTrueSize SD methods.
..
Patch Set 6:
(2 comments)
File vdsm/storage/blockSD.py
Line 132:
Eduardo has posted comments on this change.
Change subject: New getChildrenList implementation.
..
Patch Set 9: Verified-1
Checking file domains.
--
To view, visit http://gerrit.ovirt.org/15765
To unsubscribe, visit
Eduardo has posted comments on this change.
Change subject: New getChildrenList implementation.
..
Patch Set 9: Verified+1
* With Change-Id
Ibf374e6abe81962619baecf96fffa0f817ce5dcb
for debugging *
│ │ │ ├──
Eduardo has posted comments on this change.
Change subject: Fill volume children info.
..
Patch Set 2: Verified+1
Verified on file:
│ │ │ ├── cca667fd-d1d5-4377-8bc4-a1653795b72d
│ │ │ │ ├──
Eduardo has posted comments on this change.
Change subject: getVolumeInfo() new implementation.
..
Patch Set 3: Verified+1
* Verified for block volumes *
# vdsClient -s 0 getConnectedStoragePoolsList
# vdsClient -s 0
Eduardo has posted comments on this change.
Change subject: getVolumeInfo() new implementation.
..
Patch Set 4: Verified+1
# vdsClient -s 0 getVolumeInfo d0dccb15-bc4e-4815-889a-c116028f30b0
Eduardo has posted comments on this change.
Change subject: Making getVSize and getVTrueSize SD methods.
..
Patch Set 5: Verified+1
Verified (block) with
Change-Id: Ic82fab1966bc6606e3c29483bea62dd17b4c56bc
verification.
Eduardo has posted comments on this change.
Change subject: Rename Image.copy() to Image.copyCollapsed().
..
Patch Set 3: Verified+1
# vdsClient -s 0 copyImage 2756f45a-6c7a-449a-baed-e796cd293168
Eduardo has posted comments on this change.
Change subject: Making getVSize and getVTrueSize SD methods.
..
Patch Set 6: Verified+1
Patch Set 5: Verified+1
Verified (block) with
Change-Id:
Eduardo has posted comments on this change.
Change subject: getVolumeInfo() new implementation.
..
Patch Set 5: Verified+1
As before.
--
To view, visit http://gerrit.ovirt.org/18233
To unsubscribe, visit
Eduardo has posted comments on this change.
Change subject: New getChildrenList implementation.
..
Patch Set 8:
(1 comment)
File vdsm/storage/fileVolume.py
Line 378:
Eduardo has posted comments on this change.
Change subject: New getChildrenList implementation.
..
Patch Set 9: Verified+1
No significative changes from patchset 7.
--
To view, visit http://gerrit.ovirt.org/15765
To
Eduardo has posted comments on this change.
Change subject: Make getRepoStats() a hsm method.
..
Patch Set 10: Verified+1
Verified by Liron that running a VM with CD is working.
--
To view, visit
Eduardo has posted comments on this change.
Change subject: Make getRepoStats() a hsm method.
..
Patch Set 9: Verified-1
Adding the working patch.
--
To view, visit http://gerrit.ovirt.org/14673
To unsubscribe, visit
Eduardo has posted comments on this change.
Change subject: More precise catch in block volume create.
..
Patch Set 1: Verified+1
7b5ef3c5-adad-4fa5-a9dd-e2b80cf5cec0::WARNING::2013-10-09
Eduardo has posted comments on this change.
Change subject: Fill volume children info.
..
Patch Set 1:
(1 comment)
File vdsm/storage/volume.py
Line 900:
Eduardo has posted comments on this change.
Change subject: New getChildrenList implementation.
..
Patch Set 8:
(6 comments)
Commit Message
Line 3: AuthorDate: 2013-06-16
Eduardo has posted comments on this change.
Change subject: Make hsm.getVolumesList() pool independent.
..
Patch Set 7: Verified+1
# lvs 9615bd0c-ed20-4d47-b8d9-61a06e634830
LV VG
Eduardo has posted comments on this change.
Change subject: New getChildrenList implementation.
..
Patch Set 6:
(2 comments)
File vdsm/storage/fileVolume.py
Line 378:
Eduardo has posted comments on this change.
Change subject: WIP: sd.py: Remove sds from sdCache when connecting
..
Patch Set 1: Code-Review-1
connectStorageServer calls for FC by engine is required.
A solution for this (and
Eduardo has posted comments on this change.
Change subject: Make hsm.getVolumesList() pool independent.
..
Patch Set 8:
# vdsClient -s 0 getVolumesList d0dccb15-bc4e-4815-889a-c116028f30b0
----
Eduardo has posted comments on this change.
Change subject: New getChildrenList implementation.
..
Patch Set 7:
## Block verification with extra debug
# lvs -o lv_name,lv_tags,lv_attr d0dccb15-bc4e-4815-889a-c116028f30b0
Eduardo has posted comments on this change.
Change subject: New getChildrenList implementation.
..
Patch Set 7:
(Verification continuation)
# Leaf (No children)
# vdsClient -s 0 deleteVolume
Eduardo has uploaded a new change for review.
Change subject: Fill volume children info.
..
Fill volume children info.
In spite that they are no consumers for 'children' key in
Volume.getInfo() result adding the children set
Eduardo has posted comments on this change.
Change subject: Fill volume children info.
..
Patch Set 1: Verified+1
# lvs -o lv_name,lv_tags,lv_attr d0dccb15-bc4e-4815-889a-c116028f30b0
/dev/dm-19: read failed after 0 of 4096
Eduardo has posted comments on this change.
Change subject: Adding [start|stop]MonitoringDomain().
..
Patch Set 1:
(1 comment)
File client/vdsClient.py
Line 1694:
Line
Eduardo has uploaded a new change for review.
Change subject: Enable VM migration to old vdsm's.
..
Enable VM migration to old vdsm's.
Old vdsm's can't run VM from /var/run/vdsm/storage and rely on
/rhev/data-center hierarchy.
Eduardo has posted comments on this change.
Change subject: Enable VM migration to old vdsm's.
..
Patch Set 1:
vmId: b889a032-0a78-4591-bbc4-53157dd6d1be
namethe_vm/name
was started in compatibility mode (valid spUUID) with:
Eduardo has posted comments on this change.
Change subject: Enable VM migration to old vdsm's.
..
Patch Set 2:
(2 comments)
File vdsm/storage/blockSD.py
Line 1035:
Eduardo has posted comments on this change.
Change subject: hsm: protect deleteImage with the spm lock
..
Patch Set 2:
(1 comment)
File vdsm/storage/hsm.py
Line 1505:
Line
Eduardo has posted comments on this change.
Change subject: Enable VM migration to old vdsm's.
..
Patch Set 2:
(1 comment)
File vdsm/storage/blockSD.py
Line 1035:
Eduardo has posted comments on this change.
Change subject: Adding [start|stop]MonitoringDomain().
..
Patch Set 1:
(1 comment)
File vdsm/storage/sp.py
Line 1545: #
Eduardo has posted comments on this change.
Change subject: revert premature selinux dependency
..
Patch Set 1: Code-Review-1
(1 comment)
Commit Message
Line 12: EL6, so
Eduardo has uploaded a new change for review.
Change subject: Adding [start|stop]MonitoringDomain().
..
Adding [start|stop]MonitoringDomain().
startMonitoringDomain() is added for monitoring a storage domain
without being
Eduardo has posted comments on this change.
Change subject: Adding [start|stop]MonitoringDomain().
..
Patch Set 1: Verified+1
More verification (with engine) is required!
[root@localhost ~]# vdsClient -s 0
Eduardo has posted comments on this change.
Change subject: Make getRepoStats() a hsm method.
..
Patch Set 8: Verified+1
Verified with Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
--
To view, visit
Eduardo has posted comments on this change.
Change subject: Fix getStorageDomainInfo() logic.
..
Patch Set 6: Verified+1
Verified with Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
--
To view, visit
Eduardo has posted comments on this change.
Change subject: Read pool metadata once in StoragePool.getInfo()
..
Patch Set 7: Verified+1
Verified with Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
--
To view, visit
Eduardo has uploaded a new change for review.
Change subject: Fix vdsClient.repoStats() bad path.
..
Fix vdsClient.repoStats() bad path.
(Or why using your list as a dict is bad.)
Change-Id:
Eduardo has uploaded a new change for review.
Change subject: vdsClient: is list a dict?
..
vdsClient: is list a dict?
Short answer: NO!
Change-Id: Iacd7af3691eb2ed15b7fbb042f8ce43528dce31e
Signed-off-by: Eduardo
Eduardo has uploaded a new change for review.
Change subject: Convert guids into mapper devs for extend blockSD
..
Convert guids into mapper devs for extend blockSD
After I1ec54147205992ac130684d01e73cd7aceccad48, which changed
Eduardo has posted comments on this change.
Change subject: Convert guids into mapper devs for extend blockSD
..
Patch Set 1: Verified+1
[root@localhost ~]# vgs -o +pv_name 2a7fbb64-f64c-4139-ba79-aaf21547845f
VG
Eduardo has posted comments on this change.
Change subject: Convert guids into mapper devs for extend blockSD
..
Patch Set 2: Verified+1
Patchset 1 verified using vdsClient.
See previous comment.
--
To view, visit
Eduardo has uploaded a new change for review.
Change subject: getStorageDomainInfo: SP keys when disconnected.
..
getStorageDomainInfo: SP keys when disconnected.
Before this patch, getStorageDomainInfo() returns the real pool
Eduardo has posted comments on this change.
Change subject: Avoid hsm image deletions.
..
Patch Set 4:
Comments addressed.
This is fossilized code, failing to solve flaws from code that is not existing
anymore, cluttering
Eduardo has posted comments on this change.
Change subject: Fix getStorageDomainInfo() logic.
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.ovirt.org/14671
To unsubscribe, visit http://gerrit.ovirt.org/settings
Eduardo has posted comments on this change.
Change subject: Read pool metadata once in StoragePool.getInfo()
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.ovirt.org/14672
To unsubscribe, visit
Eduardo has posted comments on this change.
Change subject: getVolumeInfo() new implementation.
..
Patch Set 3:
(2 comments)
Commit Message
Line 5: CommitDate: 2013-09-16
Eduardo has posted comments on this change.
Change subject: Making getVSize and getVTrueSize SD methods.
..
Patch Set 4:
(3 comments)
Commit Message
Line 12:
Line 13:
1 - 100 of 550 matches
Mail list logo
