Francesco Romani has submitted this change and it was merged.
Change subject: vdscli: Provide py3 compatible xmlrpclib (using six)
..
vdscli: Provide py3 compatible xmlrpclib (using six)
Change-Id:
Francesco Romani has submitted this change and it was merged.
Change subject: net virt: Support connecting VM/s to an ovs bridge
..
net virt: Support connecting VM/s to an ovs bridge
Change-Id:
Francesco Romani has submitted this change and it was merged.
Change subject: net: move ip configuration to ip.address module
..
net: move ip configuration to ip.address module
We need to share IP configuration functions with
Francesco Romani has submitted this change and it was merged.
Change subject: netswitch: split setup actions on netswitch level
..
netswitch: split setup actions on netswitch level
This patch relocates split of nets and bonds
Francesco Romani has submitted this change and it was merged.
Change subject: py3: Require libselinux-python3
..
py3: Require libselinux-python3
The selinux package/module is not required in the spec and CI automation
Francesco Romani has submitted this change and it was merged.
Change subject: net: Setup ipv6autoconf with OVS switch
..
net: Setup ipv6autoconf with OVS switch
When handling an OVS switch setup, set ipv6autoconf for its
Francesco Romani has submitted this change and it was merged.
Change subject: ovs: don't count bond slave duplicates
..
ovs: don't count bond slave duplicates
We should check that set(slaves) contains 2 or more slaves to not
Francesco Romani has submitted this change and it was merged.
Change subject: ovs: edit bond mode
..
ovs: edit bond mode
With this patch we allow setup of OVS bond with one of 'fallback'
modes 1 and 4 and miimon.
In another
Francesco Romani has submitted this change and it was merged.
Change subject: ovs: add/remove OVS network based on a bond
..
ovs: add/remove OVS network based on a bond
Bond modes will be handled in a following patch.
Francesco Romani has submitted this change and it was merged.
Change subject: ovs: use transaction class for devices setup
..
ovs: use transaction class for devices setup
With this patch we use transaction class instead of
Francesco Romani has submitted this change and it was merged.
Change subject: ovs: fix bond removal validation
..
ovs: fix bond removal validation
We should allow removal of a bond which network-user will use nic
instead.
Francesco Romani has submitted this change and it was merged.
Change subject: ovs: validate that to-be-removed bond is not used
..
ovs: validate that to-be-removed bond is not used
Change-Id:
Francesco Romani has submitted this change and it was merged.
Change subject: ovs: add/remove OVS network based on a VLAN
..
ovs: add/remove OVS network based on a VLAN
Change-Id: I98be71c300f2413ea8a8f6c71ba7daac0cd16d5d
Francesco Romani has submitted this change and it was merged.
Change subject: ovs: add/remove OVS network that is based on a nic
..
ovs: add/remove OVS network that is based on a nic
Change-Id:
Francesco Romani has submitted this change and it was merged.
Change subject: ovs: don't check if changes are needed in net editation
..
ovs: don't check if changes are needed in net editation
We cannot compare query
Francesco Romani has submitted this change and it was merged.
Change subject: ovs: use unfaked ovs_netinfo under ovs package
..
ovs: use unfaked ovs_netinfo under ovs package
Change-Id:
Francesco Romani has submitted this change and it was merged.
Change subject: ovs: add bridges_by_sb property to OvsInfo
..
ovs: add bridges_by_sb property to OvsInfo
This will be used in a following ovs setupNetworks patch.
Francesco Romani has submitted this change and it was merged.
Change subject: ovs: bridge is optional for del-port
..
ovs: bridge is optional for del-port
ovs-vsctl does not require bridge name for port removal. We will
use
Francesco Romani has submitted this change and it was merged.
Change subject: net: use netinfo to split OVS nets and bonds
..
net: use netinfo to split OVS nets and bonds
Our decision of what should be done with a query (add,
Francesco Romani has submitted this change and it was merged.
Change subject: net: use netinfo to split OVS/legacy nets and bonds
..
net: use netinfo to split OVS/legacy nets and bonds
Netinfo now contains 'switch' attribute
Francesco Romani has submitted this change and it was merged.
Change subject: net: use netinfo for OVS validation
..
net: use netinfo for OVS validation
Use real running netinfo configuration for OVS validation instead
of
Francesco Romani has submitted this change and it was merged.
Change subject: net: ovs validator should accept multiple untagged nets
..
net: ovs validator should accept multiple untagged nets
Change-Id:
Francesco Romani has submitted this change and it was merged.
Change subject: net: fix validation bug: ovs_bonds should be used
..
net: fix validation bug: ovs_bonds should be used
Change-Id:
Francesco Romani has submitted this change and it was merged.
Change subject: net: common and legacy CachingNetInfo
..
net: common and legacy CachingNetInfo
CachingNetInfo is not suitable for mixed OVS and Legacy networks.
Francesco Romani has posted comments on this change.
Change subject: net: common and legacy CachingNetInfo
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60866
To unsubscribe, visit
Francesco Romani has submitted this change and it was merged.
Change subject: net: report OVS netinfo in caps
..
net: report OVS netinfo in caps
Even non-root caps (legacy networks+nics) are now obtained
from supervdsm. The
Francesco Romani has posted comments on this change.
Change subject: net: report OVS netinfo in caps
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60865
To unsubscribe, visit
Francesco Romani has submitted this change and it was merged.
Change subject: netinfo: report 'vlanid' only if vlan is set
..
netinfo: report 'vlanid' only if vlan is set
Change-Id: I6a0c30177f238154b34513f83b7914d1783fd422
Francesco Romani has posted comments on this change.
Change subject: sampling: refactor tests
..
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/61309/1//COMMIT_MSG
Commit Message:
PS1, Line 7: sampling:
Francesco Romani has submitted this change and it was merged.
Change subject: virt net: Change graphics type from network to address
..
virt net: Change graphics type from network to address
This patch changes the graphics
Francesco Romani has posted comments on this change.
Change subject: vm: periodic: fix stats age reporting
..
Patch Set 1: Verified+1
verified
1. using the tests
2. as described in BZ: running one VM, SIGSTOP'ing QEMU, waited
Francesco Romani has posted comments on this change.
Change subject: sampling: refactor tests
..
Patch Set 1: Verified+1
(1 comment)
https://gerrit.ovirt.org/#/c/61309/1/tests/samplingTests.py
File tests/samplingTests.py:
Francesco Romani has posted comments on this change.
Change subject: sampling: micro-optimization
..
Patch Set 1: Verified-1
not yet ready.
--
To view, visit https://gerrit.ovirt.org/61311
To unsubscribe, visit
Francesco Romani has uploaded a new change for review.
Change subject: sampling: refactor tests
..
sampling: refactor tests
Refactor the tests to make them clearer and to make room
for further improvements.
Change-Id:
Francesco Romani has uploaded a new change for review.
Change subject: vm: periodic: fix stats age reporting
..
vm: periodic: fix stats age reporting
The Vm class reports the monitor responsiveness in two ways:
1. if a libvirt
Francesco Romani has uploaded a new change for review.
Change subject: sampling: micro-optimization
..
sampling: micro-optimization
make timestamp update faster.
Change-Id: Id4361bf4ccae67be3a9e42a0d3368e1e1c246393
TODO:
Francesco Romani has posted comments on this change.
Change subject: v2v: Do not give Xen a special treatment.
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/57430/1/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 995:
Francesco Romani has posted comments on this change.
Change subject: logging: Improve logging when receiving signals
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61289
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: logging: Improve logging when receiving signals
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61289
To unsubscribe, visit
Francesco Romani has submitted this change and it was merged.
Change subject: refmt: Use more standard main() function
..
refmt: Use more standard main() function
There is no need to make main() private.
Change-Id:
Francesco Romani has submitted this change and it was merged.
Change subject: remft: Add online help
..
remft: Add online help
Example:
$ contrib/refmt -h
usage: refmt [-h] [file [file ...]]
Reformat python
Francesco Romani has abandoned this change.
Change subject: vmxml: move namespace declaration
..
Abandoned
made obsolete by updated https://gerrit.ovirt.org/#/c/60481/15
--
To view, visit https://gerrit.ovirt.org/57381
To
Francesco Romani has posted comments on this change.
Change subject: vm: reorder operations in _domDependentInit
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/59817/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS5,
Francesco Romani has abandoned this change.
Change subject: vm: split guest agent init from domDependentInit
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/59816
To unsubscribe, visit
Francesco Romani has abandoned this change.
Change subject: vm: split device init from domDependentInit
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/59814
To unsubscribe, visit https://gerrit.ovirt.org/settings
Francesco Romani has posted comments on this change.
Change subject: vm: reorder operations in _domDependentInit
..
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/59817/18/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Francesco Romani has posted comments on this change.
Change subject: vm: split guest agent init from domDependentInit
..
Patch Set 18: Code-Review-2
Let's do like this:
1. improve Vm.domDependentInit() separately:
Francesco Romani has posted comments on this change.
Change subject: vm: split device init from domDependentInit
..
Patch Set 18: Code-Review-2
the plan changed as follows:
1. improve Vm.domDependentInit in a separate series
Francesco Romani has posted comments on this change.
Change subject: vm: split device init from domDependentInit
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/59814/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS5,
Francesco Romani has uploaded a new change for review.
Change subject: vm: rename Vm._guestEvent
..
vm: rename Vm._guestEvent
The _guestEvent field of Vm class is misleading.
It does not track a "guest event", but rather sets a
Francesco Romani has uploaded a new change for review.
Change subject: vm: legacy rng devices fix not needed anymore
..
vm: legacy rng devices fix not needed anymore
We introduced this fix to deal with upgrades from Vdsm
Francesco Romani has uploaded a new change for review.
Change subject: vm: move device initialization together
..
vm: move device initialization together
It was scatthered around in Vm._domDependentInit for no good reason
No
Francesco Romani has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/60533/2/README.logging
File README.logging:
PS2, Line
Francesco Romani has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 3: Verified+1
copied score.
--
To view, visit https://gerrit.ovirt.org/60533
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/60533/2/README.logging
File README.logging:
Line 29:
Francesco Romani has posted comments on this change.
Change subject: build: Remove python 3 test run
..
Patch Set 1:
We can make an exception to the flow for this patch.
--
To view, visit https://gerrit.ovirt.org/61189
To
Francesco Romani has submitted this change and it was merged.
Change subject: virt net: Change graphics type from network to address
..
virt net: Change graphics type from network to address
This patch changes the graphics
Francesco Romani has posted comments on this change.
Change subject: remft: Add online help
..
Patch Set 2:
need ACK from Dan before merge into master. Nir, feel free to go forward if you
wish.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: refmt: Use more standard main() function
..
Patch Set 2:
need ACK from Dan before merge into master. Nir, feel free to go forward if you
wish.
--
To view,
Francesco Romani has posted comments on this change.
Change subject: hostdev: add back setup log message
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61181
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: hostdev: add back setup log message
..
Patch Set 2: Code-Review+1
(1 comment)
one question inside
Francesco Romani has posted comments on this change.
Change subject: json: use forzenset for filtered methods
..
Patch Set 3: Code-Review-2
we are using this scapegoat patch to verify if a previously reported failure is
real
Francesco Romani has restored this change.
Change subject: json: use forzenset for filtered methods
..
Restored
--
To view, visit https://gerrit.ovirt.org/58796
To unsubscribe, visit https://gerrit.ovirt.org/settings
Francesco Romani has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 2: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/60533/2/README.logging
File
Francesco Romani has posted comments on this change.
Change subject: utils: add utlity to generate positive cpuset notation
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/60639/4/lib/vdsm/utils.py
File
Francesco Romani has posted comments on this change.
Change subject: utils: add utlity to generate positive cpuset notation
..
Patch Set 4: Code-Review-1
(1 comment)
-1 for visibility
Francesco Romani has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 2: Verified+1
we can't really break anything here.
"make rpm" still works as expected.
--
To
Francesco Romani has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/60533/1/README.logging
File README.logging:
Line 36:
Francesco Romani has posted comments on this change.
Change subject: hostdev: prefer numa nodes close to device MMIO
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/60640/4/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Francesco Romani has posted comments on this change.
Change subject: automation: Use ovirt-4.0 repositories
..
Patch Set 1:
no changes to code whatsoever -> we can make one exception to the flow.
--
To view, visit
Francesco Romani has submitted this change and it was merged.
Change subject: automation: Use ovirt-4.0 repositories
..
automation: Use ovirt-4.0 repositories
The master repositories do not provide the fc23 packages any more,
Francesco Romani has posted comments on this change.
Change subject: automation: Use ovirt-4.0 repositories
..
Patch Set 1: Code-Review+2
thanks, I missed this and I was wondering what was broken :\
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: WIP: vm: skip domDependentInit for containers
..
Patch Set 24:
(1 comment)
https://gerrit.ovirt.org/#/c/54179/24/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Francesco Romani has posted comments on this change.
Change subject: utils: add utlity to generate positive cpuset notation
..
Patch Set 3:
If you used a recipe, a link/reference/whatever to that recipe is an awesome
first
Francesco Romani has posted comments on this change.
Change subject: vm: reorder operations in _domDependentInit
..
Patch Set 16:
rationale for this patch is to pave the road for
https://gerrit.ovirt.org/#/c/53820
AND make
Francesco Romani has posted comments on this change.
Change subject: vm: split device init from domDependentInit
..
Patch Set 16:
rationale for this patch is to pave the road for
https://gerrit.ovirt.org/#/c/53820
AND make
Francesco Romani has posted comments on this change.
Change subject: vm: split guest agent init from domDependentInit
..
Patch Set 16:
rationale for this patch is to pave the road for
https://gerrit.ovirt.org/#/c/53820
AND
Francesco Romani has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 39:
(1 comment)
https://gerrit.ovirt.org/#/c/53820/39/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Francesco Romani has posted comments on this change.
Change subject: hostdev: prefer numa nodes close to device MMIO
..
Patch Set 3: Code-Review-1
(1 comment)
only one minor style comment
Francesco Romani has posted comments on this change.
Change subject: vmxml: add appendNumaTune return value
..
Patch Set 1: Code-Review+2
why not?
--
To view, visit https://gerrit.ovirt.org/61106
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: Use DOM helpers in Vm._findGraphicsDeviceXMLByType etc.
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56107
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: virt: Minor formatting fix in vmdevices/storage.py
..
Patch Set 1: Code-Review-1
(1 comment)
-1 for visibility, no really strong feelings here
Francesco Romani has posted comments on this change.
Change subject: virt: Use vmxml DOM helpers in storage devices
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56102
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: osutils: Move NoIntrCall to osutils.uninterruptible
..
Patch Set 2: Code-Review+1
much nicer this way
--
To view, visit https://gerrit.ovirt.org/61153
To
Francesco Romani has posted comments on this change.
Change subject: osutils: Start the osutils module
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61142
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: utils: add utlity to generate positive cpuset notation
..
Patch Set 3: Code-Review-1
(1 comment)
-1 for visibility. The code is clever, but maybe too packed
Francesco Romani has posted comments on this change.
Change subject: hostdev: report device MMIO numa node
..
Patch Set 3: Code-Review+2
could also be useful for Engine's scheduler, so looks like a good change on its
own.
--
Francesco Romani has posted comments on this change.
Change subject: hostdev: expose numa_node in host device
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60638
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt net: Change graphics type from network to address
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61120
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vmdevices: New method Base._update_device_attributes
..
Patch Set 2: Code-Review-1
(1 comment)
this method is a bit messy, but overall I think that
Francesco Romani has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/55769/7/tests/vmXmlTests.py
File tests/vmXmlTests.py:
Francesco Romani has posted comments on this change.
Change subject: virt: Use DOM helpers in Vm.setLinkAndNetwork
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/58190
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: Return first child from vmxml.xml_to_dom
..
Patch Set 6: Code-Review+1
good enough for now.
--
To view, visit https://gerrit.ovirt.org/58194
To
Francesco Romani has posted comments on this change.
Change subject: virt: Switch to etree in vmxml.py
..
Patch Set 6: Code-Review+1
my previous comment was addressed partially. I'm fine to have it as proof of
concept and
Francesco Romani has posted comments on this change.
Change subject: virt: Use DOM helpers in Vm disk device handling
..
Patch Set 7: Code-Review+1
thanks, for the updates, looks better now
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: virt: Introduce MutableDomainDescriptor
..
Patch Set 1: Code-Review+1
I tend to like it, still not sure this is the best approach (perhaps changing
the
Francesco Romani has posted comments on this change.
Change subject: virt: Use DOM helpers in vmxml.device_address
..
Patch Set 7:
Milan answered to this comment in a previous patch, I'm fine with his plan.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55769
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: Send vm info report each sampling interval from VMBulkSampler
..
Patch Set 5:
Here is a *proof of concept* of the periodic uploader, the alternative approach
Francesco Romani has submitted this change and it was merged.
Change subject: oop: Explicitly close running ioprocesses
..
oop: Explicitly close running ioprocesses
IOProcess client is using __del__ for automatic closing when
901 - 1000 of 9835 matches
Mail list logo
