Irit Goihman has posted comments on this change.
Change subject: vdscli: added DeprecationWarning to module
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/60318
To unsubscribe, visit
Irit Goihman has posted comments on this change.
Change subject: tox: fail make process if required tox version isn't installed.
..
Patch Set 21: Verified+1
(7 comments)
https://gerrit.ovirt.org/#/c/59306/20/Makefile.am
File
Irit Goihman has uploaded a new change for review.
Change subject: vdscli: added DeprecationWarning to module
..
vdscli: added DeprecationWarning to module
vdscli is deprecated and will be replaced soon by jsonrpccli.
since we
Irit Goihman has uploaded a new change for review.
Change subject: wip: tests: change testing framework to pytest
..
wip: tests: change testing framework to pytest
Change-Id: Ife527b9274c31a72b57da9b958a1dd2f9f1e5ea0
Irit Goihman has posted comments on this change.
Change subject: infra: moved infra package from lib/vdsm/infra to
lib/vdsm/common
..
Patch Set 10:
verified infra removal on fedora 23 and centos 7
--
To view, visit
Irit Goihman has posted comments on this change.
Change subject: infra: moved infra package from lib/vdsm/infra to
lib/vdsm/common
..
Patch Set 10: Verified+1
--
To view, visit https://gerrit.ovirt.org/59304
To unsubscribe,
Irit Goihman has posted comments on this change.
Change subject: infra: moved infra package from lib/vdsm/infra to
lib/vdsm/common
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/59304/9/vdsm/vdsm
File vdsm/vdsm:
Irit Goihman has posted comments on this change.
Change subject: infra: moved infra package from lib/vdsm/infra to
lib/vdsm/common
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/59304/8//COMMIT_MSG
Commit Message:
Irit Goihman has posted comments on this change.
Change subject: tox: fail make process if required tox version isn't installed.
..
Patch Set 17: Verified+1
--
To view, visit https://gerrit.ovirt.org/59306
To unsubscribe,
Irit Goihman has posted comments on this change.
Change subject: tox: fail make process if required tox version isn't installed.
..
Patch Set 16:
(1 comment)
https://gerrit.ovirt.org/#/c/59306/16/build-aux/vercmp
File
Irit Goihman has posted comments on this change.
Change subject: tests: converted main.py to a test module
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/59975
To unsubscribe, visit
Irit Goihman has posted comments on this change.
Change subject: tests: storage and gluster exception tests pass py3
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/59869
To unsubscribe, visit
Irit Goihman has posted comments on this change.
Change subject: tests: converted main.py to a test module
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/59975/3/tests/Makefile.am
File tests/Makefile.am:
Line 112:
Irit Goihman has uploaded a new change for review.
Change subject: wip: py3: port storage misc.py file to python3
..
wip: py3: port storage misc.py file to python3
Change-Id: I1adec40146967965329024718c6ff48d0fa089fb
Irit Goihman has uploaded a new change for review.
Change subject: tests: converted main.py to a test module
..
tests: converted main.py to a test module
main.py is now a test module and has been renamed to
Irit Goihman has posted comments on this change.
Change subject: Makefile: added 'tests' target
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/59417
To unsubscribe, visit
Irit Goihman has posted comments on this change.
Change subject: tox: fail make process if required tox version isn't installed.
..
Patch Set 15:
(2 comments)
https://gerrit.ovirt.org/#/c/59306/15/Makefile.am
File
Irit Goihman has posted comments on this change.
Change subject: vdsm.spec: during rpm build only tests target will run
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/59910
To unsubscribe, visit
Irit Goihman has posted comments on this change.
Change subject: tox: fail make process if required tox version isn't installed.
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/59306/15/Makefile.am
File Makefile.am:
Irit Goihman has uploaded a new change for review.
Change subject: vdsm.spec: during rpm build only tests target will run
..
vdsm.spec: during rpm build only tests target will run
during vdsm rpm check 'make check' is running
Irit Goihman has posted comments on this change.
Change subject: Makefile: added 'tests' target
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/59417/5//COMMIT_MSG
Commit Message:
Line 6:
Line 7: Makefile: added
Irit Goihman has posted comments on this change.
Change subject: net tests: Pass config_network_test on py3
..
Patch Set 4: Verified+1
(1 comment)
https://gerrit.ovirt.org/#/c/59860/3/lib/vdsm/network/netconfpersistence.py
Irit Goihman has uploaded a new change for review.
Change subject: py3: tests: ported main.py test to python3
..
py3: tests: ported main.py test to python3
changed types.TypeType (which is deprecated in python3)
to primitive
Irit Goihman has posted comments on this change.
Change subject: vdsm.conf: Add drop-in dir
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/59858
To unsubscribe, visit https://gerrit.ovirt.org/settings
Irit Goihman has posted comments on this change.
Change subject: Makefile: added 'tests' target
..
Patch Set 3:
(5 comments)
https://gerrit.ovirt.org/#/c/59417/3//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2016-06-18
Irit Goihman has posted comments on this change.
Change subject: vdsm: removed unnecessary calls to vdsm config.read
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/59802
To unsubscribe, visit
Irit Goihman has posted comments on this change.
Change subject: vdsm.spec: change 'make check' to 'make unittest'
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/59417/3/Makefile.am
File Makefile.am:
Line 105
Line
Irit Goihman has posted comments on this change.
Change subject: py3 tests: ported imagetickets_test.py to python3
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/59859/2/vdsm/storage/imagetickets.py
File
Irit Goihman has uploaded a new change for review.
Change subject: py3 tests: ported network/conf_test.py to python3
..
py3 tests: ported network/conf_test.py to python3
ported relevant code to python3 in order that
Irit Goihman has posted comments on this change.
Change subject: py3 tests: ported imagetickets_test.py to python3
..
Patch Set 2: Verified+1
test passes on jenkins
--
To view, visit https://gerrit.ovirt.org/59859
To
Irit Goihman has uploaded a new change for review.
Change subject: py3 tests: ported imagetickets_test.py to python3
..
py3 tests: ported imagetickets_test.py to python3
ported relevant code to python3 in order that
Hello Piotr Kliczewski, Nir Soffer, Yaniv Bronhaim,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/59858
to review the following change.
Change subject: vdsm.conf: Add drop-in dir
..
vdsm.conf:
Irit Goihman has posted comments on this change.
Change subject: tox: fail make process if required tox version isn't installed.
..
Patch Set 14:
(4 comments)
https://gerrit.ovirt.org/#/c/59306/13/build-aux/vercmp
File
Irit Goihman has posted comments on this change.
Change subject: vdsm: removed unnecessary calls to vdsm config.read
..
Patch Set 1:
> add the droppin bug-url
It's not the drop-in patch
--
To view, visit
Irit Goihman has posted comments on this change.
Change subject: tox: fail make process if required tox version isn't installed.
..
Patch Set 13:
(14 comments)
https://gerrit.ovirt.org/#/c/59306/12/Makefile.am
File
Hello Piotr Kliczewski, Yaniv Bronhaim,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/59802
to review the following change.
Change subject: vdsm: removed unnecessary calls to vdsm config.read
..
Irit Goihman has posted comments on this change.
Change subject: vdsm.conf: Add drop-in dir
..
Patch Set 24: Verified+1
--
To view, visit https://gerrit.ovirt.org/58728
To unsubscribe, visit https://gerrit.ovirt.org/settings
Irit Goihman has posted comments on this change.
Change subject: vdsm: changed relative imports to absolute imports
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/56607
To unsubscribe, visit
Irit Goihman has posted comments on this change.
Change subject: py3 tests: ported vdsClientTests.py to python3
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/59710
To unsubscribe, visit
Irit Goihman has posted comments on this change.
Change subject: vdsm.conf: Add drop-in dir
..
Patch Set 23:
(1 comment)
https://gerrit.ovirt.org/#/c/58728/22/tests/config_test.py
File tests/config_test.py:
Line 137:
Line
Irit Goihman has posted comments on this change.
Change subject: vdsm.conf: Add drop-in dir
..
Patch Set 22:
(5 comments)
https://gerrit.ovirt.org/#/c/58728/21//COMMIT_MSG
Commit Message:
Line 26
Line 27
Line 28
Line 29
Line
Irit Goihman has posted comments on this change.
Change subject: py3 tests: ported vdsClientTests.py to python3
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/59710/1/client/vdsClient.py
File client/vdsClient.py:
Irit Goihman has posted comments on this change.
Change subject: tox: fail make process if required tox version isn't installed.
..
Patch Set 11:
(2 comments)
https://gerrit.ovirt.org/#/c/59306/11/build-aux/vercmp
File
Irit Goihman has posted comments on this change.
Change subject: tox: fail make process if required tox version isn't installed.
..
Patch Set 11:
(2 comments)
https://gerrit.ovirt.org/#/c/59306/10/Makefile.am
File
Irit Goihman has posted comments on this change.
Change subject: py3 tests: ported securableTests.py to python3
..
Patch Set 1: Verified+1
test passes on jenkins
--
To view, visit https://gerrit.ovirt.org/59726
To
Irit Goihman has posted comments on this change.
Change subject: tox: skip code style validation if required tox version isn't
installed.
..
Patch Set 10:
(6 comments)
https://gerrit.ovirt.org/#/c/59306/10//COMMIT_MSG
Commit
Irit Goihman has uploaded a new change for review.
Change subject: py3 tests: ported securableTests.py to python3
..
py3 tests: ported securableTests.py to python3
ported securable.py to python3 in order that securableTests.py
Irit Goihman has posted comments on this change.
Change subject: py3 tests: ported vdsClientTests.py to python3
..
Patch Set 1: Verified+1
test pass on jenkins
--
To view, visit https://gerrit.ovirt.org/59710
To unsubscribe,
Irit Goihman has posted comments on this change.
Change subject: With Tox we dont need to have local installation of pep8 and
pyflakes
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59723
To
Irit Goihman has uploaded a new change for review.
Change subject: py3 tests: ported vdsClientTests.py to python3
..
py3 tests: ported vdsClientTests.py to python3
ported relevant code to python3 in order that
vdsClientTests.py
Irit Goihman has posted comments on this change.
Change subject: tests: ported testlibTests.py to python3
..
Patch Set 3: Verified+1
testlibTests.py pass on jenkins
--
To view, visit https://gerrit.ovirt.org/59694
To
Irit Goihman has uploaded a new change for review.
Change subject: tests: ported testlibTests.py to python3
..
tests: ported testlibTests.py to python3
ported testlib.py to python3 in order that
testlibTests.py to be python3
Irit Goihman has abandoned this change.
Change subject: tests: migrate tests to python3
..
Abandoned
this patch contains changes that were already merged by other patches.
--
To view, visit https://gerrit.ovirt.org/57251
To
Irit Goihman has posted comments on this change.
Change subject: git: Add .tox to .gitignore
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59676
To unsubscribe, visit
Irit Goihman has posted comments on this change.
Change subject: py3 test: shorten python3 blacklist
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/59681
To unsubscribe, visit
Irit Goihman has uploaded a new change for review.
Change subject: py3 test: shorten python3 blacklist
..
py3 test: shorten python3 blacklist
removed a few tests from python3 blacklist.
these tests already pass under python3
Irit Goihman has posted comments on this change.
Change subject: infra: moved infra package contents from lib/vdsm to
lib/vdsm/common
..
Patch Set 6:
(7 comments)
https://gerrit.ovirt.org/#/c/59304/5//COMMIT_MSG
Commit
Irit Goihman has posted comments on this change.
Change subject: vdsm.conf: Add drop-in dir
..
Patch Set 21: Verified+1
--
To view, visit https://gerrit.ovirt.org/58728
To unsubscribe, visit https://gerrit.ovirt.org/settings
Irit Goihman has posted comments on this change.
Change subject: py3 test: shorten blacklist
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59547
To unsubscribe, visit
Irit Goihman has posted comments on this change.
Change subject: infra: moved infra package contents from lib/vdsm to
lib/vdsm/common
..
Patch Set 5:
(4 comments)
Irit Goihman has posted comments on this change.
Change subject: py3 test: shorten blacklist
..
Patch Set 2: Code-Review-1
ovs_driver_test and iproute2_test don't pass
--
To view, visit https://gerrit.ovirt.org/59547
To
Irit Goihman has posted comments on this change.
Change subject: py3 test: shorten blacklist
..
Patch Set 2: Code-Review+1
I removed some of the tests in
https://gerrit.ovirt.org/#/c/57251/9/tests/Makefile.am
--
To view,
Irit Goihman has posted comments on this change.
Change subject: wip: infra: moved infra package from lib/vdsm to lib/vdsm/common
..
Patch Set 2:
OK, I'm working on the changes
--
To view, visit
Irit Goihman has posted comments on this change.
Change subject: vdsm: removed unnecessary calls to vdsm config.read
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/59513
To unsubscribe, visit
Irit Goihman has posted comments on this change.
Change subject: vdsm.conf: Add drop-in dir
..
Patch Set 18:
(14 comments)
https://gerrit.ovirt.org/#/c/58728/18/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 537:
Irit Goihman has uploaded a new change for review.
Change subject: vdsm: removed unnecessary calls to vdsm config.read
..
vdsm: removed unnecessary calls to vdsm config.read
libvirt and vdscli modules had calls to config.read
Irit Goihman has posted comments on this change.
Change subject: build: Make sure run_tests*.sh scripts are executable
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55949
To unsubscribe, visit
Irit Goihman has posted comments on this change.
Change subject: tests: migrate tests to python3
..
Patch Set 9:
(2 comments)
https://gerrit.ovirt.org/#/c/57251/9/tests/Makefile.am
File tests/Makefile.am:
Line 143
Line 144
Irit Goihman has posted comments on this change.
Change subject: tox: skip code style validation if required tox version isn't
installed.
..
Patch Set 7:
(3 comments)
https://gerrit.ovirt.org/#/c/59306/6//COMMIT_MSG
Commit
Irit Goihman has posted comments on this change.
Change subject: vdsm.conf: Add drop-in dir
..
Patch Set 13:
(22 comments)
https://gerrit.ovirt.org/#/c/58728/13/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 25:
Irit Goihman has posted comments on this change.
Change subject: py3: Require libselinux-python3
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59425
To unsubscribe, visit
Irit Goihman has posted comments on this change.
Change subject: py3: Require libselinux-python3
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/59425/1//COMMIT_MSG
Commit Message:
PS1, Line 7: Require
Irit Goihman has uploaded a new change for review.
Change subject: tox: added disable tox style validation option to Makefile
..
tox: added disable tox style validation option to Makefile
This patch adds
Irit Goihman has posted comments on this change.
Change subject: tox: fail make process if tox version isn't right
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/59306/3//COMMIT_MSG
Commit Message:
Line 6:
Line
Irit Goihman has posted comments on this change.
Change subject: vdsm.conf: Add drop-in dir
..
Patch Set 12:
(14 comments)
https://gerrit.ovirt.org/#/c/58728/12/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 24:
Irit Goihman has posted comments on this change.
Change subject: wip: infra: moved infra package from lib/vdsm to lib/vdsm/common
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/59304/1/vdsm/vdsm
File vdsm/vdsm:
Irit Goihman has uploaded a new change for review.
Change subject: wip: tox: add version check and disable tox running option
..
wip: tox: add version check and disable tox running option
if tox is installed with 'yum install'
Irit Goihman has uploaded a new change for review.
Change subject: wip: infra: moved infra package from lib/vdsm to lib/vdsm/common
..
wip: infra: moved infra package from lib/vdsm to lib/vdsm/common
Change-Id:
Irit Goihman has posted comments on this change.
Change subject: Adding report_stats to host.api
..
Patch Set 8: -Verified
--
To view, visit https://gerrit.ovirt.org/58661
To unsubscribe, visit
Irit Goihman has posted comments on this change.
Change subject: Adding report_stats to host.api
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/58661
To unsubscribe, visit
Irit Goihman has posted comments on this change.
Change subject: vdsm.conf: Add drop-in dir
..
Patch Set 12: Verified+1
--
To view, visit https://gerrit.ovirt.org/58728
To unsubscribe, visit https://gerrit.ovirt.org/settings
Irit Goihman has uploaded a new change for review.
Change subject: infra tests: moved infra tests to tests directory
..
infra tests: moved infra tests to tests directory
infra tests were located with infra source code and were
Irit Goihman has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 29:
(1 comment)
https://gerrit.ovirt.org/#/c/53214/28/lib/vdsm/Makefile.am
File
Irit Goihman has posted comments on this change.
Change subject: tests: both Python2 and Python3 are default in Makefile
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/57106
To unsubscribe, visit
Irit Goihman has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 28:
(1 comment)
https://gerrit.ovirt.org/#/c/53214/27/lib/vdsm/module_loader.py
Irit Goihman has posted comments on this change.
Change subject: tests: both Python2 and Python3 are default in Makefile
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/57106
To unsubscribe, visit
Irit Goihman has posted comments on this change.
Change subject: tests: changed Makefile so that both python2 and pyhton3 will
be default. That way, all tests (including new ones) will have to support
python3 eventually.
..
Irit Goihman has posted comments on this change.
Change subject: tests: changed Makefile so that both python2 and pyhton3 will
be default. That way, all tests (including new ones) will have to support
python3 eventually.
..
Irit Goihman has posted comments on this change.
Change subject: Makefile: use tox to run make pep8 and pyflakes
..
Patch Set 14:
(10 comments)
https://gerrit.ovirt.org/#/c/49952/14/Makefile.am
File Makefile.am:
Line 107
Irit Goihman has posted comments on this change.
Change subject: Makefile: use tox to run make pep8 and pyflakes
..
Patch Set 14:
> with this patch, we require el7 developers and builders to install
> tox by pip.
>
> Can
Irit Goihman has posted comments on this change.
Change subject: Makefile: use tox to run make pep8 and pyflakes
..
Patch Set 14: Verified+1
--
To view, visit https://gerrit.ovirt.org/49952
To unsubscribe, visit
Irit Goihman has posted comments on this change.
Change subject: WIP: Makefile: use tox to run make pep8 and pyflakes
..
Patch Set 11: Verified-1
Tox fails on RHEL because it expects setup.py file. This option is disabled in
Irit Goihman has posted comments on this change.
Change subject: Introduce vdsm.common.host package for all host related code
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57172
To unsubscribe,
Irit Goihman has uploaded a new change for review.
Change subject: WIP: tests: migrate tests to python3
..
WIP: tests: migrate tests to python3
Change-Id: Iab8fda7a289aeaba9dd29ece6efad24bfecb2320
Signed-off-by: Irit Goihman
Irit Goihman has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 21: Verified+1
--
To view, visit https://gerrit.ovirt.org/53214
To unsubscribe,
Irit Goihman has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 21:
(1 comment)
Irit Goihman has uploaded a new change for review.
Change subject: WIP: Makefile: changed tests Makefile so that both python2 and
pyhton3 will be default. That way, all tests (including new ones) will have to
support python3 eventually.
Irit Goihman has posted comments on this change.
Change subject: Move host stats dict creation from API.py to host module
..
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/56874/6/lib/vdsm/host.py
File
Irit Goihman has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 15:
(5 comments)
Irit Goihman has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 15: Verified+1
(6 comments)
201 - 300 of 308 matches
Mail list logo
