Martin Betak has posted comments on this change.
Change subject: utils: Introduce CallbackChain
..
Patch Set 12:
(1 comment)
File lib/vdsm/utils.py
Line 997:
Martin Betak has posted comments on this change.
Change subject: utils: Introduce CallbackChain
..
Patch Set 13: Verified+1
--
To view, visit http://gerrit.ovirt.org/19228
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 34:
(1 comment)
File vdsm/vm.py
Line 1747:
Line 1748:
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: utils: Introduce CallbackChain
..
Patch Set 11:
(1 comment)
File tests/utilsTests.py
Line 160:
Martin Betak has posted comments on this change.
Change subject: utils: Introduce CallbackChain
..
Patch Set 12: Verified+1
--
To view, visit http://gerrit.ovirt.org/19228
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 33:
(1 comment)
File vdsm/vm.py
Line 1780: while not
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 34: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: utils: Introduce CallbackChain
..
Patch Set 11: Verified+1
--
To view, visit http://gerrit.ovirt.org/19228
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: utils: Introduce CallbackChain
..
Patch Set 9:
(2 comments)
File lib/vdsm/utils.py
Line 984: returning
Hello Federico Simoncelli, Dan Kenigsberg, Michal Skrivanek,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21521
to review the following change.
Change subject: vdsm: Accents in the vm name break the migration
Martin Betak has posted comments on this change.
Change subject: vdsm: Accents in the vm name break the migration
..
Patch Set 1:
(1 comment)
File vdsm/vm.py
Line 4876:
Martin Betak has posted comments on this change.
Change subject: vdsm: Accents in the vm name break the migration
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/21521
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 33: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 31: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: utils: Introduce CallbackChain
..
Patch Set 8: Verified+1
--
To view, visit http://gerrit.ovirt.org/19228
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 30: Verified+1
The retry check success mechanism in VmPowerDown enabled us to drop support
for timeouts in
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 28:
(4 comments)
File vdsm/vm.py
Line 1734:
Line 1735:
Martin Betak has posted comments on this change.
Change subject: utils: Introduce CallbackChain
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.ovirt.org/19228
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Betak has posted comments on this change.
Change subject: vdsm: Remove dead code in MigrationSourceThread.run
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/18336
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.ovirt.org/19361
To unsubscribe, visit
Martin Betak has uploaded a new change for review.
Change subject: vdsm: Accents in the vm name break the migration
..
vdsm: Accents in the vm name break the migration
Added utf-8 encoding of the configuration xml on the
Martin Betak has posted comments on this change.
Change subject: vdsm: Accents in the vm name break the migration
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/19684
To unsubscribe, visit
Martin Betak has uploaded a new change for review.
Change subject: utils: Introduce CallbackChain
..
utils: Introduce CallbackChain
Added new utility class encapsulating the pattern
of invoking multiple alternative methods to
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 23:
Dan: First of all, sorry for this incomplete patch set. Its purpose was to
serve as a quick check if all the
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 22:
(1 comment)
File vdsm/guestIF.py
Line 298:
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 21: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Fix potential leak in Vm.destroy()
..
Patch Set 1:
Git blame traced this back to the initial commit by 'Tabula Rasa' so no help
there. But my concern was
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 18:
(1 comment)
File vdsm/vm.py
Line 1631:
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 19: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 17:
(1 comment)
File vdsm/vm.py
Line 1631:
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 17:
(1 comment)
File vdsm/vm.py
Line 1619: return m
Martin Betak has uploaded a new change for review.
Change subject: vdsm: Fix potential leak in Vm.destroy()
..
vdsm: Fix potential leak in Vm.destroy()
The deleteVm method is now always called when destroying the VM.
Martin Betak has uploaded a new change for review.
Change subject: vdsm: Remove dead code in MigrationSourceThread.run
..
vdsm: Remove dead code in MigrationSourceThread.run
Removed the mstate variable and the corresponding if
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 18: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 16: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 17: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 15: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 14:
(7 comments)
File lib/vdsm/utils.py
Line 913:
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 14: Verified
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 12: (6 inline comments)
File lib/vdsm/utils.py
Line 929:
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 12: Verified
New callback design, with support of QEMU-GA.
--
To view, visit http://gerrit.ovirt.org/15829
To
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 10: (1 inline comment)
File vdsm/vm.py
Line 4099: def
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 11: Verified
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 11: Fails
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 10: Verified
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 5: (3 inline comments)
File vdsm_api/vdsmapi-schema.json
Line
Martin Beták has uploaded a new change for review.
Change subject: vdsm: [WIP] Reboot capability for VM
..
vdsm: [WIP] Reboot capability for VM
Added optional boolean parameters 'reboot' and 'force' to shutdown
both in API.py
201 - 249 of 249 matches
Mail list logo
