Michal Skrivanek has posted comments on this change.
Change subject: virt: Correct epoll unregistration usage in vmchannels
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51521
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: health: Introduce Vdsm health monitoring
..
Patch Set 1:
nice. though...for long running debugging I'd go with 1h interval or perhaps
even more hours
Michal Skrivanek has posted comments on this change.
Change subject: health: Introduce Vdsm health monitoring
..
Patch Set 1:
ah ok, you used DEBUG_LEAK. then not "hours":)
could it be turned on/off in runtime? same
Michal Skrivanek has posted comments on this change.
Change subject: virt: Correct epoll unregistration usage in vmchannels
..
Patch Set 4: Code-Review+1
I'm afraid we may underestimate the amount of "weird" error
Michal Skrivanek has posted comments on this change.
Change subject: spec: Move vdsm package contents to vdsm-deamon
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/42491/1/vdsm.spec.in
File vdsm.spec.in:
Line 304
Michal Skrivanek has posted comments on this change.
Change subject: virt: vm: Update time on VM after migration
..
Patch Set 3: Code-Review-1
I concur, based on the fact that the migration downtime is 500ms max by
default
Michal Skrivanek has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 1: Code-Review+1
same us master
--
To view, visit https://gerrit.ovirt.org/50426
To unsubscribe
Michal Skrivanek has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48860
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 9:
(2 comments)
https://gerrit.ovirt.org/#/c/48860/9/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1217
Michal Skrivanek has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 9: -Code-Review
(2 comments)
https://gerrit.ovirt.org/#/c/48860/9/vdsm/virt/vm.py
File vdsm/virt/vm.py
Michal Skrivanek has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/48860/9/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2814
Michal Skrivanek has posted comments on this change.
Change subject: daemon: revert cpu-affinity enabling by default
..
Patch Set 2: Code-Review-1
I'm fine disabling it for 3.6.1, but why on master? 49402 is the best solution
Michal Skrivanek has posted comments on this change.
Change subject: daemon: revert cpu-affinity enabling by default
..
Patch Set 3: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/49460
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: daemon: revert cpu-affinity enabling by default
..
Patch Set 3: -Code-Review
Sorry, I meant: yes, but there is on need to revert on master, is there? We
Michal Skrivanek has posted comments on this change.
Change subject: migration: Add incoming migration semaphore
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/45954/12/vdsm/virt/migration.py
File vdsm/virt
Michal Skrivanek has posted comments on this change.
Change subject: spec: bump cpopen requirements
..
Patch Set 3: Code-Review+1
don't we need this asap?
--
To view, visit https://gerrit.ovirt.org/46673
To unsubscribe
Michal Skrivanek has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46502
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: virt: add logic for POWER cpu xml element
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46451
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: hostdev: change ownership for passthrough USB devices
..
Patch Set 15: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44679
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: virt: add logic for POWER cpu xml element
..
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42736
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: supervdsm: only trigger 'vfio' subsystem for VFIO devices
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45345
To unsubscribe
Michal Skrivanek has posted comments on this change.
Change subject: graphics: use global displayNetwork if no local specified
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46224
To unsubscribe
Michal Skrivanek has posted comments on this change.
Change subject: vm: always hold confLock when updating pauseCode
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46005
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 15:
I hope you all realize we have a 3.6 RC build next week. We can't go back and
forth multiple
Michal Skrivanek has posted comments on this change.
Change subject: graphics: use global displayNetwork if no local specified
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/46224/3/vdsm/virt/vmdevices/graphics.py
Michal Skrivanek has posted comments on this change.
Change subject: graphics: use global displayNetwork if no local specified
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/46224/4/vdsm/virt/vmdevices/graphics.py
Michal Skrivanek has posted comments on this change.
Change subject: migration: Add incoming migration semaphore
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/45954/2/vdsm/virt/migration.py
File vdsm/virt
Michal Skrivanek has posted comments on this change.
Change subject: vm: graphics: fix settings after restore
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/44842/8/vdsm/virt/vmdevices/graphics.py
File vdsm/virt
Michal Skrivanek has posted comments on this change.
Change subject: hostdev: add udev rules for USB devices
..
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44679
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: fakekvm: report correct POWER8 model
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45249
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: vm: graphics: fix settings after restore
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44842
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: migration: Add incoming migration semaphore
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/45954/2/vdsm/virt/migration.py
File vdsm/virt
Michal Skrivanek has posted comments on this change.
Change subject: Add an empty metadata qos element to the created domain
..
Patch Set 2:
finally!:-)
great
--
To view, visit https://gerrit.ovirt.org/45664
To unsubscribe
Michal Skrivanek has posted comments on this change.
Change subject: storage: Hidden files filtered form listings of storage domains
..
Patch Set 2:
getISOList is not supposed to be used for anything like that. The other one
Michal Skrivanek has posted comments on this change.
Change subject: lib: daemon: cpu affinity support using taskset
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/45738/1/lib/vdsm/config.py.in
File lib/vdsm
Michal Skrivanek has posted comments on this change.
Change subject: storage: Hidden files filtered form listings of storage domains
..
Patch Set 2:
actually, I find it quite useless to send data which are never going
Michal Skrivanek has posted comments on this change.
Change subject: virt: add logic for POWER cpu xml element
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/42736/8/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line
Michal Skrivanek has posted comments on this change.
Change subject: virt: add logic for POWER cpu xml element
..
Patch Set 8: Code-Review+1
Dan, IIUC it is not needed for this patch, it will work just fine on any
libvirt
Michal Skrivanek has posted comments on this change.
Change subject: virt: add logic for POWER cpu xml element
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/42736/8/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line
Michal Skrivanek has posted comments on this change.
Change subject: vm: graphics: fix console open after restore
..
Patch Set 4:
Which inner piece? Liver?
:-D
Sorry, sorry, I couldn't help it:-)
--
To view, visit https
Michal Skrivanek has posted comments on this change.
Change subject: log: Use INFO log level as default
..
Patch Set 1:
please get something into 3.6 already. The verbosity is terrible, not only in
storage
--
To view, visit
Michal Skrivanek has posted comments on this change.
Change subject: v2v: Try to be nicer to other processes
..
Patch Set 3: Code-Review+1
since we think the cause lied in the actual specific NFS server implementation
Michal Skrivanek has posted comments on this change.
Change subject: hostdev: add udev rules for USB devices
..
Patch Set 3:
(1 comment)
please mention that this is needed due to dynamic_ownership parameter
https
Michal Skrivanek has posted comments on this change.
Change subject: Removing prefix definition for qemu-kvm-ev
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43993
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: vm: event: simplify send_status_event
..
Patch Set 16: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43414
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: virt: Handle disconnects only if endpoints match
..
Patch Set 1:
@vinzenz: please verify
--
To view, visit https://gerrit.ovirt.org/43141
To unsubscribe
Michal Skrivanek has posted comments on this change.
Change subject: vm: make up pauseCode if libvirt is omitting it
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44115
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: vm: make up pauseCode if libvirt is omitting it
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/44115/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Michal Skrivanek has posted comments on this change.
Change subject: vm: event: send status event on IO Error
..
Patch Set 21:
(1 comment)
https://gerrit.ovirt.org/#/c/43312/21/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3622
Michal Skrivanek has posted comments on this change.
Change subject: vm: make up pauseCode if libvirt is omitting it
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/44115/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Michal Skrivanek has posted comments on this change.
Change subject: vm: event: send status event on IO Error
..
Patch Set 21: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43312
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: vm: event: send status event on reboot
..
Patch Set 17: -Code-Review
all 3 are from libvirtEventLoop context...so perhaps libvirt is emitting
multiple times
Michal Skrivanek has posted comments on this change.
Change subject: Removing prefix definition for qemu-kvm-ev
..
Patch Set 1: Code-Review+1
(1 comment)
one more place
https://gerrit.ovirt.org/#/c/43993/1/vdsm.spec.in
File
Michal Skrivanek has posted comments on this change.
Change subject: fakevmstats: add config entry to enable/disable the hook
..
Patch Set 4: Code-Review+1
@ybronhei: AFAIK this is the only one which actually does something
Michal Skrivanek has posted comments on this change.
Change subject: fakevmstats: add config entry to enable/disable the hook
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43931
To unsubscribe
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: drop cluster version 3.6 for ppc64le
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/43892/2//COMMIT_MSG
Commit Message:
Line 3: AuthorDate
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: drop cluster version 3.6
..
Patch Set 1:
?
--
To view, visit https://gerrit.ovirt.org/43307
To unsubscribe, visit https://gerrit.ovirt.org/settings
Michal Skrivanek has posted comments on this change.
Change subject: virt: Send event after shutdown or reboot initiation
..
Patch Set 1:
@piotr: yeah, it's spreading like plague:) That's why I would think the
existing guest
Michal Skrivanek has posted comments on this change.
Change subject: vm: events: skip event after failed migration
..
Patch Set 2: Code-Review-1
will try to resolve on engine side, should be straightforward
--
To view, visit
Michal Skrivanek has posted comments on this change.
Change subject: vm: events: skip event after destroy
..
Patch Set 5: Code-Review-1
will investigate possible solution on engine side
--
To view, visit https
Michal Skrivanek has posted comments on this change.
Change subject: virt: Send event after shutdown or reboot initiation
..
Patch Set 1:
why not in guest agent?
--
To view, visit https://gerrit.ovirt.org/43862
Michal Skrivanek has posted comments on this change.
Change subject: virt: Change state of the agent only after heartbeat processing
..
Patch Set 1: Code-Review+1
@piotr - well, only fixing of a narrow race window
we shouldn't
Michal Skrivanek has posted comments on this change.
Change subject: lib: executor: get and show TID alongside name
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43771
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: clientIF: add logs during the recovery
..
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/43770/1/vdsm/clientIF.py
File vdsm/clientIF.py
Michal Skrivanek has posted comments on this change.
Change subject: vm: events: reorganize events
..
Patch Set 2: Code-Review+1
(4 comments)
https://gerrit.ovirt.org/#/c/43538/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Michal Skrivanek has posted comments on this change.
Change subject: vm: events: reorganize events
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/43538/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1806
Michal Skrivanek has posted comments on this change.
Change subject: vm: events: reorganize events
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/43538/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3649
Michal Skrivanek has posted comments on this change.
Change subject: vm: stats: do not send empty disks/networks
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43464
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: vm: events: do not send hashes in status messages
..
Patch Set 2: Code-Review+1
we do need hash in domDependentInit flow. For everything else we can drop
Michal Skrivanek has posted comments on this change.
Change subject: vm: event: send status event on powerdown
..
Patch Set 4:
not sure. poweringdown confuses engine a lot...we may be better off without it
should be tested
Michal Skrivanek has posted comments on this change.
Change subject: vm: event: emit event on setDownStatus
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43270
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: vm: event: send status event on IO Error
..
Patch Set 6:
(1 comment)
not sure, should be tested.
no harm if we dont' send it (we can skip some quick pause
Michal Skrivanek has posted comments on this change.
Change subject: virt: make vm events callback public
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43308
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: virt: event: send status event on migrations
..
Patch Set 3:
(2 comments)
not sure it's worth it. keep it for now, but i think it's not
critical/important
Michal Skrivanek has posted comments on this change.
Change subject: virt: clientif: remove generic vm status event
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43314
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: vm: event: emit event on domDependentInit
..
Patch Set 8:
looks ok
running stats is the best bet I suppose.
In future we should send everything so engine
Michal Skrivanek has posted comments on this change.
Change subject: vm: event: add arguments to send_status_event
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43396
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: vm: event: change logic to emit events
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/43345/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 390
Michal Skrivanek has posted comments on this change.
Change subject: vm: event: send status event on watchdog trigger
..
Patch Set 3: Code-Review-1
I wouldn't bother right now. Bigger problem is that we don't update lastStatus
Michal Skrivanek has posted comments on this change.
Change subject: vm: event: send status event on powerdown
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/43365/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3701
Michal Skrivanek has posted comments on this change.
Change subject: vm: event: emit event on guest status change
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43289
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: vm: event: send status event on RTC update
..
Patch Set 3: Code-Review-1
no need for events on RTC change, we don't use it anymore eanyway
--
To view
Michal Skrivanek has posted comments on this change.
Change subject: vm: event: send status event on IO Error
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43312
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: vm: event: send status event on lifecycle event
..
Patch Set 3:
(1 comment)
setDownStatus should be enough.
other events we don't really care about
https
Michal Skrivanek has posted comments on this change.
Change subject: virt: clientif: remove generic vm status event
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43314
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: vm: event: send status event on reboot
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43309
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: vm: event: emit event on setDownStatus
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43270
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: vm: emit event when domDependentInit is done
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/43269/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Michal Skrivanek has posted comments on this change.
Change subject: vm: event: emit event on setDownStatus
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/43270/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1308
Michal Skrivanek has posted comments on this change.
Change subject: virt: events: extract function to make event info
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43268
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: freeze: Freeze guest even when creating memory snapshot
..
Patch Set 5: Code-Review-1
still not convinced we should freeze when doing memory snapshots
Michal Skrivanek has posted comments on this change.
Change subject: virt: logging: introduce the 'virt' logger
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42687
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: API: streamline and make setLogLevel correct
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38425
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: client: update to keep up with setLogLevel changes
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42283
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: freeze: Freeze guest even when creating memory snapshot
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/43299/3//COMMIT_MSG
Commit Message:
Line
Michal Skrivanek has posted comments on this change.
Change subject: json-rpc: export setLogLevel API
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38424
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: virt: Handle disconnects only if endpoints match
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43141
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: freeze: Freeze guest even when creating memory snapshot
..
Patch Set 3: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/43299/3//COMMIT_MSG
Commit
Michal Skrivanek has posted comments on this change.
Change subject: vm: clock: always use rtc timer
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43195
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: virt: Handle disconnects only if endpoints match
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/43141/1/vdsm/clientIF.py
File vdsm/clientIF.py
101 - 200 of 799 matches
Mail list logo
