Oved Ourfali has posted comments on this change.
Change subject: jsonvdscli: change hostname default
..
Patch Set 1:
Rerun-Hooks: all
--
To view, visit https://gerrit.ovirt.org/63308
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..
Patch Set 11:
Irit - can you answer Piotr?
--
To view, visit https://gerrit.ovirt.org/62324
To unsubscribe,
Oved Ourfali has posted comments on this change.
Change subject: sos: replace dumpStorageTable with dump_volume_chains
..
Patch Set 3:
Irit - can you answer Dan's comment?
--
To view, visit https://gerrit.ovirt.org/62628
To
Oved Ourfali has posted comments on this change.
Change subject: sd: Remove unused setMetadata
..
Patch Set 10:
Nir, please abandon this if it isn't needed anymore.
--
To view, visit https://gerrit.ovirt.org/45613
To
Oved Ourfali has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60450
To unsubscribe, visit https://gerrit.ovirt.org/settings
Oved Ourfali has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 2:
We don't want to use the terminology "reports" at all here, as it confused with
other reports mechanism we used to
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: recovery error passed as response
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/60138
To unsubscribe, visit
Hello Piotr Kliczewski, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/60138
to review the following change.
Change subject: jsonrpc: recovery error passed as response
..
Oved Ourfali has posted comments on this change.
Change subject: [WIP]fencenode: split fenceNode into its own module
..
Patch Set 1:
We need to separate it
--
To view, visit https://gerrit.ovirt.org/43597
To unsubscribe,
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: recovery error passed as response
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/60006
To unsubscribe, visit
Hello Piotr Kliczewski, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/60006
to review the following change.
Change subject: jsonrpc: recovery error passed as response
..
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: recovery error passed as response
..
Patch Set 1: Verified+1
verified by QE and us.
--
To view, visit https://gerrit.ovirt.org/59948
To unsubscribe,
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: recovery error passed as response
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59948
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: migration: usage of single reactor in vdsm
..
Patch Set 5:
We want this merged ASAP. Tests will be added in the future.
Nir - can you merge?
--
To view, visit
Oved Ourfali has posted comments on this change.
Change subject: client: use representation object
..
Patch Set 2:
is it for 4.0 as well?
--
To view, visit https://gerrit.ovirt.org/59827
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: vdsm: return error when status cmd fail
..
Patch Set 3:
should you retrigger the build?
--
To view, visit https://gerrit.ovirt.org/57463
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: spec: change python-yaml to PyYAML
..
Patch Set 2:
It would be nice to understand what's the origin (i.e., where does it happen
exactly) to prevent future
Oved Ourfali has uploaded a new change for review.
Change subject: spec: change python-yaml to PyYAML
..
spec: change python-yaml to PyYAML
Seems like python-yaml is provided by PyYAML, and CI complains.
Change-Id:
Oved Ourfali has posted comments on this change.
Change subject: service: change vdsm KillMode to mixed
..
Patch Set 8:
can it be merged?
--
To view, visit https://gerrit.ovirt.org/45038
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: migration: set timeout to 10 mins
..
Patch Set 4:
Can we merge that?
--
To view, visit https://gerrit.ovirt.org/51786
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: migration: set timeout to 10 mins
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51786
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: health: Introduce Vdsm health monitoring
..
Patch Set 1: Code-Review+1
(1 comment)
Wait for Piotr/Yaniv to review, of course.
Oved Ourfali has posted comments on this change.
Change subject: migration: set timeout to 10 mins
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51786
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: Require safelease 1.0-6 for fedora 23 due to wrong build
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51377
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: spec: remove leftover directories on host
..
Patch Set 1:
as the relevent patch it merged on master, can this be merged as well?
--
To view, visit
Oved Ourfali has posted comments on this change.
Change subject: service: change vdsm KillMode to mixed
..
Patch Set 6:
Douglas - can you elaborate?
--
To view, visit https://gerrit.ovirt.org/45038
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: Adding compatibility for ovirt-engine 4.0 support
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49060
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: Adding compatibility for ovirt-engine 4.0 support
..
Patch Set 2:
the test issue is with:
14:51:28 FAIL: testEnablePromisc (ipwrapperTests.TestDrvinfo)
14:51:28
Oved Ourfali has posted comments on this change.
Change subject: adding compatibility for ovirt-engine 4.0 support
..
Patch Set 1:
Who can merge this?
--
To view, visit https://gerrit.ovirt.org/49060
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: adding compatibility for ovirt-engine 4.0 support
..
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/49060/1/vdsm/dsaversion.py.in
File
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 4:
@Francesco - so should we merge it without CI?
Or, is it in the works?
--
To view, visit
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 2:
bug created + commit message updated.
--
To view, visit https://gerrit.ovirt.org/48293
To unsubscribe,
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 2:
any way to trigger CI? I don't see it running at all on this patch...
--
To view, visit
Oved Ourfali has posted comments on this change.
Change subject: init: run configure --force on upgrade from ovirt-3.5
..
Patch Set 2:
No.
It should be abandoned.
Thanks for the quick response on this one.
--
To view, visit
Oved Ourfali has posted comments on this change.
Change subject: Adding call to configure passwd (libvirt sasl password)
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48231
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: Adding call to configure passwd (libvirt sasl password)
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48232
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: Adding call to configure passwd (libvirt sasl password)
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48232
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: init: configure multipath on upgrade from ovirt-3.5
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/47941
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: ssl: ssl socket may throw sslerror during reading
..
Patch Set 2: Code-Review+1
As this is a backport, why do we need to wait?
--
To view, visit
Oved Ourfali has posted comments on this change.
Change subject: ssl: ssl socket may throw sslerror during reading
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46625
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: ssl: ssl socket may throw sslerror during reading
..
Patch Set 2:
do you understand the jenkins failure?
--
To view, visit https://gerrit.ovirt.org/46625
To
Oved Ourfali has posted comments on this change.
Change subject: ssl: ssl socket may throw sslerror during reading
..
Patch Set 1: Code-Review+1
Is this fix only for m2crypto? What about standard SSL module?
--
To view,
Oved Ourfali has posted comments on this change.
Change subject: vdsClient: parse no value arguments
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46511
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: configurator doesn't load pyc files under configurators folder
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45846
To unsubscribe,
Oved Ourfali has posted comments on this change.
Change subject: configurator doesn't load pyc files under configurators folder
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45846
To unsubscribe,
Oved Ourfali has posted comments on this change.
Change subject: configurator doesn't load pyc files under configurators folder
..
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45846
To unsubscribe,
Oved Ourfali has posted comments on this change.
Change subject: configurator doesn't load pyc files under configurators folder
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45846
To unsubscribe,
Oved Ourfali has posted comments on this change.
Change subject: configurator doesn't load pyc files under configurators folder
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45846
To unsubscribe,
Oved Ourfali has posted comments on this change.
Change subject: configurator doesn't load pyc files under configurators folder
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45846/1/lib/vdsm/tool/configurator.py
Oved Ourfali has posted comments on this change.
Change subject: service: change vdsm KillMode to mixed
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45038
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: service: change vdsm KillMode to mixed
..
Patch Set 4:
thanks for the clarification.
--
To view, visit https://gerrit.ovirt.org/45038
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: service: change vdsm KillMode to mixed
..
Patch Set 4:
Yeela - can you verify?
Can we merge this?
--
To view, visit https://gerrit.ovirt.org/45038
To
Oved Ourfali has posted comments on this change.
Change subject: logging: remove log messages which give little or no value
..
Patch Set 2:
can we make sure the master patch is merged, and also merge this one?
--
To view,
Oved Ourfali has posted comments on this change.
Change subject: logging: remove log messages which give little or no value
..
Patch Set 1:
can we merge this one?
--
To view, visit https://gerrit.ovirt.org/43720
To
Oved Ourfali has posted comments on this change.
Change subject: ssl: ssl protocol configurable
..
Patch Set 3:
can we merge this one?
--
To view, visit https://gerrit.ovirt.org/43183
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: ceph: Report librbd1 package details
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/42717/1/vdsm/caps.py
File vdsm/caps.py:
Line 756:
Oved Ourfali has posted comments on this change.
Change subject: fix to commit aff0ccd which catches el7 exception when sysv not
exist
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41496
To
Oved Ourfali has posted comments on this change.
Change subject: vdscli: only write to stderr on plaintext connection given
timeout
..
Patch Set 2: -Code-Review
yes. we will probably abandon this one, as the issue will be
Oved Ourfali has posted comments on this change.
Change subject: vdscli: only write to stderr on plaintext connection given
timeout
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41384
To
Oved Ourfali has posted comments on this change.
Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..
Patch Set 5: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/39823/5//COMMIT_MSG
Commit
Oved Ourfali has posted comments on this change.
Change subject: client: Add warning prompt on dangerous commands
..
Patch Set 2:
Ping for storage review
--
To view, visit https://gerrit.ovirt.org/28174
To unsubscribe,
Oved Ourfali has posted comments on this change.
Change subject: client: Add warning prompt on dangerous commands
..
Patch Set 2: Code-Review-1
I closed the bug as wontfix.
Dima - please abandon.
--
To view, visit
Oved Ourfali has posted comments on this change.
Change subject: Introducing getAvailableUpdates API
..
Patch Set 9:
(2 comments)
https://gerrit.ovirt.org/#/c/38559/9/vdsm/API.py
File vdsm/API.py:
Line 1311: with
Oved Ourfali has posted comments on this change.
Change subject: Hack to fix vdsm-tool import issues during upgrade
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: Hack to fix vdsm-tool import issues during upgrade
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: json-rpc: fix the Host.getVMList return value
..
Patch Set 1:
Rerun-Hooks: all
--
To view, visit https://gerrit.ovirt.org/38322
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: Adding support for cluster level 3.6
..
Patch Set 1:
There are no engine tricks... People will just keep on doing the vdsm trick
manually...
--
To view, visit
Oved Ourfali has posted comments on this change.
Change subject: Adding support for cluster level 3.6
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37384
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: stomp: Make sure the \0 is read before slicing the buffer
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/36806
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: client: Add warning prompt on dangerous commands
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28174
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: regression on setupNetworks
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/36612
To unsubscribe, visit
Oved Ourfali has reverted this change.
Change subject: Revert jsonrpc: Image_upload missing in command_info
..
Patch Set 2: Reverted
This patchset was reverted in change: I3837c27bfbe2629c8959bf47a10ee72bcdec37cf
--
To view,
Oved Ourfali has uploaded a new change for review.
Change subject: Revert jsonrpc: Image_upload missing in command_info
..
Revert jsonrpc: Image_upload missing in command_info
This reverts commit
Oved Ourfali has posted comments on this change.
Change subject: Revert jsonrpc: Image_upload missing in command_info
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/36534
To unsubscribe, visit
Oved Ourfali has uploaded a new change for review.
Change subject: jsonrpc: Image_upload missing in command_info
..
jsonrpc: Image_upload missing in command_info
Change-Id: I79e28fed4caf3da5bdfefe030e4cfccb823d81d7
Bug-Url:
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: Image_upload missing in command_info
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/36516
To unsubscribe, visit
Oved Ourfali has uploaded a new change for review.
Change subject: jsonrpc: Image_upload missing in command_info
..
jsonrpc: Image_upload missing in command_info
Change-Id: I79e28fed4caf3da5bdfefe030e4cfccb823d81d7
Bug-Url:
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: Image_upload missing in command_info
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/36515
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: Image_upload missing in command_info
..
Patch Set 1:
Rerun-Hooks: all
--
To view, visit http://gerrit.ovirt.org/36516
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: VM_setCpuTuneQuota
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35553
To unsubscribe, visit http://gerrit.ovirt.org/settings
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: VM_updateVmPolicy
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35556
To unsubscribe, visit http://gerrit.ovirt.org/settings
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: VM_snapshot
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/3
To unsubscribe, visit http://gerrit.ovirt.org/settings
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: VM_setIoTune
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35554
To unsubscribe, visit http://gerrit.ovirt.org/settings
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: VM_setCpuTunePeriod
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35552
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: VM_getDiskAlignment
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35550
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: StoragePool_updateVMs
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35549
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: StoragePool_removeVM
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35548
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: StoragePool_getDomainsContainingImage
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35547
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: diskSizeExtend missing in command_info
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35218
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: diskSizeExtend missing in command_info
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35218
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: diskSizeExtend missing in command_info
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35218
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: ssl: accept_ssl needs to close socket
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35227
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: diskSizeExtend missing in command_info
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35229
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: cannot put link down on vNIC
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34447
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: Bridge.py reducing logging level
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34397
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: protocol_acceptor: Make SSL handshake asynchronous
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34200
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: Bridge.py reducing logging level
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34097
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: default args values in wrong order
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/33861
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: ssl: ssl_accept blocks after reboot
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/33644
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: ssl: ssl_accept blocks after reboot
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/33643
To unsubscribe, visit
1 - 100 of 167 matches
Mail list logo
