Piotr Kliczewski has posted comments on this change.
Change subject: logging: Improve logging when receiving signals
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61289
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: build: require only the same version, not release
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62672
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: yajsonrpc: switch to concurrent.thread()
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61462
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: test: Introduce mock module for testing
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62279
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: Adding units to cpu metrics name according to metrics2.0 spec
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/62156/4/lib/vdsm/virt/vmstats.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: api: Move getAllVmStats hooks and logging from API to clientIF
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/60583/2/vdsm/clientIF.py
File vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: Log RPC call arguments
..
Patch Set 2:
(1 comment)
It would be good to add some tests.
https://gerrit.ovirt.org/#/c/60572/2//COMMIT_MSG
Commit
Piotr Kliczewski has posted comments on this change.
Change subject: Adding units to memory metrics name according to metrics2.0 spec
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/62155/4/lib/vdsm/host/api.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: Adding memTotal metric
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/62154/4//COMMIT_MSG
Commit Message:
Line 4: Commit: Yaniv Bronhaim
Piotr Kliczewski has posted comments on this change.
Change subject: Add all MOM calls to jsonrpc client
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60492
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: health: Warn about delays in monitor threads
..
Patch Set 1:
can we have this patch in?
--
To view, visit https://gerrit.ovirt.org/52524
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: shorten executor thread system names
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61978
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: enabling ppc64le builds for vdsm
..
Patch Set 17: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62123
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: compat: py3: capture output of CPopen.communicate
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61393
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: lib: concurrent: fallback python name for system
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62275
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpcvdscli: change getVolumesList schema conversion
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62325
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: Removed unused global
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62533
To unsubscribe, visit https://gerrit.ovirt.org/settings
Piotr Kliczewski has posted comments on this change.
Change subject: vdsm reg: clean up
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62463
To unsubscribe, visit https://gerrit.ovirt.org/settings
Piotr Kliczewski has posted comments on this change.
Change subject: configs: move modprobe files loading to static
..
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61762
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: configs: move systemd service files to static
..
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61763
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: configs: move limits to static
..
Patch Set 14: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61605
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpcvdscli: change getVolumesList schema conversion
..
Patch Set 2:
Simone please take a look whether this change won't break your code.
--
To
Piotr Kliczewski has posted comments on this change.
Change subject: Fix in hawkular provider
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62357
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: Fix in hawkular provider
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62355
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: retry when flushing socket
..
Patch Set 8:
Let's keep it for a bit longer.
--
To view, visit https://gerrit.ovirt.org/47637
To unsubscribe,
Piotr Kliczewski has posted comments on this change.
Change subject: yml: return type fixes for StoragePool.getInfo
..
Patch Set 2:
ping
--
To view, visit https://gerrit.ovirt.org/58184
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: yajsonrpc: switch to concurrent.thread()
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61461
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: api: emit warnings only if configured
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62198
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: api: emit warnings only if configured
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62195
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: api: emit warnings only if configured
..
Patch Set 1: Code-Review+2
With this patch validation of request/responses goes down the drain. We could
not
Piotr Kliczewski has posted comments on this change.
Change subject: automation: build also vhostmd hook
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/61984/1//COMMIT_MSG
Commit Message:
Line 4: Commit: Sandro
Piotr Kliczewski has posted comments on this change.
Change subject: automation: use 3.6 repos
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61970
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: configs: move sysctl to static
..
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61619
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: configs: move logrotate to static
..
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61616
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: configs: move kernel module loading to static
..
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61617
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: configs: move sudoers to static
..
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61603
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: configs: move limits to static
..
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61605
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: configs: move rwtab to static
..
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61604
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: configs: move mom to static
..
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61602
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: configs: move logger to static
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61601
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: Simple jsonrpc client
..
Patch Set 16:
(1 comment)
https://gerrit.ovirt.org/#/c/35181/16/contrib/jsonrpc
File contrib/jsonrpc:
Line 43
Piotr Kliczewski has posted comments on this change.
Change subject: Update spec change-log after re-review
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61844
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: Removed %config(noreplace) from
%{_tmpfilesdir}/%{vdsm_name}.conf
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62030
To
Piotr Kliczewski has posted comments on this change.
Change subject: Specifies vdsm-infra version to obsoletes
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62029
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: Require python2-devel specifically to avoid python3 pkg
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62028
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: Change Source0 after uploading latest tar
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62027
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: Using %{_libdir} macro instead of /usr/lib
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62026
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: Rename reports to metrics
..
Patch Set 4: Code-Review+2
Rising the score. @Francesco please take a look as well.
--
To view, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: packaging: spec: drop default defattr
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61384
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: osutils: Move NoIntrCall to osutils.uninterruptible
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61153
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: osutils: Start the osutils module
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61142
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: lib: set system name for threads
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55074
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: Rename reports to metrics
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61870
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: Rename reports to metrics
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61870
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: Collect ksm values only if exist
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61767
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: Send vm info report each sampling interval from VMBulkSampler
..
Patch Set 14: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59523
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: packaging: spec: drop default defattr
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61384
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: Rename reports to metrics
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61870
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/57347/11/vdsm/API.py
File vdsm/API.py:
PS11, Line 1597
Piotr Kliczewski has posted comments on this change.
Change subject: Moving vmstatus to vdsm.common.virt
..
Patch Set 11: Code-Review-1
Please fix failing test:
16:17:12 File
"/home/jenkins/workspace/vdsm_master_
Piotr Kliczewski has posted comments on this change.
Change subject: Rename reports to metrics
..
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/61870/1/lib/vdsm/host/api.py
File lib/vdsm/host/api.py
Piotr Kliczewski has posted comments on this change.
Change subject: Send metrics info only if metrics enabled to avoid parsing logic
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61869
To
Piotr Kliczewski has posted comments on this change.
Change subject: Send vm info report each sampling interval from VMBulkSampler
..
Patch Set 13: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59523
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: vdsm: removing txRate and rxRate from code
..
Patch Set 6: Code-Review+1
Based on last comment I do not have more concerns about backward compatibility
Piotr Kliczewski has posted comments on this change.
Change subject: Send vm info report each sampling interval from VMBulkSampler
..
Patch Set 12:
is it worth adding some tests?
--
To view, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: Adding get_batch to StatsCache - returns dict with all vms stat
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/61768/3//COMMIT_MSG
Commit Message
Piotr Kliczewski has posted comments on this change.
Change subject: jsonvdscli: change hostname default
..
Patch Set 5: Verified+1
Verified by running vdsClient with enabled and disabled ipv6.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: use socket pending
..
Patch Set 1: Verified+1
Verified by updating existing vdsm and seeing that there are no issues with
communication.
--
To view
Piotr Kliczewski has uploaded a new change for review.
Change subject: stomp: use socket pending
..
stomp: use socket pending
Dispatcher pending method is deprecated and we want to use socket
pending method instead.
Change-Id
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: expose Volume.setDescription as setVolumeDescription
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61793
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: jsonvdscli: change hostname default
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/61782/2/lib/vdsm/jsonrpcvdscli.py
File lib/vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: jsonvdscli: change hostname default
..
Patch Set 1:
Simone can you check whether it works with diabled and enabled ipv6?
--
To view, visit https
Piotr Kliczewski has uploaded a new change for review.
Change subject: jsonvdscli: change hostname default
..
jsonvdscli: change hostname default
We want to mitigate dns lookups due to potential issues with
connectivity or dns
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: Simple jsonrpc client
..
Patch Set 16:
(1 comment)
https://gerrit.ovirt.org/#/c/35181/16/contrib/jsonrpc
File contrib/jsonrpc:
Line 43
Piotr Kliczewski has posted comments on this change.
Change subject: gluster:enforce gluster fencing policies
..
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59600
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: introduce vdsm.gluster module
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61019
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: yajsonrpc: use proper exception in the recovery
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61631
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: yajsonrpc: use proper exception in the recovery
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61613
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: log: Use INFO log level as default
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/32504
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: gluster:enforce gluster fencing policies
..
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59600
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: introduce vdsm.gluster module
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61019
To unsubscribe, visit https
Piotr Kliczewski has uploaded a new change for review.
Change subject: Log which client called a verb
..
Log which client called a verb
Change-Id: I48f781d29c19d0b7e884d864d6ab6ecb52216f68
Signed-off-by: Piotr Kliczewski
Piotr Kliczewski has posted comments on this change.
Change subject: configure: drop dead constant
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61312
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: gluster:enforce gluster fencing policies
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/59600/9/vdsm/API.py
File vdsm/API.py:
PS9, Line 1296
Piotr Kliczewski has posted comments on this change.
Change subject: tests: fix integration tests
..
Patch Set 5:
ping
--
To view, visit https://gerrit.ovirt.org/55871
To unsubscribe, visit https://gerrit.ovirt.org/settings
Piotr Kliczewski has posted comments on this change.
Change subject: tests: JsonRpcClient tests suite
..
Patch Set 4:
ping
--
To view, visit https://gerrit.ovirt.org/43582
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: [wip] build: assumptions about the path do not work for
distcheck
..
Patch Set 1:
Let's keep it for a bit longer
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: tests: JsonRpcServer tests suite
..
Patch Set 4:
We still want it in
--
To view, visit https://gerrit.ovirt.org/43581
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: api: expose stop and start of profilers
..
Patch Set 1:
still need to work on it
--
To view, visit https://gerrit.ovirt.org/52562
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: betterAsyncore: Log dispatcher on SSL errors
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61303
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: gluster:enforce gluster fencing policies
..
Patch Set 8: Code-Review-1
(5 comments)
https://gerrit.ovirt.org/#/c/59600/8/lib/api/vdsm-api.yml
File lib/api
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: introduce vdsm.gluster module
..
Patch Set 3: Code-Review+1
Please verify the change. Yaniv any additional comments?
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: oop: Fix and simplify oop lifetime
..
Patch Set 16:
(1 comment)
https://gerrit.ovirt.org/#/c/58622/16/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
Line
Piotr Kliczewski has posted comments on this change.
Change subject: oop: Fix and simplify oop lifetime
..
Patch Set 16:
(1 comment)
https://gerrit.ovirt.org/#/c/58622/16/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
Line
Piotr Kliczewski has posted comments on this change.
Change subject: oop: Fix and simplify oop lifetime
..
Patch Set 16:
(1 comment)
https://gerrit.ovirt.org/#/c/58622/16/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
PS16
Piotr Kliczewski has posted comments on this change.
Change subject: api: fixing default value for GlusterHost.createBrick
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60379
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: add simple tool to prettify python dumps
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60272
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: schema: fix VM.create parameters
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59258
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: api: tests: add test for VM.create
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60382
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: schema: fix VM.create parameters
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/59258/7/tests/vdsmapi_test.py
File tests/vdsmapi_test.py:
Line
201 - 300 of 2910 matches
Mail list logo
