Piotr Kliczewski has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 16: Verified+1
Code rebased. Verified by updating existing vdsm and seeing that communication
works without any
Piotr Kliczewski has posted comments on this change.
Change subject: vm: destroy: retry to gracefully destroy
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55537
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: guestagent: Add support for containers message
..
Patch Set 3: Code-Review+2
Schema change looks good now
--
To view, visit https://gerrit.ovirt.org/47519
Piotr Kliczewski has posted comments on this change.
Change subject: guestagent: Add support for containers message
..
Patch Set 2: Code-Review-1
(4 comments)
https://gerrit.ovirt.org/#/c/47519/2/lib/api/vdsmapi-schema.json
Piotr Kliczewski has posted comments on this change.
Change subject: hostdev: add support for hotplug
..
Patch Set 18: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42661
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: hostdev: add support for hotunplug
..
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42747
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: API: net: introduce 'switch' attribute for nets and bonds
..
Patch Set 3: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/55494/3/lib/api/vdsmapi
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 27:
(1 comment)
https://gerrit.ovirt.org/#/c/52864/27/lib/api/schemaapi.py
File lib/api/schemaapi.py:
Line 73
Piotr Kliczewski has posted comments on this change.
Change subject: vm: destroy: retry to gracefully destroy
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55537
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: commands: import StringIO when AsyncProc is started
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55380
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: suppress for python2
..
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55065
To unsubscribe, visit https://gerrit.ovirt.org/settings
Piotr Kliczewski has posted comments on this change.
Change subject: test: Use mock module for testing
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55342
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: testlib: Fix temporaryPath on Python 3.
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55489
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: hostdev: add support for hotplug
..
Patch Set 16: Code-Review-1
Repeating my score from patch set #12
--
To view, visit https://gerrit.ovirt.org/42661
Piotr Kliczewski has posted comments on this change.
Change subject: compat: mock CPopen for Python 3 testing
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55379
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: compat: mock CPopen for Python 3 testing
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55379
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: set default timeout value
..
Patch Set 1:
Sandro asked for it for hosted engine. Migration to jsonrpc is in progress.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: commands: import StringIO only on Python 2
..
Patch Set 2: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/55380/2/tests/Makefile.am
File tests
Piotr Kliczewski has posted comments on this change.
Change subject: vm: destroy: retry to gracefully destroy
..
Patch Set 6: Code-Review+2
For API related change.
--
To view, visit https://gerrit.ovirt.org/55224
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: set default timeout value
..
Patch Set 1:
Build failure on el7 not related to this patch.
--
To view, visit https://gerrit.ovirt.org/55397
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpcvdscli: disconnectStorageServer verb
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55250
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: vm: events: don't abort creation if event fails
..
Patch Set 3:
Once we have a log please open BZ.
--
To view, visit https://gerrit.ovirt.org/54933
Piotr Kliczewski has posted comments on this change.
Change subject: suppress for python2
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55065
To unsubscribe, visit https://gerrit.ovirt.org/settings
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: set default timeout value
..
Patch Set 1:
Sandro can you verify whether it works for you?
--
To view, visit https://gerrit.ovirt.org/55397
Piotr Kliczewski has uploaded a new change for review.
Change subject: jsonrpc: set default timeout value
..
jsonrpc: set default timeout value
Change-Id: I1a8fd964fec20621cf4c13df49719b9a242854c1
Signed-off-by: pkliczewski
Piotr Kliczewski has posted comments on this change.
Change subject: test: Use mock module for testing
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55342
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 6: Code-Review-1
Please fix issue that Edward mentioned.
--
To view, visit https://gerrit.ovirt.org/55065
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 27:
(8 comments)
https://gerrit.ovirt.org/#/c/52864/27/lib/api/schemaapi.py
File lib/api/schemaapi.py:
Line 37
Piotr Kliczewski has posted comments on this change.
Change subject: configure.ac: hard-require python3
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/55284/2/configure.ac
File configure.ac:
Line 244: if test &q
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpcvdscli: add storage verbs
..
Patch Set 1:
It looks like hsm makes them optional:
@public
def createStoragePool(self, poolType, spUUID
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpcvdscli: add storage verbs
..
Patch Set 1:
It looks like xmlrpc was providing some default values:
def poolCreate(self, poolType, spUUID
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpcvdscli: add storage verbs
..
Patch Set 1:
Sandro checking API.py I can see following params needed by this call :
def __init__(self, UUID
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 10: Verified+1
Fixed issue with default types such as tuple and dict. Yaml parser assumed them
to be strings
Piotr Kliczewski has posted comments on this change.
Change subject: json: removal of old schemas
..
Patch Set 10: Verified+1
Rebase only no code changes.
--
To view, visit https://gerrit.ovirt.org/54548
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 27: Verified+1
Updated default types in schema file. No code changes.
--
To view, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: el7: require newly available python34-nose
..
Patch Set 8:
When I run a build on el7 it fails with:
error: Failed build dependencies:
python34-nose
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpcvdscli: add storage verbs
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55252
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpcvdscli: getStorageDomainsList verb
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55249
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpcvdscli: connectStorageServer verb
..
Patch Set 1: Code-Review+2
It looks like required params are provided in wrong order. The mapping looks OK
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpcvdscli: getConnectedStoragePoolsList verb
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55246
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpcvdscli: add getVdsHardwareInfo verb
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55244
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: vm: safer early return if destroyed on startup
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/55151/4//COMMIT_MSG
Commit Message:
PS4, Line 17
Piotr Kliczewski has posted comments on this change.
Change subject: hostdev: expose hostdevReattach maintenance verb
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54891
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55065
To unsubscribe, visit https://gerrit.ovirt.org/settings
Piotr Kliczewski has posted comments on this change.
Change subject: virt: common handling of exceptions
..
Patch Set 13: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54664
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: json: removal of old schemas
..
Patch Set 9: Verified+1
Rebase only. Verified by upgrading existing vdsm and running and stopping a vm.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 26: Verified+1
Fixed schema to align with storage method removal. No other code changes.
Verified by upgrading
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 14: Verified+1
Fixed Nir's comments. Verified by upgrading existing vdsm and running and
stopping a vm.
--
To view
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 9: Verified+1
Fixed Nir's comments. Verified by upgrading existing vdsm and running and
stopping a vm
Piotr Kliczewski has posted comments on this change.
Change subject: hostdev: expose hostdevReattach maintenance verb
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/54891/6/client/vdsClient.py
File client
Piotr Kliczewski has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 4: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/55065/4/vdsm_hooks/ovs/ovs_before_network_setup.py
File vdsm_hooks
Piotr Kliczewski has posted comments on this change.
Change subject: vm: improve safety between startup and shutdown
..
Patch Set 5:
(3 comments)
https://gerrit.ovirt.org/#/c/44989/5/lib/api/vdsmapi-schema.json
File lib/api
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 25:
(7 comments)
https://gerrit.ovirt.org/#/c/52864/25/lib/api/schemaapi.py
File lib/api/schemaapi.py:
Line 48
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 13:
(5 comments)
https://gerrit.ovirt.org/#/c/53919/13/tests/schemaapi_test.py
File tests/schemaapi_test.py:
Line 66
Piotr Kliczewski has posted comments on this change.
Change subject: virt: common handling of exceptions
..
Patch Set 12: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54664
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: hostdev: expose hostdevReattach maintenance verb
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/54891/5/lib/vdsm/rpc/Bridge.py
File lib/vdsm/rpc
Piotr Kliczewski has posted comments on this change.
Change subject: hostdev: add support for hotunplug
..
Patch Set 6: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/42747/6/lib/api/vdsmapi-schema.json
File lib/api
Piotr Kliczewski has posted comments on this change.
Change subject: hostdev: add support for hotplug
..
Patch Set 12: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/42661/12/lib/api/vdsmapi-schema.json
File lib/api
Piotr Kliczewski has posted comments on this change.
Change subject: hostdev: add support for hotunplug
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/42747/6/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi
Piotr Kliczewski has posted comments on this change.
Change subject: vm: events: don't abort creation if event fails
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/54933/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Piotr Kliczewski has posted comments on this change.
Change subject: net: IP address hosttail split tool
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54312
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: json: removal of old schemas
..
Patch Set 8: Verified+1
Added changes in jsonrpcvdscli to fix vm migration issue. Client verified by
running subset
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 8: Verified+1
Added changes in jsonrpcvdscli to fix vm migration issue. Client verified by
running subset
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 13: Verified+1
Fixed build verification issue. No other code changes.
--
To view, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 24: Code-Review+2
Looks good to me, we need a patch which would make errors code part of api
Piotr Kliczewski has posted comments on this change.
Change subject: json: removal of old schemas
..
Patch Set 7: Verified+1
Change verified by host deploying vdsm, configuring a data domain and running
single vm
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 12: Verified+1
Change verified by host deploying vdsm, configuring a data domain and running
single vm.
--
To view
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 7: Verified+1
Change verified by host deploying vdsm, configuring a data domain and running
single vm
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 24: Verified+1
Change verified by host deploying vdsm, configuring a data domain and running
single vm.
--
To view
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: fix naming style
..
Patch Set 2: Verified+1
Change verified by host deploying vdsm, configuring a data domain and running
single vm.
--
To view
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 23:
(5 comments)
https://gerrit.ovirt.org/#/c/52864/23/contrib/schema-converter
File contrib/schema-converter:
Line
Piotr Kliczewski has posted comments on this change.
Change subject: api: remove unused methods
..
Patch Set 5: Verified+1
Rebase only, no code changes. Verified by running local build.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 22:
(2 comments)
https://gerrit.ovirt.org/#/c/52864/22/contrib/schema-converter
File contrib/schema-converter:
Line
Piotr Kliczewski has posted comments on this change.
Change subject: api: remove unused methods
..
Patch Set 5:
ping
--
To view, visit https://gerrit.ovirt.org/53673
To unsubscribe, visit https://gerrit.ovirt.org/settings
Piotr Kliczewski has posted comments on this change.
Change subject: net tests: IPv6 autoconf with RA server
..
Patch Set 6:
Can we revert this change?
I can see:
ERROR: test_local_auto_with_dynamic_address_from_ra
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 22:
(1 comment)
https://gerrit.ovirt.org/#/c/52864/22//COMMIT_MSG
Commit Message:
Line 8:
Line 9: As part
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 22:
(2 comments)
https://gerrit.ovirt.org/#/c/52864/22/lib/api/vdsmapi.py
File lib/api/vdsmapi.py:
Line 333
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/54528/6/lib/api/schemaapi.py
File lib/api/schemaapi.py:
Line 48
Line
Piotr Kliczewski has uploaded a new change for review.
Change subject: bridge: fix naming style
..
bridge: fix naming style
Change-Id: I149b233303a7bddfc52a7d690e77ae91b8152f84
Signed-off-by: pkliczewski <piotr.klic
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/54528/5/lib/vdsm/rpc/Bridge.py
File lib/vdsm/rpc/Bridge.py:
Line 1
Piotr Kliczewski has posted comments on this change.
Change subject: virt: common handling of exceptions
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54664
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 10:
(6 comments)
https://gerrit.ovirt.org/#/c/53919/10/lib/api/schemaapi.py
File lib/api/schemaapi.py:
Line 111
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/54528/5/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Run unit tests using travis-ci and docker
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/54856/1/.travis.yml
File .travis.yml:
Line 8
Piotr Kliczewski has posted comments on this change.
Change subject: WIP: POC: virt: common handling of exception
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/54664/2/lib/vdsm/virt/utils.py
File lib/vdsm/virt
Piotr Kliczewski has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 15:
(2 comments)
https://gerrit.ovirt.org/#/c/48871/15/lib/vdsm/exception.py
File lib/vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: rfh: Remove legacy remoteFileHandler
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54703
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: events: introduction of schema
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/54754/1/lib/api/vdsm-events.yaml
File lib/api/vdsm-events.yaml
Piotr Kliczewski has posted comments on this change.
Change subject: json: removal of old schemas
..
Patch Set 5: Verified+1
Set of patches verified by host deploying a host, configuring nfs data domain
and provision a vm
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 22: Verified+1
I updated schema with recent networking changes and removed monitorCommand
verb. Set of patches
Piotr Kliczewski has uploaded a new change for review.
Change subject: events: introduction of schema
..
events: introduction of schema
Change-Id: I43a9f1852b1459a2e905244049507704f0187201
Signed-off-by: pkliczewski
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Classify network tests type
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54391
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: test: Unit Test target with NOSE attribute/marker
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54388
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 15:
(3 comments)
https://gerrit.ovirt.org/#/c/48871/15/lib/vdsm/exception.py
File lib/vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: vm: remove not used monitorCommand
..
Patch Set 1: Verified+1
Verified that during runtime no issues found.
--
To view, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: vm: remove not used monitorCommand
..
Patch Set 1:
@Francesco any news?
--
To view, visit https://gerrit.ovirt.org/54513
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 21:
(1 comment)
https://gerrit.ovirt.org/#/c/52864/21/lib/api/vdsm-api.yaml
File lib/api/vdsm-api.yaml:
Line 6697
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 21:
(1 comment)
https://gerrit.ovirt.org/#/c/52864/21/lib/api/vdsm-api.yaml
File lib/api/vdsm-api.yaml:
Line 6697
Piotr Kliczewski has posted comments on this change.
Change subject: build: clean tests certificates
..
Patch Set 3: Verified+1
Verified that changes to makecert script causes regeneration of certs.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 16: Code-Review-1
Please see my comments from patch set #15.
--
To view, visit https
801 - 900 of 2901 matches
Mail list logo
