Petr Šebek has posted comments on this change.
Change subject: configNetwork: provide IPv6 configuration editing API
..
Patch Set 1:
I believe that this should be abandoned since this patch
http://gerrit.ovirt.org/#/c/18284/
Petr Šebek has posted comments on this change.
Change subject: Get rid of mutables(lists) as default parameters
..
Patch Set 5: Verified+1 Code-Review+1
I applied given patch to my host. In webadmin host smoothly went from
Petr Šebek has posted comments on this change.
Change subject: sampling.ImagePathStatus: drop unused code, and only it
..
Patch Set 1: Verified+1 Code-Review+1
I applied given patch to my host. In webadmin host smoothly went
Petr Šebek has posted comments on this change.
Change subject: sampling.ImagePathStatus: drop unused code
..
Patch Set 4: Verified+1 Code-Review+1
Installed without errors, getVdsStats returns statistics as expected.
--
To
Petr Šebek has posted comments on this change.
Change subject: sampling: StatsThread: dropped unused methods
..
Patch Set 1: Verified+1 Code-Review+1
VdsStats works as should. Pausing thread is not used anywhere so it's
Petr Šebek has posted comments on this change.
Change subject: drop unused checkPathStat
..
Patch Set 1: Verified+1 Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20673
To unsubscribe, visit
Petr Šebek has posted comments on this change.
Change subject: vdsm.utils: drop unused ImagePathStatus and getPidNiceness
..
Patch Set 2: Verified+1 Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20674
To
Petr Šebek has posted comments on this change.
Change subject: Monitor bridges using vdsStats
..
Patch Set 4:
(2 comments)
File vdsm/sampling.py
Line 371:
Petr Šebek has uploaded a new change for review.
Change subject: Removal of needless base class StatsThread
..
Removal of needless base class StatsThread
From this base class inherit only class HostStatsThread, therefore can
be
Petr Šebek has posted comments on this change.
Change subject: Monitor bridges using vdsStats
..
Patch Set 3:
(2 comments)
Commit Message
Line 10:
Line 11: Changes in
Petr Šebek has posted comments on this change.
Change subject: Add IPv6 support to configNetwork
..
Patch Set 11: Verified+1
Functional tests works on my server.
--
To view, visit http://gerrit.ovirt.org/18284
To
Petr Šebek has posted comments on this change.
Change subject: Add IPv6 support to configNetwork
..
Patch Set 9:
(3 comments)
File vdsm/sourceRoute.py
Line 49:
Petr Šebek has posted comments on this change.
Change subject: Add IPv6 support to configNetwork
..
Patch Set 10: Verified+1
It passes all functional tests at my server.
--
To view, visit http://gerrit.ovirt.org/18284
To
Petr Šebek has posted comments on this change.
Change subject: Add IPv6 support to configNetwork
..
Patch Set 6:
(1 comment)
File tests/functional/networkTests.py
Line
Petr Šebek has posted comments on this change.
Change subject: Add IPv6 support to configNetwork
..
Patch Set 7: Verified-1
Fixed bug with not showing IPv6 related attributes in ipconfig and ifcfg file.
But there is still no
Petr Šebek has posted comments on this change.
Change subject: bugfix: UpdateVmDevice QoS
..
Patch Set 6: Verified+1
Verified with ovirt-engine webadmin. Before update nic's bandwidth looks like
this:
bandwidth
inbound
Petr Šebek has restored this change.
Change subject: Monitor bridges using vdsStats
..
Restored
Change restored because:
Bug 996678 - Admin Portal (and REST API) not reporting the data used to
generate the network graph
Petr Šebek has posted comments on this change.
Change subject: Add IPv6 support to configNetwork
..
Patch Set 6: Verified-1
Added functional test but it fails, need to fix. Don't know why connection
refused in those other
Petr Šebek has posted comments on this change.
Change subject: Add IPv6 support to configNetwork
..
Patch Set 4:
(2 comments)
File vdsm/netmodels.py
Line 407: class
Petr Šebek has posted comments on this change.
Change subject: Add IPv6 support to configNetwork
..
Patch Set 2:
(2 comments)
File vdsm/configNetwork.py
Line 471:
Petr Šebek has posted comments on this change.
Change subject: Add IPv6 support to configNetwork
..
Patch Set 3: Code-Review-1
TODO add functional tests. Tests will be little incomplete, though. Functional
tests with dummy
Petr Šebek has posted comments on this change.
Change subject: bugfix: UpdateVmDevice QoS
..
Patch Set 3:
(4 comments)
File vdsm/vm.py
Line 1309: return iface
Line
Petr Šebek has posted comments on this change.
Change subject: bugfix: UpdateVmDevice QoS
..
Patch Set 4: Verified-1
There is unexpected exception when tried to run vmUpdateDevice. It's because
bandwidth / isn't populated:
Petr Šebek has posted comments on this change.
Change subject: bugfix: UpdateVmDevice QoS
..
Patch Set 5: Verified-1
Missing bandwidth content fixed. But there is still exception
SetLinkAndNetworkError: this function is not
Petr Šebek has posted comments on this change.
Change subject: bugfix: UpdateVmDevice QoS
..
Patch Set 1:
(3 comments)
File vdsm/vm.py
Line 1302: if
Petr Šebek has uploaded a new change for review.
Change subject: bugfix: UpdateVmDevice QoS
..
bugfix: UpdateVmDevice QoS
QoS was not handled in method Vm._updateInterfaceDevice.
Change-Id:
Petr Šebek has posted comments on this change.
Change subject: Fix missing bootproto line
..
Patch Set 7:
(1 comment)
File vdsm/netconf/ifcfg.py
Line 570: mtu =
Petr Šebek has posted comments on this change.
Change subject: Change of ConfigWriter._createConfFile parameters
..
Patch Set 7: Verified+1
Passes functional/networkTests.py
--
To view, visit http://gerrit.ovirt.org/18331
To
Petr Šebek has uploaded a new change for review.
Change subject: Testcase vlaned network to bridgeless
..
Testcase vlaned network to bridgeless
Added functional set to test bug 980174. Add network with protocol dhcp,
bridgeless
Petr Šebek has posted comments on this change.
Change subject: Avoid re-setting boot element when updating nic properties
..
Patch Set 1: Verified-1
When I tried to verify it there were this exception:
File
Petr Šebek has posted comments on this change.
Change subject: Avoid re-setting boot element when updating nic properties
..
Patch Set 1:
So I changed
vnicXML.firstChild.removeChild(vnicXML.getElementsByTagName('boot')[0])
Petr Šebek has posted comments on this change.
Change subject: Unified network persistence [3/3] - Restore network
configuration
..
Patch Set 7: Code-Review-1
(2 comments)
Petr Šebek has posted comments on this change.
Change subject: Change of ConfigWriter._createConfFile parameters
..
Patch Set 2:
(3 comments)
File vdsm/netconf/ifcfg.py
Petr Šebek has posted comments on this change.
Change subject: Change of ConfigWriter._createConfFile parameters
..
Patch Set 1:
(1 comment)
File vdsm/netconf/ifcfg.py
Line
Petr Šebek has posted comments on this change.
Change subject: Add IPv6 support to configNetwork
..
Patch Set 2:
(1 comment)
File vdsm/netconf/ifcfg.py
Line 478:
Petr Šebek has uploaded a new change for review.
Change subject: Change of ConfigWriter._createConfFile parameters
..
Change of ConfigWriter._createConfFile parameters
ifcfg.ConfigWriter._createConfFile now accepts IpConfig
Petr Šebek has uploaded a new change for review.
Change subject: Add IPv6 support to configNetwork
..
Add IPv6 support to configNetwork
This patch add IPv6 functionality to network configuration. We want to
run every device as
Petr Šebek has posted comments on this change.
Change subject: Don't reconfigure vlan devs unless necessary.
..
Patch Set 4:
(1 comment)
File vdsm/netmodels.py
Line 186:
Petr Šebek has posted comments on this change.
Change subject: jsonrpc: make TCPReactor IPv6 capable
..
Patch Set 3: Verified
without patch:
import asyncoreReactor
ar = asyncoreReactor.AsyncoreReactor()
aclient =
Petr Šebek has posted comments on this change.
Change subject: vdscli: update cannonize helper function for IPv6 environment
..
Patch Set 2:
I just want to make clear what IPv6%interface means because it was first time
I've
Petr Šebek has posted comments on this change.
Change subject: QoS host networks: caps now reports QoS for networks.
..
Patch Set 4: Verified; Looks good to me, but someone else must approve
Verified as Giuseppe suggested.
--
Petr Šebek has posted comments on this change.
Change subject: Deleted ovirt check from vdsm-restore-net-config
..
Patch Set 3: Verified
Verified on Red Hat Enterprise Virtualization Hypervisor release 6.4
(20130528.0.el6_4).
Petr Šebek has posted comments on this change.
Change subject: Add iproute2 configurator
..
Patch Set 4: (1 inline comment)
File vdsm/netconf/iproute2.py
Line 103:
Petr Šebek has posted comments on this change.
Change subject: vdscli: update cannonize helper function for IPv6 environment
..
Patch Set 1: Fails
When I try to run command
vdsClient -s [fe80::f472:60ff:fee7:d3e8] getVdsCaps
Petr Šebek has posted comments on this change.
Change subject: Add iproute2 configurator
..
Patch Set 4: (1 inline comment)
Waiting to see what will happen with that vlan issue.
Petr Šebek has posted comments on this change.
Change subject: [WIP] Unified persistence.
..
Patch Set 10: (1 inline comment)
File vdsm/vdsm-restore-net-config
Line 39:
Petr Šebek has posted comments on this change.
Change subject: Hidden bonds[2/2]: Refactored and updated nics implementation.
..
Patch Set 14: Verified; Looks good to me, but someone else must approve
Verified as suggested
Petr Šebek has abandoned this change.
Change subject: Monitor bridges using vdsStats
..
Patch Set 2: Abandoned
It seems that this change would have no real-life use case. All nics are
already monitored. There is no need to
Petr Šebek has posted comments on this change.
Change subject: [WIP] Unified persistence.
..
Patch Set 8: (1 inline comment)
File vdsm/configNetwork.py
Line 632: for
Petr Šebek has posted comments on this change.
Change subject: [WIP] Unified persistence.
..
Patch Set 9: I would prefer that you didn't submit this
(1 inline comment)
I just want to see your response to Mark Wu's comments.
Petr Šebek has uploaded a new change for review.
Change subject: Deleted ovirt check from vdsm-restore-net-config
..
Deleted ovirt check from vdsm-restore-net-config
Check if the machine is ovirt node prevented from proper
Petr Šebek has posted comments on this change.
Change subject: Remove mac address from host interface statistics
..
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
Petr Šebek has posted comments on this change.
Change subject: Remove mac address from host interface statistics
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13840
Petr Šebek has posted comments on this change.
Change subject: Bugfix update device hooks: after_update_device failure.
..
Patch Set 5: Verified; Looks good to me, but someone else must approve
Verified, behaves in expected
Petr Šebek has posted comments on this change.
Change subject: Monitor bridges using vdsStats
..
Patch Set 2:
Vlans are added. But constructor of clientIF class is called only on start of
vdsmd service and therefore in
Petr Šebek has posted comments on this change.
Change subject: XMLRPCServer: make XMLRPCServer able to listen on IPv6 addresses
..
Patch Set 8: Verified; Looks good to me, but someone else must approve
Everything working as it
Petr Sebek has posted comments on this change.
Change subject: netinfo: get an interface using one of IP addresses assigned to
it
..
Patch Set 6: Verified
Verified with python-ethtool-0.8. Passed the tests in netinfoTests.py,
Petr Sebek has abandoned this change.
Change subject: XMLRPCServer able to listen on IPv6 addresses
..
Patch Set 1: Abandoned
Working on original change 11520.
--
To view, visit http://gerrit.ovirt.org/14779
To unsubscribe,
Petr Sebek has uploaded a new change for review.
Change subject: XMLRPCServer able to listen on IPv6 addresses
..
XMLRPCServer able to listen on IPv6 addresses
SimpleXMLRPCServer is derived from SocketServer.TCPServer of which
Petr Sebek has posted comments on this change.
Change subject: drop a few unused external scripts
..
Patch Set 4: Verified; Looks good to me, but someone else must approve
Verified doing migration from one host to another.
--
Petr Sebek has posted comments on this change.
Change subject: Added setupNetworks command to vdsClient
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/14132
To unsubscribe, visit
Petr Sebek has posted comments on this change.
Change subject: Added setupNetworks command to vdsClient
..
Patch Set 3:
Fixed ineffective command to adding connectivityCheckout=False as default.
Example of Usage:
vdsClient 0
Petr Sebek has posted comments on this change.
Change subject: Added setupNetworks command to vdsClient
..
Patch Set 1: (5 inline comments)
Changed parameters to dicts. Only con of this approach is that it needs to be
in
Petr Sebek has posted comments on this change.
Change subject: drop a few unused external scripts
..
Patch Set 1: (1 inline comment)
File lib/vdsm/constants.py.in
Line 139:
Petr Sebek has posted comments on this change.
Change subject: drop a few unused external scripts
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14220
To unsubscribe,
Petr Sebek has uploaded a new change for review.
Change subject: Added setupNetworks command to vdsClient
..
Added setupNetworks command to vdsClient
To have ability to setup networks and bondings configuration from vdsClient.
Petr Sebek has posted comments on this change.
Change subject: Bond destroying
..
Patch Set 5: Verified
I have tested
# vdsm-tool load-needed-modules
and everything seems to work properly.
--
To view, visit
Petr Šebek has posted comments on this change.
Change subject: Bond destroying
..
Patch Set 1: (1 inline comment)
File vdsm/configNetwork.py
Line 517:
Petr Šebek has uploaded a new change for review.
Change subject: Bond destroying
..
Bond destroying
If there is deleted network with bond other than bond[0-4] and no
other network is using that bond, the bond is destroyed. It
69 matches
Mail list logo
