Change in vdsm[master]: fcoe hook: enable service

Pavel Zhukov has posted comments on this change. Change subject: fcoe hook: enable service .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/60311/1/vdsm_hooks/fcoe/fcoe_before_network_setup.py File

Change in vdsm[master]: hooks: Fix import of netconfpersistence

Pavel Zhukov has uploaded a new change for review. Change subject: hooks: Fix import of netconfpersistence .. hooks: Fix import of netconfpersistence Change-Id: Ia1060367ff4edca560b41f8b9c82c69172d85971 Signed-off-by: Pavel

Change in vdsm[ovirt-3.6]: net: Ignore noqueue queuing discipline

Pavel Zhukov has posted comments on this change. Change subject: net: Ignore noqueue queuing discipline .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57557 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: hooks: Add fcoe hook

Pavel Zhukov has posted comments on this change. Change subject: hooks: Add fcoe hook .. Patch Set 2: DEBUG util.py:393: https://repos.fedorapeople.org/repos/openstack/openstack-kilo/el7/repodata/repomd.xml: [Errno 14]

Change in vdsm[ovirt-3.6]: hooks: Add fcoe hook

Hello Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/57553 to review the following change. Change subject: hooks: Add fcoe hook .. hooks: Add fcoe hook This hook is used to

Change in vdsm[master]: hooks: Add fcoe hook

Pavel Zhukov has posted comments on this change. Change subject: hooks: Add fcoe hook .. Patch Set 33: Verified+1 -- To view, visit https://gerrit.ovirt.org/55029 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: hooks: Add fcoe hook

Pavel Zhukov has posted comments on this change. Change subject: hooks: Add fcoe hook .. Patch Set 27: Verified+1 -- To view, visit https://gerrit.ovirt.org/55029 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: hooks: Add fcoe hook

Pavel Zhukov has posted comments on this change. Change subject: hooks: Add fcoe hook .. Patch Set 26: Seems irrelevant to this change: 08:16:48 InvalidCall: Attempt to call function: > with arguments: ({'vmID':

Change in vdsm[master]: hooks: Add fcoe hook

Pavel Zhukov has posted comments on this change. Change subject: hooks: Add fcoe hook .. Patch Set 25: Verified+1 Verified as per #23. Fixed pep8/pylint stuff -- To view, visit https://gerrit.ovirt.org/55029 To unsubscribe,

Change in vdsm[master]: hooks: Add fcoe hook

Pavel Zhukov has posted comments on this change. Change subject: hooks: Add fcoe hook .. Patch Set 24: Verified+1 -- To view, visit https://gerrit.ovirt.org/55029 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: hooks: Add fcoe hook

Pavel Zhukov has posted comments on this change. Change subject: hooks: Add fcoe hook .. Patch Set 23: Verified+1 Verified using: 1) Added fcoe network to NIC: check configuration exists 2) Removed fcoe attribute: check file

Change in vdsm[master]: hooks: Add fcoe hook

Pavel Zhukov has posted comments on this change. Change subject: hooks: Add fcoe hook .. Patch Set 22: Verified-1 -- To view, visit https://gerrit.ovirt.org/55029 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: hooks: Add fcoe hook

Pavel Zhukov has posted comments on this change. Change subject: hooks: Add fcoe hook .. Patch Set 22: Seems like jenkins is broken. -- To view, visit https://gerrit.ovirt.org/55029 To unsubscribe, visit

Change in vdsm[master]: hooks: Add fcoe hook

Pavel Zhukov has posted comments on this change. Change subject: hooks: Add fcoe hook .. Patch Set 21: (3 comments) https://gerrit.ovirt.org/#/c/55029/21/vdsm_hooks/fcoe/fcoe_before_network_setup.py File

Change in vdsm[master]: hooks: Add fcoe hook

Pavel Zhukov has posted comments on this change. Change subject: hooks: Add fcoe hook .. Patch Set 20: (9 comments) https://gerrit.ovirt.org/#/c/55029/20/vdsm_hooks/fcoe/fcoe_before_network_setup.py File

Change in vdsm[master]: hooks: Add fcoe hook

Pavel Zhukov has posted comments on this change. Change subject: hooks: Add fcoe hook .. Patch Set 20: Verified-1 (1 comment) https://gerrit.ovirt.org/#/c/55029/20/vdsm_hooks/fcoe/fcoe_before_network_setup.py File

Change in vdsm[master]: hooks: Add fcoe hook

Pavel Zhukov has posted comments on this change. Change subject: hooks: Add fcoe hook .. Patch Set 20: (11 comments) https://gerrit.ovirt.org/#/c/55029/18/vdsm_hooks/fcoe/fcoe_before_network_setup.py File

Change in vdsm[master]: hooks: Add fcoe hook

Pavel Zhukov has posted comments on this change. Change subject: hooks: Add fcoe hook .. Patch Set 18: (4 comments) https://gerrit.ovirt.org/#/c/55029/17/vdsm_hooks/fcoe/fcoe_before_network_setup.py File

Change in vdsm[master]: hooks: Add fcoe hook

Pavel Zhukov has posted comments on this change. Change subject: hooks: Add fcoe hook .. Patch Set 14: (1 comment) https://gerrit.ovirt.org/#/c/55029/14/vdsm_hooks/fcoe/fcoe_before_network_setup.py File

Change in vdsm[master]: hooks: Add fcoe hook

Pavel Zhukov has posted comments on this change. Change subject: hooks: Add fcoe hook .. Patch Set 14: (4 comments) https://gerrit.ovirt.org/#/c/55029/14/vdsm_hooks/fcoe/fcoe_before_network_setup.py File

Change in vdsm[master]: hooks: Add fcoe hook

Pavel Zhukov has posted comments on this change. Change subject: hooks: Add fcoe hook .. Patch Set 14: F23 Build failed but seems not related: 18:50:43 ==

Change in vdsm[master]: hooks: Add fcoe hook

Pavel Zhukov has posted comments on this change. Change subject: hooks: Add fcoe hook .. Patch Set 13: Verified+1 (5 comments) https://gerrit.ovirt.org/#/c/55029/3/vdsm_hooks/fcoe/fcoe_before_network_setup.py File

Change in vdsm[master]: hooks: Add fcoe hook

Pavel Zhukov has posted comments on this change. Change subject: hooks: Add fcoe hook .. Patch Set 11: Verified+1 -- To view, visit https://gerrit.ovirt.org/55029 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: hooks: Add fcoe hook

Pavel Zhukov has posted comments on this change. Change subject: hooks: Add fcoe hook .. Patch Set 10: (3 comments) https://gerrit.ovirt.org/#/c/55029/10/vdsm.spec.in File vdsm.spec.in: Line 622: VDSM hook used for applying

Change in vdsm[master]: hooks: Add fcoe hook

Pavel Zhukov has posted comments on this change. Change subject: hooks: Add fcoe hook .. Patch Set 10: Verified+1 -- To view, visit https://gerrit.ovirt.org/55029 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: hooks: Add fcoe hook

Pavel Zhukov has posted comments on this change. Change subject: hooks: Add fcoe hook .. Patch Set 6: Verified+1 Tested with: 1) Add two fcoe networks 2) Move one of them to another interface 3) Changed fcoe=true to false 4)

Change in vdsm[master]: hooks: Add fcoe hook

Pavel Zhukov has uploaded a new change for review. Change subject: hooks: Add fcoe hook .. hooks: Add fcoe hook This hook is used to enable fcoe on one or several network interfaces Change-Id:

Change in vdsm[master]: hooks: Add fcoe hook

Pavel Zhukov has posted comments on this change. Change subject: hooks: Add fcoe hook .. Patch Set 4: Tested with flow: 1) Add 2 fcoe networks - both configs are in place 2) Changed one network set fcoe = false - corresponding

Change in vdsm[master]: hooks: Add fcoe hook

Pavel Zhukov has posted comments on this change. Change subject: hooks: Add fcoe hook .. Patch Set 2: I removed persist code because I was thinking it's redundant (supervdsm will restore config every boot (setupNetworks call)

Change in vdsm[master]: monitor: Refresh domains only if needed

Pavel Zhukov has posted comments on this change. Change subject: monitor: Refresh domains only if needed .. Patch Set 1: Verified+1 Nir, Thank you for explanation. Switched verified flag back as the original issue seems to be

Change in vdsm[master]: monitor: Refresh domains only if needed

Pavel Zhukov has posted comments on this change. Change subject: monitor: Refresh domains only if needed .. Patch Set 1: Nir, I've put Verified -1 because the fix makes the situation even worse. Example: User had X domains

Change in vdsm[master]: monitor: Refresh domains only if needed

Pavel Zhukov has posted comments on this change. Change subject: monitor: Refresh domains only if needed .. Patch Set 1: Verified-1 Once SPM restarted the issue came back. vgs should be run for all SDs as the result host is

Change in vdsm[master]: monitor: Refresh domains only if needed

Pavel Zhukov has posted comments on this change. Change subject: monitor: Refresh domains only if needed .. Patch Set 1: It works fine until SPM re-contending. LVM locking storm starts again... -- To view, visit

Change in vdsm[master]: monitor: Refresh domains only if needed

Pavel Zhukov has posted comments on this change. Change subject: monitor: Refresh domains only if needed .. Patch Set 1: Tested with reproducers from the BZ: Added 50 SD. everything went smooth Copy disk images between SD. OK

Change in vdsm[master]: monitor: Refresh domains only if needed

Pavel Zhukov has posted comments on this change. Change subject: monitor: Refresh domains only if needed .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/53395 To unsubscribe, visit

Change in vdsm[master]: virt: Add support for vgamem attribute

Pavel Zhukov has posted comments on this change. Change subject: virt: Add support for vgamem attribute .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/50091/2/vdsm/virt/vmdevices/core.py File

Change in vdsm[master]: Improve readability of _ownedIfcfg procedure

Pavel Zhukov has posted comments on this change. Change subject: Improve readability of _ownedIfcfg procedure .. Patch Set 3: Code-Review+1 Verified+1 -- To view, visit https://gerrit.ovirt.org/42287 To unsubscribe, visit

Change in vdsm[master]: Improve readability of _ownedIfcfg procedure

Pavel Zhukov has posted comments on this change. Change subject: Improve readability of _ownedIfcfg procedure .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/42287/1/vdsm/network/configurators/ifcfg.py File

Change in vdsm[master]: Improve readability of _ownedIfcfg procedure

Pavel Zhukov has posted comments on this change. Change subject: Improve readability of _ownedIfcfg procedure .. Patch Set 1: (1 comment) Petr, I don't understand you question. See inline comment (and original code). Thanks

Change in vdsm[master]: Improve readability of _ownedIfcfg procedure

Pavel Zhukov has posted comments on this change. Change subject: Improve readability of _ownedIfcfg procedure .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/42287 To unsubscribe, visit

Change in vdsm[master]: Improve readability of _ownedIfcfg procedure

Pavel Zhukov has uploaded a new change for review. Change subject: Improve readability of _ownedIfcfg procedure .. Improve readability of _ownedIfcfg procedure Before _ownedIfcfg returned free possible values (True, False or

Change in vdsm[master]: Invalidate filters on HSMs before rescanning extended VG

Pavel Zhukov has posted comments on this change. Change subject: Invalidate filters on HSMs before rescanning extended VG .. Patch Set 18: Dan, On other threads, getDevVis may now report the device as visible, a vgextend

Change in vdsm[master]: Invalidate filters on HSMs before rescanning extended VG

Pavel Zhukov has posted comments on this change. Change subject: Invalidate filters on HSMs before rescanning extended VG .. Patch Set 18: Dan, I though about it (that's why I've submitted wrong patch first time actually).

Change in vdsm[master]: Invalidate filters on HSMs before rescanning extended VG

Pavel Zhukov has posted comments on this change. Change subject: Invalidate filters on HSMs before rescanning extended VG .. Patch Set 18: Verified+1 verification steps: Extend VG with new LUN. wait for next vgs call

Change in vdsm[master]: Invalidate filters on HSMs before rescanning extended VG

Pavel Zhukov has posted comments on this change. Change subject: Invalidate filters on HSMs before rescanning extended VG .. Patch Set 16: Verified+1 Step to verification: - Extend VG with new LUN. - wait for next vgs call

Change in vdsm[master]: Invalidate filters before reloading vgs

Pavel Zhukov has restored this change. Change subject: Invalidate filters before reloading vgs .. Restored Checked http://gerrit.ovirt.org/#/c/17968/ It doesn't solve the problem -- To view, visit

Change in vdsm[master]: Invalidate filters before reloading vgs

Pavel Zhukov has abandoned this change. Change subject: Invalidate filters before reloading vgs .. Abandoned Fixed in http://gerrit.ovirt.org/#/c/17968/ -- To view, visit http://gerrit.ovirt.org/20552 To unsubscribe, visit

Change in vdsm[master]: Add additional vgcheck to fix vgextend workflow on HSMs.

Pavel Zhukov has posted comments on this change. Change subject: Add additional vgcheck to fix vgextend workflow on HSMs. .. Patch Set 9: I don't understand how this fixes the related bug. If the issue was a missing pv, how

Change in vdsm[master]: Add additional vgck.

Pavel Zhukov has uploaded a new change for review. Change subject: Add additional vgck. .. Add additional vgck. vgscan doesn't return nonzero return code if one or more phisycal volumes are filtered (missed). As a result

Change in vdsm[master]: Add additional vgck.

Pavel Zhukov has abandoned this change. Change subject: Add additional vgck. .. Abandoned need to resubmit the patch -- To view, visit http://gerrit.ovirt.org/20546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: vgscan doesn't return nonzero return code if one or more phi...

Pavel Zhukov has uploaded a new change for review. Change subject: vgscan doesn't return nonzero return code if one or more phisycal volumes are filtered (missed). We should check vg before raising of the exception. chkVG itself raises storageAccessError if failed, so selftest doesn't have to

Change in vdsm[master]: Add additional vgcheck to fix vgextend workflow on HSMs.

Pavel Zhukov has posted comments on this change. Change subject: Add additional vgcheck to fix vgextend workflow on HSMs. .. Patch Set 8: I'm sorry for the push flooding. Added the main reason of the patch (vgextend workflow)

Change in vdsm[master]: dumpStorageTable: Avoid an unnecessary traceback if vdsmd is...

Pavel Zhukov has posted comments on this change. Change subject: dumpStorageTable: Avoid an unnecessary traceback if vdsmd is down. .. Patch Set 2: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: dumpStorageTable: Avoid an unnecessary traceback if vdsmd is...

Pavel Zhukov has posted comments on this change. Change subject: dumpStorageTable: Avoid an unnecessary traceback if vdsmd is down. .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: vdsmd.init: replace libvirt logs filter

Pavel Zhukov has posted comments on this change. Change subject: vdsmd.init: replace libvirt logs filter .. Patch Set 3: (1 inline comment) File vdsm/vdsmd.init.in Line 309:

Change in vdsm[master]: vdsmd.init: replace libvirt logs filter

Pavel Zhukov has posted comments on this change. Change subject: vdsmd.init: replace libvirt logs filter .. Patch Set 3: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/13642

Change in vdsm[master]: vdsm: fix Vm cleanup routine

Pavel Zhukov has posted comments on this change. Change subject: vdsm: fix Vm cleanup routine .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/13610 To unsubscribe,

Change in vdsm[master]: vdsmd.init: replace libvirt logs filter

Pavel Zhukov has posted comments on this change. Change subject: vdsmd.init: replace libvirt logs filter .. Patch Set 2: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/13642

Change in vdsm[master]: Use absolute path of multipath.conf file, patch fix error 's...

Pavel Zhukov has uploaded a new change for review. Change subject: Use absolute path of multipath.conf file, patch fix error 'sudo: sorry, a password is required to run sudo' while rotating multipath.conf file. .. Use absolute

Change in vdsm[master]: Change sudo wildcards to work with absolute paths

Pavel Zhukov has uploaded a new change for review. Change subject: Change sudo wildcards to work with absolute paths .. Change sudo wildcards to work with absolute paths VDSM works with absolute paths of multipath,conf file but