Tal Nisan has posted comments on this change.
Change subject: alignmentScan: Use proper environment
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64123
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: storage: add getDeviceList discard related fields
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/60628/1/vdsm/storage/multipath.py
File
Tal Nisan has posted comments on this change.
Change subject: storage: Do not reference image dir in backing volume path
..
Patch Set 2:
Commit message was edited to contain the correct zstream clone bug link
--
To view,
Tal Nisan has posted comments on this change.
Change subject: sp: race in domains upgrade prevents further pool upgrades
..
Patch Set 7:
Liron, please verify asap so we can proceed with it
--
To view, visit
Tal Nisan has posted comments on this change.
Change subject: Don't prepare image with illegal volumes
..
Patch Set 1: -Code-Review
Please use this bug in the Bug-Url:
https://bugzilla.redhat.com/1332038
--
To view, visit
Tal Nisan has posted comments on this change.
Change subject: Don't prepare image with illegal volumes
..
Patch Set 1: Code-Review-1
Wait with the merge, we need a different Bug-Url
--
To view, visit
Tal Nisan has posted comments on this change.
Change subject: spec: qemu-kvm-img to handle unaligned images
..
Patch Set 1:
Nir, ping?
--
To view, visit https://gerrit.ovirt.org/56142
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: qemuimg: Make QCOW2_COMPAT configurable
..
Patch Set 2:
Adam, ping?
--
To view, visit https://gerrit.ovirt.org/54759
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: storage: fix spec normalization when mounting
..
Patch Set 8:
ping?
--
To view, visit https://gerrit.ovirt.org/55182
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: virt: Use libvirt to get drive size
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/55399/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3498
Line 3499
Tal Nisan has posted comments on this change.
Change subject: fileUtils: Convert unhelpful warnings to debug messages
..
Patch Set 9:
Will this ever be merged?
--
To view, visit https://gerrit.ovirt.org/36764
To unsubscribe,
Tal Nisan has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 1:
Francesco, I don't think Jenkins is set to run on this branch, can you please
test locally as you
Tal Nisan has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 1:
Quite a thorough test Francesco, thanks! Ever considered changing your surname
to Jenkins? ;)
--
To view,
Tal Nisan has posted comments on this change.
Change subject: lun: Serial attr should not passed to libvirt for lun disks.
..
Patch Set 4:
So can we move forward and merge it then?
--
To view, visit
Tal Nisan has posted comments on this change.
Change subject: Alignment scans will now run in direct mode
..
Patch Set 1:
Rerun-Hooks: all
--
To view, visit https://gerrit.ovirt.org/51619
To unsubscribe, visit
Tal Nisan has uploaded a new change for review.
Change subject: Alignment scans will now run in direct mode
..
Alignment scans will now run in direct mode
Currently on RHEL 7 and Fedora 22 or later alignment scan via libguestfs
Tal Nisan has posted comments on this change.
Change subject: Alignment scans will now run in direct mode
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/51619
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: Alignment scans will not run in direct mode
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/40402
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: Return correct scan alignment result through jsonrpc
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/51607/3/lib/api/vdsmapi-schema.json
File
Tal Nisan has uploaded a new change for review.
Change subject: Return correct scan alignment result through jsonrpc
..
Return correct scan alignment result through jsonrpc
Change-Id: If9ace1a9596f13225e493eda090d69a82d7c2bc1
Tal Nisan has posted comments on this change.
Change subject: Return correct scan alignment result through jsonrpc
..
Patch Set 2:
(5 comments)
https://gerrit.ovirt.org/#/c/51607/2//COMMIT_MSG
Commit Message:
Line 3:
Tal Nisan has posted comments on this change.
Change subject: Return correct scan alignment result through jsonrpc
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/51613
To unsubscribe, visit
Tal Nisan has uploaded a new change for review.
Change subject: Return correct scan alignment result through jsonrpc
..
Return correct scan alignment result through jsonrpc
Since jsonrpc was introduced in oVirt 3.5 the scan
Tal Nisan has posted comments on this change.
Change subject: Alignment scans will not run in direct mode
..
Patch Set 10:
Verified by running alignment scan on a host that failed to run one prior to
this fix, alignment scan
Tal Nisan has posted comments on this change.
Change subject: Return correct scan alignment result through jsonrpc
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/51607
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: Alignment scans will not run in direct mode
..
Patch Set 10: Verified+1
--
To view, visit https://gerrit.ovirt.org/40402
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: sslTests.py: Fix typos
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51311
To unsubscribe, visit https://gerrit.ovirt.org/settings
Tal Nisan has posted comments on this change.
Change subject: verify.py: Fix typo "attribets" -> "attributes"
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51312
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: momTests.py: Fix typo "paramters" -> "parameters"
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51309
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: utils.py: Fix typo "placeholer" -> "placeholder"
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51307
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: betterAsyncore.py: Fix typo "enought"->"enough"
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51308
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: rwlock_test.py: Fix typo "shold" -> "should"
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51310
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: dump_volume_chains.py: Spelling in comment
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51306
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: schema: Fix Typos
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51302
To unsubscribe, visit https://gerrit.ovirt.org/settings
Tal Nisan has posted comments on this change.
Change subject: compat.py: Fixed typo "libary"->"library"
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51303
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: zombiereaper: Fix typo "happend" -> "happened"
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51305
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: sigutils: Fix typo "the the" -> "the"
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51304
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: nfs-check.py: apostrophe
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51301
To unsubscribe, visit https://gerrit.ovirt.org/settings
Tal Nisan has posted comments on this change.
Change subject: vdsClient: Fix typo parmeter->parameter
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51300
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: Added the option to scan alignment directly according to a
config value
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/40402/5//COMMIT_MSG
Commit
Tal Nisan has posted comments on this change.
Change subject: Added the option to scan alignment directly according to a
config value
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/40402/5/lib/vdsm/config.py.in
Tal Nisan has uploaded a new change for review.
Change subject: spec: Require newer multipath version
..
spec: Require newer multipath version
There is a race between udev and multiapth which is solved in newer
multipath
Tal Nisan has posted comments on this change.
Change subject: spec: Require newer multipath version
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/49113
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: spec: Require newer libvirt version for el7
..
Patch Set 1:
The error in the check-patch job is not relevant:
Error: nothing provides ovirt-vmconsole >= 1.0.0-0
Tal Nisan has posted comments on this change.
Change subject: spec: Require newer multipath version
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/49461
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: spec: Require newer libvirt version for el7
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/49444
To unsubscribe, visit
Hello Dan Kenigsberg, Allon Mureinik, Freddy Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/49444
to review the following change.
Change subject: spec: Require newer libvirt version for el7
Tal Nisan has posted comments on this change.
Change subject: spec: Require newer multipath version
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/49113/3//COMMIT_MSG
Commit Message:
Line 7: spec: Require newer
Tal Nisan has uploaded a new change for review.
Change subject: spec: Require newer multipath version
..
spec: Require newer multipath version
There is a race between udev and multiapth which is solved in newer
multipath
Tal Nisan has posted comments on this change.
Change subject: Live Merge: Restore watermark tracking
..
Patch Set 4:
Ping?
--
To view, visit https://gerrit.ovirt.org/36924
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: spec: Require newer libvirt version for el7
..
Patch Set 3:
Ping?
--
To view, visit https://gerrit.ovirt.org/44834
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: build: Introduce --enable-gluster-mgmt option
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46708
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: build: Introduce --enable-gluster-mgmt option
..
Patch Set 5:
Barak, this is a much needed patch, if you have a better solution please share
with us otherwise
Tal Nisan has posted comments on this change.
Change subject: block: add blkdiscard on zero image
..
Patch Set 3:
ping???
--
To view, visit https://gerrit.ovirt.org/35631
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: spec: Require newer kernel version for RHEL
..
Patch Set 8:
Guys, please review, we need this for 3.5.6
--
To view, visit https://gerrit.ovirt.org/47078
To
Tal Nisan has posted comments on this change.
Change subject: blockVolume: Fail if metadata overflows
..
Patch Set 3: Code-Review+1
Giving +1 from the Engine side of the patch
--
To view, visit https://gerrit.ovirt.org/45472
Tal Nisan has uploaded a new change for review.
Change subject: Cleanup of storage domain creation in hsm.py
..
Cleanup of storage domain creation in hsm.py
This patch changes the specific per domain type creation handling is
Tal Nisan has posted comments on this change.
Change subject: Cleanup of storage domain creation in hsm.py
..
Patch Set 2: Verified+1
Verified by creating a file domain and a block domain, both worked correctly
--
To view,
Tal Nisan has posted comments on this change.
Change subject: spmprotect: Switch from fencing by pid to fencing using
systemctl
..
Patch Set 7:
Dima, there is a comment waiting for you reply here
--
To view, visit
Tal Nisan has posted comments on this change.
Change subject: multipath: Fix COMPELNT/Compellent Vol configuration
..
Patch Set 6:
How can we proceed then? What do we need to verify? I guess we don't want to
leave it hanging
Tal Nisan has posted comments on this change.
Change subject: iscsicred: Protect sensitive return value in supervdsm log
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43178
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: virt: enable libgfapi with snapshot support
..
Patch Set 3:
ping?
--
To view, visit https://gerrit.ovirt.org/33768
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: block: add blkdiscard on zero image
..
Patch Set 3:
ping?
--
To view, visit https://gerrit.ovirt.org/35631
To unsubscribe, visit https://gerrit.ovirt.org/settings
Tal Nisan has posted comments on this change.
Change subject: lvm: Update hsm.__processVGInfos() with lvm.getPV() new API
..
Patch Set 1:
ping?
--
To view, visit https://gerrit.ovirt.org/38421
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: Add environment variable to scan alignment calls
..
Patch Set 2: Code-Review-1
After discussing with Richard Jones, marking as -1 till we figure out a better
Tal Nisan has posted comments on this change.
Change subject: Add environment variable to scan alignment calls
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/40402/2/vdsm/alignmentScan.py
File vdsm/alignmentScan.py:
Tal Nisan has posted comments on this change.
Change subject: lvm: Update hsm.__processVGInfos() with lvm.getPV() new API
..
Patch Set 1:
Guys, any reason this patch doesn't have +2? Quite simple and straight
forward... Dan,
Tal Nisan has posted comments on this change.
Change subject: qemu-img: Handle image end offset on different lines of output
..
Patch Set 2: Code-Review+1
(1 comment)
Minor comment in the test
Tal Nisan has posted comments on this change.
Change subject: spec: Require lvm = 2.02.100-8
..
Patch Set 3: Verified-1
I agree with Nir, I'm gonna try and contact the LVM bug assignee again to know
exactly which one we
Tal Nisan has uploaded a new change for review.
Change subject: spec: Require lvm = 2.02.100-8
..
spec: Require lvm = 2.02.100-8
Change-Id: Iee80ffbbee55768aa632725c9f129813a8815d4b
Signed-off-by: Tal Nisan tni...@redhat.com
Tal Nisan has posted comments on this change.
Change subject: fileUtils: Remove bogus warning from log [1/2]
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/36764
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: fileUtils: Remove bogus warning from log [1/2]
..
Patch Set 5:
Federico/Dan, ping?
--
To view, visit http://gerrit.ovirt.org/36764
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: API: move diskSizeExtend logic from BindingXMLRPC
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/36590
To unsubscribe, visit
Hello Nir Soffer, Daniel Erez, Dan Kenigsberg, Allon Mureinik,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/36613
to review the following change.
Change subject: API: move diskSizeExtend logic from BindingXMLRPC
Hello Nir Soffer, Daniel Erez, Dan Kenigsberg, Allon Mureinik,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/36614
to review the following change.
Change subject: API: move diskSizeExtend logic from BindingXMLRPC
Tal Nisan has abandoned this change.
Change subject: API: move diskSizeExtend logic from BindingXMLRPC
..
Abandoned
Wrong branch, this is meant to be in ovirt-3.5
--
To view, visit http://gerrit.ovirt.org/36613
To
Tal Nisan has posted comments on this change.
Change subject: qemuimg: Create qcow2 compat 0.10 images
..
Patch Set 1:
Guys, can we go forward with this patch?
--
To view, visit http://gerrit.ovirt.org/33022
To unsubscribe,
Tal Nisan has posted comments on this change.
Change subject: spec: Require qemu-kvm-rhev in EL
..
Patch Set 3:
Any updates about this patch? Seem to be stuck from the 14th
--
To view, visit http://gerrit.ovirt.org/32239
To
Tal Nisan has posted comments on this change.
Change subject: vm, guestagent: return hash should include also the disk mapping
..
Patch Set 3:
Rerun-Hooks: run
--
To view, visit http://gerrit.ovirt.org/33198
To unsubscribe,
Tal Nisan has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 3:
Rerun-Hooks: all
--
To view, visit http://gerrit.ovirt.org/33197
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: vm, guestagent: return hash should include also the disk mapping
..
Patch Set 3:
Rerun-Hooks: all
--
To view, visit http://gerrit.ovirt.org/33198
To unsubscribe,
Tal Nisan has posted comments on this change.
Change subject: Create destination image as preallocated only if format is RAW
..
Patch Set 1:
Verified by:
Cold move in the same storage type (block/file)
Cold move in the
Tal Nisan has posted comments on this change.
Change subject: Create destination image as preallocated only if format is RAW
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/27274
To unsubscribe, visit
Tal Nisan has uploaded a new change for review.
Change subject: Create destination image as preallocated only if format is RAW
..
Create destination image as preallocated only if format is RAW
Create a destination image as
Tal Nisan has posted comments on this change.
Change subject: Create destination image as preallocated only if format is RAW
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/27244/1/vdsm/storage/image.py
File
Tal Nisan has posted comments on this change.
Change subject: core: return lver/spm id from pool metadata
..
Patch Set 2:
In V4 it will al go away :)
--
To view, visit http://gerrit.ovirt.org/27226
To unsubscribe,
Tal Nisan has posted comments on this change.
Change subject: fileUtils: Make memory filesystems support configurable
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27236
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: Create destination image as preallocated only if format is RAW
..
Patch Set 3: Verified+1
Verified by ratamir and some by me by:
- Cold move in the same storage
Tal Nisan has posted comments on this change.
Change subject: storage: fix pep issue with image.py
..
Patch Set 1: Code-Review+1
Fix seems ok but it's strange, I double checked with pep8 on image.py before
pushing the patch,
Tal Nisan has uploaded a new change for review.
Change subject: Create destination image as preallocated only if format is RAW
..
Create destination image as preallocated only if format is RAW
Create a destination image as
Tal Nisan has posted comments on this change.
Change subject: storage: fix pep issue with image.py
..
Patch Set 2:
On the contrary, I totally agreed with Douglas, the Jenkins build also failed
although it was a couple of
Tal Nisan has posted comments on this change.
Change subject: storage: fix pep issue with image.py
..
Patch Set 2:
I meant *a couple of hours after the merge
--
To view, visit http://gerrit.ovirt.org/27273
To unsubscribe,
Tal Nisan has posted comments on this change.
Change subject: Allow moving of sparse images to a block domains
..
Patch Set 3: Verified+1
Verified moving all different options of format types and sparse/preallocated
from file
Hello Federico Simoncelli, Dan Kenigsberg, Allon Mureinik,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/26469
to review the following change.
Change subject: Allow moving of sparse images to a block domains
Tal Nisan has abandoned this change.
Change subject: Fix a reference before assignment bug in Hsm.py
..
Abandoned
After a discussion in the bug itself it seems that the workaround suggested is
not correct, thus abandoning
--
Tal Nisan has uploaded a new change for review.
Change subject: Fix a reference before assignment bug in Hsm.py
..
Fix a reference before assignment bug in Hsm.py
https://bugzilla.redhat.com/show_bug.cgi?id=1080106
Tal Nisan has posted comments on this change.
Change subject: Fix a reference before assignment bug in Hsm.py
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26109/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line
Tal Nisan has posted comments on this change.
Change subject: Allow moving of sparse images to a block domains
..
Patch Set 7: Verified+1
Verified moving all different options of format types and sparse/preallocated
from file
Tal Nisan has posted comments on this change.
Change subject: Allow moving of sparse images to a block domains
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/25778/7/vdsm/storage/image.py
File vdsm/storage/image.py:
Tal Nisan has posted comments on this change.
Change subject: Allow moving of sparse images to a block domains
..
Patch Set 8: Verified+1
Verified moving all different options of format types and sparse/preallocated
from file
1 - 100 of 120 matches
Mail list logo