Francesco Romani has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 27: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28714
To unsubscribe, visit http://gerrit.ovirt.org/settings
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Add API.VM.setIoTune
..
Add API.VM.setIoTune
This allows MoM (and the engine if necessary) to set the iotune
limits for disk devices.
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 27: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/28714
To unsubscribe, visit http://gerrit.ovirt.org/settings
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 28:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5603/ :
SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 27:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10197/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 25:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10160/ : SUCCESS
Martin Sivák has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 26: Verified+1
Rebase only, tests ok.
--
To view, visit http://gerrit.ovirt.org/28714
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 26:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10178/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 23:
Inline comments in patchset 22
--
To view, visit http://gerrit.ovirt.org/28714
To unsubscribe, visit
Martin Sivák has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 23: Verified+1
It still passes my tests, but I wonder if there is a better way to update the
vdsm caches here.
--
To view,
Martin Sivák has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 24: Verified+1
Additional lines covered by tests, the rest did not change.
--
To view, visit http://gerrit.ovirt.org/28714
To
Martin Sivák has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 22:
(1 comment)
http://gerrit.ovirt.org/#/c/28714/22/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3824:
Francesco Romani has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 24: Code-Review+1
(1 comment)
good enough for me.
http://gerrit.ovirt.org/#/c/28714/24/vdsm/virt/vm.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 24:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10147/ : ABORTED
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 21:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10080/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 22:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10089/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 22: Code-Review-1
(2 comments)
see inline comment, I'm concerned about a field not being properly updated.
Besides that,
Martin Sivák has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 22:
(2 comments)
http://gerrit.ovirt.org/#/c/28714/22/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3778:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 23:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10112/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 20:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10053/ : SUCCESS
Martin Sivák has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 19: Verified+1
--
To view, visit http://gerrit.ovirt.org/28714
To unsubscribe, visit http://gerrit.ovirt.org/settings
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 19:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9997/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 18: Code-Review-1
(1 comment)
The new setIoTune is a quite big chunk of code, but I don't see any obvious way
to improve
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 13:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9903/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 14:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9912/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 15:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9922/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 16:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9924/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 17:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9935/ : SUCCESS
Martin Sivák has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 17:
Verified using setIoTune call to set the info, virsh to verify that the info is
set and getVmStats to get the same info
Martin Sivák has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 17: Verified+1
--
To view, visit http://gerrit.ovirt.org/28714
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Sivák has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 18: Verified+1
Just a commit message update..
--
To view, visit http://gerrit.ovirt.org/28714
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 18:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9955/ : SUCCESS
Martin Sivák has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 10: Verified+1
--
To view, visit http://gerrit.ovirt.org/28714
To unsubscribe, visit http://gerrit.ovirt.org/settings
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 10:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9859/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 11:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9868/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 12:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9877/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9758/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9765/ : FAILURE
Martin Sivák has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.ovirt.org/28714
To unsubscribe, visit http://gerrit.ovirt.org/settings
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9584/ : SUCCESS
Martin Sivák has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.ovirt.org/28714
To unsubscribe, visit http://gerrit.ovirt.org/settings
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9601/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9538/ : SUCCESS
Martin Sivák has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 4: Verified-1
This patch uses blkio tune, which is probably not what we want (and it won't
work here). blkio tune sets the
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9394/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9315/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 2: Code-Review-1
(1 comment)
Perhaps I'm missing something but I don't see where this is actually bound to
Martin Sivák has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 3:
You are missing the point of this patch being not ready for review, that is why
there were no reviewers assigned to it..
Francesco Romani has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 3: -Code-Review
Removing score then
--
To view, visit http://gerrit.ovirt.org/28714
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9337/ : SUCCESS
Martin Sivák has uploaded a new change for review.
Change subject: Add API.VM.setIoTune
..
Add API.VM.setIoTune
Change-Id: I0bd48f13311ad2efc4241117a777ca3400c259ea
Signed-off-by: Martin Sivak msi...@redhat.com
---
M
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9252/ : SUCCESS
52 matches
Mail list logo
