Fernando Granha Jeronimo has posted comments on this change.
Change subject: Fix vdsm-reg service name
..
Patch Set 3: (2 inline comments)
File vdsm_reg/vdsm-config
Line 16:
Fernando Granha Jeronimo has posted comments on this change.
Change subject: Fix vdsm-reg service name
..
Patch Set 3:
Hello Ryan,
I totally agree, I will split this patch.
WRT the race condition, I think I have a different
Dan Kenigsberg has posted comments on this change.
Change subject: Fix vdsm-reg service name
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8037
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fix vdsm-reg service name
..
Fix vdsm-reg service name
Due to a problem with the vdsm-reg service name (vdsmd-reg instead of vdsm-reg),
the service is
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Fix vdsm-reg service name
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8037
To
Ryan Harper has posted comments on this change.
Change subject: Fix vdsm-reg service name
..
Patch Set 4: I would prefer that you didn't submit this
4) If just before reboot, the vdsm-reg sees that it has enough information
Ryan Harper has posted comments on this change.
Change subject: Fix vdsm-reg service name
..
Patch Set 4: Looks good to me, but someone else must approve
While my comment still stands, that's really for your other patch. This
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Fix vdsm-reg service name
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/8037
To unsubscribe, visit
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Fix vdsm-reg service name
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8037
To
Ryan Harper has posted comments on this change.
Change subject: Fix vdsm-reg service name
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
I also agree we have more than one patch
1) fix vdsm-reg
Ryan Harper has posted comments on this change.
Change subject: Fix vdsm-reg service name
..
Patch Set 3:
Here's how I understand the problem, please correct if I don't have the
complete picture
1) node boots (firstboot=1,
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Fix vdsm-reg service name
..
Patch Set 3: (2 inline comments)
Hi Fernando, IMO, you could split your patch. Also, fell free to add your name
into
12 matches
Mail list logo
