gerrit-hooks has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Yaniv Bronhaim has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 9: Verified+1
(1 comment)
https://gerrit.ovirt.org/#/c/51763/9/lib/vdsm/utils.py
File
Nir Soffer has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/51763/9/lib/vdsm/utils.py
File
gerrit-hooks has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Nir Soffer has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/51763/8/lib/vdsm/utils.py
File
gerrit-hooks has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Yaniv Bronhaim has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/51763
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 6:
ok, agree with that - it doesn't block anything regarding
Nir Soffer has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 6:
Yaniv, sync is not standard subprocess.Popen parameter, and we should remove it
anyway,
Yaniv Bronhaim has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 6:
I don't see any usage with sync=False and data, but it still useful and should
be
Nir Soffer has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/51763/6/tests/commands_test.py
File
Yaniv Bronhaim has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/51763/6/tests/commands_test.py
File
Nir Soffer has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 6:
Ping, this blocks removal of deathSignal
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/51763/6/tests/commands_test.py
File
Yaniv Bronhaim has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/51763/6/tests/commands_test.py
File
Nir Soffer has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 6: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/51763/6/tests/commands_test.py
Yaniv Bronhaim has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/51763
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Piotr Kliczewski has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51763
To unsubscribe,
Dan Kenigsberg has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 5:
(3 comments)
https://gerrit.ovirt.org/#/c/51763/5/lib/vdsm/commands.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 5: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/51763
To unsubscribe,
Yaniv Bronhaim has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/51763/5/lib/vdsm/commands.py
File
Yaniv Bronhaim has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 5: Verified+1
(1 comment)
if you already here - can you check why test_echo(16384,
Piotr Kliczewski has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 5:
(1 comment)
Will fix the test
Piotr Kliczewski has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/51763/5/lib/vdsm/commands.py
File
Yaniv Bronhaim has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/51763/3/lib/vdsm/commands.py
File
gerrit-hooks has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Nir Soffer has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 3: Code-Review+1
(2 comments)
A test would be nice.
gerrit-hooks has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Piotr Kliczewski has posted comments on this change.
Change subject: kill and report asyncProc if fails on first write to stdin
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/51763/2//COMMIT_MSG
Commit Message:
gerrit-hooks has posted comments on this change.
Change subject: kill and report asyncProc if fails on first write to stdin
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Piotr Kliczewski has posted comments on this change.
Change subject: kill and report asyncProc if fails on first write to stdin
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/51763/2/lib/vdsm/commands.py
File
Nir Soffer has posted comments on this change.
Change subject: kill and report asyncProc if fails on first write to stdin
..
Patch Set 2: Code-Review+1
(2 comments)
Code looks fine, but commit message needs more love.
Nir Soffer has posted comments on this change.
Change subject: kill and report asyncProc if fails on first write to stdin
..
Patch Set 2: Code-Review-1
(2 comments)
On second look there are some issues.
Yaniv Bronhaim has posted comments on this change.
Change subject: kill and report asyncProc if fails on first write to stdin
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/51763
To unsubscribe, visit
Yaniv Bronhaim has uploaded a new change for review.
Change subject: kill and report asyncProc if fails on first write to stdin
..
kill and report asyncProc if fails on first write to stdin
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: kill and report asyncProc if fails on first write to stdin
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
38 matches
Mail list logo
