Dan Kenigsberg has submitted this change and it was merged.
Change subject: debug: Integrate manhole debugging service
..
debug: Integrate manhole debugging service
Manhole is in-process service that will accept unix domain
automat...@ovirt.org has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Dan Kenigsberg has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 7: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/32147
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 7:
Rebased and tested again.
--
To view, visit https://gerrit.ovirt.org/32147
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 6:
Will rebase soon, thanks.
--
To view, visit https://gerrit.ovirt.org/32147
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 6:
I'm happy to include this, please rebase. And in another patch - remove the
debug plugin
--
To
Francesco Romani has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 6:
ping for other reviews - I think this is an useful addition
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 6:
ping?
--
To view, visit http://gerrit.ovirt.org/32147
To unsubscribe, visit
Saggi Mizrahi has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 6:
How is this better than https://github.com/ficoos/gdb-python-scripts Which
doesn't need any
Nir Soffer has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 6:
Saggi, it looks that manhole integration and improving gdb python support are
different things, and I
Francesco Romani has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 6: Code-Review+1
Useful and helpful addition for debugging, seems harmless in other scenarios,
so
Nir Soffer has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 6: Verified+1
Tested on rhel 6.6 and 7.
--
To view, visit http://gerrit.ovirt.org/32147
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 6:
Version 6 is rebase on master and update the commit message.
manhole-1.0.0 supports now the required
oVirt Jenkins CI Server has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12984/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32147
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 3:
The console is unusable now because of the exceptions Python prints to stderr
every few seconds.
I
Nir Soffer has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 4: Verified+1
This version works with current vdsm using my git.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11684/ :
Dan Kenigsberg has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 4: Code-Review+1
I believe this deprecates the debugPlugin. Let's drop it in a subsequent patch.
--
Nir Soffer has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 5:
Upstream manhole supports now redirect_stderr, no need to use my repository.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11685/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11683/ :
Nir Soffer has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 3: Verified+1
It works - and reveal that we have serious threading issue - we get this
warning to stderr
Antoni Segura Puimedon has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 2:
Why would we need to restart vdsm to enable it.
What I propose is
1. Enable it:
vdsClient
Nir Soffer has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 2:
What you suggest is convenient, but it gives someone out of the machine too
much control.
We can use
Antoni Segura Puimedon has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 2:
I would like the signal because to investigate problems that accumulate over
time, it is
Francesco Romani has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 2:
I see Nir's point, but signal is very convenient.
A good way to accomodate both convenience and
Antoni Segura Puimedon has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 2:
Have you considered instead of making it be a config value that it there would
be a verb
Nir Soffer has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 2:
No, but why make it more complex? If we had to restart vdsm to enable it, I
would like to use it
Nir Soffer has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/32147/1//COMMIT_MSG
Commit Message:
Line 22:
Nir Soffer has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 2:
Use safer and more convenient /var/run/vdsm/vdsmd.manhole
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11216/ :
Nir Soffer has uploaded a new change for review.
Change subject: debug: Integrate manhole debugging service
..
debug: Integrate manhole debugging service
Manhole is in-process service that will accept unix domain socket
Nir Soffer has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 1:
Untested - posted so people can try this awesome thing.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11199/ :
Nir Soffer has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/32147/1//COMMIT_MSG
Commit Message:
Line 22:
37 matches
Mail list logo
