oVirt Jenkins CI Server has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 11: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5988/ :
Antoni Segura Puimedon has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 9:
(12 comments)
http://gerrit.ovirt.org/#/c/23248/9/lib/vdsm/netlink.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 12: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5992/ :
Antoni Segura Puimedon has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 13: Verified+1
--
To view, visit http://gerrit.ovirt.org/23248
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ipwrapper: switch link polling to netlink
..
ipwrapper: switch link polling to netlink
Getting the links from iproute2 implied creating a process each
Dan Kenigsberg has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 13: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/23248
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 13:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5993/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 13:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/289/
Antoni Segura Puimedon has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 9: Verified+1
--
To view, visit http://gerrit.ovirt.org/23248
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 9:
(4 comments)
Few initial comments
http://gerrit.ovirt.org/#/c/23248/9/lib/vdsm/netlink.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 6: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5918/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 7: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5920/ :
Antoni Segura Puimedon has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 9:
(4 comments)
Thanks for the review Francesco
Antoni Segura Puimedon has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 10: Verified+1
--
To view, visit http://gerrit.ovirt.org/23248
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 10:
Looks good, but need more documentation and some cleanup.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 9:
(15 comments)
See comments
http://gerrit.ovirt.org/#/c/23248/9/lib/vdsm/netlink.py
File
Nir Soffer has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 10:
Note that I reviewed patch set 9.
--
To view, visit http://gerrit.ovirt.org/23248
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 9:
(1 comment)
http://gerrit.ovirt.org/#/c/23248/9/lib/vdsm/netlink.py
File lib/vdsm/netlink.py:
Line 61:
Dan Kenigsberg has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 5: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/23248/5/lib/vdsm/ipwrapper.py
File
Nir Soffer has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 7:
(1 comment)
Only started to look at it, will continue later.
Francesco Romani has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 1:
Haven't still looked at the code in detail, but looks like the dependency on
libnl isn't declared.
Antoni Segura Puimedon has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 1: Verified-1
(7 comments)
For some reason the code works perfectly when running from the
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6726/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6756/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6766/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 4: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6772/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 5: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6774/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 5: -Verified
Build Successful
Antoni Segura Puimedon has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.ovirt.org/23248
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/23248/5/lib/vdsm/ipwrapper.py
File lib/vdsm/ipwrapper.py:
Antoni Segura Puimedon has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/23248/5/lib/vdsm/netlink.py
File
Antoni Segura Puimedon has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/23248/5/lib/vdsm/ipwrapper.py
File
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: ipwrapper: switch link polling to netlink
..
ipwrapper: switch link polling to netlink
getting the links from iproute2 implied creating a process each
Dan Kenigsberg has posted comments on this change.
Change subject: ipwrapper: switch link polling to netlink
..
Patch Set 1: Code-Review-1
(9 comments)
Few comments and questions.
34 matches
Mail list logo
