Change in vdsm[master]: json-rpc: fix the Host.getVMList return value

2015-03-15 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: json-rpc: fix the Host.getVMList return value .. Patch Set 1: Code-Review+1 Please take a look at comment of Host_getVMList_Call method: """ This cal

Change in vdsm[master]: json-rpc: fix the Host.getVMList return value

2015-03-15 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: json-rpc: fix the Host.getVMList return value .. Patch Set 1: This is what I was afraid of. The engine expects different type and we see marshalling issue. P

Change in vdsm[master]: json-rpc: fix the Host.getVMList return value

2015-03-15 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: json-rpc: fix the Host.getVMList return value .. Patch Set 1: * Update tracker::#1196327::OK * Check Bug-Url::OK * Check Public Bug::#1196327::OK, public

Change in vdsm[master]: json-rpc: fix the Host.getVMList return value

2015-03-15 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: json-rpc: fix the Host.getVMList return value .. Patch Set 2: * Update tracker::#1196327::OK * Set MODIFIED::bug 1196327#1196327IGNORE, not all re

Change in vdsm[master]: json-rpc: fix the Host.getVMList return value

2015-03-03 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: json-rpc: fix the Host.getVMList return value .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/701

Change in vdsm[master]: json-rpc: fix the Host.getVMList return value

2015-03-03 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: json-rpc: fix the Host.getVMList return value .. json-rpc: fix the Host.getVMList return value Host.getVMList() should return either VmDefinition or Vm

Change in vdsm[master]: json-rpc: fix the Host.getVMList return value

2015-03-03 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: json-rpc: fix the Host.getVMList return value .. Patch Set 1: Code-Review+2 Barak Azulay just told me that with this patch applied, old (e.g. 3.5.0) Engine suf

Change in vdsm[master]: json-rpc: fix the Host.getVMList return value

2015-03-03 Thread fromani
Francesco Romani has posted comments on this change. Change subject: json-rpc: fix the Host.getVMList return value .. Patch Set 1: -Verified -- To view, visit https://gerrit.ovirt.org/38172 To unsubscribe, visit https://gerrit

Change in vdsm[master]: json-rpc: fix the Host.getVMList return value

2015-03-03 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: json-rpc: fix the Host.getVMList return value .. Patch Set 1: Verified+1 please note that engine fix for this is posted: https://gerrit.ovirt.org/#/c/38271 i've

Change in vdsm[master]: json-rpc: fix the Host.getVMList return value

2015-02-26 Thread fromani
Francesco Romani has posted comments on this change. Change subject: json-rpc: fix the Host.getVMList return value .. Patch Set 1: Verified-1 Engine has demarshalling issues with this patch. See previous two comments (from me

Change in vdsm[master]: json-rpc: fix the Host.getVMList return value

2015-02-26 Thread fromani
Francesco Romani has posted comments on this change. Change subject: json-rpc: fix the Host.getVMList return value .. Patch Set 1: with this patch applied, I DO NOT see anymore the storm of Vm.getStats() after each Host.getVmL

Change in vdsm[master]: json-rpc: fix the Host.getVMList return value

2015-02-26 Thread fromani
Francesco Romani has posted comments on this change. Change subject: json-rpc: fix the Host.getVMList return value .. Patch Set 1: My claim[1] is that comment, as well as the one removed with this patch, was wrong and mislead

Change in vdsm[master]: json-rpc: fix the Host.getVMList return value

2015-02-26 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: json-rpc: fix the Host.getVMList return value .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38172 To unsubscribe, visit https://gerrit

Change in vdsm[master]: json-rpc: fix the Host.getVMList return value

2015-02-25 Thread fromani
Francesco Romani has posted comments on this change. Change subject: json-rpc: fix the Host.getVMList return value .. Patch Set 1: did initial rough verification and this seems to fix the issue. Doing proper verification. --

Change in vdsm[master]: json-rpc: fix the Host.getVMList return value

2015-02-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: json-rpc: fix the Host.getVMList return value .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16074/ : SUCCESS htt

Change in vdsm[master]: json-rpc: fix the Host.getVMList return value

2015-02-25 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: json-rpc: fix the Host.getVMList return value .. json-rpc: fix the Host.getVMList return value Host.getVMList() should return either VmDefinition or VmShortS