oVirt Jenkins CI Server has posted comments on this change.
Change subject: open: Change file() to open()
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4081/ : SUCCESS
Yeela Kaplan has posted comments on this change.
Change subject: open: Change file() to open()
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.ovirt.org/26776
To unsubscribe, visit http://gerrit.ovirt.org/settings
Yeela Kaplan has posted comments on this change.
Change subject: open: Change file() to open()
..
Patch Set 6:
verified by:
ran a vm with a disk on iscsi storage on one host and then migrated the vm to
another host and it
Dan Kenigsberg has submitted this change and it was merged.
Change subject: open: Change file() to open()
..
open: Change file() to open()
Update file calls to open calls due to file's deprecation.
This patch does not convert
Dan Kenigsberg has posted comments on this change.
Change subject: open: Change file() to open()
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26776
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: open: Change file() to open()
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12788/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: open: Change file() to open()
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26776
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: open: Change file() to open()
..
Patch Set 5:
verification still missing. will be later on.. won't be in 3.5 for now
--
To view, visit
Petr Horáček has posted comments on this change.
Change subject: open: Change file() to open()
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26776
To unsubscribe, visit
Yeela Kaplan has posted comments on this change.
Change subject: open: Change file() to open()
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26776
To unsubscribe, visit
Saggi Mizrahi has posted comments on this change.
Change subject: open: Change file() to open()
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26776
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: open: Change file() to open()
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9569/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: open: Change file() to open()
..
Patch Set 5: Code-Review+1
I would split the libvirtconnection and netinfo changes into a separate patch
about closing open files
Antoni Segura Puimedon has posted comments on this change.
Change subject: open: Change file() to open()
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26776
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: open: Change file() to open()
..
Patch Set 4: Code-Review-1
(1 comment)
The patch contain unrelated and wrong change. This is not a replacement of
file with
Dima Kuznetsov has posted comments on this change.
Change subject: open: Change file() to open()
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/26776/4/lib/vdsm/libvirtconnection.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: open: Change file() to open()
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9406/ : SUCCESS
Dima Kuznetsov has posted comments on this change.
Change subject: open: Change file() to open()
..
Patch Set 3: Verified+1
Ran nosetest and all the tests ran ok, open to suggestions about additional
tests.
--
To view,
Dan Kenigsberg has posted comments on this change.
Change subject: open: Change file() to open()
..
Patch Set 3:
Prudent verification should make sure the relevant code passes are used.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: open: Change file() to open()
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/26776/2//COMMIT_MSG
Commit Message:
Line 3: AuthorDate:
Antoni Segura Puimedon has posted comments on this change.
Change subject: open: Change file() to open()
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26776
To unsubscribe, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: open: Change file() to open()
..
Patch Set 3:
The +1 is for those that are here. I don't mind getting the rest in another
patch.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: open: Change file() to open()
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1302/
: There
Dan Kenigsberg has posted comments on this change.
Change subject: open: Change file() to open()
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26776
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: open: Change file() to open()
..
Patch Set 3:
Next round please include vdsm_reg dir, like deployUtil and vdsm-reg-setup.
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: open: Change file() to open()
..
Patch Set 3: Code-Review+1
please verify.
--
To view, visit http://gerrit.ovirt.org/26776
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: open: Change file() to open()
..
Patch Set 2:
Changed file() shadowing, fixed file() in a few more places.
--
To view, visit http://gerrit.ovirt.org/26776
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: open: Change file() to open()
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1296/
: There
Dan Kenigsberg has posted comments on this change.
Change subject: open: Change file() to open()
..
Patch Set 1: Code-Review-1
Sorry Toni and Dima, shadowing file is too brutal for me. Please find a more
original variable
Dima Kuznetsov has uploaded a new change for review.
Change subject: open: Change file() to open()
..
open: Change file() to open()
Update file calls to open calls due to file's deprecation.
Change-Id:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: open: Change file() to open()
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8063/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: open: Change file() to open()
..
Patch Set 1: Code-Review+1
Thanks for this. It was long overdue that we'd get rid of the 'file' calling.
The only
32 matches
Mail list logo
