Nir Soffer has submitted this change and it was merged.
Change subject: rpc: Log important info from VM stats
..
rpc: Log important info from VM stats
Currently, we don't log results of getAllVmStats API calls. This is not
to
gerrit-hooks has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 29:
* #1339291::Update tracker: OK
* Set MODIFIED::bug 1339291#1339291IGNORE, not oVirt classification
Nir Soffer has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 28: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/58465
To unsubscribe, visit https://gerrit.ovirt.or
Milan Zamazal has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 28: Verified+1
Just rebased.
Verified at the end of the patch series that everything works as expected after
gerrit-hooks has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 28:
* #1339291::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1339291::OK, public bug
* Check Pro
Nir Soffer has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 27:
Milan, can you rebase?
--
To view, visit https://gerrit.ovirt.org/58465
To unsubscribe, visit https://gerri
Piotr Kliczewski has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 27: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/58465
To unsubscribe, visit https://gerrit.ov
Nir Soffer has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 27: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/58465
To unsubscribe, visit https://gerrit.ovirt.or
Milan Zamazal has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 27: Verified+1
Verified that all VM stats are logged periodically as expected.
--
To view, visit https://ger
Milan Zamazal has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 27:
(3 comments)
https://gerrit.ovirt.org/#/c/58465/26/tests/Makefile.am
File tests/Makefile.am:
PS26, Line
gerrit-hooks has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 27:
* #1339291::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1339291::OK, public bug
* Check Pro
Piotr Kliczewski has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 26:
(1 comment)
https://gerrit.ovirt.org/#/c/58465/26/tests/Makefile.am
File tests/Makefile.am:
PS26, Lin
Nir Soffer has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 26:
(2 comments)
https://gerrit.ovirt.org/#/c/58465/26/tests/logutils_test.py
File tests/logutils_test.py:
Line
Milan Zamazal has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 26:
Logging moved from clienIF.py to API.py. We are going to find a better place
in future, master only, pat
gerrit-hooks has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 26:
* #1339291::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1339291::OK, public bug
* Check Pro
gerrit-hooks has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 25:
* #1339291::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1339291::OK, public bug
* Check Pro
Piotr Kliczewski has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 24: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/58465
To unsubscribe, visit https://gerrit.ov
Francesco Romani has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 24: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/58465
To unsubscribe, visit https://gerrit.ov
Francesco Romani has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 24:
please rebase on top of master to get rid of jenkins error (which was real, but
unrelated)
--
To vie
gerrit-hooks has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 24:
* #1339291::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1339291::OK, public bug
* Check Pro
Nir Soffer has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 23: Code-Review+1
Waiting for more acks.
--
To view, visit https://gerrit.ovirt.org/58465
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 20:
(1 comment)
https://gerrit.ovirt.org/#/c/58465/20/lib/vdsm/throttledlog.py
File lib/vdsm/throttledlog.py:
L
gerrit-hooks has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 23:
* #1339291::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1339291::OK, public bug
* Check Pro
Milan Zamazal has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 22:
(4 comments)
> Please separate the throttledlog and its test to another patch.
Done.
https://gerrit.ovi
gerrit-hooks has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 22:
* #1339291::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1339291::OK, public bug
* Check Pro
gerrit-hooks has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 21:
* #1339291::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1339291::OK, public bug
* Check Pro
Nir Soffer has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 20:
(2 comments)
https://gerrit.ovirt.org/#/c/58465/20/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 442
Line 44
Nir Soffer has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 20:
(4 comments)
Please separate the throttledlog and its test to another patch. This is trivial
backport that
Nir Soffer has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 19:
(1 comment)
https://gerrit.ovirt.org/#/c/58465/19/lib/vdsm/throttledlog.py
File lib/vdsm/throttledlog.py:
L
Milan Zamazal has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 19:
(2 comments)
https://gerrit.ovirt.org/#/c/58465/19/lib/vdsm/throttledlog.py
File lib/vdsm/throttledlog.py
Nir Soffer has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 19:
(3 comments)
https://gerrit.ovirt.org/#/c/58465/19/lib/vdsm/throttledlog.py
File lib/vdsm/throttledlog.py:
Milan Zamazal has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 19:
(2 comments)
https://gerrit.ovirt.org/#/c/58465/19/lib/vdsm/throttledlog.py
File lib/vdsm/throttledlog.py
gerrit-hooks has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 20:
* #1339291::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1339291::OK, public bug
* Check Pro
Nir Soffer has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 19:
(2 comments)
https://gerrit.ovirt.org/#/c/58465/19/lib/vdsm/throttledlog.py
File lib/vdsm/throttledlog.py:
Nir Soffer has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 19:
(1 comment)
Partial review, will continue next week.
https://gerrit.ovirt.org/#/c/58465/19/tests/throttledl
Milan Zamazal has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 19:
Added missing absolute_import to throttledlog.py.
--
To view, visit https://gerrit.ovirt.org/58465
To un
gerrit-hooks has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 19:
* #1339291::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1339291::OK, public bug
* Check Pro
Milan Zamazal has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 1:
Thank you, Nir, for the comments. I considered them when updating the
corresponding patch in rpc-result-lo
Milan Zamazal has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 18:
Based on several discussions and Nir's comments in the experimental draft patch
referenced above, I rewor
Nir Soffer has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/59339/1/lib/vdsm/rpc/bindingxmlrpc.py
File lib/vdsm/rpc/bindingxmlr
gerrit-hooks has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 18:
* #1339291::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1339291::OK, public bug
* Check Pro
Milan Zamazal has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/59339/1/lib/vdsm/rpc/bindingxmlrpc.py
File lib/vdsm/rpc/bindingxm
Nir Soffer has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 1:
(11 comments)
https://gerrit.ovirt.org/#/c/59339/1/lib/vdsm/logUtils.py
File lib/vdsm/logUtils.py:
Line 221:
Milan Zamazal has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 17:
Based on Nir's suggestion and the recent discussion elsewhere, I drafted
https://gerrit.ovirt.org/59339.
gerrit-hooks has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 18:
* #1339291::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1339291::OK, public bug
* Check Pro
Michal Skrivanek has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 17:
(1 comment)
https://gerrit.ovirt.org/#/c/58465/17/vdsm/API.py
File vdsm/API.py:
Line 1344: ""
Piotr Kliczewski has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 17:
(1 comment)
https://gerrit.ovirt.org/#/c/58465/17/vdsm/API.py
File vdsm/API.py:
Line 1344: ""
Michal Skrivanek has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 17:
(1 comment)
https://gerrit.ovirt.org/#/c/58465/17/vdsm/API.py
File vdsm/API.py:
Line 1344: ""
Nir Soffer has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 17:
(1 comment)
https://gerrit.ovirt.org/#/c/58465/17/vdsm/API.py
File vdsm/API.py:
Line 1344: """
Line
Piotr Kliczewski has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 17:
(1 comment)
https://gerrit.ovirt.org/#/c/58465/17/lib/vdsm/logUtils.py
File lib/vdsm/logUtils.py:
PS1
Piotr Kliczewski has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 17: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/58465/17/vdsm/API.py
File vdsm/API.py:
Line 13
Nir Soffer has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 14:
(2 comments)
https://gerrit.ovirt.org/#/c/58465/14/vdsm/API.py
File vdsm/API.py:
Line 1200:
Line 1201: cla
Milan Zamazal has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 17:
(10 comments)
https://gerrit.ovirt.org/#/c/58465/14/lib/vdsm/logUtils.py
File lib/vdsm/logUtils.py:
Line
gerrit-hooks has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 17:
* #1339291::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1339291::OK, public bug
* Check Pro
Francesco Romani has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 16: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/58465
To unsubscribe, visit https://gerrit.ov
Milan Zamazal has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 16:
Just rebase for now, I'll reviewers' comments later.
--
To view, visit https://gerrit.ovirt.org/58465
To
gerrit-hooks has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 16:
* #1339291::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1339291::OK, public bug
* Check Pro
58 matches
Mail list logo
