gerrit-hooks has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 10:
* #1271771::Update tracker: OK
* Set MODIFIED::bug 1271771#1271771OK
--
To view, visit https://
Nir Soffer has submitted this change and it was merged.
Change subject: sp: update domain links on state change
..
sp: update domain links on state change
In some situations (e.g. after a reconstructMaster command) the domain
l
Allon Mureinik has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 9:
"This patch", not "This bug", of course.
--
To view, visit https://gerrit.ovirt.org/51393
To unsubscri
Allon Mureinik has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 9:
Nir - this bug has been code reviewed, passed CI tests and was verified.
Can we progress and merge it pl
gerrit-hooks has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 9:
* #1271771::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1271771::OK, public bug
* Check Pr
Idan Shaby has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 8: Verified+1
Verified by performing the next steps on engine built on master and on
ovirt-engine-3.5 (with 3.
Nir Soffer has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51393
To unsubscribe, visit https://gerrit.ovirt.o
gerrit-hooks has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 8:
* #1271771::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1271771::OK, public bug
* Check Pr
Idan Shaby has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 7:
(4 comments)
https://gerrit.ovirt.org/#/c/51393/7//COMMIT_MSG
Commit Message:
Line 34: we won't be liste
Nir Soffer has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/51393/7/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line 145:
Liron Aravot has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/51393/7/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line 145:
Nir Soffer has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/51393/7/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line 149:
Nir Soffer has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/51393/7/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line 145:
Liron Aravot has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 7: Code-Review+1
(2 comments)
https://gerrit.ovirt.org/#/c/51393/7/vdsm/storage/sp.py
File vdsm/storage/sp.p
Nir Soffer has abandoned this change.
Change subject: sp: update domain links on state change
..
Abandoned
Replaced by https://gerrit.ovirt.org/51393
--
To view, visit https://gerrit.ovirt.org/27334
To unsubscribe, visit http
gerrit-hooks has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 4:
* #1271771::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/27334
To unsubscribe, visit ht
Nir Soffer has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 7:
Liron, can you review this again?
--
To view, visit https://gerrit.ovirt.org/51393
To unsubscribe, visit h
Adam Litke has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 7: Code-Review+1
Looks good to me but I'd prefer Nir to +2 it.
--
To view, visit https://gerrit.ovirt.org/513
Nir Soffer has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 7: Code-Review+1
(2 comments)
Looks good, the commit message needs minor cleanup.
Waiting for Adam and Liron
Idan Shaby has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/51393/6/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line 144:
L
gerrit-hooks has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 7:
* #1271771::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1271771::OK, public bug
* Check Pr
Nir Soffer has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/27334/4/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line 140:
Liron Aravot has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/27334/4/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line 144: (
Idan Shaby has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 4:
Adam, here's how I verified this patch:
1. Activated the host (two scenarios - when it became the SPM and w
Adam Litke has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 4:
This looks correct to me. I think we should go ahead and merge it and try it
out in the real world.
Idan,
Idan Shaby has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 3: -Verified
--
To view, visit https://gerrit.ovirt.org/27334
To unsubscribe, visit https://gerrit.ovirt.org/s
Idan Shaby has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 3:
(2 comments)
Please also review https://gerrit.ovirt.org/#/c/51393/ .
https://gerrit.ovirt.org/#/c/27334/3
Nir Soffer has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 3: Code-Review+1
Waiting for the next patch, addressing the issues in Federico patch.
--
To view, visit https
Nir Soffer has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 3: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/27334/3/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Idan Shaby has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 3:
Verification scenario which was tested:
1. Add a host with two storage domains - iscsi domain A and file do
Jenkins CI has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 3: Continuous-Integration-1
Propagate review hook: Continuous Integration value inherited from patch 2
--
To
Idan Shaby has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/27334
To unsubscribe, visit https://gerrit.ovirt.org/
gerrit-hooks has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 3:
* #1271771::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1271771::OK, public bug
* Check Pr
gerrit-hooks has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 2:
* #1091030::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1091030::OK, public bug
* Check Pr
Nir Soffer has restored this change.
Change subject: sp: update domain links on state change
..
Restored
We still need this, it is better then the current long-term no-solution in
master.
--
To view, visit https://gerrit.ovi
Federico Simoncelli has abandoned this change.
Change subject: sp: update domain links on state change
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/27334
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit
Dan Kenigsberg has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 1: Code-Review-1
As described in http://gerrit.ovirt.org/27466, we agreed to solve this on the
Engine side
Nir Soffer has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 1: Code-Review+1
Seems that there is no other way to do this.
--
To view, visit http://gerrit.ovirt.org/27334
Allon Mureinik has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 1: Code-Review+1
Ping?
--
To view, visit http://gerrit.ovirt.org/27334
To unsubscribe, visit http://gerri
Allon Mureinik has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 1:
Nir, without being able to access the domain, you cannot produce it. Hence, you
have no way to know if
Nir Soffer has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 1:
It looks ok, but why do we need the domain to be reachable to create symbolic
links? there is no requiremen
Federico Simoncelli has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/27334
To unsubscribe, visit http://gerrit.ovi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8512/ : SUCCESS
http:/
Federico Simoncelli has uploaded a new change for review.
Change subject: sp: update domain links on state change
..
sp: update domain links on state change
In some situations (e.g. after a reconstructMaster command) the
domain
44 matches
Mail list logo
