gerrit-hooks has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Adam Litke has submitted this change and it was merged.
Change subject: storage: Introduce guarded utilities
..
storage: Introduce guarded utilities
Throughout the storage code we have implicit locking rules which we
follow in
Adam Litke has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 15: Verified+1
Verified by unit tests.
--
To view, visit https://gerrit.ovirt.org/61435
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 15: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61435
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 13:
(2 comments)
Splitting the patches and will resend.
Nir Soffer has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 13:
This became too big - can we separate the generic infrastructure (gourded.py)
from the storage
Nir Soffer has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 13:
Rebase on master should solve the network test failure:
test_local_auto_with_dynamic_address_from_ra
Nir Soffer has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 13: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/61435/13/tests/storage_guarded_test.py
File
gerrit-hooks has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 11:
(18 comments)
https://gerrit.ovirt.org/#/c/61435/11/tests/Makefile.am
File tests/Makefile.am:
Line 222:
Adam Litke has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 11:
(12 comments)
https://gerrit.ovirt.org/#/c/61435/11//COMMIT_MSG
Commit Message:
Line 29: mode (in that
gerrit-hooks has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 11: Code-Review-1
(32 comments)
Separating the storage related code, simplifying the interface and tests, this
Adam Litke has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 11: Verified+1
Verified with unit tests and as part of the new copy_data flow.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 9:
(5 comments)
https://gerrit.ovirt.org/#/c/61435/9/lib/vdsm/storage/guarded.py
File
gerrit-hooks has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/61435/9/lib/vdsm/storage/guarded.py
File
Nir Soffer has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 9:
(4 comments)
https://gerrit.ovirt.org/#/c/61435/9/lib/vdsm/storage/guarded.py
File
Nir Soffer has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 9: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/61435/9/lib/vdsm/storage/guarded.py
File
Nir Soffer has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/61435/6/lib/vdsm/storage/guarded.py
File
Adam Litke has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/61435/6/lib/vdsm/storage/guarded.py
File
Adam Litke has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/61435/7/tests/storage_guarded_test.py
File
Nir Soffer has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 6:
(3 comments)
https://gerrit.ovirt.org/#/c/61435/6/lib/vdsm/storage/guarded.py
File
Adam Litke has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 6:
(4 comments)
https://gerrit.ovirt.org/#/c/61435/6/tests/storagetestlib.py
File tests/storagetestlib.py:
Line
Adam Litke has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/61435/6/lib/vdsm/storage/guarded.py
File
Adam Litke has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 6:
(7 comments)
https://gerrit.ovirt.org/#/c/61435/6/lib/vdsm/storage/guarded.py
File
Adam Litke has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/61435/1/lib/vdsm/storage/guarded.py
File
gerrit-hooks has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/61435/7/tests/storage_guarded_test.py
File
gerrit-hooks has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 6: Code-Review-1
(6 comments)
The actual code looks very nice, but __eq__ is completely wrong.
Nir Soffer has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 6:
(4 comments)
Generally looks too complicated, specially the test code and infrastructure
looks much more
gerrit-hooks has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Adam Litke has abandoned this change.
Change subject: storage: Introduce guarded utilities
..
Abandoned
Temporary
--
To view, visit https://gerrit.ovirt.org/61694
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/61694
To
gerrit-hooks has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Adam Litke has uploaded a new change for review.
Change subject: storage: Introduce guarded utilities
..
storage: Introduce guarded utilities
Change-Id: I9e85ecc8e7e332674183a53d67355f0a1692af0e
Signed-off-by: Adam Litke
gerrit-hooks has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Adam Litke has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 2:
(10 comments)
https://gerrit.ovirt.org/#/c/61435/2//COMMIT_MSG
Commit Message:
Line 23:
Line 24: The
gerrit-hooks has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 2:
(10 comments)
https://gerrit.ovirt.org/#/c/61435/2//COMMIT_MSG
Commit Message:
Line 23:
Line 24: The
gerrit-hooks has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Adam Litke has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/61435/1/lib/vdsm/storage/guarded.py
File
Adam Litke has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 1:
(7 comments)
https://gerrit.ovirt.org/#/c/61435/1/lib/vdsm/storage/guarded.py
File
Nir Soffer has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 1:
(8 comments)
Nice! I'll continue tomorrow.
https://gerrit.ovirt.org/#/c/61435/1/lib/vdsm/storage/guarded.py
Adam Litke has uploaded a new change for review.
Change subject: storage: Introduce guarded utilities
..
storage: Introduce guarded utilities
Throughout the storage code we have implicit locking rules which we follow in
order
gerrit-hooks has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
52 matches
Mail list logo
