Lei Li has posted comments on this change.
Change subject: tests: add testcases for configNetwork
..
Patch Set 4:
Sorry for my negligence... just test it by running run_tests.sh. I should be
more careful, and it will not happe
Dan Kenigsberg has posted comments on this change.
Change subject: tests: add testcases for configNetwork
..
Patch Set 4:
-1 to the verifier (me)
-1 to the maintainer (me) for not waiting for someone else to tick V+1.
--
To v
Zhou Zheng Sheng has posted comments on this change.
Change subject: tests: add testcases for configNetwork
..
Patch Set 4: (1 inline comment)
Just update my pyflakes and it reports error on this file, and this causes
"make ch
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: add testcases for configNetwork
..
tests: add testcases for configNetwork
Add testcases for functions nicSort() and
isBridgeNameValid() in confi
Dan Kenigsberg has posted comments on this change.
Change subject: tests: add testcases for configNetwork
..
Patch Set 3: Verified; Looks good to me, approved
Thanks, I've verified your patch by myself.
--
To view, visit http:
Igor Lvovsky has posted comments on this change.
Change subject: tests: add testcases for configNetwork
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5351
To unsubscri
Dan Kenigsberg has posted comments on this change.
Change subject: tests: add testcases for configNetwork
..
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
.
