oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5771/ :
Antoni Segura Puimedon has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31741
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31741
To unsubscribe, visit
mooli tayer has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31741
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/31741
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tool: Make configurators more Pythonic
..
tool: Make configurators more Pythonic
The configurations used to have Java like getters, which make the
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5771/ :
Francesco Romani has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 7: Code-Review+1
nice improvement
--
To view, visit http://gerrit.ovirt.org/31741
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/31741/5/lib/vdsm/tool/configurators/__init__.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11177/ :
Nir Soffer has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 7: Verified+1
Rebase after significant changes in master and address Antoni comment.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11179/ :
Nir Soffer has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 5: Verified+1
Rebase - no code change except one indentation fix required to work with old
pep8 (1.4.5) on
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11156/ :
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31741
To unsubscribe, visit
mooli tayer has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31741
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/31741/1/lib/vdsm/tool/configurators/libvirt.py
File
Nir Soffer has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 2:
Verfied on Fedora 19, need to test also on EL 6.
--
To view, visit http://gerrit.ovirt.org/31741
To
Nir Soffer has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/31741/1/lib/vdsm/tool/configurators/libvirt.py
File
Nir Soffer has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 3:
Address Dima comments.
--
To view, visit http://gerrit.ovirt.org/31741
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11045/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11049/ : FAILURE
Alon Bar-Lev has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 3: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/31741/3/lib/vdsm/tool/configurators/__init__.py
Nir Soffer has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/31741/3/lib/vdsm/tool/configurators/__init__.py
File
Alon Bar-Lev has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/31741/3/lib/vdsm/tool/configurators/__init__.py
File
Nir Soffer has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/31741/3/lib/vdsm/tool/configurators/__init__.py
File
Nir Soffer has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 4:
Rebase, address Alon comments.
Using properties, we loose the option to use the configuration class name
Alon Bar-Lev has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31741
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 4: Verified+1
Verified by running the tests and manually.
--
To view, visit http://gerrit.ovirt.org/31741
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 4: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11054/ : FAILURE
Nir Soffer has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 4:
jenkins pep8 is too old, ignore this error.
--
To view, visit http://gerrit.ovirt.org/31741
To
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 4: Code-Review-1
its not even pep8 issue, its SyntaxError. use {'a': 'b'}.
but i like those changes.
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 4: Code-Review+1
(1 comment)
re trigger the jenkins job please
Nir Soffer has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/31741/4/tests/toolTests.py
File tests/toolTests.py:
Line 77:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11054/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11054/ : FAILURE
Nir Soffer has uploaded a new change for review.
Change subject: tool: Make configurators more Pythonic
..
tool: Make configurators more Pythonic
The configurations used to have Java like getters, which make the code
more
Nir Soffer has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 1:
Tests pass, but since test coverage is low, this needs manual verification.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11034/ : FAILURE
40 matches
Mail list logo