Change in vdsm[master]: tool: Make configurators more Pythonic

2014-09-02 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5771/ :

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-09-01 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/31741 To unsubscribe, visit

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-09-01 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/31741 To unsubscribe, visit

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-09-01 Thread mtayer
mooli tayer has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/31741 To unsubscribe, visit

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-09-01 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/31741 To unsubscribe, visit

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-09-01 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: tool: Make configurators more Pythonic .. tool: Make configurators more Pythonic The configurations used to have Java like getters, which make the

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-09-01 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5771/ :

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-29 Thread fromani
Francesco Romani has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 7: Code-Review+1 nice improvement -- To view, visit http://gerrit.ovirt.org/31741 To unsubscribe, visit

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/31741/5/lib/vdsm/tool/configurators/__init__.py File

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11177/ :

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 7: Verified+1 Rebase after significant changes in master and address Antoni comment. -- To view, visit

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11179/ :

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-26 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 5: Verified+1 Rebase - no code change except one indentation fix required to work with old pep8 (1.4.5) on

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11156/ :

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-26 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/31741 To unsubscribe, visit

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-24 Thread mtayer
mooli tayer has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/31741 To unsubscribe, visit

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-21 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/31741/1/lib/vdsm/tool/configurators/libvirt.py File

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 2: Verfied on Fedora 19, need to test also on EL 6. -- To view, visit http://gerrit.ovirt.org/31741 To

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/31741/1/lib/vdsm/tool/configurators/libvirt.py File

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 3: Address Dima comments. -- To view, visit http://gerrit.ovirt.org/31741 To unsubscribe, visit

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-21 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11045/ : FAILURE

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-21 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11049/ : FAILURE

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-21 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 3: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/31741/3/lib/vdsm/tool/configurators/__init__.py

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/31741/3/lib/vdsm/tool/configurators/__init__.py File

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-21 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/31741/3/lib/vdsm/tool/configurators/__init__.py File

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/31741/3/lib/vdsm/tool/configurators/__init__.py File

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 4: Rebase, address Alon comments. Using properties, we loose the option to use the configuration class name

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-21 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/31741 To unsubscribe, visit

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 4: Verified+1 Verified by running the tests and manually. -- To view, visit http://gerrit.ovirt.org/31741 To

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-21 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 4: Code-Review-1 Verified-1 Build Failed

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-21 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11054/ : FAILURE

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 4: jenkins pep8 is too old, ignore this error. -- To view, visit http://gerrit.ovirt.org/31741 To

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-21 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 4: Code-Review-1 its not even pep8 issue, its SyntaxError. use {'a': 'b'}. but i like those changes.

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-21 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 4: Code-Review+1 (1 comment) re trigger the jenkins job please

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/31741/4/tests/toolTests.py File tests/toolTests.py: Line 77:

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-21 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11054/ : FAILURE

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-21 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11054/ : FAILURE

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-20 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: tool: Make configurators more Pythonic .. tool: Make configurators more Pythonic The configurations used to have Java like getters, which make the code more

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-20 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 1: Tests pass, but since test coverage is low, this needs manual verification. -- To view, visit

Change in vdsm[master]: tool: Make configurators more Pythonic

2014-08-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Make configurators more Pythonic .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11034/ : FAILURE