gerrit-hooks has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 13:
* update_tracker: OK
* Set MODIFIED::bug 1283999#1283999IGNORE, not oVirt classification but
--
To view, v
Dan Kenigsberg has submitted this change and it was merged.
Change subject: utils: add weakmethod helper
..
utils: add weakmethod helper
The libvirtconnection module adds wrapping around virDomain
objects, to detect and react l
Martin Polednik has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/51865/12/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 908:
Line 909
Martin Polednik has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 12: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51865
To unsubscribe, visit https://gerrit.ovirt.org/se
Francesco Romani has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 12: Verified+1
stripped out the tests in 52408 because of unrelated failures/they are not
trivial to get right in t
Nir Soffer has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51865
To unsubscribe, visit https://gerrit.ovirt.org/setting
gerrit-hooks has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 12:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1283999::ERROR, private bug
* Check Public Bug::WARN,
Francesco Romani has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 11:
Nir, sure thing.
Looks like my test caught the ResourceRef leak you fixed:
00:17:03.041
=
Nir Soffer has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 11:
Francesco, can you chec why jenkins is unhappy?
--
To view, visit https://gerrit.ovirt.org/51865
To unsubscribe, vis
Piotr Kliczewski has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 11: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51865
To unsubscribe, visit https://gerrit.ovirt.org/s
Nir Soffer has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51865
To unsubscribe, visit https://gerrit.ovirt.org/setting
Michal Skrivanek has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 11: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51865
To unsubscribe, visit https://gerrit.ovirt.org/s
Francesco Romani has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 11: Verified+1
v11 polishes the tests a bit more, thanks to Nir's suggestions.
There are no changes to production co
gerrit-hooks has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 11:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1283999::ERROR, private bug
* Check Public Bug::WARN,
Francesco Romani has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 10:
(4 comments)
https://gerrit.ovirt.org/#/c/51865/10/tests/utilsTests.py
File tests/utilsTests.py:
Line 1034:
Nir Soffer has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 10:
(4 comments)
https://gerrit.ovirt.org/#/c/51865/10/tests/utilsTests.py
File tests/utilsTests.py:
Line 1034:
Nir Soffer has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/51865/9/tests/utilsTests.py
File tests/utilsTests.py:
Line 1037:
Francesco Romani has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 10: Verified+1
tested together: 51685 51630
reproduced the virdomain leak, which is now gone using these patches.
-
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51865
To unsubscribe, visit https://gerrit.ovirt.org/set
Piotr Kliczewski has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51865
To unsubscribe, visit https://gerrit.ovirt.org/s
Francesco Romani has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/51865/9/tests/utilsTests.py
File tests/utilsTests.py:
Line 1037:
Dan Kenigsberg has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51865
To unsubscribe, visit https://gerrit.ovirt.org/set
gerrit-hooks has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 10:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1283999::ERROR, private bug
* Check Public Bug::WARN,
Nir Soffer has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 9: Code-Review+1
(2 comments)
Looks good, can be little simpler, see the comments in the tests.
https://gerrit.ovirt.org
Francesco Romani has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 9:
since v8 only tests are changed, to make them (hopefully) clearer and safer, as
per last comments. Will re-verif
gerrit-hooks has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 9:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1283999::ERROR, private bug
* Check Public Bug::WARN, n
Nir Soffer has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 8: Verified+1
Tested together with https://gerrit.ovirt.org/51708.
--
To view, visit https://gerrit.ovirt.org/51865
To u
Nir Soffer has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/51865/8/tests/utilsTests.py
File tests/utilsTests.py:
Line 1043:
Francesco Romani has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 8:
(2 comments)
https://gerrit.ovirt.org/#/c/51865/8/tests/utilsTests.py
File tests/utilsTests.py:
Line 1004:
Lin
Nir Soffer has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 8:
(2 comments)
https://gerrit.ovirt.org/#/c/51865/8/tests/utilsTests.py
File tests/utilsTests.py:
Line 1004:
Line 1005
gerrit-hooks has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 8:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1283999::ERROR, private bug
* Check Public Bug::WARN, n
Francesco Romani has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 7:
(5 comments)
https://gerrit.ovirt.org/#/c/51865/7/tests/utilsTests.py
File tests/utilsTests.py:
Line 993:
Francesco Romani has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/51865/4/tests/utilsTests.py
File tests/utilsTests.py:
Line 1009: @con
Nir Soffer has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 7:
(5 comments)
https://gerrit.ovirt.org/#/c/51865/7/tests/utilsTests.py
File tests/utilsTests.py:
Line 993:
Nir Soffer has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/51865/4/tests/utilsTests.py
File tests/utilsTests.py:
Line 1009: @contextli
gerrit-hooks has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 7:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1283999::ERROR, private bug
* Check Public Bug::WARN, n
gerrit-hooks has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 6:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1283999::ERROR, private bug
* Check Public Bug::WARN, n
Francesco Romani has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/51865/4//COMMIT_MSG
Commit Message:
Line 14: cycular
> ... circular ..
Milan Zamazal has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/51865/4//COMMIT_MSG
Commit Message:
Line 13: an
... a ...
Line 14: cyc
Francesco Romani has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 5: Code-Review-1
(2 comments)
missing docstring, will add in the next upload.
https://gerrit.ovirt.org/#/c/51865/5
gerrit-hooks has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 5:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1283999::ERROR, private bug
* Check Public Bug::WARN, n
Francesco Romani has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 4:
(10 comments)
https://gerrit.ovirt.org/#/c/51865/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 905: func
Vinzenz Feenstra has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/51865/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 905: func =
Nir Soffer has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 4:
(9 comments)
https://gerrit.ovirt.org/#/c/51865/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 905: func = meth
Vinzenz Feenstra has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/51865/4/tests/utilsTests.py
File tests/utilsTests.py:
Line 1057:
Line
Vinzenz Feenstra has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 4: Code-Review-1
(1 comment)
-1 for visibility
https://gerrit.ovirt.org/#/c/51865/4/tests/utilsTests.py
File tests
gerrit-hooks has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 4:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1283999::ERROR, private bug
* Check Public Bug::WARN, n
gerrit-hooks has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 3:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1283999::ERROR, private bug
* Check Public Bug::WARN, n
gerrit-hooks has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1283999::ERROR, private bug
* Check Public Bug::WARN, n
Francesco Romani has uploaded a new change for review.
Change subject: utils: add weakmethod helper
..
utils: add weakmethod helper
TODO: write proper commit message.
Change-Id: I9f26aa314e26142122e9f594275406cf7fbade98
Bug-Url
gerrit-hooks has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url
51 matches
Mail list logo
