gerrit-hooks has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 18:
* #1350465::Update tracker: OK
* Set MODIFIED::bug 1350465#1350465::IGNORE, skipping for branch
Dan Kenigsberg has submitted this change and it was merged.
Change subject: v2v: Log detailed output of virt-v2v
..
v2v: Log detailed output of virt-v2v
The detailed log of virt-v2v output is often necessary to debug
gerrit-hooks has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 17:
* #1350465::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1350465::OK, public bug
* Check
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 16: Verified+1
Verified the topic as whole. Tried successful and unsuccessful import. In both
cases
Francesco Romani has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 16: Code-Review+2
Good enough for me: we could improve later on the things still pending. Thanks
Tomas for
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/59834/14/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
PS14, Line
gerrit-hooks has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 16:
* #1350465::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1350465::OK, public bug
* Check
Francesco Romani has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 15:
this patch looks good enough, I'm worried by the io.FileIO issue (actually by
the issue fixed by
Francesco Romani has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/59834/14/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
PS14, Line
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/59834/14/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
PS14, Line
Francesco Romani has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 14: Code-Review+1
(1 comment)
initial, partial review.
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 13:
(4 comments)
Mostly splitting parts into separate commits. Added code for removing old log
files
gerrit-hooks has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 14:
* #1350465::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1350465::OK, public bug
* Check
Francesco Romani has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 13:
-1 for visibility of the comments
--
To view, visit https://gerrit.ovirt.org/59834
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 13:
(4 comments)
overall looks good, the only problem is there are a bit too many things packed
in one
gerrit-hooks has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 13:
* #1350465::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1350465::OK, public bug
* Check
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 10:
(2 comments)
https://gerrit.ovirt.org/#/c/59834/10/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
PS10, Line
gerrit-hooks has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 12:
* #1350465::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1350465::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 11:
* #1350465::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1350465::OK, public bug
* Check
Francesco Romani has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 10:
(2 comments)
initial review. Good improvements!
https://gerrit.ovirt.org/#/c/59834/10/lib/vdsm/v2v.py
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 10:
CI-1 is unrelated:
11:30:57 ./automation/check-patch.sh: line 7: easy_install: command not
gerrit-hooks has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 10:
* #1350465::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1350465::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 9:
* #1350465::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1350465::OK, public bug
* Check
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 8:
CI failure is unrelated:
13:10:58 == Running the shellscript automation/check-patch.sh
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/59834/6/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 722:
gerrit-hooks has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 8:
* #1350465::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1350465::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 7:
* #1350465::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1350465::OK, public bug
* Check
Francesco Romani has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 6:
(1 comment)
partial review, but as the story unfolds, the shell redirect approach is
gaining some
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 6:
(3 comments)
https://gerrit.ovirt.org/#/c/59834/4//COMMIT_MSG
Commit Message:
Line 13: It would be
Francesco Romani has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 6: Code-Review-1
(3 comments)
This version is an improvement, I'm not still completely happy about doing
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 6: Verified+1
Rebase, no code changes. Restoring V+1
--
To view, visit https://gerrit.ovirt.org/59834
gerrit-hooks has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 5:
* #1350465::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1350465::OK, public bug
* Check
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/59834/4//COMMIT_MSG
Commit Message:
Line 13: It would be
Dan Kenigsberg has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/59834/4//COMMIT_MSG
Commit Message:
Line 13: It would be
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 4: Verified-1
(1 comment)
The basic command works as it should, but the error code is not propagated
Francesco Romani has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/59834/4/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
PS4, Line 401:
Shahar Havivi has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/59834/1/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 383:
Francesco Romani has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/59834/1/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 811:
Line
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/59834/1/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 811:
Francesco Romani has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/59834/1/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 383:
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 3:
Main changes:
* storing logs in /var/log/vdsm/import instead of /var/run/vdsm/v2v because
/var/run is
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/59834/1/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 383:
Shahar Havivi has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/59834/1/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 785:
Francesco Romani has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 1: Code-Review-1
-1 for visibility, the concept is fine, we just need to sort out some details
--
To
Francesco Romani has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/59834/1/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 383:
Shahar Havivi has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/59834/1/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 383:
gerrit-hooks has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 1:
* #1350465::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1350465::OK, public bug
* Check
Tomas Golembiovsky has uploaded a new change for review.
Change subject: v2v: Log detailed output of virt-v2v
..
v2v: Log detailed output of virt-v2v
The detailed log virt-v2v output is often necessary to debug conversion
48 matches
Mail list logo
