Change in vdsm[master]: v2v: get VM information from OVA file

2015-08-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 12: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view,

Change in vdsm[master]: v2v: get VM information from OVA file

2015-08-17 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: v2v: get VM information from OVA file .. v2v: get VM information from OVA file In order to import a VM that exists in an OVA file the oVirt engine

Change in vdsm[master]: v2v: get VM information from OVA file

2015-08-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/43271/10/vdsm/v2v.py File vdsm/v2v.py: Line 185:

Change in vdsm[master]: v2v: get VM information from OVA file

2015-08-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 11: Code-Review+2 raising score -- To view, visit https://gerrit.ovirt.org/43271 To unsubscribe, visit

Change in vdsm[master]: v2v: get VM information from OVA file

2015-08-16 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/43271/10/vdsm/v2v.py File vdsm/v2v.py: Line 185:

Change in vdsm[master]: v2v: get VM information from OVA file

2015-08-14 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 11: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: v2v: get VM information from OVA file

2015-08-13 Thread fromani
Francesco Romani has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 10: Code-Review+1 (2 comments) partial ACK. Since we're cleaning up schema and return value, fuether

Change in vdsm[master]: v2v: get VM information from OVA file

2015-08-12 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/43271/9/vdsm/rpc/vdsmapi-schema.json File

Change in vdsm[master]: v2v: get VM information from OVA file

2015-08-12 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: v2v: get VM information from OVA file

2015-08-12 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 10: Verified+1 -- To view, visit https://gerrit.ovirt.org/43271 To unsubscribe, visit

Change in vdsm[master]: v2v: get VM information from OVA file

2015-08-11 Thread alitke
Adam Litke has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 9: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/43271/9/vdsm/rpc/vdsmapi-schema.json File

Change in vdsm[master]: v2v: get VM information from OVA file

2015-08-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 9: Code-Review+2 thanks for the updates, looks good to me now. -- To view, visit

Change in vdsm[master]: v2v: get VM information from OVA file

2015-08-10 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 9: Verified+1 -- To view, visit https://gerrit.ovirt.org/43271 To unsubscribe, visit

Change in vdsm[master]: v2v: get VM information from OVA file

2015-08-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: v2v: get VM information from OVA file

2015-08-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: v2v: get VM information from OVA file

2015-08-06 Thread fromani
Francesco Romani has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 8: Code-Review+1 (2 comments) minor doc comments inside. I see patch 44471 adds tests, hence preliminar

Change in vdsm[master]: v2v: get VM information from OVA file

2015-08-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: v2v: get VM information from OVA file

2015-08-06 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 6: (3 comments) testing patch: https://gerrit.ovirt.org/#/c/44471/

Change in vdsm[master]: v2v: get VM information from OVA file

2015-08-05 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: v2v: get VM information from OVA file

2015-08-05 Thread fromani
Francesco Romani has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 6: (4 comments) minor comments. Looks OK so far. I of course trust the verification, but this code begs

Change in vdsm[master]: v2v: get VM information from OVA file

2015-08-05 Thread fromani
Francesco Romani has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 6: Code-Review-1 minor nits, -1 for visibility -- To view, visit https://gerrit.ovirt.org/43271 To

Change in vdsm[master]: v2v: get VM information from OVA file

2015-08-04 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/43271 To unsubscribe, visit

Change in vdsm[master]: v2v: get VM information from OVA file

2015-08-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: v2v: get VM information from OVA file

2015-08-03 Thread fromani
Francesco Romani has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 4: Code-Review-1 (10 comments) mostly questions, but quite some of them. -1 for visibility.

Change in vdsm[master]: v2v: get VM information from OVA file

2015-08-03 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/43271/4/vdsm/v2v.py File vdsm/v2v.py: Line 175: root =

Change in vdsm[master]: v2v: get VM information from OVA file

2015-08-03 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 4: (9 comments) https://gerrit.ovirt.org/#/c/43271/4/vdsm/rpc/vdsmapi-schema.json File

Change in vdsm[master]: v2v: get VM information from OVA file

2015-08-02 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: v2v: get VM information from OVA file

2015-08-02 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/43271 To unsubscribe, visit

Change in vdsm[master]: v2v: get VM information from OVA file

2015-07-19 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: v2v: get VM information from OVA file

2015-07-09 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: v2v: get VM information from OVA file

2015-07-09 Thread fromani
Francesco Romani has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/43271/2/vdsm/v2v.py File vdsm/v2v.py: Line 49: Line 50:

Change in vdsm[master]: v2v: get VM information from OVA file

2015-07-09 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/43271/2/vdsm/v2v.py File vdsm/v2v.py: Line 49: Line 50:

Change in vdsm[master]: v2v: get VM information from OVA file

2015-07-07 Thread shavivi
Shahar Havivi has uploaded a new change for review. Change subject: v2v: get VM information from OVA file .. v2v: get VM information from OVA file In order to import a VM that exists in an OVA file the oVirt engine needs to get

Change in vdsm[master]: v2v: get VM information from OVA file

2015-07-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure