gerrit-hooks has posted comments on this change.
Change subject: vdsm: Remove unreachable code
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/52997
To unsubscribe, visit
Martin Betak has abandoned this change.
Change subject: vdsm: Remove unreachable code
..
Abandoned
duplicate change
--
To view, visit https://gerrit.ovirt.org/52997
To unsubscribe, visit https://gerrit.ovirt.org/settings
Francesco Romani has posted comments on this change.
Change subject: vdsm: Remove unreachable code
..
Patch Set 2: Code-Review+1
this is mostly infra's territory, hence +1 and not +2
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: vdsm: Remove unreachable code
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: Remove unreachable code
..
vdsm: Remove unreachable code
Change-Id: I919ca97f7b1077be2415287a43b9a9372e1fa593
Signed-off-by: Martin Betak
Piotr Kliczewski has posted comments on this change.
Change subject: vdsm: Remove unreachable code
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52980
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: vdsm: Remove unreachable code
..
Patch Set 1: Code-Review-1
split the hook from other modifications, would love to see both in
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: vdsm: Remove unreachable code
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Martin Polednik has posted comments on this change.
Change subject: vdsm: Remove unreachable code
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52980
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Remove unreachable code
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/52980
To unsubscribe, visit
Martin Betak has uploaded a new change for review.
Change subject: vdsm: Remove unreachable code
..
vdsm: Remove unreachable code
Change-Id: Ie84749d01a735bc8177c7d16fb0612636f547004
Signed-off-by: Martin Betak
Martin Betak has posted comments on this change.
Change subject: vdsm: Remove unreachable code
..
Patch Set 2:
split the hook part as per mpolednik's request
--
To view, visit https://gerrit.ovirt.org/52980
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: vdsm: Remove unreachable code
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Martin Betak has posted comments on this change.
Change subject: vdsm: Remove unreachable code
..
Patch Set 1:
(4 comments)
https://gerrit.ovirt.org/#/c/52980/1/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 294
Line 295
Martin Betak has uploaded a new change for review.
Change subject: vdsm: Remove unreachable code
..
vdsm: Remove unreachable code
Change-Id: I919ca97f7b1077be2415287a43b9a9372e1fa593
Signed-off-by: Martin Betak
gerrit-hooks has posted comments on this change.
Change subject: vdsm: Remove unreachable code
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Milan Zamazal has posted comments on this change.
Change subject: vdsm: Remove unreachable code
..
Patch Set 1: Code-Review-1
(1 comment)
Good idea, just an objection about modifying the hook.
Milan Zamazal has posted comments on this change.
Change subject: vdsm: Remove unreachable code
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52980
To unsubscribe, visit
18 matches
Mail list logo
