Nir Soffer has submitted this change and it was merged.
Change subject: virt: Add support for vgamem attribute
..
virt: Add support for vgamem attribute
SPICE/QXL video RAM sizes are currently specified in domain XML
element
Nir Soffer has posted comments on this change.
Change subject: virt: Add support for vgamem attribute
..
Patch Set 3: Verified+1
Was verified before improving schema docs.
--
To view, visit https://gerrit.ovirt.org/50091
To
gerrit-hooks has posted comments on this change.
Change subject: virt: Add support for vgamem attribute
..
Patch Set 4:
* #1275539::Update tracker: OK
* Set MODIFIED::bug 1275539#1275539IGNORE, not oVirt classification
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: Add support for vgamem attribute
..
Patch Set 3: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/50091/3/tests/deviceTests.py
File
Milan Zamazal has posted comments on this change.
Change subject: virt: Add support for vgamem attribute
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/50091/3/tests/deviceTests.py
File tests/deviceTests.py:
Line
Francesco Romani has posted comments on this change.
Change subject: virt: Add support for vgamem attribute
..
Patch Set 2: -Code-Review
temporary changing score to highlight Nir's comments about the schema. Other
than that
Nir Soffer has posted comments on this change.
Change subject: virt: Add support for vgamem attribute
..
Patch Set 3: Code-Review+2
Can we have another review?
--
To view, visit https://gerrit.ovirt.org/50091
To unsubscribe,
Milan Zamazal has posted comments on this change.
Change subject: virt: Add support for vgamem attribute
..
Patch Set 3:
Improved doc in schema.
--
To view, visit https://gerrit.ovirt.org/50091
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: virt: Add support for vgamem attribute
..
Patch Set 3:
* #1275539::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1275539::OK, public bug
* Check
Francesco Romani has posted comments on this change.
Change subject: virt: Add support for vgamem attribute
..
Patch Set 3: Code-Review+2
schema looks good now.
--
To view, visit https://gerrit.ovirt.org/50091
To
Francesco Romani has posted comments on this change.
Change subject: virt: Add support for vgamem attribute
..
Patch Set 2: Code-Review+2
seems fine, thanks!
--
To view, visit https://gerrit.ovirt.org/50091
To unsubscribe,
Pavel Zhukov has posted comments on this change.
Change subject: virt: Add support for vgamem attribute
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/50091/2/vdsm/virt/vmdevices/core.py
File
Francesco Romani has posted comments on this change.
Change subject: virt: Add support for vgamem attribute
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/50091/2/vdsm/virt/vmdevices/core.py
File
Milan Zamazal has posted comments on this change.
Change subject: virt: Add support for vgamem attribute
..
Patch Set 2: Verified+1
Tested together with the corresponding Engine change: Changing number of heads
on single PCI
Nir Soffer has posted comments on this change.
Change subject: virt: Add support for vgamem attribute
..
Patch Set 2: Code-Review-1
(1 comment)
Looks good, needs more info in the schema.
gerrit-hooks has posted comments on this change.
Change subject: virt: Add support for vgamem attribute
..
Patch Set 1:
* #1275539::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1275539::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: virt: Add support for vgamem attribute
..
Patch Set 2:
* #1275539::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1275539::OK, public bug
* Check
17 matches
Mail list logo
