Martin Betak has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 14:
no longer needed but still pretty nice piece of code I would say. Pity that
gerrit doesn't have *Archive* feature
Francesco Romani has abandoned this change.
Change subject: virt: add run_async helper
..
Abandoned
no longer needed
--
To view, visit https://gerrit.ovirt.org/49570
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/49570
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 14: Verified+1
--
To view, visit https://gerrit.ovirt.org/49570
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Martin Betak has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 11:
(3 comments)
https://gerrit.ovirt.org/#/c/49570/11//COMMIT_MSG
Commit Message:
Line 11: support
> supportS
Done
gerrit-hooks has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Francesco Romani has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/49570/11/tests/vmUtilsTests.py
File tests/vmUtilsTests.py:
Line 184:
Francesco Romani has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 11: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/49570/11//COMMIT_MSG
Commit Message:
Line 11: support
Martin Betak has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 10: Verified+1
--
To view, visit https://gerrit.ovirt.org/49570
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Francesco Romani has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/49570/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 680:
gerrit-hooks has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Francesco Romani has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/49570/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 680:
gerrit-hooks has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Francesco Romani has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 5: Code-Review-1
(1 comment)
will simplify a bit more, let's save changes for the next patches.
gerrit-hooks has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Francesco Romani has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 4:
Rebase and fix the docstring mistakes kindly pointed out by Milan.
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49570
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/49570/3/vdsm/virt/utils.py
File vdsm/virt/utils.py:
Line 137: If
Francesco Romani has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/49570/3/vdsm/virt/utils.py
File vdsm/virt/utils.py:
Line 137: If
Francesco Romani has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 3:
(5 comments)
https://gerrit.ovirt.org/#/c/49570/3/vdsm/virt/utils.py
File vdsm/virt/utils.py:
Line 133: """
Francesco Romani has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 5: Verified+1
tested the unthrottled path using patched VDSM running (and migrating) vms.
Tested the other paths
Francesco Romani has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 5:
Martin, please share your thoughts!
--
To view, visit https://gerrit.ovirt.org/49570
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 5: Code-Review+1
(1 comment)
Nice job! I really like the simplification over the previous implementations.
gerrit-hooks has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Milan Zamazal has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 3:
(5 comments)
Documentation better now, I still suggest some fixes run_async docstring, see
the comments.
gerrit-hooks has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Milan Zamazal has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/49570/2/vdsm/virt/utils.py
File vdsm/virt/utils.py:
Line 121:
Line 122:
Francesco Romani has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 2: Verified+1
verified no regression running a couple of VMs.
--
To view, visit https://gerrit.ovirt.org/49570
To
Francesco Romani has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 2: Code-Review-1
need to address Milan's comments.
--
To view, visit https://gerrit.ovirt.org/49570
To unsubscribe,
Milan Zamazal has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 1:
(2 comments)
Looks nice to me. Just docstrings are missing and see my comments on tests.
Francesco Romani has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/49570/1/tests/vmUtilsTests.py
File tests/vmUtilsTests.py:
Line 169:
Francesco Romani has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 1:
OK, this is the final form, ready for reviews, and candidate for merging when
everyone's happy.
--
To view,
Francesco Romani has uploaded a new change for review.
Change subject: virt: add run_async helper
..
virt: add run_async helper
Introduce the run_async function, to run one-shot long operations in
background.
run_async support
gerrit-hooks has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
41 matches
Mail list logo