Change in vdsm[master]: vm: Remove useless volume size monitoring

2016-09-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: Remove useless volume size monitoring .. Patch Set 5: Verified-1 This does not work yet - we must replace the usage of Drive.apparentsize and Drive.truesize in

Change in vdsm[master]: vm: Remove useless volume size monitoring

2016-09-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: Remove useless volume size monitoring .. Patch Set 5: Code-Review+1 Not 100% sure we can merge this, but I'd love to have this patch in. -- To view, vis

Change in vdsm[master]: vm: Remove useless volume size monitoring

2016-09-16 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: Remove useless volume size monitoring .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header mat

Change in vdsm[master]: vm: Remove useless volume size monitoring

2016-09-16 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: Remove useless volume size monitoring .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header mat

Change in vdsm[master]: vm: Remove useless volume size monitoring

2016-09-16 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: Remove useless volume size monitoring .. Patch Set 3: This should work now, the previous patch remove the last usage. -- To view, visit https://gerrit.ovirt.o

Change in vdsm[master]: vm: Remove useless volume size monitoring

2016-09-16 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: Remove useless volume size monitoring .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header mat

Change in vdsm[master]: vm: Remove useless volume size monitoring

2016-09-15 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: Remove useless volume size monitoring .. Patch Set 2: Verified-1 Rebae on master, fixing merge conflicts, no code change. I found that we report these values t

Change in vdsm[master]: vm: Remove useless volume size monitoring

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: Remove useless volume size monitoring .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header mat

Change in vdsm[master]: vm: Remove useless volume size monitoring

2016-06-27 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: vm: Remove useless volume size monitoring .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59801 To unsubscribe, visit https://gerrit.o

Change in vdsm[master]: vm: Remove useless volume size monitoring

2016-06-27 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: vm: Remove useless volume size monitoring .. Patch Set 1: Code-Review+1 Not that I completely understand everything here, but I can't see any obvious error. --

Change in vdsm[master]: vm: Remove useless volume size monitoring

2016-06-27 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: Remove useless volume size monitoring .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59801 To unsubscribe, visit https://gerrit.o

Change in vdsm[master]: vm: Remove useless volume size monitoring

2016-06-27 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: Remove useless volume size monitoring .. Patch Set 1: Code-Review+1 I *think* this is safe and we can now drop this (and perhaps even backport to 4.0.x),

Change in vdsm[master]: vm: Remove useless volume size monitoring

2016-06-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: Remove useless volume size monitoring .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header mat

Change in vdsm[master]: vm: Remove useless volume size monitoring

2016-06-27 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: vm: Remove useless volume size monitoring .. vm: Remove useless volume size monitoring We used to check drive volume size every 60 seconds but we do not use the re