gerrit-hooks has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/49173
To
Francesco Romani has abandoned this change.
Change subject: vm: devices: drop support for ancient Engines
..
Abandoned
split patches merged, we don't need this anymore.
--
To view, visit https://gerrit.ovirt.org/49173
To
Francesco Romani has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 9: Code-Review-2
please let's continue here:
Francesco Romani has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 9: Code-Review-1
will (try to) transform in a series of patches as per Nir's request.
--
To
Edward Haas has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49173
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 9: Code-Review+1
I love this patch
--
To view, visit https://gerrit.ovirt.org/49173
To
Francesco Romani has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 9:
let's check what happens if one uses:
vdsClient -s 0 create /dev/null
Nir Soffer has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 9:
Can we split it to smaller changes?
--
To view, visit https://gerrit.ovirt.org/49173
To
gerrit-hooks has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Milan Zamazal has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49173
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 7: Code-Review-1
missed comment from Milan.
--
To view, visit https://gerrit.ovirt.org/49173
To
gerrit-hooks has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 6:
simple rebase. If we keep the getConfGraphics backward compatibility, we should
cover Engine
Milan Zamazal has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 5: Code-Review-1
testGraphicsDeviceLegacy should probably be also removed (it fails now). Other
test
gerrit-hooks has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Milan Zamazal has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 4: Code-Review-1
Please take care about other objects related to those and only to those
methods.
Francesco Romani has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/49173/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Nir Soffer has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/49173/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 431
gerrit-hooks has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 2: Verified-1
Of course I don't want to sneak anything into, here's why I proposed this patch
for
Nir Soffer has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 2: Code-Review-1
Are you sure about not supporting engine < 3.6?
In 3.6 we support engine > 3.3. I
Nir Soffer has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 2:
Changing policy regarding backward compatibility should be discussed in devel.
It is not acceptable
Martin Polednik has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 1: Code-Review+1
Great effort, I'm ok with Dan's comments added in later patches.
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has uploaded a new change for review.
Change subject: vm: devices: drop support for ancient Engines
..
vm: devices: drop support for ancient Engines
Since version 4.0 Engine is supposed to send proper devices
Dan Kenigsberg has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 1: Code-Review-1
more update points:
- vdsClient
- schema?
- testVmDefinitionLegacyGraphics
Francesco Romani has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 1:
make sure that migration from 3.6.x to 4.0 works ok
--
To view, visit
Marek Libra has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49173
To unsubscribe, visit
Shmuel Leib Melamud has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49173
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
33 matches
Mail list logo
