Change in vdsm[master]: vm: move device attached check to device itself

gerrit-hooks has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 17: * #1134256::Update tracker: OK * Set MODIFIED::bug 1134256#1134256IGNORE, not oVirt class

Change in vdsm[master]: vm: move device attached check to device itself

Nir Soffer has submitted this change and it was merged. Change subject: vm: move device attached check to device itself .. vm: move device attached check to device itself Moving the check for being attached to the device in que

Change in vdsm[master]: vm: move device attached check to device itself

gerrit-hooks has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 16: * #1134256::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1134256::OK, public bug *

Change in vdsm[master]: vm: move device attached check to device itself

Marcin Mirecki has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 15: Verified+1 -- To view, visit https://gerrit.ovirt.org/48881 To unsubscribe, visit https://gerr

Change in vdsm[master]: vm: move device attached check to device itself

gerrit-hooks has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 15: * #1134256::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1134256::OK, public bug *

Change in vdsm[master]: vm: move device attached check to device itself

Ido Barkan has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 14: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48881 To unsubscribe, visit https://gerri

Change in vdsm[master]: vm: move device attached check to device itself

Francesco Romani has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 14: Code-Review+2 please see my comment in 48473 -- To view, visit https://gerrit.ovirt.org/488

Change in vdsm[master]: vm: move device attached check to device itself

gerrit-hooks has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 14: * #1134256::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1134256::OK, public bug *

Change in vdsm[master]: vm: move device attached check to device itself

gerrit-hooks has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 13: * #1134256::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1134256::OK, public bug *

Change in vdsm[master]: vm: move device attached check to device itself

Marcin Mirecki has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 12: Verified+1 -- To view, visit https://gerrit.ovirt.org/48881 To unsubscribe, visit https://gerr

Change in vdsm[master]: vm: move device attached check to device itself

Nir Soffer has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 12: Code-Review+2 Can you verify? -- To view, visit https://gerrit.ovirt.org/48881 To unsubscribe, vi

Change in vdsm[master]: vm: move device attached check to device itself

gerrit-hooks has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: vm: move device attached check to device itself

Francesco Romani has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48881 To unsubscribe, visit https:/

Change in vdsm[master]: vm: move device attached check to device itself

Nir Soffer has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 11: Code-Review+2 Thanks Marcin, excellent work -- To view, visit https://gerrit.ovirt.org/48881 To u

Change in vdsm[master]: vm: move device attached check to device itself

gerrit-hooks has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: vm: move device attached check to device itself

Marcin Mirecki has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 10: (2 comments) https://gerrit.ovirt.org/#/c/48881/10/vdsm/virt/vmdevices/storage.py File vdsm/vi

Change in vdsm[master]: vm: move device attached check to device itself

Nir Soffer has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/48881/10/vdsm/virt/vmdevices/storage.py File vdsm/virt/vm

Change in vdsm[master]: vm: move device attached check to device itself

Nir Soffer has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 10: Code-Review-1 (1 comment) Just need to remove the unneeded changes in storage.py https://gerrit.o

Change in vdsm[master]: vm: move device attached check to device itself

Marcin Mirecki has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/48881/7/vdsm/virt/vmdevices/storage.py File vdsm/virt/

Change in vdsm[master]: vm: move device attached check to device itself

gerrit-hooks has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: vm: move device attached check to device itself

Francesco Romani has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48881 To unsubscribe, visit https://

Change in vdsm[master]: vm: move device attached check to device itself

gerrit-hooks has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: vm: move device attached check to device itself

gerrit-hooks has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: vm: move device attached check to device itself

Nir Soffer has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 7: (1 comment) Nice, see the comment about breaking long lines. https://gerrit.ovirt.org/#/c/48881/7/

Change in vdsm[master]: vm: move device attached check to device itself

gerrit-hooks has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: vm: move device attached check to device itself

gerrit-hooks has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: vm: move device attached check to device itself

Marcin Mirecki has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/48881/4/vdsm/virt/vmdevices/core.py File vdsm/virt/vm

Change in vdsm[master]: vm: move device attached check to device itself

gerrit-hooks has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: vm: move device attached check to device itself

Marcin Mirecki has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/48881/4/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 26

Change in vdsm[master]: vm: move device attached check to device itself

Nir Soffer has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 4: (3 comments) https://gerrit.ovirt.org/#/c/48881/4/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2687:

Change in vdsm[master]: vm: move device attached check to device itself

Marcin Mirecki has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/48881/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 26

Change in vdsm[master]: vm: move device attached check to device itself

gerrit-hooks has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: vm: move device attached check to device itself

Francesco Romani has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 3: Code-Review-1 (1 comment) nice, -1 for one question inside https://gerrit.ovirt.org/#/c/4888

Change in vdsm[master]: vm: move device attached check to device itself

gerrit-hooks has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: vm: move device attached check to device itself

Nir Soffer has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 2: (2 comments) I like this, but lest fist have a working version before we think about the improving

Change in vdsm[master]: vm: move device attached check to device itself

Nir Soffer has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/48881/1/tests/vmTests.py File tests/vmTests.py: Line 1252

Change in vdsm[master]: vm: move device attached check to device itself

gerrit-hooks has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: vm: move device attached check to device itself

Marcin Mirecki has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/48881/1/tests/vmTests.py File tests/vmTests.py: Line

Change in vdsm[master]: vm: move device attached check to device itself

Nir Soffer has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 1: (4 comments) https://gerrit.ovirt.org/#/c/48881/1/tests/vmTests.py File tests/vmTests.py: Line 125

Change in vdsm[master]: vm: move device attached check to device itself

Marcin Mirecki has uploaded a new change for review. Change subject: vm: move device attached check to device itself .. vm: move device attached check to device itself Moving the check for being attached to the device in questio

Change in vdsm[master]: vm: move device attached check to device itself

gerrit-hooks has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head