Change in vdsm[ovirt-3.3]: vm: Fix attribute error when accessing drive in sampling method

2013-12-18 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: vm: Fix attribute error when accessing drive in sampling method .. vm: Fix attribute error when accessing drive in sampling method Du to race when migration is

Change in vdsm[ovirt-3.3]: vm: Fix attribute error when accessing drive in sampling method

2013-12-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: Fix attribute error when accessing drive in sampling method .. Patch Set 1: Patch for testing this issue on a user machine. Patch for upstream and ovirt

Change in vdsm[ovirt-3.3]: vm: Fix attribute error when accessing drive in sampling method

2013-12-18 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: vm: Fix attribute error when accessing drive in sampling method .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22518 To

Change in vdsm[ovirt-3.3]: vm: Fix attribute error when accessing drive in sampling method

2013-12-18 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: vm: Fix attribute error when accessing drive in sampling method .. Patch Set 1: Is this a backport or is it a patch needed only in ovirt-3.3? -- To

Change in vdsm[ovirt-3.3]: vm: Fix attribute error when accessing drive in sampling method

2013-12-18 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: vm: Fix attribute error when accessing drive in sampling method .. Patch Set 1: Code-Review+1 (1 comment) I assume that this is an upstream patch, right?

Change in vdsm[ovirt-3.3]: vm: Fix attribute error when accessing drive in sampling method

2013-12-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: Fix attribute error when accessing drive in sampling method .. Patch Set 1: This is a patch for a user running 4.13.0. Patch for upstream will be in another

Change in vdsm[ovirt-3.3]: vm: Fix attribute error when accessing drive in sampling method

2013-12-18 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: Fix attribute error when accessing drive in sampling method .. Patch Set 1: (1 comment) Commit

Change in vdsm[ovirt-3.3]: vm: Fix attribute error when accessing drive in sampling method

2013-12-18 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: Fix attribute error when accessing drive in sampling method .. Patch Set 1: Ah sorry, Nir, I did not see your latest comment. How does the __slots__ patch

Change in vdsm[ovirt-3.3]: vm: Fix attribute error when accessing drive in sampling method

2013-12-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: Fix attribute error when accessing drive in sampling method .. Patch Set 1: (1 comment) Commit Message

Change in vdsm[ovirt-3.3]: vm: Fix attribute error when accessing drive in sampling method

2013-12-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: Fix attribute error when accessing drive in sampling method .. Patch Set 1: The race is not the problem. The problem is that the code treat attributes as

Change in vdsm[ovirt-3.3]: vm: Fix attribute error when accessing drive in sampling method

2013-12-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: Fix attribute error when accessing drive in sampling method .. Patch Set 1: Note also that in the context of _highwrite, we don't care if the vmDrive has a

Change in vdsm[ovirt-3.3]: vm: Fix attribute error when accessing drive in sampling method

2013-12-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: Fix attribute error when accessing drive in sampling method .. Patch Set 1: Verified+1 Verified on user machine. -- To view, visit

Change in vdsm[ovirt-3.3]: vm: Fix attribute error when accessing drive in sampling method

2013-12-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: Fix attribute error when accessing drive in sampling method .. Patch Set 1: For reference: http://lists.ovirt.org/pipermail/users/2013-December/018905.html --

Change in vdsm[ovirt-3.3]: vm: Fix attribute error when accessing drive in sampling method

2013-12-18 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: Fix attribute error when accessing drive in sampling method .. Patch Set 1: Code-Review-1 (2 comments)

Change in vdsm[ovirt-3.3]: vm: Fix attribute error when accessing drive in sampling method

2013-12-18 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: vm: Fix attribute error when accessing drive in sampling method .. Patch Set 1: Code-Review-1 (1 comment) Sorry, I changed my mind either, please see my

Change in vdsm[ovirt-3.3]: vm: Fix attribute error when accessing drive in sampling method

2013-12-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: Fix attribute error when accessing drive in sampling method .. Patch Set 1: (1 comment) File vdsm/vm.py