Assaf Muller has posted comments on this change.
Change subject: Management network is now kept in main routing table
..
Patch Set 4: (1 inline comment)
File
Saggi Mizrahi has posted comments on this change.
Change subject: refactoring: fix imports stmts, replaced glob with iglob for
uniformity.
..
Patch Set 4: Looks good to me, but someone else must approve
though I do think that
Saggi Mizrahi has posted comments on this change.
Change subject: Fix log level for failures in execCmd
..
Patch Set 2: I would prefer that you didn't submit this
a command failing isn't necessarily warning worthy all of the
Saggi Mizrahi has posted comments on this change.
Change subject: mount: Reassign mount specification in case of backup option
..
Patch Set 2: I would prefer that you didn't submit this
I still don't really understand what you
Mark Wu has posted comments on this change.
Change subject: netconf: skip validation on bonding's slaves on removal
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/17216
To unsubscribe, visit
Mark Wu has posted comments on this change.
Change subject: configNetwork: remove the option implicitBonding
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/17215
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netconf: make ifcfg's rollback cover new added networks
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3674/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: configNetwork: remove the option implicitBonding
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3673/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netconf: skip validation on bonding's slaves on removal
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3672/ :
Giuseppe Vallarelli has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 1:
This means that I need to rewrite a new patch - redo the work.
--
To view, visit
Petr Šebek has posted comments on this change.
Change subject: jsonrpc: make TCPReactor IPv6 capable
..
Patch Set 3: Verified
without patch:
import asyncoreReactor
ar = asyncoreReactor.AsyncoreReactor()
aclient =
Dan Kenigsberg has submitted this change and it was merged.
Change subject: jsonrpc: make TCPReactor IPv6 capable
..
jsonrpc: make TCPReactor IPv6 capable
Change-Id: I108c3f804476ace8b9b1f0c5cca3f9b196d1163b
Signed-off-by:
Dan Kenigsberg has posted comments on this change.
Change subject: jsonrpc: make TCPReactor IPv6 capable
..
Patch Set 3: Looks good to me, approved
Thanks, Petr. It's a convincing verification.
--
To view, visit
Giuseppe Vallarelli has posted comments on this change.
Change subject: refactoring: fix imports stmts, replaced glob with iglob for
uniformity.
..
Patch Set 4:
Sometimes it takes time to have a patch approved and then merged
Sandro Bonazzola has uploaded a new change for review.
Change subject: ClientIF: avoid runtime errors at VM shutdown
..
ClientIF: avoid runtime errors at VM shutdown
Avoids:
RuntimeError: dictionary changed size during
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ClientIF: avoid runtime errors at VM shutdown
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3675/ : SUCCESS
Sandro Bonazzola has posted comments on this change.
Change subject: ClientIF: avoid runtime errors at VM shutdown
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/17599
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: ClientIF: avoid runtime errors at VM shutdown
..
Patch Set 1: (1 inline comment)
File vdsm/clientIF.py
Sandro Bonazzola has posted comments on this change.
Change subject: [WIP] Decouple images and volumes from pool path
..
Patch Set 2:
Eduardo, can you rebase this patch?
--
To view, visit http://gerrit.ovirt.org/16055
To
Michal Skrivanek has posted comments on this change.
Change subject: ClientIF: avoid runtime errors at VM shutdown
..
Patch Set 1: I would prefer that you didn't submit this
Ideally please work in the sugestions from Toni and
Sandro Bonazzola has posted comments on this change.
Change subject: ClientIF: avoid runtime errors at VM shutdown
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/17599
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ClientIF: avoid runtime errors at VM shutdown
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3676/ : SUCCESS
Michal Skrivanek has posted comments on this change.
Change subject: ClientIF: avoid runtime errors at VM shutdown
..
Patch Set 2: (1 inline comment)
File vdsm/clientIF.py
Sandro Bonazzola has posted comments on this change.
Change subject: ClientIF: avoid runtime errors at VM shutdown
..
Patch Set 2: (1 inline comment)
File vdsm/clientIF.py
Michal Skrivanek has posted comments on this change.
Change subject: ClientIF: avoid runtime errors at VM shutdown
..
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
Overall I won't mind merging
Vinzenz Feenstra has uploaded a new change for review.
Change subject: vdsm: Always retrieve alias for Balloon and Console devices
..
vdsm: Always retrieve alias for Balloon and Console devices
We haven't been retrieving the
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Always retrieve alias for Balloon and Console devices
..
Patch Set 1:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ClientIF: avoid runtime errors at VM shutdown
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3678/ : SUCCESS
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: Always retrieve alias for Balloon and Console devices
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/17602
To unsubscribe, visit
Vinzenz Feenstra has posted comments on this change.
Change subject: Crash fix for migrations that involve devices with no aliases
..
Patch Set 1:
Yes it is not beautiful however it will avoid our issue. There's no other real
Martin Sivák has posted comments on this change.
Change subject: Add support for direct setting of cpu_shares when creating a VM
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/17603
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: ClientIF: avoid runtime errors at VM shutdown
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/17599
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Add support for direct setting of cpu_shares when creating a VM
..
Patch Set 2: I would prefer that you didn't submit this
We attempt to stabilize ovirt-3.3 in
Martin Sivák has posted comments on this change.
Change subject: Add support for direct setting of cpu_shares when creating a VM
..
Patch Set 2:
It is an approved 3.3 bug. See
Antoni Segura Puimedon has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 1: (3 inline comments)
Dropping the two things that are already tested (for good or for a future
Giuseppe Vallarelli has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 1: No score
(4 inline comments)
File
Giuseppe Vallarelli has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/17435
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3679/ : SUCCESS
Giuseppe Vallarelli has posted comments on this change.
Change subject: tests: addNetwork with one or more vlans.
..
Patch Set 2: (3 inline comments)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: addNetwork with one or more vlans.
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3680/ : SUCCESS
Giuseppe Vallarelli has posted comments on this change.
Change subject: tests: addNetwork with one or more vlans.
..
Patch Set 4: Verified
Cherry-picking Now this patch doesn't depend on an abandoned one.
--
To view, visit
Giuseppe Vallarelli has posted comments on this change.
Change subject: tests: setupNetworks add one or more vlans.
..
Patch Set 1: (4 inline comments)
File
Giuseppe Vallarelli has posted comments on this change.
Change subject: tests: setupNetworks add one or more vlans.
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/17432
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: setupNetworks add one or more vlans.
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3682/ : SUCCESS
Giuseppe Vallarelli has posted comments on this change.
Change subject: tests: addNetwork bond with one or many vlans.
..
Patch Set 3: (4 inline comments)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: addNetwork bond with one or many vlans.
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3683/ : SUCCESS
Giuseppe Vallarelli has posted comments on this change.
Change subject: tests: addNetwork bond with one or many vlans.
..
Patch Set 5: Verified
Rebased on top of a different commit.
--
To view, visit
Giuseppe Vallarelli has posted comments on this change.
Change subject: tests: addNetwork bond with one or many vlans.
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/17387
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: addNetwork bond with one or many vlans.
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3685/ : SUCCESS
Giuseppe Vallarelli has posted comments on this change.
Change subject: refactoring: fix imports stmts, replaced glob with iglob for
uniformity.
..
Patch Set 5: Verified
Simply a rebase on top of the updated patch.
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: refactoring: fix imports stmts, replaced glob with iglob for
uniformity.
..
Patch Set 5:
Build Successful
Giuseppe Vallarelli has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 3: Verified
Cherrypicked on top of the updated patch.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3687/ : SUCCESS
Giuseppe Vallarelli has posted comments on this change.
Change subject: tests: addNetwork bond with one or many vlans.
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/17387
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: addNetwork bond with one or many vlans.
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3688/ : SUCCESS
55 matches
Mail list logo
