Change in vdsm[master]: Refactor getFilelist()

2013-10-26 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: Refactor getFilelist() .. Patch Set 2: After all I decided to define 'caseSensitive' option explicitly instead of using it as part of the options. I checked

Change in vdsm[master]: Refactor getFilelist()

2013-10-26 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: Refactor getFilelist() .. Patch Set 2: I aware of the jenkins failure and will fix it later. I am just checking direction. -- To view, visit

Change in vdsm[master]: Refactor getFilelist()

2013-10-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Refactor getFilelist() .. Patch Set 3: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5093/ : UNSTABLE

Change in vdsm[master]: Refactor getFilelist()

2013-10-26 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: Refactor getFilelist() .. Patch Set 4: PEP8 -- To view, visit http://gerrit.ovirt.org/20476 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: Refactor getFilelist()

2013-10-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Refactor getFilelist() .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5094/ : SUCCESS

Change in vdsm[master]: Add additional vgcheck to fix vgextend workflow on HSMs.

2013-10-26 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Add additional vgcheck to fix vgextend workflow on HSMs. .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20552 To unsubscribe, visit

Change in vdsm[master]: Refactor getFilelist()

2013-10-26 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Refactor getFilelist() .. Patch Set 4: (12 comments) Looks good but needs some cleanups. Commit Message Line

Change in vdsm[master]: Add additional vgcheck to fix vgextend workflow on HSMs.

2013-10-26 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Add additional vgcheck to fix vgextend workflow on HSMs. .. Patch Set 9: Code-Review-1 (1 comment) I don't understand how this fixes the related bug. If the issue

Change in vdsm[master]: tests: Add miniaml issciadm tests

2013-10-26 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Add miniaml issciadm tests .. Patch Set 10: Waking up reviewers - this patch is verified and ready for merging. -- To view, visit

Change in vdsm[master]: Get rid of mutables(lists) as default parameters

2013-10-26 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Get rid of mutables(lists) as default parameters .. Patch Set 2: Wake up author - this is important fix that only needs minor cleanup to complete. Why is this not