David Gibson has posted comments on this change.
Change subject: supervdsm: Enable multiprocessing module logging.
..
Patch Set 5:
Supervdsm doesn't share logging with vdsm - it logs to supervdsm.log seperately
from the rest.
Dan Kenigsberg has posted comments on this change.
Change subject: Move zombieReaper to its own package
..
Patch Set 8: Code-Review-1
Any comment about my suggestion to keep running the zombiereaper tests?
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Move zombieReaper to its own package
..
Patch Set 8:
(A comment beginning with we should not test zr because... may be a valid one)
--
To view, visit
Dan Kenigsberg has abandoned this change.
Change subject: Move safelease to its own sub-rpm
..
Abandoned
Too bad, but separating this does not change the arch of the main rpm, only
adding complexity to vdsm packaging.
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: xmlrpc: Parsing error logging enhancement
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5108/ : SUCCESS
Sergey Gotliv has posted comments on this change.
Change subject: Replace unused getFileList() with more flexible getFileStats()
..
Patch Set 5:
Yes, it's correct. I did a lot of changes due to your comments in the patch set
Ayal Baron has posted comments on this change.
Change subject: Invalidate filters before reloading vgs
..
Patch Set 11: Code-Review-1
This beats the purpose of short filters [1] which I believe already takes care
of this (so
Dan Kenigsberg has posted comments on this change.
Change subject: xmlrpc: Parsing error logging enhancement
..
Patch Set 5: Code-Review-1
(4 comments)
Commit Message
Line
Pavel Zhukov has abandoned this change.
Change subject: Invalidate filters before reloading vgs
..
Abandoned
Fixed in http://gerrit.ovirt.org/#/c/17968/
--
To view, visit http://gerrit.ovirt.org/20552
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm.spec: Requires python-cpopen = 1.2.3-3
..
Patch Set 1:
even worse ! currently 1.2.3-3 doesn't contain the newest code. until then
please avoid merging
Greg Padgett has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 6: Verified+1
Builds fine for me, too. Tested with and without HA client module available.
--
To
Doron Fediuck has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 6:
The error is:
./vdsm/API.py:54: redefinition of unused 'haClient' from line 52
Try modifying as
Saggi Mizrahi has posted comments on this change.
Change subject: Move zombieReaper to its own package
..
Patch Set 8:
I don't understand. We keep running them.
I added check-local entry in the makefile
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: xmlrpc: Parsing error logging enhancement - status collection
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5109/ :
Nir Soffer has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 6:
Looks like a tool error to me; the original code is valid.
Maybe there is an old version of pep8 on
Greg Padgett has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 7: Verified+1
Doron, thanks. Nir, agreed... it looks like an open issue in pyflakes [1].
The latest
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5110/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: xmlrpc: Parsing error logging enhancement - vdsClient
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5111/ : SUCCESS
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm.spec: Requires python-cpopen = 1.2.3-3
..
Patch Set 1:
(1 comment)
File vdsm.spec.in
Line 97:
Nir Soffer has abandoned this change.
Change subject: iscsiadm: Add debug level option
..
Abandoned
We are not going to implement this RFE, since this is not the best place to
collect iscsiadm debug logs.
--
To view, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Introducing configurator package in vdsm-tool
..
Patch Set 16:
(1 comment)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introducing configurator package in vdsm-tool
..
Patch Set 18:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5112/ : SUCCESS
Yaniv Bronhaim has posted comments on this change.
Change subject: Introducing configurator package in vdsm-tool
..
Patch Set 18:
Should be WIP label.. maybe next time I'll change it
Anyhow, the argument about the --force
Alon Bar-Lev has posted comments on this change.
Change subject: Introducing configurator package in vdsm-tool
..
Patch Set 18:
(4 comments)
File
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Move zombieReaper to its own package
..
Move zombieReaper to its own package
It is not vdsm specific so it's a prime candidate for extraction.
Dan Kenigsberg has posted comments on this change.
Change subject: Move zombieReaper to its own package
..
Patch Set 8: Verified+1 Code-Review+2
Oh, I've missed that `make check` still runs the zombiereaper tests. You could
26 matches
Mail list logo
