Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm: Report fake capabilities
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19396
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Renaming /etc/sysctl.d/vdsm to /etc/sysctl.d/vdsm.conf
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21160
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Renaming /etc/sysctl.d/vdsm to /etc/sysctl.d/vdsm.conf
..
Renaming /etc/sysctl.d/vdsm to /etc/sysctl.d/vdsm.conf
Fixing Bug #740887 it has been added
Dan Kenigsberg has posted comments on this change.
Change subject: Renaming /etc/sysctl.d/vdsm to /etc/sysctl.d/vdsm.conf
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21160
To unsubscribe, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: tests: Add NetworkTest.testAddDelNetworkDhcp
..
Patch Set 4: Code-Review-1
Please, rebase on top of master so the jenkins functional test can work
Hello Yaniv Bronhaim, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21202
to review the following change.
Change subject: Renaming /etc/sysctl.d/vdsm to /etc/sysctl.d/vdsm.conf
..
Sandro Bonazzola has posted comments on this change.
Change subject: Renaming /etc/sysctl.d/vdsm to /etc/sysctl.d/vdsm.conf
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/21202
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Renaming /etc/sysctl.d/vdsm to /etc/sysctl.d/vdsm.conf
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21202
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: clientIF: Check device visibility on failed hotplugDisk
..
Patch Set 2:
(2 comments)
Commit Message
Line
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Add NetworkTest.testAddDelNetworkDhcp
..
Patch Set 4: Code-Review-1
(2 comments)
File
Sergey Gotliv has posted comments on this change.
Change subject: vm: refresh raw disk before live extension
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21177
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: refresh raw disk before live extension
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4593/ : SUCCESS
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Remove vdsm directories on uninstallation
..
Remove vdsm directories on uninstallation
Change-Id: I119c691cfdf6a487f36aef6ab451073af0230143
Dan Kenigsberg has posted comments on this change.
Change subject: Remove vdsm directories on uninstallation
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/16764
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Add build-dep packages so yum-builddep is effective
..
Add build-dep packages so yum-builddep is effective
yum-builddep doesn't get all of the
Dan Kenigsberg has posted comments on this change.
Change subject: Add build-dep packages so yum-builddep is effective
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/7955
To unsubscribe, visit
Sergey Gotliv has posted comments on this change.
Change subject: clientIF: Check device visibility on failed hotplugDisk
..
Patch Set 2:
(1 comment)
Commit Message
Line 9:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: unify _highWrite and _onAbnormalStop
..
vm: unify _highWrite and _onAbnormalStop
Both _highWrite and _onAbnormalStop should share the same logic
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Removing hack for stopping libvirt-guests as conflict service
..
Removing hack for stopping libvirt-guests as conflict service
Due to recent fix in libvirt,
Federico Simoncelli has posted comments on this change.
Change subject: vm: refresh raw disk before live extension
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/21177
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: tests: Add simple mocking library
..
Patch Set 1:
I wonder if we haven't reached the point we'd like to add a mockito-python
dependency, or something to that
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Removing hack for stopping libvirt-guests as conflict service
..
Patch Set 1:
Build Successful
Antoni Segura Puimedon has posted comments on this change.
Change subject: Renaming /etc/sysctl.d/vdsm to /etc/sysctl.d/vdsm.conf
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21202
To unsubscribe,
Allon Mureinik has posted comments on this change.
Change subject: hsm: Check all devices visibility after multipath rescan
..
Patch Set 1:
(2 comments)
File
Dan Kenigsberg has posted comments on this change.
Change subject: Removing hack for stopping libvirt-guests as conflict service
..
Patch Set 1: Code-Review-1
We have to wait for the availability of libvirt =
Sergey Gotliv has posted comments on this change.
Change subject: hsm: Check all devices visibility after multipath rescan
..
Patch Set 1:
(1 comment)
File
Vered Volansky has posted comments on this change.
Change subject: hsm: Remove uneeded public annotation
..
Patch Set 1:
(1 comment)
Commit Message
Line 3: AuthorDate:
Allon Mureinik has posted comments on this change.
Change subject: fcp: Deactivate vdsm logical volumes
..
Patch Set 12:
(1 comment)
File
Federico Simoncelli has posted comments on this change.
Change subject: vm: prevent faulty volume extensions
..
Patch Set 3: Verified+1
Verified: regular highWrite, onAbnormalStop (enospc), end of file (reaching the
full
Federico Simoncelli has posted comments on this change.
Change subject: vm: prevent faulty volume extensions
..
Patch Set 3:
@Sergey, I didn't update the commit message because all the info are included
as comments in the
Sergey Gotliv has posted comments on this change.
Change subject: vm: prevent faulty volume extensions
..
Patch Set 3:
I am fine with that!
--
To view, visit http://gerrit.ovirt.org/21150
To unsubscribe, visit
Federico Simoncelli has abandoned this change.
Change subject: sp: stop monitoring on detach storage domain
..
Abandoned
Abandoned in favor of: http://gerrit.ovirt.org/#/c/21165/
--
To view, visit
Allon Mureinik has posted comments on this change.
Change subject: vdsm: Add an exception for wrong master version.
..
Patch Set 3:
(1 comment)
File
Nir Soffer has posted comments on this change.
Change subject: Revert clientIF: rescan devices on failed hotplugDisk
..
Patch Set 1:
(1 comment)
Commit Message
Line 37:
Allon Mureinik has posted comments on this change.
Change subject: lvm: Invalidate lvm cache after extend
..
Patch Set 1:
(1 comment)
File vdsm/storage/lvm.py
Line 297:
Nir Soffer has posted comments on this change.
Change subject: Revert clientIF: rescan devices on failed hotplugDisk
..
Patch Set 2:
Rebased and the missing comment when invalidating lvm filter.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: Check device visibility on failed hotplugDisk
..
Patch Set 3:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hsm: Check all devices visibility after multipath rescan
..
Patch Set 2:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Revert clientIF: rescan devices on failed hotplugDisk
..
Patch Set 2: Verified-1
Build Failed
Nir Soffer has posted comments on this change.
Change subject: clientIF: Check device visibility on failed hotplugDisk
..
Patch Set 2:
(1 comment)
Commit Message
Line 19:
Nir Soffer has posted comments on this change.
Change subject: clientIF: Check device visibility on failed hotplugDisk
..
Patch Set 3:
Rebased over previous commit.
--
To view, visit http://gerrit.ovirt.org/21181
To
Nir Soffer has posted comments on this change.
Change subject: hsm: Check all devices visibility after multipath rescan
..
Patch Set 2:
Rebased on modified dependent patch.
Revert the error handling changes, these will be
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: pre-validate disks for snapshot
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4598/ : SUCCESS
Nir Soffer has uploaded a new change for review.
Change subject: hsm: Do not hide errors when checking device visibility
..
hsm: Do not hide errors when checking device visibility
When checking devices visibility, all errors
Liron Ar has posted comments on this change.
Change subject: vm: pre-validate disks for snapshot
..
Patch Set 5:
(1 comment)
File vdsm/vm.py
Line 3712: for
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Over rhel (sysv) set LC_ALL=C when starting vdsm
..
Over rhel (sysv) set LC_ALL=C when starting vdsm
This forces vdsm to use the default language for output,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hsm: Do not hide errors when checking device visibility
..
Patch Set 1: Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Over rhel (sysv) set LC_ALL=C when starting vdsm
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4600/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Create VMs for the POWER architecture
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4601/ : To avoid
Nir Soffer has posted comments on this change.
Change subject: hsm: Do not hide errors when checking device visibility
..
Patch Set 2:
Fixed typo.
--
To view, visit http://gerrit.ovirt.org/21211
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hsm: Do not hide errors when checking device visibility
..
Patch Set 2:
Build Successful
Allon Mureinik has posted comments on this change.
Change subject: clientIF: Check device visibility on failed hotplugDisk
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21181
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Over rhel (sysv) set LC_ALL=C when starting vdsm
..
Patch Set 1: Code-Review-1
(2 comments)
Commit
Sergey Gotliv has posted comments on this change.
Change subject: hsm: Do not hide errors when checking device visibility
..
Patch Set 2:
(1 comment)
File
Sergey Gotliv has posted comments on this change.
Change subject: hsm: Check all devices visibility after multipath rescan
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21182
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: hsm: Do not hide errors when checking device visibility
..
Patch Set 2:
(1 comment)
File vdsm/storage/hsm.py
Nir Soffer has posted comments on this change.
Change subject: Revert clientIF: rescan devices on failed hotplugDisk
..
Patch Set 2:
Tests failure is not related.
--
To view, visit http://gerrit.ovirt.org/21173
To
Allon Mureinik has posted comments on this change.
Change subject: vm: prevent faulty volume extensions
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21150
To unsubscribe, visit
Sergey Gotliv has posted comments on this change.
Change subject: hsm: Do not hide errors when checking device visibility
..
Patch Set 2: Code-Review-1
1. If such errors really exists then this patch is not backward compatible
Sergey Gotliv has posted comments on this change.
Change subject: Revert clientIF: rescan devices on failed hotplugDisk
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21173
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: init: add --pidfile option in vdsmd.service
..
Patch Set 1:
No Builds Executed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4603/ : To
Hunt Xu has uploaded a new change for review.
Change subject: init: add --pidfile option in vdsmd.service
..
init: add --pidfile option in vdsmd.service
The pid file is not automatically created when using systemd. However
the
Nir Soffer has posted comments on this change.
Change subject: tests: Add simple mocking library
..
Patch Set 1:
(1 comment)
Commit Message
Line 5: CommitDate: 2013-11-12
Hello Ayal Baron, Nir Soffer, Federico Simoncelli, Pavel Zhukov, Tomáš Došek,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21223
to review the following change.
Change subject: Invalidate filters on HSMs before rescanning extended VG
Nir Soffer has posted comments on this change.
Change subject: hsm: Do not hide errors when checking device visibility
..
Patch Set 2:
1. If such errors really exists then this patch is not backward compatible
because I am
Dan Kenigsberg has posted comments on this change.
Change subject: vm: refresh raw disk before live extension
..
Patch Set 2: Code-Review-1
we have __refreshDriveVolume() since direct refresh was reported to be
dangerous.
--
Dan Kenigsberg has posted comments on this change.
Change subject: vm: prevent faulty volume extensions
..
Patch Set 3:
(1 comment)
File vdsm/vm.py
Line 2291:
Line 2292:
Martin Sivák has uploaded a new change for review.
Change subject: Allow setting just a single value in MoM policy
..
Allow setting just a single value in MoM policy
This patch prevents a policy coruption that could have
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Allow setting just a single value in MoM policy
..
Patch Set 1: Code-Review-1 Verified-1
Build Failed
Federico Simoncelli has posted comments on this change.
Change subject: vm: refresh raw disk before live extension
..
Patch Set 2:
__refreshDriveVolume() will disappear with http://gerrit.ovirt.org/#/c/8382/
LVM is freezing
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Allow setting just a single value in MoM policy
..
Patch Set 2: Code-Review-1 Verified-1
Build Failed
Dan Kenigsberg has uploaded a new change for review.
Change subject: Report qemu-kvm-rhev if installed
..
Report qemu-kvm-rhev if installed
Change-Id: If6b59241bbf38b6cd15fd941e1f68115853d22c1
Bug-Url:
Amador Pahim has posted comments on this change.
Change subject: Allow setting just a single value in MoM policy
..
Patch Set 2:
(1 comment)
File vdsm/momIF.py
Line 45:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Report qemu-kvm-rhev if installed
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4606/ : SUCCESS
Martin Sivák has posted comments on this change.
Change subject: Allow setting just a single value in MoM policy
..
Patch Set 2:
(1 comment)
File vdsm/momIF.py
Line 45:
Ayal Baron has posted comments on this change.
Change subject: Invalidate filters on HSMs before rescanning extended VG
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21223
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: Invalidate filters on HSMs before rescanning extended VG
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21223
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: Invalidate filters on HSMs before rescanning extended VG
..
Patch Set 1: -Verified Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21223
To unsubscribe,
Amador Pahim has posted comments on this change.
Change subject: [RFC] storage: Configure multipath using local interfaces
..
Patch Set 1:
(2 comments)
File
Amador Pahim has posted comments on this change.
Change subject: [RFC] storage: Configure multipath using local interfaces
..
Patch Set 2: Code-Review-1
Keeping -1 while we discuss whole solution.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [RFC] storage: Configure multipath using local interfaces
..
Patch Set 2: Code-Review-1 Verified-1
Build Failed
Sergey Gotliv has posted comments on this change.
Change subject: Invalidate filters on HSMs before rescanning extended VG
..
Patch Set 1: Verified+1
I put verified based on the original Pavel's verification.
--
To view,
Nir Soffer has posted comments on this change.
Change subject: hsm: Do not hide errors when checking device visibility
..
Patch Set 2:
If engine is too broken for handling an exception here, I can instead log the
error
Amador Pahim has posted comments on this change.
Change subject: [RFC] storage: Configure multipath using local interfaces
..
Patch Set 3: Code-Review-1
Keeping -1 while we discuss the whole solution.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [RFC] storage: Configure multipath using local interfaces
..
Patch Set 3:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: domainMonitor: tag pool monitored domains
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4610/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: fcp: Deactivate vdsm logical volumes
..
Patch Set 12:
(1 comment)
File lib/vdsm/tool/lvm_deactivate_lvs.py
Federico Simoncelli has posted comments on this change.
Change subject: domainMonitor: tag pool monitored domains
..
Patch Set 2:
(1 comment)
File
Federico Simoncelli has posted comments on this change.
Change subject: domainMonitor: tag pool monitored domains
..
Patch Set 2:
(1 comment)
Commit Message
Line 27:
Allon Mureinik has posted comments on this change.
Change subject: fcp: Deactivate vdsm logical volumes
..
Patch Set 12:
(1 comment)
File
Federico Simoncelli has posted comments on this change.
Change subject: domainMonitor: tag pool monitored domains
..
Patch Set 2: Verified+1
Verified: start/stopMonitoringDomain(), startMonitoringDomain() followed by
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Enhanced netinfo.getBootProtocol, added unit tests
..
Patch Set 13: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: do not pause during refreshVolume
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4613/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: refresh raw disk before live extension
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4612/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Enhanced netinfo.getBootProtocol, added unit tests
..
Patch Set 14:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4614/ :
Amador Pahim has posted comments on this change.
Change subject: Allow setting just a single value in MoM policy
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21225
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: Invalidate filters on HSMs before rescanning extended VG
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21223
To unsubscribe,
Federico Simoncelli has posted comments on this change.
Change subject: vm: refresh raw disk before live extension
..
Patch Set 3:
@Dan, even more... when the VM is running on the SPM the LV is extended (live)
to the new size
Sergey Gotliv has posted comments on this change.
Change subject: hsm: Do not hide errors when checking device visibility
..
Patch Set 2: Code-Review+1
I verified that Engine survives the error that now may be thrown by VDSM.
Federico Simoncelli has posted comments on this change.
Change subject: vm: refresh raw disk before live extension
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/21177
To unsubscribe, visit
1 - 100 of 128 matches
Mail list logo
