Change in vdsm[master]: Extract the DOM to Drive name, alias and path logic to reusa...

2014-06-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extract the DOM to Drive name, alias and path logic to reusable method .. Patch Set 1: Build Successful

Change in vdsm[master]: vdsm hostdev: add support for SCSI devices

2014-06-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm hostdev: add support for SCSI devices .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9540/ :

Change in vdsm[master]: vdsm hostdev: add support for SCSI devices

2014-06-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm hostdev: add support for SCSI devices .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9549/ :

Change in vdsm[master]: vdsm hostdev: add support for USB devices

2014-06-23 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vdsm hostdev: add support for USB devices .. Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/29054/1/vdsm/rpc/vdsmapi-schema.json File

Change in vdsm[master]: vdsm hostdev: add support for SCSI devices

2014-06-23 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vdsm hostdev: add support for SCSI devices .. Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/29058/3/vdsm/rpc/vdsmapi-schema.json File

Change in vdsm[master]: oop: Add an option to configure oop implementation

2014-06-23 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: oop: Add an option to configure oop implementation .. Patch Set 27: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26576 To unsubscribe, visit

Change in vdsm[master]: vm: per-attribute monitor response check

2014-06-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: per-attribute monitor response check .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9554/ :

Change in vdsm[master]: oop: Add an option to configure oop implementation

2014-06-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: oop: Add an option to configure oop implementation .. Patch Set 27: (1 comment) http://gerrit.ovirt.org/#/c/26576/27/vdsm/storage/outOfProcess.py File

Change in vdsm[master]: fencing: Introduce getHostLeaseStatus API

2014-06-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: fencing: Introduce getHostLeaseStatus API .. Patch Set 6: Verified+1 Changes: - Use string statuses to make results more readable - Fix incorrect status when host

Change in vdsm[master]: ioprocess implementation

2014-06-23 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: ioprocess implementation .. Patch Set 26: fix vdsm/storage/outOfProcess.py:310:18: E127 continuation line over-indented for visual indent -- To view, visit

Change in vdsm[master]: fencing: Introduce getHostLeaseStatus API

2014-06-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: fencing: Introduce getHostLeaseStatus API .. Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/28873/5/vdsm/storage/clusterlock.py File

Change in vdsm[master]: ioprocess implementation

2014-06-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: ioprocess implementation .. Patch Set 26: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26967 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: ioprocess implementation

2014-06-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: ioprocess implementation .. Patch Set 26: (except for the pep8, which I did not hunt) -- To view, visit http://gerrit.ovirt.org/26967 To unsubscribe, visit

Change in vdsm[master]: vm: spice support to agent file transfer disable

2014-06-23 Thread fromani
Francesco Romani has abandoned this change. Change subject: vm: spice support to agent file transfer disable .. Abandoned replaced by http://gerrit.ovirt.org/#/c/26917/ -- To view, visit http://gerrit.ovirt.org/23270 To

Change in vdsm[master]: Additional oop functionality

2014-06-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Additional oop functionality .. Patch Set 20: (2 comments) http://gerrit.ovirt.org/#/c/27641/20//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-06-23

Change in vdsm[master]: fencing: Introduce getHostLeaseStatus API

2014-06-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: fencing: Introduce getHostLeaseStatus API .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9556/ : SUCCESS

Change in vdsm[master]: vm: per-attribute monitor response check

2014-06-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: per-attribute monitor response check .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9555/ :

Change in vdsm[master]: Final separation of IOProcess and RFH

2014-06-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Final separation of IOProcess and RFH .. Patch Set 17: Code-Review+1 I do not understand why this could not be used as the base (and only) form of

Change in vdsm[master]: oop: Add an option to configure oop implementation

2014-06-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: oop: Add an option to configure oop implementation .. Patch Set 28: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26576 To unsubscribe, visit

Change in vdsm[master]: ioprocess implementation

2014-06-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: ioprocess implementation .. Patch Set 27: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26967 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: sampling: allow window=1 in AdvancedStatsFunction

2014-06-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sampling: allow window=1 in AdvancedStatsFunction .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9557/ :

Change in vdsm[master]: virt: stats: move VmStatsThread away from vm.py

2014-06-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: stats: move VmStatsThread away from vm.py .. Patch Set 13: Build Successful

Change in vdsm[master]: oop: Add an option to configure oop implementation

2014-06-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: oop: Add an option to configure oop implementation .. Patch Set 28: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9562/

Change in vdsm[master]: ioprocess implementation

2014-06-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ioprocess implementation .. Patch Set 27: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9563/ : SUCCESS

Change in vdsm[master]: virt: do not access devices directly outside Vm

2014-06-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: do not access devices directly outside Vm .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9559/

Change in vdsm[master]: Additional oop functionality

2014-06-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Additional oop functionality .. Patch Set 21: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9564/ : SUCCESS

Change in vdsm[master]: Final separation of IOProcess and RFH

2014-06-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Final separation of IOProcess and RFH .. Patch Set 18: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9565/ :

Change in vdsm[master]: vm: add direct import of advancedstats helpers

2014-06-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add direct import of advancedstats helpers .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9561/

Change in vdsm[master]: janitorial: move isVdsmImage into utils

2014-06-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: move isVdsmImage into utils .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9560/ : SUCCESS

Change in vdsm[master]: fencing: Introduce getHostLeaseStatus API

2014-06-23 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: fencing: Introduce getHostLeaseStatus API .. Patch Set 6: Code-Review+2 Ok but I want https://bugzilla.redhat.com/210 fixed asap. -- To view, visit

Change in vdsm[master]: janitorial: move isVdsmImage into utils

2014-06-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: janitorial: move isVdsmImage into utils .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28477 To unsubscribe, visit

Change in vdsm[master]: janitorial: move isVdsmImage into utils

2014-06-23 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: janitorial: move isVdsmImage into utils .. Patch Set 6: Code-Review-1 Before doing a proper code review... vdsm/virt/virtutils.py doesn't make much

Change in vdsm[master]: janitorial: move isVdsmImage into utils

2014-06-23 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: janitorial: move isVdsmImage into utils .. Patch Set 6: after reviewing, only the name is bad. -- To view, visit http://gerrit.ovirt.org/28477 To

Change in vdsm[master]: open: Change file() to open()

2014-06-23 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: open: Change file() to open() .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26776 To unsubscribe, visit

Change in vdsm[master]: virt: do not access devices directly outside Vm

2014-06-23 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: virt: do not access devices directly outside Vm .. Patch Set 6: Code-Review+1 Maybe the commit message could expand more on what benefits will this

Change in vdsm[master]: hook: noipspoof: consume libvirt's clean-traffic filter

2014-06-23 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: hook: noipspoof: consume libvirt's clean-traffic filter .. hook: noipspoof: consume libvirt's clean-traffic filter This hook converts all vnic filters of a VM

Change in vdsm[master]: sslutils: Document M2Crypto threading initialization

2014-06-23 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: sslutils: Document M2Crypto threading initialization .. sslutils: Document M2Crypto threading initialization As documented and painfully recognized long ago in,

Change in vdsm[master]: sslutils: Document M2Crypto threading initialization

2014-06-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sslutils: Document M2Crypto threading initialization .. Patch Set 1: Verified+1 Tests pass. -- To view, visit http://gerrit.ovirt.org/29104 To unsubscribe, visit

Change in vdsm[master]: sslutils: Document M2Crypto threading initialization

2014-06-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sslutils: Document M2Crypto threading initialization .. Patch Set 2: Fix url to the patch trying to remove this. -- To view, visit http://gerrit.ovirt.org/29104

Change in vdsm[master]: hook: noipspoof: consume libvirt's clean-traffic filter

2014-06-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: hook: noipspoof: consume libvirt's clean-traffic filter .. Patch Set 1: Build Failed

Change in vdsm[master]: sslutils: Document M2Crypto threading initialization

2014-06-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sslutils: Document M2Crypto threading initialization .. Patch Set 1: Build Successful

Change in vdsm[master]: sslutils: Document M2Crypto threading initialization

2014-06-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sslutils: Document M2Crypto threading initialization .. Patch Set 2: Build Successful

Change in vdsm[master]: sslutils: Document M2Crypto threading initialization

2014-06-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sslutils: Document M2Crypto threading initialization .. Patch Set 2: Grepping M2Crypto source reveal that threading.init() is not called automatically by other

Change in vdsm[master]: Extract the DOM to Drive name, alias and path logic to reusa...

2014-06-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Extract the DOM to Drive name, alias and path logic to reusable method .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/29059 To

Change in vdsm[master]: open: Change file() to open()

2014-06-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: open: Change file() to open() .. Patch Set 4: Code-Review-1 (1 comment) The patch contain unrelated and wrong change. This is not a replacement of file with

Change in vdsm[master]: open: Change file() to open()

2014-06-23 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: open: Change file() to open() .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/26776/4/lib/vdsm/libvirtconnection.py File

<    1   2