Nir Soffer has posted comments on this change.
Change subject: storage: Stop using tempnam in deleteImage
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38768
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Make sure the \0 is a last char in the buffer
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16756/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: events
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16764/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ceph: Support hotunplug of network disks
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16766/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: API: getVMList: compatibity with internal clients
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16771/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: API: getVMList: compatibity with internal clients
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16775/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16748/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: asyncore: dynamic tick support
..
Patch Set 15:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16750/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: asyncore: Move ssl buffer handling to dispatcher
..
Patch Set 14:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16754/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Remove JsonRpcClientPool
..
Patch Set 10:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16758/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: Stomp encoder\decoder improvements
..
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16762/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: vdscli: allow a connection with a configurable timeout
..
Patch Set 4:
The score is copied because you did not add any change (such as a unit test for
the new
oVirt Jenkins CI Server has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16769/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: API: getVMList: compatibity with internal clients
..
Patch Set 2: Code-Review+2
Wow, so no need in mom updates and conflicts!
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: storage: Add multipath-resize command line tool
..
Patch Set 7:
Example run with verbose logging:
# /usr/libexec/vdsm/multipath-resize -v
Nir Soffer has posted comments on this change.
Change subject: storage: Add multipath-resize command line tool
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/38467/7/vdsm/storage/multipath-resize
File
automat...@ovirt.org has posted comments on this change.
Change subject: storage: Add multipath-resize command line tool
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Nir Soffer has posted comments on this change.
Change subject: storage: Add multipath-resize command line tool
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/38467
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: storage: Add multipath-resize command line tool
..
Patch Set 7:
Changes in this version:
- Address Dan concern about exotic characters in lun names by using
oVirt Jenkins CI Server has posted comments on this change.
Change subject: storage: Add multipath-resize command line tool
..
Patch Set 7:
Build Failed
Daniel Erez has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 4: Verified+1 Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38766
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: ceph: Support hotunplug of network disks
..
Patch Set 3: Verified+1 Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38804
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: hsm: Report info needed for refreshing devices
..
Patch Set 2:
Freddy, can you verify this?
--
To view, visit https://gerrit.ovirt.org/38675
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: use response.error() with custom message
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16744/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: remove unwanted 'response' aliasing
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16745/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ceph: Support hotunplug of network disks
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16746/ : SUCCESS
automat...@ovirt.org has posted comments on this change.
Change subject: Introduce storage domain version 4
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has uploaded a new change for review.
Change subject: storage: Stop using tempnam in deleteImage
..
storage: Stop using tempnam in deleteImage
tempnam does not guarantee that the entire requested prefix is part of
automat...@ovirt.org has posted comments on this change.
Change subject: hsm: Add refresh device verb
..
Patch Set 4:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#609689::ERROR, private bug
* Check Public
automat...@ovirt.org has posted comments on this change.
Change subject: network: models: tag non-VDSM devices used by VDSM
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: Adds new verb to setup geo-rep mount broker.
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: acquire image ns in copy task
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Darshan N has posted comments on this change.
Change subject: gluster: Patch adds geo-replication create and delete verbs.
..
Patch Set 29: Verified+1
--
To view, visit https://gerrit.ovirt.org/17644
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38679
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: frolland 2
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16711/ : SUCCESS
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: models: tag non-VDSM devices used by VDSM
..
network: models: tag non-VDSM devices used by VDSM
When we setup network over pre-existing
automat...@ovirt.org has posted comments on this change.
Change subject: SDM: add the copyVolumeData command
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: SDM: removeVolume command and volume garbage collection
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
automat...@ovirt.org has posted comments on this change.
Change subject: storage: Stop using tempnam in deleteImage
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Adam Litke has uploaded a new change for review.
Change subject: acquire image ns in copy task
..
acquire image ns in copy task
Change-Id: I93aa381fb6c17c3a71f832f2dd51975a250159f7
Signed-off-by: Adam Litke ali...@redhat.com
automat...@ovirt.org has posted comments on this change.
Change subject: storage: export volume lease state in getVolumeInfo
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: clusterLock: Make inquire retval consistent
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Petr Horáček has posted comments on this change.
Change subject: network: models: tag non-VDSM devices used by VDSM
..
Patch Set 1: Verified+1
Passed network's functional tests except unrelated ChangedOperstate errors.
Passed
Shahar Havivi has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
..
Patch Set 10:
(38 comments)
https://gerrit.ovirt.org/#/c/37509/10/vdsm/v2v.py
File vdsm/v2v.py:
Line
Ido Barkan has posted comments on this change.
Change subject: split network restoration from vdsmd.service
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/29441/13/vdsm/vdsm-restore-net-config
File
Francesco Romani has posted comments on this change.
Change subject: lib: Add vdsm.concurrent library
..
Patch Set 2: Code-Review+1
(1 comment)
I'm OK to give this code a better spotlight.
automat...@ovirt.org has posted comments on this change.
Change subject: init: fix network service status checking
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: init: fix network service status checking
..
init: fix network service status checking
In init file, we check if network service is running by its
automat...@ovirt.org has posted comments on this change.
Change subject: hsm: Add refresh device verb
..
Patch Set 3:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#609689::ERROR, private bug
* Check Public
automat...@ovirt.org has posted comments on this change.
Change subject: network: models: tag non-VDSM devices used by VDSM
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Dan Kenigsberg has posted comments on this change.
Change subject: network: models: tag non-VDSM devices used by VDSM
..
Patch Set 6: Code-Review+2
Thanks!!
--
To view, visit https://gerrit.ovirt.org/38572
To unsubscribe,
automat...@ovirt.org has posted comments on this change.
Change subject: Network: Flush all configurators before restoring networks
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
automat...@ovirt.org has posted comments on this change.
Change subject: split network restoration from vdsmd.service
..
Patch Set 15:
* Update tracker::#1187244::OK
* Check Bug-Url::OK
* Check Public Bug::#1187244::OK, public
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: Patch adds geo-replication create and delete verbs.
..
Patch Set 29:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Federico Simoncelli has posted comments on this change.
Change subject: storage: Remove validateStorageServerConnection
..
Patch Set 2: Code-Review+1
It seems ok (engine side was removed a long time ago), +1 waiting for Dan as
oVirt Jenkins CI Server has posted comments on this change.
Change subject: network: models: tag non-VDSM devices used by VDSM
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16713/ :
Petr Horáček has posted comments on this change.
Change subject: network: models: tag non-VDSM devices used by VDSM
..
Patch Set 6: Verified+1
Passed network's functional tests except three occurrences of ChangingOperstate
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: Adds new verbs to setup gluster geo-replication.
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Ido Barkan has uploaded a new change for review.
Change subject: Network: Flush all configurators before restoring networks
..
Network: Flush all configurators before restoring networks
Right now, when there are many networks
automat...@ovirt.org has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/38771
to review the following change.
Change subject: network: models: tag non-VDSM devices used by VDSM
..
network: models:
Federico Simoncelli has posted comments on this change.
Change subject: utils: add CommandStream class
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/33909/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 362:
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
oVirt Jenkins CI Server has posted comments on this change.
Change subject: frolland
..
Patch Set 2: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16712/ : UNSTABLE
Bala.FA has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 24: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/35498/24/vdsm/gluster/storagedev.py
File
automat...@ovirt.org has posted comments on this change.
Change subject: network: models: tag non-VDSM devices used by VDSM
..
Patch Set 1:
* Update tracker::#1154399::OK
* Check Bug-Url::OK
* Check Public Bug::#1154399::OK,
Dan Kenigsberg has posted comments on this change.
Change subject: no need for quotes in supervdsmd service file
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/38744
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: no need to call setupNetworks with empty argument during
network restoration
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38745
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: Move generic reactor functionality
..
Patch Set 15: Verified+1
Rebased and added docstring in betterAsyncore as requested. Copying verify flag
due
oVirt Jenkins CI Server has posted comments on this change.
Change subject: network: tests: restoration of bridged network over external
vlan bond
..
Patch Set 2:
Build Successful
Francesco Romani has posted comments on this change.
Change subject: lib: Simplify and generalize concurrent.tmap()
..
Patch Set 2: Code-Review+1
(1 comment)
This patch makes the code nicer. But I'm not sure about the longer
automat...@ovirt.org has posted comments on this change.
Change subject: frolland 2
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hsm: Add refresh device verb
..
Patch Set 2: Code-Review-1 Verified-1
Build Unstable
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16708/ :
automat...@ovirt.org has posted comments on this change.
Change subject: network: models: tag non-VDSM devices used by VDSM
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Francesco Romani has posted comments on this change.
Change subject: storage: Add multipath-resize command line tool
..
Patch Set 6: Code-Review+1
(2 comments)
seems fine, minor possible improvements inside
automat...@ovirt.org has posted comments on this change.
Change subject: network: models: tag non-VDSM devices used by VDSM
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Francesco Romani has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/38679/4/vdsm/API.py
File vdsm/API.py:
Line 1385:
Fred Rolland has posted comments on this change.
Change subject: hsm: Add refresh device verb
..
Patch Set 1:
(29 comments)
https://gerrit.ovirt.org/#/c/38754/1//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2015-03-15
Darshan N has posted comments on this change.
Change subject: gluster: Adds new verbs to setup gluster geo-replication.
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/38228
To unsubscribe, visit
Shubhendu Tripathi has posted comments on this change.
Change subject: gluster: modified parsing logic in snapshot config list.
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38758
To unsubscribe,
automat...@ovirt.org has posted comments on this change.
Change subject: network: tests: restoration of bridged network over external
vlan bond
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN,
Petr Horáček has posted comments on this change.
Change subject: network: tests: restoration of bridged network over external
vlan bond
..
Patch Set 2:
explodes, need fix
--
To view, visit https://gerrit.ovirt.org/38572
To
automat...@ovirt.org has posted comments on this change.
Change subject: frolland
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is
Petr Horáček has posted comments on this change.
Change subject: network: persistence: skip bonds owned and used by vdsm
..
Patch Set 3: Verified+1
Passed network functional tests, passed unit net* tests (except
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: Allow to use 'serial' or 'virtio' type consoles
..
Patch Set 12:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16705/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: asyncore: Move generic reactor functionality
..
Patch Set 15:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16706/ : SUCCESS
automat...@ovirt.org has posted comments on this change.
Change subject: hsm: Add refresh device verb
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#609689::ERROR, private bug
* Check Public
automat...@ovirt.org has posted comments on this change.
Change subject: frolland
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is
Francesco Romani has posted comments on this change.
Change subject: asyncore: Move generic reactor functionality
..
Patch Set 15: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/37055
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: network: models: tag non-VDSM devices used by VDSM
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: split network restoration from vdsmd.service
..
Patch Set 14:
Build Failed
Dan Kenigsberg has posted comments on this change.
Change subject: network: models: tag non-VDSM devices used by VDSM
..
Patch Set 5: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/38572
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: network: models: tag non-VDSM devices used by VDSM
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/38572/4/tests/functional/networkTests.py
File
Liron Aravot has posted comments on this change.
Change subject: misc: Support zero-time in getReadDelay()
..
Patch Set 2: Code-Review+1
I don't see how returning zero can affect the engine.
I haven't tested/looked into
Nir Soffer has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/37509/10/vdsm/v2v.py
File vdsm/v2v.py:
Line 394:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: frolland
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16710/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: modified parsing logic in snapshot config list.
..
Patch Set 1:
Build Successful
Michal Skrivanek has posted comments on this change.
Change subject: virt: Only filter guest agent data, only on XMLRPC
..
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/36949/6/vdsm/virt/guestagent.py
File
1 - 100 of 282 matches
Mail list logo