Change in vdsm[master]: daemon: ignore cpu affinity on single processor

Francesco Romani has posted comments on this change. Change subject: daemon: ignore cpu affinity on single processor .. Patch Set 6: Verified+1 trivial change since last verification, copied score -- To view, visit

Change in vdsm[master]: tests: Test both ssl and m2c

Piotr Kliczewski has posted comments on this change. Change subject: tests: Test both ssl and m2c .. Patch Set 3: Verified+1 Verified locally by running the tests with and without m2crypto available on the system. -- To

Change in vdsm[master]: migration: added support for convergance schedule

Tomas Jelinek has posted comments on this change. Change subject: migration: added support for convergance schedule .. Patch Set 8: - added the support for the init part - fixed some issues - not tested too deeply but seems to

Change in vdsm[master]: stomp: Drain pending bytes from ssl socket

Francesco Romani has posted comments on this change. Change subject: stomp: Drain pending bytes from ssl socket .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48803 To unsubscribe, visit

Change in vdsm[master]: virt: vm: Update time on VM after resume

Milan Zamazal has uploaded a new change for review. Change subject: virt: vm: Update time on VM after resume .. virt: vm: Update time on VM after resume When a VM is resumed from suspension and/or migrated, its clock continues

Change in vdsm[master]: virt: vm: Update time on VM after resume

Milan Zamazal has posted comments on this change. Change subject: virt: vm: Update time on VM after resume .. Patch Set 1: (5 comments) https://gerrit.ovirt.org/#/c/48860/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1200:

Change in vdsm[master]: virt: vm: Update time on VM after resume

Francesco Romani has posted comments on this change. Change subject: virt: vm: Update time on VM after resume .. Patch Set 1: Code-Review-1 (5 comments) few questions inside, -1 for visibility

Change in vdsm[master]: virt: vm: Update time on VM after resume

gerrit-hooks has posted comments on this change. Change subject: virt: vm: Update time on VM after resume .. Patch Set 1: * #1156194::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1156194::OK, public bug * Check

Change in vdsm[master]: migration: added support for convergance schedule

Francesco Romani has posted comments on this change. Change subject: migration: added support for convergance schedule .. Patch Set 8: (2 comments) initial comments, deeper review later

Change in vdsm[master]: migration: Added support for setting the convergenceSchedule

Francesco Romani has posted comments on this change. Change subject: migration: Added support for setting the convergenceSchedule .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/47734 To unsubscribe,

Change in vdsm[master]: virt: vm: Update time on VM after resume

gerrit-hooks has posted comments on this change. Change subject: virt: vm: Update time on VM after resume .. Patch Set 2: * #1156194::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1156194::OK, public bug * Check

Change in vdsm[master]: tests: v2v: add test for commit f8127d8

Nir Soffer has posted comments on this change. Change subject: tests: v2v: add test for commit f8127d8 .. Patch Set 8: Code-Review+2 Waiting for another reviewer. -- To view, visit https://gerrit.ovirt.org/47367 To

Change in vdsm[master]: stomp: Drain pending bytes from ssl socket

Piotr Kliczewski has posted comments on this change. Change subject: stomp: Drain pending bytes from ssl socket .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48803 To unsubscribe, visit

Change in vdsm[master]: tests: Test both ssl and m2c

gerrit-hooks has posted comments on this change. Change subject: tests: Test both ssl and m2c .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: v2v: use namedtuple and not plain tuples

Nir Soffer has posted comments on this change. Change subject: tests: v2v: use namedtuple and not plain tuples .. Patch Set 1: Thanks, much easier to review now. -- To view, visit https://gerrit.ovirt.org/48851 To

Change in vdsm[master]: tests: v2v: simplify setup of test

Nir Soffer has posted comments on this change. Change subject: tests: v2v: simplify setup of test .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48852 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: netinfo: report DHCP from configuration to avoid confusion a...

Petr Horáček has posted comments on this change. Change subject: netinfo: report DHCP from configuration to avoid confusion after stopping DHCP .. Patch Set 2: Code-Review-1 (1 comment)

Change in vdsm[master]: tests: v2v: use namedtuple and not plain tuples

Nir Soffer has posted comments on this change. Change subject: tests: v2v: use namedtuple and not plain tuples .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48851 To unsubscribe, visit

Change in vdsm[master]: tests: v2v: let the fake use VMs, not specs

Nir Soffer has posted comments on this change. Change subject: tests: v2v: let the fake use VMs, not specs .. Patch Set 1: Code-Review+2 Waiting for another reviewer. -- To view, visit https://gerrit.ovirt.org/48854 To

Change in vdsm[master]: misc: remove rotateFiles

Nir Soffer has submitted this change and it was merged. Change subject: misc: remove rotateFiles .. misc: remove rotateFiles Since commit 8bc23a66b409 (Make misc.py conform pep8 and other minor cleanup) in March 2012,

Change in vdsm[master]: misc: remove rotateFiles

gerrit-hooks has posted comments on this change. Change subject: misc: remove rotateFiles .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: migration: Added support for setting the convergenceSchedule

gerrit-hooks has posted comments on this change. Change subject: migration: Added support for setting the convergenceSchedule .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: migration: added support for convergance schedule

gerrit-hooks has posted comments on this change. Change subject: migration: added support for convergance schedule .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: daemon: ignore cpu affinity on single processor

Nir Soffer has posted comments on this change. Change subject: daemon: ignore cpu affinity on single processor .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48619 To unsubscribe, visit

Change in vdsm[master]: build: Introduce --enable-gluster-mgmt option

gerrit-hooks has posted comments on this change. Change subject: build: Introduce --enable-gluster-mgmt option .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view,

Change in vdsm[master]: tests: v2v: use namedtuple and not plain tuples

Nir Soffer has posted comments on this change. Change subject: tests: v2v: use namedtuple and not plain tuples .. Patch Set 1: Waiting for another reviewer. -- To view, visit https://gerrit.ovirt.org/48851 To unsubscribe,

Change in vdsm[master]: tests: v2v: extract _assertVmDisksMatchSpec helper

Nir Soffer has posted comments on this change. Change subject: tests: v2v: extract _assertVmDisksMatchSpec helper .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48853 To unsubscribe, visit

Change in vdsm[master]: tests: v2v: extract _assertVmDisksMatchSpec helper

Nir Soffer has posted comments on this change. Change subject: tests: v2v: extract _assertVmDisksMatchSpec helper .. Patch Set 1: Waiting for another reviewer. -- To view, visit https://gerrit.ovirt.org/48853 To unsubscribe,

Change in vdsm[master]: tests: v2v: simplify setup of test

Nir Soffer has posted comments on this change. Change subject: tests: v2v: simplify setup of test .. Patch Set 1: Waiting for another reviewer. -- To view, visit https://gerrit.ovirt.org/48852 To unsubscribe, visit

Change in vdsm[master]: daemon: ignore cpu affinity on single processor

Nir Soffer has posted comments on this change. Change subject: daemon: ignore cpu affinity on single processor .. Patch Set 6: Waiting for Dan -- To view, visit https://gerrit.ovirt.org/48619 To unsubscribe, visit

Change in vdsm[master]: build: Introduce --enable-gluster-mgmt option

Nir Soffer has submitted this change and it was merged. Change subject: build: Introduce --enable-gluster-mgmt option .. build: Introduce --enable-gluster-mgmt option Previously building gluster package and building for RHEV

Change in vdsm[master]: net: ifup ignores invalid gateway settings

Petr Horáček has posted comments on this change. Change subject: net: ifup ignores invalid gateway settings .. Patch Set 1: I have some troubles installing vdsm on el6, so there is the first part of reportd: EL7, Vdsm

Change in vdsm[master]: network: api: _handleBondings refactoring

Petr Horáček has posted comments on this change. Change subject: network: api: _handleBondings refactoring .. Patch Set 1: Test test test 1. test 2. test - test - test test test -- To view, visit

Change in vdsm[master]: periodic: explicitely track domain availability

Francesco Romani has abandoned this change. Change subject: periodic: explicitely track domain availability .. Abandoned it seems we'll not need this soon,abandoning for now -- To view, visit https://gerrit.ovirt.org/47246

Change in vdsm[master]: periodic: make ttl factors tunable

Francesco Romani has abandoned this change. Change subject: periodic: make ttl factors tunable .. Abandoned depends on parent patch. No real need now. -- To view, visit https://gerrit.ovirt.org/47894 To unsubscribe, visit

Change in vdsm[master]: daemon: ignore cpu affinity on single processor

Dan Kenigsberg has submitted this change and it was merged. Change subject: daemon: ignore cpu affinity on single processor .. daemon: ignore cpu affinity on single processor If VDSM runs on single processor hosts (E.g. VMs)

Change in vdsm[master]: daemon: ignore cpu affinity on single processor

gerrit-hooks has posted comments on this change. Change subject: daemon: ignore cpu affinity on single processor .. Patch Set 7: * #1279431::Update tracker: OK * Set MODIFIED::bug 1279431#1279431OK -- To view, visit

Change in vdsm[master]: mkimage: set uid/gid right before mkisofs

gerrit-hooks has posted comments on this change. Change subject: mkimage: set uid/gid right before mkisofs .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/48539 To

Change in vdsm[master]: mkimage: set uid/gid right before mkisofs

Francesco Romani has abandoned this change. Change subject: mkimage: set uid/gid right before mkisofs .. Abandoned wrong approach, see inline comments. -- To view, visit https://gerrit.ovirt.org/48539 To unsubscribe, visit

Change in vdsm[master]: mkimage: check image attributes after creation

Francesco Romani has posted comments on this change. Change subject: mkimage: check image attributes after creation .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/48540/2/vdsm/mkimage.py File vdsm/mkimage.py: Line

Change in vdsm[master]: periodic: add __str__ methods

Nir Soffer has posted comments on this change. Change subject: periodic: add __str__ methods .. Patch Set 8: (2 comments) Merge too fast :-) https://gerrit.ovirt.org/#/c/48193/8/vdsm/virt/periodic.py File

Change in vdsm[master]: periodic: add __str__ methods

Dan Kenigsberg has submitted this change and it was merged. Change subject: periodic: add __str__ methods .. periodic: add __str__ methods We want to make as easy as possible to debug thread leaks from executor, so we make the

Change in vdsm[master]: mkimage: check image attributes after creation

Nir Soffer has posted comments on this change. Change subject: mkimage: check image attributes after creation .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48540 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: netinfo: report DHCP from configuration to avoid confusion a...

Ondřej Svoboda has posted comments on this change. Change subject: netinfo: report DHCP from configuration to avoid confusion after stopping DHCP .. Patch Set 2: (1 comment) I had readability concerns.

Change in vdsm[master]: stomp: Drain pending bytes from ssl socket

Nir Soffer has posted comments on this change. Change subject: stomp: Drain pending bytes from ssl socket .. Patch Set 4: Waiting for Dan. -- To view, visit https://gerrit.ovirt.org/48803 To unsubscribe, visit

Change in vdsm[master]: periodic: explicitely track domain availability

gerrit-hooks has posted comments on this change. Change subject: periodic: explicitely track domain availability .. Patch Set 13: * #1250839::Update tracker: OK -- To view, visit https://gerrit.ovirt.org/47246 To

Change in vdsm[master]: periodic: make ttl factors tunable

gerrit-hooks has posted comments on this change. Change subject: periodic: make ttl factors tunable .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/47894 To unsubscribe,

Change in vdsm[master]: vmstats: rewrite disk stats to handle missing data

gerrit-hooks has posted comments on this change. Change subject: vmstats: rewrite disk stats to handle missing data .. Patch Set 3: * #1281337::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1281337::OK, public

Change in vdsm[master]: mkimage: setup right permissions before mkisofs

Nir Soffer has posted comments on this change. Change subject: mkimage: setup right permissions before mkisofs .. Patch Set 3: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/48538/3/vdsm/mkimage.py File

Change in vdsm[master]: periodic: add __str__ methods

Francesco Romani has posted comments on this change. Change subject: periodic: add __str__ methods .. Patch Set 8: Nir, Dan: I think this patch is ready -- To view, visit https://gerrit.ovirt.org/48193 To unsubscribe, visit

Change in vdsm[master]: periodic: add __str__ methods

Dan Kenigsberg has posted comments on this change. Change subject: periodic: add __str__ methods .. Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48193 To unsubscribe, visit

Change in vdsm[master]: periodic: add __str__ methods

gerrit-hooks has posted comments on this change. Change subject: periodic: add __str__ methods .. Patch Set 9: * #1250839::Update tracker: OK * Set MODIFIED::bug 1250839#1250839IGNORE, not all related patches are

Change in vdsm[master]: vmstats: reformat to make the code nicer

gerrit-hooks has posted comments on this change. Change subject: vmstats: reformat to make the code nicer .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: periodic: more cautious return to fast path

Francesco Romani has abandoned this change. Change subject: periodic: more cautious return to fast path .. Abandoned no real need for now -- To view, visit https://gerrit.ovirt.org/48190 To unsubscribe, visit

Change in vdsm[master]: periodic: more cautious return to fast path

gerrit-hooks has posted comments on this change. Change subject: periodic: more cautious return to fast path .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/48190 To

Change in vdsm[master]: mkimage: set uid/gid right before mkisofs

Francesco Romani has posted comments on this change. Change subject: mkimage: set uid/gid right before mkisofs .. Patch Set 2: Verified-1 ok, then it is done already in _commonCleanFs, so no need for this patch -- To view,

Change in vdsm[master]: mkimage: setup right permissions before mkisofs

gerrit-hooks has posted comments on this change. Change subject: mkimage: setup right permissions before mkisofs .. Patch Set 3: * #1278414::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1278414::OK, public bug *

Change in vdsm[master]: stomp: Drain pending bytes from ssl socket

Dan Kenigsberg has submitted this change and it was merged. Change subject: stomp: Drain pending bytes from ssl socket .. stomp: Drain pending bytes from ssl socket Since commit b2da4effe01f (asyncore: use default handing of

Change in vdsm[master]: stomp: Drain pending bytes from ssl socket

gerrit-hooks has posted comments on this change. Change subject: stomp: Drain pending bytes from ssl socket .. Patch Set 5: * #1274670::Update tracker: OK * Set MODIFIED::bug 1274670#1274670FAILED, -- To view, visit

Change in vdsm[master]: mkimage: check image attributes after creation

gerrit-hooks has posted comments on this change. Change subject: mkimage: check image attributes after creation .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: debuging: Use __repr__ instead of __str__

gerrit-hooks has posted comments on this change. Change subject: debuging: Use __repr__ instead of __str__ .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: debuging: Use __repr__ instead of __str__

Nir Soffer has uploaded a new change for review. Change subject: debuging: Use __repr__ instead of __str__ .. debuging: Use __repr__ instead of __str__ Recently we are implementing __str__ for objects, for improved logging:

Change in vdsm[master]: debuging: Use __repr__ instead of __str__

Nir Soffer has posted comments on this change. Change subject: debuging: Use __repr__ instead of __str__ .. Patch Set 1: Continuous-Integration+1 CI failure is bogus, both tests and rpm installation were ok. -- To view,

Change in vdsm[master]: exception: Gather exceptions in vdsm.exception

Nir Soffer has uploaded a new change for review. Change subject: exception: Gather exceptions in vdsm.exception .. exception: Gather exceptions in vdsm.exception Move GeneralException and ActionStopped from vdsm.utils to

Change in vdsm[master]: exception: Inherit from VdsmException

gerrit-hooks has posted comments on this change. Change subject: exception: Inherit from VdsmException .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: exception: Inherit from VdsmException

Nir Soffer has uploaded a new change for review. Change subject: exception: Inherit from VdsmException .. exception: Inherit from VdsmException All exceptions used by vdsm API inherit now from VdsmException, removing duplicate

Change in vdsm[master]: tests: Diskable flaky test

Nir Soffer has uploaded a new change for review. Change subject: tests: Diskable flaky test .. tests: Diskable flaky test testGetBondingOptions fails randomly in the CI for more than a week. Mark it as broken tests until the

Change in vdsm[master]: exception: Inherit from VdsmException

gerrit-hooks has posted comments on this change. Change subject: exception: Inherit from VdsmException .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: exception: Gather exceptions in vdsm.exception

gerrit-hooks has posted comments on this change. Change subject: exception: Gather exceptions in vdsm.exception .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: tests: Disable flaky test

Jenkins CI has posted comments on this change. Change subject: tests: Disable flaky test .. Patch Set 2: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from patch 1 -- To view, visit

Change in vdsm[master]: exception: Gather exceptions in vdsm.exception

gerrit-hooks has posted comments on this change. Change subject: exception: Gather exceptions in vdsm.exception .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: tests: Diskable flaky test

gerrit-hooks has posted comments on this change. Change subject: tests: Diskable flaky test .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: exception: Add an exception for vdsm.define errors

gerrit-hooks has posted comments on this change. Change subject: exception: Add an exception for vdsm.define errors .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: gluster: Unbreak gluster management

gerrit-hooks has posted comments on this change. Change subject: gluster: Unbreak gluster management .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: gluster: Unbreak gluster management

Nir Soffer has uploaded a new change for review. Change subject: gluster: Unbreak gluster management .. gluster: Unbreak gluster management In commit 61d7427fc1 (build: Introduce --enable-gluster-mgmt option) we renamed

Change in vdsm[master]: network: Use new concurrent.thread() utility

Nir Soffer has posted comments on this change. Change subject: network: Use new concurrent.thread() utility .. Patch Set 3: Dan? -- To view, visit https://gerrit.ovirt.org/45553 To unsubscribe, visit

Change in vdsm[master]: exception: Gather exceptions in vdsm.exception

Nir Soffer has posted comments on this change. Change subject: exception: Gather exceptions in vdsm.exception .. Patch Set 2: Continuous-Integration+1 CI failure is bogus again. -- To view, visit

Change in vdsm[master]: exception: Add an exception for vdsm.define errors

gerrit-hooks has posted comments on this change. Change subject: exception: Add an exception for vdsm.define errors .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: exception: Add an exception for vdsm.define errors

gerrit-hooks has posted comments on this change. Change subject: exception: Add an exception for vdsm.define errors .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: exception: Add an exception for vdsm.define errors

Nir Soffer has uploaded a new change for review. Change subject: exception: Add an exception for vdsm.define errors .. exception: Add an exception for vdsm.define errors Add an exception class for each error in vdsm.define.

Change in vdsm[master]: exception: Add an exception for vdsm.define errors

Nir Soffer has posted comments on this change. Change subject: exception: Add an exception for vdsm.define errors .. Patch Set 3: CI failure is real :-) -- To view, visit https://gerrit.ovirt.org/48871 To unsubscribe, visit

Change in vdsm[master]: gluster: Unbreak gluster management

Nir Soffer has posted comments on this change. Change subject: gluster: Unbreak gluster management .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/48872 To unsubscribe, visit

Change in vdsm[master]: exception: Inherit from VdsmException

Nir Soffer has posted comments on this change. Change subject: exception: Inherit from VdsmException .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/48869 To unsubscribe, visit

Change in vdsm[master]: tests: Test both ssl and m2c

Piotr Kliczewski has posted comments on this change. Change subject: tests: Test both ssl and m2c .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/48823/2/tests/stompTests.py File tests/stompTests.py: Line 59:

Change in vdsm[master]: tests: v2v: add test for commit f8127d8

Francesco Romani has posted comments on this change. Change subject: tests: v2v: add test for commit f8127d8 .. Patch Set 7: right, this is too messy. Splitting. -- To view, visit https://gerrit.ovirt.org/47367 To

Change in vdsm[master]: tests: v2v: extract _assertVmDisksMatchSpec helper

Francesco Romani has uploaded a new change for review. Change subject: tests: v2v: extract _assertVmDisksMatchSpec helper .. tests: v2v: extract _assertVmDisksMatchSpec helper Future tests in the patch series want to test

Change in vdsm[master]: tests: v2v: let the fake use VMs, not specs

Francesco Romani has uploaded a new change for review. Change subject: tests: v2v: let the fake use VMs, not specs .. tests: v2v: let the fake use VMs, not specs Simplify the faking in v2vtests in two ways: - make the vm specs

Change in vdsm[master]: tests: v2v: let the fake use VMs, not specs

gerrit-hooks has posted comments on this change. Change subject: tests: v2v: let the fake use VMs, not specs .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: tests: v2v: add test for commit f8127d8

gerrit-hooks has posted comments on this change. Change subject: tests: v2v: add test for commit f8127d8 .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: tests: v2v: use namedtuple and not plain tuples

Francesco Romani has posted comments on this change. Change subject: tests: v2v: use namedtuple and not plain tuples .. Patch Set 1: Verified+1 trivial patch, verified by the tests -- To view, visit

Change in vdsm[master]: tests: v2v: let the fake use VMs, not specs

Francesco Romani has posted comments on this change. Change subject: tests: v2v: let the fake use VMs, not specs .. Patch Set 1: Verified+1 verified by the tests -- To view, visit https://gerrit.ovirt.org/48854 To

Change in vdsm[master]: tests: v2v: simplify setup of test

Francesco Romani has uploaded a new change for review. Change subject: tests: v2v: simplify setup of test .. tests: v2v: simplify setup of test Simplify the setup of fakes needed for one test. Makes the code a tiny bit nicer,

Change in vdsm[master]: tests: v2v: use namedtuple and not plain tuples

Francesco Romani has uploaded a new change for review. Change subject: tests: v2v: use namedtuple and not plain tuples .. tests: v2v: use namedtuple and not plain tuples Make access using names (foo.bar) is nicer than using

Change in vdsm[master]: tests: v2v: extract _assertVmDisksMatchSpec helper

Francesco Romani has posted comments on this change. Change subject: tests: v2v: extract _assertVmDisksMatchSpec helper .. Patch Set 1: Verified+1 verified by the tests -- To view, visit https://gerrit.ovirt.org/48853 To

Change in vdsm[master]: tests: v2v: use namedtuple and not plain tuples

gerrit-hooks has posted comments on this change. Change subject: tests: v2v: use namedtuple and not plain tuples .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: tests: v2v: extract _assertVmDisksMatchSpec helper

gerrit-hooks has posted comments on this change. Change subject: tests: v2v: extract _assertVmDisksMatchSpec helper .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: tests: v2v: simplify setup of test

gerrit-hooks has posted comments on this change. Change subject: tests: v2v: simplify setup of test .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: v2v: add test for commit f8127d8

Francesco Romani has posted comments on this change. Change subject: tests: v2v: add test for commit f8127d8 .. Patch Set 8: Verified+1 verified by the tests -- To view, visit https://gerrit.ovirt.org/47367 To unsubscribe,

Change in vdsm[master]: tests: v2v: simplify setup of test

Francesco Romani has posted comments on this change. Change subject: tests: v2v: simplify setup of test .. Patch Set 1: Verified+1 verified by the tests -- To view, visit https://gerrit.ovirt.org/48852 To unsubscribe, visit

Change in vdsm[master]: tests: v2v: add test for commit f8127d8

Francesco Romani has posted comments on this change. Change subject: tests: v2v: add test for commit f8127d8 .. Patch Set 8: Split the messy patch in five smaller pieces. Please check 48851-48854 -- To view, visit

  1   2   >