Change in vdsm[master]: Makefile: use tox to run make pep8 and pyflakes

2016-04-22 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Makefile: use tox to run make pep8 and pyflakes .. Patch Set 7: (3 comments) https://gerrit.ovirt.org/#/c/49952/7/automation/check-patch.packages.el7 File

Change in vdsm[master]: tests: volume_artifacts: validate FileVolumeArtifacts metadata

2016-04-22 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: volume_artifacts: validate FileVolumeArtifacts metadata .. Patch Set 6: Please check my comments on version 2:

Change in vdsm[master]: qemuimg.py: Don't check -T support

2016-04-22 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: qemuimg.py: Don't check -T support .. Patch Set 1: Code-Review+1 Looks good, waiting for another review. -- To view, visit https://gerrit.ovirt.org/55926 To

Change in vdsm[master]: qemuimg.py: Don't check compat support

2016-04-22 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: qemuimg.py: Don't check compat support .. Patch Set 1: Code-Review+1 Looks good, waiting for rebase and another review. -- To view, visit

Change in vdsm[master]: mount: Add mounts monitor

2016-04-22 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: mount: Add mounts monitor .. Patch Set 3: Verified+1 Verified using the tests (when running as root). -- To view, visit https://gerrit.ovirt.org/56516 To

Change in vdsm[master]: mount: Remove EL 6 /etc/mtab support

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: mount: Remove EL 6 /etc/mtab support .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: mount: Remove EL 6 mtab support

2016-04-22 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: mount: Remove EL 6 mtab support .. mount: Remove EL 6 mtab support On EL6 we used /etc/mtab to resolve loop devices backing image. On EL7 (and Fedora) /etc/mtab

Change in vdsm[master]: mount: Remove EL 6 mtab support

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: mount: Remove EL 6 mtab support .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: mount: Streamline backing file path building

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: mount: Streamline backing file path building .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: mount: Streamline backing file path building

2016-04-22 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: mount: Streamline backing file path building .. mount: Streamline backing file path building Use os.path.join to create the path instead of joining strings,

Change in vdsm[master]: mount: Remove EL 6 /etc/mtab support

2016-04-22 Thread Jenkins CI
Jenkins CI has posted comments on this change. Change subject: mount: Remove EL 6 /etc/mtab support .. Patch Set 2: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from patch 1 -- To

Change in vdsm[master]: mount: Add mounts monitor

2016-04-22 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: mount: Add mounts monitor .. mount: Add mounts monitor Since kernel version 2.6.15, /proc/mounts is pollable: after opening the file for reading, a change in this

Change in vdsm[master]: mount: Add mounts monitor

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: mount: Add mounts monitor .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: mount: Add mounts monitor

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: mount: Add mounts monitor .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: mount: Add mounts monitor

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: mount: Add mounts monitor .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: network: supervdsm: configure container networks

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: network: supervdsm: configure container networks .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: containers: optional container support

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: containers: optional container support .. Patch Set 20: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: HACK: virt: override vm type from custom property

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: HACK: virt: override vm type from custom property .. Patch Set 16: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: supervdsm: expose systemd utilities

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: supervdsm: expose systemd utilities .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: virt: utils: add is_kvm helper

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: utils: add is_kvm helper .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: supervdsm: expose systemd utilities

2016-04-22 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: supervdsm: expose systemd utilities .. supervdsm: expose systemd utilities Instead of adding sudo permissions to allow to run those commands, we expose them

Change in vdsm[master]: containers: always add emulator to XML

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: containers: always add emulator to XML .. Patch Set 20: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: hook: add imagerepo feed containers

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hook: add imagerepo feed containers .. Patch Set 16: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: contrib: schema converter

2016-04-22 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: contrib: schema converter .. Patch Set 35: (9 comments) https://gerrit.ovirt.org/#/c/52864/35/lib/api/json_schema.py File lib/api/json_schema.py: Line 1:

Change in vdsm[master]: hostdev: add is_assignable flag

2016-04-22 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: hostdev: add is_assignable flag .. Patch Set 3: (1 comment) I can't judge the technical side, but codewise fine, except for wondering about one style issue.

Change in vdsm[master]: bridge: usage of yaml schema

2016-04-22 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: bridge: usage of yaml schema .. Patch Set 18: (2 comments) https://gerrit.ovirt.org/#/c/54528/18/lib/api/schemaapi.py File lib/api/schemaapi.py: PS18, Line

Change in vdsm[master]: client: do not protect requests on client side

2016-04-22 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56288/1/lib/yajsonrpc/__init__.py File

Change in vdsm[master]: virt: Don't set connected attribute in if already...

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: Don't set connected attribute in if already set .. Patch Set 4: * #1060573::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1060573::OK,

Change in vdsm[master]: events: introduction of schema

2016-04-22 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: events: introduction of schema .. Patch Set 15: (3 comments) https://gerrit.ovirt.org/#/c/54754/15/lib/api/vdsm-events.yml File lib/api/vdsm-events.yml:

Change in vdsm[master]: WIP: vm: skip domDependentInit for containers

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: WIP: vm: skip domDependentInit for containers .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: virt: Don't set connected attribute in if already...

2016-04-22 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: Don't set connected attribute in if already set .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56224 To unsubscribe, visit

Change in vdsm[master]: jsonrpcvdscli: add storage verbs

2016-04-22 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: jsonrpcvdscli: add storage verbs .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55252 To unsubscribe, visit

Change in vdsm[master]: yml: generate api doc from the schema

2016-04-22 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: yml: generate api doc from the schema .. Patch Set 1: (5 comments) https://gerrit.ovirt.org/#/c/56387/1/lib/api/Makefile.am File lib/api/Makefile.am: Line

Change in vdsm[master]: virt: Don't set connected attribute in if already...

2016-04-22 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: virt: Don't set connected attribute in if already set .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56224 To unsubscribe, visit

Change in vdsm[master]: migration: enhanced the legacy downtime alg

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migration: enhanced the legacy downtime alg .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: net: native ovs: ovsnettestlib.py

2016-04-22 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: native ovs: ovsnettestlib.py .. Patch Set 8: (2 comments) https://gerrit.ovirt.org/#/c/56391/8/tests/network/ovs_driver_test.py File

Change in vdsm[master]: virt: Set timeout on boot menu

2016-04-22 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: Set timeout on boot menu .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56393 To unsubscribe, visit

Change in vdsm[master]: virt: Introduction of the GuestAgentEvents class

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: Introduction of the GuestAgentEvents class .. Patch Set 7: * #1298120::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1298120::OK, public bug

Change in vdsm[master]: agent: Guest agent reply capability support

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: agent: Guest agent reply capability support .. Patch Set 8: * #1298120::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1298120::OK, public bug *

Change in vdsm[master]: virt: Pass effective guest agent API version during migration

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: Pass effective guest agent API version during migration .. Patch Set 5: * #1298120::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: virt: Add the migration/hibernation event handling (GuestAgent)

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: Add the migration/hibernation event handling (GuestAgent) .. Patch Set 9: * #1298120::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: virt: Add new guest agent API function for lifecycle-events

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: Add new guest agent API function for lifecycle-events .. Patch Set 6: * #1298120::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1298120::OK,

Change in vdsm[master]: Let the engine control the guest lifecycle events

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Let the engine control the guest lifecycle events .. Patch Set 2: * #1298120::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1298120::OK, public bug

Change in vdsm[master]: agent: Introduction of first_connect event

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: agent: Introduction of first_connect event .. Patch Set 5: * #1298120::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1298120::OK, public bug *

Change in vdsm[master]: agent: Introduction of first_connect event

2016-04-22 Thread fromani
Francesco Romani has posted comments on this change. Change subject: agent: Introduction of first_connect event .. Patch Set 5: Code-Review+1 thanks for the timeout -- To view, visit https://gerrit.ovirt.org/54753 To

Change in vdsm[master]: migration: enhanced the legacy downtime alg

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migration: enhanced the legacy downtime alg .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: net: OVS driver - bond_slave commands

2016-04-22 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: OVS driver - bond_slave commands .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/56449/1/lib/vdsm/network/ovs/driver/vsctl.py File

Change in vdsm[master]: net: native ovs: reserve ovsbr0 network name

2016-04-22 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: native ovs: reserve ovsbr0 network name .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/56452/5/tests/network/ovs_test.py File

Change in vdsm[master]: virt: Pass effective guest agent API version during migration

2016-04-22 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: virt: Pass effective guest agent API version during migration .. Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/53523/4//COMMIT_MSG Commit Message:

Change in vdsm[master]: virt: Don't set connected attribute in if already...

2016-04-22 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Don't set connected attribute in if already set .. Patch Set 4: Verified+1 Verified by installing the hook as described in the referenced bug and

Change in vdsm[master]: net: native ovs: reserve ovsbr0 network name

2016-04-22 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: native ovs: reserve ovsbr0 network name .. Patch Set 6: Verified+1 Passed ovs_test.py -- To view, visit https://gerrit.ovirt.org/56452 To unsubscribe,

Change in vdsm[master]: net: native ovs: check for bond existence

2016-04-22 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: native ovs: check for bond existence .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/56461/4//COMMIT_MSG Commit Message: PS4, Line 9: connected

Change in vdsm[master]: net: native ovs: check for nic existence

2016-04-22 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: native ovs: check for nic existence .. Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/56448/6/lib/vdsm/network/ovs/validator.py File

Change in vdsm[master]: net: native ovs: ovsnettestlib.py

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: ovsnettestlib.py .. Patch Set 10: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: net: native ovs: reserve ovsbr0 network name

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: reserve ovsbr0 network name .. Patch Set 6: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug *

Change in vdsm[master]: net: native ovs: check for nic existence

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: check for nic existence .. Patch Set 7: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: net: native ovs: check for bond existence

2016-04-22 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: native ovs: check for bond existence .. Patch Set 5: Verified+1 Passed ovs_test.py -- To view, visit https://gerrit.ovirt.org/56461 To unsubscribe, visit

Change in vdsm[master]: net: native ovs: introduce constants module

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: introduce constants module .. Patch Set 8: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug *

Change in vdsm[master]: net: native ovs: ovsnettestlib.py

2016-04-22 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: native ovs: ovsnettestlib.py .. Patch Set 10: Verified+1 Passed ovs_driver_test.py -- To view, visit https://gerrit.ovirt.org/56391 To unsubscribe, visit

Change in vdsm[master]: net: native ovs: introduce constants module

2016-04-22 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: native ovs: introduce constants module .. Patch Set 8: Verified+1 Passed ovs_test.py -- To view, visit https://gerrit.ovirt.org/56451 To unsubscribe,

Change in vdsm[master]: net: native ovs: check for nic existence

2016-04-22 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: native ovs: check for nic existence .. Patch Set 7: Verified+1 Passed ovs_test.py. -- To view, visit https://gerrit.ovirt.org/56448 To unsubscribe, visit

Change in vdsm[master]: net: native ovs: check for bond existence

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: check for bond existence .. Patch Set 5: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: net: native ovs: ovs network setup

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: ovs network setup .. Patch Set 11: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: net: native ovs: ovs bonding setup

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: ovs bonding setup .. Patch Set 6: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: net: native ovs: ovs network setup

2016-04-22 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: native ovs: ovs network setup .. Patch Set 11: Verified+1 Passed ovs_test.py -- To view, visit https://gerrit.ovirt.org/56353 To unsubscribe, visit

Change in vdsm[master]: virt: Make DomainDescriptor use XML helpers

2016-04-22 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: Make DomainDescriptor use XML helpers .. Patch Set 3: (1 comment) I'm convinced that adding a (thin) wrapper layer is a good direction, probably our

Change in vdsm[master]: virt: Pass effective guest agent API version during migration

2016-04-22 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: Pass effective guest agent API version during migration .. Patch Set 5: Code-Review-1 (1 comment) still not sure about the upgrade paths. -1 for

Change in vdsm[master]: net: native ovs: check for bond existence

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: check for bond existence .. Patch Set 6: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: net: native ovs: introduce constants module

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: introduce constants module .. Patch Set 9: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug *

Change in vdsm[master]: net: OVS driver - bond_slave commands

2016-04-22 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: OVS driver - bond_slave commands .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56449 To unsubscribe, visit

Change in vdsm[master]: net: OVS driver - bond_slave commands

2016-04-22 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: OVS driver - bond_slave commands .. Patch Set 2: Verified+1 Passed ovs_driver_test.py -- To view, visit https://gerrit.ovirt.org/56449 To unsubscribe,

Change in vdsm[master]: net: native ovs: check for nic existence

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: check for nic existence .. Patch Set 8: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: net: OVS driver - bond_slave commands

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: OVS driver - bond_slave commands .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: net: native ovs: ovs bonding setup

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: ovs bonding setup .. Patch Set 7: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: net: native ovs: ovs network setup

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: ovs network setup .. Patch Set 12: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: net: native ovs: ovsnettestlib.py

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: ovsnettestlib.py .. Patch Set 11: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: net: native ovs: reserve ovsbr0 network name

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: reserve ovsbr0 network name .. Patch Set 7: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug *

Change in vdsm[master]: net: native ovs: ovs bonding setup

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: ovs bonding setup .. Patch Set 8: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: net: OVS driver - bond_slave commands

2016-04-22 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: OVS driver - bond_slave commands .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56449 To unsubscribe, visit

Change in vdsm[master]: net: native ovs: check for nic existence

2016-04-22 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: native ovs: check for nic existence .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56448 To unsubscribe, visit

Change in vdsm[master]: net: native ovs: check for bond existence

2016-04-22 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: native ovs: check for bond existence .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56461 To unsubscribe, visit

Change in vdsm[master]: virt: Don't set connected attribute in if already...

2016-04-22 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: Don't set connected attribute in if already set .. Patch Set 4: (3 comments) https://gerrit.ovirt.org/#/c/56224/4//COMMIT_MSG Commit Message: Line 19:

Change in vdsm[master]: virt: Set timeout on boot menu

2016-04-22 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: Set timeout on boot menu .. Patch Set 3: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/56393/3/lib/vdsm/config.py.in File lib/vdsm/config.py.in:

Change in vdsm[master]: qemuimg: Remove EL6 comment

2016-04-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Remove EL6 comment .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: qemuimg: Remove EL6 comment

2016-04-22 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: qemuimg: Remove EL6 comment .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/55794 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: qemuimg: Remove EL6 comment

2016-04-22 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: qemuimg: Remove EL6 comment .. qemuimg: Remove EL6 comment EL6 is no longer supported, no need to document where its qemu-img binary is installed.

Change in vdsm[master]: qemuimg.py: Don't check compat support

2016-04-22 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: qemuimg.py: Don't check compat support .. Patch Set 1: Please rebase. -- To view, visit https://gerrit.ovirt.org/55925 To unsubscribe, visit